[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#5). Change subject: [tserver] include ip:port in the tserver name

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 4: (1 comment)

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 4: (1 comment)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. tools: don't open block manager when dumping UUID The

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#4). Change subject: [tserver] include ip:port in the tserver name

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 7: Code-Review+1 (1 comment)

[kudu-CR] messenger: adjust lock usage

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14250 ) Change subject: messenger: adjust lock usage .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] messenger: adjust lock usage

2019-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14250 ) Change subject: messenger: adjust lock usage .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14250/1//COMMIT_MSG

[kudu-CR] messenger: adjust lock usage

2019-09-17 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14250 to review the following change. Change subject: messenger: adjust lock usage .. messenger: adjust

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 7: (1 comment)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. Patch Set 5: (1 comment)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14243 to look at the new patch set (#5). Change subject: tools: don't open block manager when dumping UUID

[kudu-CR] KUDU-2949: fix tablet stats race while ProcessTabletReport

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14245 ) Change subject: KUDU-2949: fix tablet stats race while ProcessTabletReport .. Patch Set 1: (1 comment) I don't see how this fixes the

[kudu-CR] KUDU-2069 p2: stop placement onto servers in maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] [catalog manager] correct the wrong comment

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [catalog manager] correct the wrong comment

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated test failure. --

[kudu-CR] [catalog manager] correct the wrong comment

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. [catalog_manager] correct the wrong comment Change-Id:

[kudu-CR] KUDU-2069 p2: stop placement onto servers in maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2069 p2: stop placement onto servers in maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14220 to look at the new patch set (#4). Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. Patch Set 4: (1 comment)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14243 to look at the new patch set (#4). Change subject: tools: don't open block manager when dumping UUID

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. Patch Set 4: (2 comments)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. Patch Set 3: (2 comments)

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14243 to look at the new patch set (#3). Change subject: tools: don't open block manager when dumping UUID ..

[kudu-CR] KUDU-2069 p2: stop placement onto servers in maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 7: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2949: fix tablet stats race while ProcessTabletReport

2019-09-17 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14245 ) Change subject: KUDU-2949: fix tablet stats race while ProcessTabletReport .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 3: (3 comments)

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 3: > > (1 comment) > > > > The TSAN failure is

[kudu-CR] KUDU-2069 p2: stop placement onto servers in maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14220 to look at the new patch set (#3). Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (12 comments)

[kudu-CR] KUDU-2069 p2: stop placement onto servers in maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode .. Patch Set 3: (8 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14221 to look at the new patch set (#3). Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14217 to look at the new patch set (#7). Change subject: KUDU-2069 p1: add persistent tserver maintenance mode

[kudu-CR] [util] Fix the bug of MaybeGCAfterRelease()

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14244 ) Change subject: [util] Fix the bug of MaybeGCAfterRelease() .. [util] Fix the bug of MaybeGCAfterRelease() The released_bytes

[kudu-CR] [util] Fix the bug of MaybeGCAfterRelease()

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: [util] Fix the bug of MaybeGCAfterRelease() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14244 To unsubscribe, visit

[kudu-CR] [util] Fix the bug of MaybeGCAfterRelease()

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14244 ) Change subject: [util] Fix the bug of MaybeGCAfterRelease() .. Patch Set 2: Verified+1 Code-Review+2 Good find. I filed KUDU-2943 for

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 ) Change subject: tools: don't open block manager when dumping UUID .. Patch Set 2: (2 comments)

[kudu-CR] WIP KUDU-2780: create thread for auto-rebalancing

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: WIP KUDU-2780: create thread for auto-rebalancing .. Patch Set 3: (2 comments)

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#3). Change subject: [tserver] include ip:port in the tserver name

[kudu-CR] KUDU-2949: fix tablet stats race while ProcessTabletReport

2019-09-17 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14245 Change subject: KUDU-2949: fix tablet stats race while ProcessTabletReport .. KUDU-2949: fix tablet stats race while ProcessTabletReport

[kudu-CR] [util] Fix the bug of MaybeGCAfterRelease()

2019-09-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14244 ) Change subject: [util] Fix the bug of MaybeGCAfterRelease() .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [util] Fix the bug of MaybeGCAfterRelease()

2019-09-17 Thread Anonymous Coward (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14244 to look at the new patch set (#2). Change subject: [util] Fix the bug of MaybeGCAfterRelease() .. [util]

[kudu-CR] [process memory] Fix the bug of MaybeGCAfterRelease()

2019-09-17 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14244 Change subject: [process_memory] Fix the bug of MaybeGCAfterRelease() .. [process_memory] Fix the bug of MaybeGCAfterRelease()

[kudu-CR] tools: don't open block manager when dumping UUID

2019-09-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14243 to look at the new patch set (#2). Change subject: tools: don't open block manager when dumping UUID ..