[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 ) Change subject: Use protobuf arenas for CommitMsgs .. Patch Set 2: (3 comments) Overall looks good to me, but it seems many tests

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Upgrade C++ to protobuf 3.12 This has various performance improvements, and

[kudu-CR](gh-pages) site: update the prior release notes page

2020-07-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/16151 ) Change subject: site: update the prior release notes page .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) site: update the prior release notes page

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16151 Change subject: site: update the prior release notes page .. site: update the prior release notes page Change-Id:

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 ) Change subject: KUDU-3090 Restrict changing ownership of a table .. Patch Set 10: Code-Review+1 (2 comments)

[kudu-CR] KUDU-3090 Add ownership privileges

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 ) Change subject: KUDU-3090 Add ownership privileges .. Patch Set 15: (4 comments)

[kudu-CR] KUDU-3090 Add delegate admin privilege

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16071 ) Change subject: KUDU-3090 Add delegate admin privilege .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3090 Support backing up ownership info

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16126 ) Change subject: KUDU-3090 Support backing up ownership info .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 12: Code-Review+1 (3 comments)

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 5: Code-Review+2 (2 comments) Thank you for this patch!

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16137 ) Change subject: Optimize GetTableLocations for better arena use .. Patch Set 7: -Code-Review Whoops, forgot to mention one issue with

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16137 ) Change subject: Optimize GetTableLocations for better arena use .. Patch Set 7: Code-Review+1 (2 comments) Looks good to me, just a

[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16147 to look at the new patch set (#2). Change subject: Use protobuf arenas for CommitMsgs .. Use

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16136 to look at the new patch set (#5). Change subject: Enable arenas for RPC request and response

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16135 to look at the new patch set (#5). Change subject: Upgrade C++ to protobuf 3.12

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#7). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 4: (7 comments)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 4: (13 comments)

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-07 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-07 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 12: Code-Review+1 (2 comments)

[kudu-CR] KUDU-2612 p2: introduce transaction status management

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16044 ) Change subject: KUDU-2612 p2: introduce transaction status management .. Patch Set 6: (11 comments)

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-07 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16125 to look at the new patch set (#7). Change subject: KUDU-3090 Ownership support in Java client

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 12: Verified+1 Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-3090: Native owner metadata in Kudu .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15841 To unsubscribe, visit

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new patch set (#12) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. KUDU-3090: Native owner

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 11: (1 comment)

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new patch set (#11) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. KUDU-3090: Native owner

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: (9 comments) > Patch Set 10: > > I think there are 2 valid

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 4: (7 comments)

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 2: (1 comment)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 4: (13 comments)