[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 3: Not sure why you needed the change to

[kudu-CR] [docs] Fix code block formatting

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14320 ) Change subject: [docs] Fix code block formatting .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14320

[kudu-CR] add a tool to create table

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 ) Change subject: add a tool to create table .. Patch Set 5: (2 comments)

[kudu-CR] [docs] Fix code block formatting

2019-10-01 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14320 to look at the new patch set (#2). Change subject: [docs] Fix code block formatting .. [docs] Fix code

[kudu-CR] [docs] Fix code block formatting

2019-10-01 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14320 ) Change subject: [docs] Fix code block formatting .. Patch Set 2: (1 comment)

[kudu-CR] [clock] modernize clock-related classes

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14330 ) Change subject: [clock] modernize clock-related classes .. Patch Set 1: Verified+1 Unrelated flake while building (the machine was

[kudu-CR] [clock] modernize clock-related classes

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14330 ) Change subject: [clock] modernize clock-related classes .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [clock] modernize clock-related classes

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14330 ) Change subject: [clock] modernize clock-related classes .. [clock] modernize clock-related classes This patch updates the

[kudu-CR] table locations-itest: restrict benchmark to slow mode

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14328 ) Change subject: table_locations-itest: restrict benchmark to slow mode .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [java] process communicates via protobuf-based protocol

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] process communicates via protobuf-based protocol .. Patch Set 1: (10 comments)

[kudu-CR] table locations-itest: restrict benchmark to slow mode

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14328 ) Change subject: table_locations-itest: restrict benchmark to slow mode .. table_locations-itest: restrict benchmark to slow mode

[kudu-CR] trace-test: fix kernel stack watchdog data race

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14256 ) Change subject: trace-test: fix kernel stack watchdog data race .. trace-test: fix kernel stack watchdog data race The

[kudu-CR] table locations-itest: restrict benchmark to slow mode

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14328 ) Change subject: table_locations-itest: restrict benchmark to slow mode .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] trace-test: fix kernel stack watchdog data race

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: trace-test: fix kernel stack watchdog data race .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14256 To unsubscribe,

[kudu-CR] trace-test: fix kernel stack watchdog data race

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14256 ) Change subject: trace-test: fix kernel stack watchdog data race .. Patch Set 2: Verified+1 Overriding Jenkins. Both test failures were

[kudu-CR] KUDU-1938 Add range partition support pt 6

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14333 Change subject: KUDU-1938 Add range partition support pt 6 .. KUDU-1938 Add range partition support pt 6 Change-Id:

[kudu-CR] KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers

2019-10-01 Thread Yifan Zhang (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14154 to look at the new patch set (#5). Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 ) Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 ) Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate .. Patch Set 1: (1 comment)

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14341 ) Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. Patch Set 1: (1 comment)

[kudu-CR] Fix compilation on XCode 11

2019-10-01 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14343 Change subject: Fix compilation on XCode 11 .. Fix compilation on XCode 11 I recently upgraded my Mac to XCode 11 which now fails with:

[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14331 ) Change subject: TestKuduPartitioner: deflake testBuildTimeout .. Patch Set 2: Verified+1 Failures are unrelated. -- To view, visit

[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: TestKuduPartitioner: deflake testBuildTimeout .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14331 To unsubscribe,

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. cfile: track memory for CFileReaders and

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 ) Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14341 To

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14341 ) Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. Patch Set 2: Verified+1 Failures are due to NTP errors.

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14341 ) Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14341 Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. test: deflake TestBackgroundFailureDuringMaintenanceMode We

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14342 to look at the new patch set (#2). Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for VARCHAR pt 1 .. Patch Set 32: Code-Review+2 -- To view, visit

[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout

2019-10-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14331 ) Change subject: TestKuduPartitioner: deflake testBuildTimeout .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [mini cluster] small fix on Mini{Chronyd,Hms}::Start()

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14345 Change subject: [mini_cluster] small fix on Mini{Chronyd,Hms}::Start() .. [mini_cluster] small fix on Mini{Chronyd,Hms}::Start() This

[kudu-CR] WIP KUDU-2780: create thread for auto-rebalancing

2019-10-01 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: WIP KUDU-2780: create thread for auto-rebalancing .. Patch Set 5: (64 comments)

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 5: (2 comments)

[kudu-CR] AsyncKuduClient: improve debug-level getTableKeyRanges logging

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14336 ) Change subject: AsyncKuduClient: improve debug-level getTableKeyRanges logging .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14341 ) Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. Patch Set 2: (2 comments)

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 ) Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate .. Patch Set 2: (1 comment)

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14341 to look at the new patch set (#2). Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14322 to look at the new patch set (#5). Change subject: cfile: track memory for CFileReaders and BloomFileReaders

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14322 to look at the new patch set (#7). Change subject: cfile: track memory for CFileReaders and BloomFileReaders

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 6: (1 comment)

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14342 Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate .. test: deflake

[kudu-CR] test: deflake TestBackgroundFailureDuringMaintenanceMode

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14341 ) Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode .. Patch Set 1: (1 comment)

[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14335 ) Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration .. TestMiniKuduCluster: deflake

[kudu-CR] AsyncKuduClient: improve debug-level getTableKeyRanges logging

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14336 ) Change subject: AsyncKuduClient: improve debug-level getTableKeyRanges logging .. AsyncKuduClient: improve debug-level

[kudu-CR] Fix compilation on XCode 11

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14343 ) Change subject: Fix compilation on XCode 11 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14343 To

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14322 to look at the new patch set (#6). Change subject: cfile: track memory for CFileReaders and BloomFileReaders

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14331 ) Change subject: TestKuduPartitioner: deflake testBuildTimeout .. TestKuduPartitioner: deflake testBuildTimeout I saw a RELEASE

[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14342 ) Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate .. test: deflake

[kudu-CR] Fix compilation on XCode 11

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14343 ) Change subject: Fix compilation on XCode 11 .. Fix compilation on XCode 11 I recently upgraded my Mac to XCode 11 which now

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 ) Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 .. Patch Set 17: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for VARCHAR pt 1 .. Patch Set 32: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 ) Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 .. Patch Set 20: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 .. Patch Set 21: (2 comments)

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for VARCHAR pt 1 .. Patch Set 31: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for VARCHAR pt 1 .. Patch Set 32: (1 comment)

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13869 to look at the new patch set (#24). Change subject: KUDU-1938 Add C++ client support for

[kudu-CR] util: add non-root FindOrCreateMemTracker()

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/14321 ) Change subject: util: add non-root FindOrCreateMemTracker() .. Abandoned Went a different route. -- To view, visit

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14322 to look at the new patch set (#4). Change subject: cfile: track memory for CFileReaders and BloomFileReaders

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for VARCHAR pt 1 .. Patch Set 30: Code-Review+2 (2 comments)

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#32). Change subject: KUDU-1938 Add support for VARCHAR pt 1

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14050 to look at the new patch set (#18). Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13869 to look at the new patch set (#23). Change subject: KUDU-1938 Add C++ client support for

[kudu-CR] KUDU-1938 Add range partition support pt 6

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 ) Change subject: KUDU-1938 Add range partition support pt 6 .. Patch Set 1: Is this all that is needed to allow for VARCHAR to be used in

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 .. Patch Set 22: (2 comments)

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13869 to look at the new patch set (#22). Change subject: KUDU-1938 Add C++ client support for

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#31). Change subject: KUDU-1938 Add support for VARCHAR pt 1

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 ) Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 .. Patch Set 17: (4 comments)

[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for VARCHAR pt 1 .. Patch Set 31: (2 comments)

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 .. Patch Set 25: (1 comment)

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 3: > Patch Set 3: > > Not sure why you needed

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 ) Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 .. Patch Set 16: Code-Review+1 (4 comments)

[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration

2019-10-01 Thread Adar Dembo (Code Review)
Hello Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14335 to review the following change. Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration ..

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14050 to look at the new patch set (#17). Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4

[kudu-CR] KUDU-1938 Add range partition support pt 6

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 ) Change subject: KUDU-1938 Add range partition support pt 6 .. Patch Set 1: > Patch Set 1: > > Is this all that is needed to allow for

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 .. Patch Set 22: (1 comment)

[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration

2019-10-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14335 ) Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] AsyncKuduClient: improve debug-level getTableKeyRanges logging

2019-10-01 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14336 to review the following change. Change subject: AsyncKuduClient: improve debug-level getTableKeyRanges logging ..

[kudu-CR] KUDU-1938 Add non-copy VARCHAR setters pt 3

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13928 ) Change subject: KUDU-1938 Add non-copy VARCHAR setters pt 3 .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 .. Patch Set 23: (1 comment)

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 ) Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 .. Patch Set 18: (1 comment)

[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration

2019-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14335 ) Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-1938 Add C++ client support for VARCHAR pt 2

2019-10-01 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13869 to look at the new patch set (#25). Change subject: KUDU-1938 Add C++ client support for

[kudu-CR] KUDU-1938 [hms] Add HMS support for VARCHAR pt 5

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14303 ) Change subject: KUDU-1938 [hms] Add HMS support for VARCHAR pt 5 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] cfile: track memory for CFileReaders and BloomFileReaders

2019-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 ) Change subject: cfile: track memory for CFileReaders and BloomFileReaders .. Patch Set 4: (1 comment)