[kudu-CR] [examples] Update collectl example

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9854 Change subject: [examples] Update collectl example .. [examples] Update collectl example This updates the collectl example by: -

[kudu-CR] [examples] Improve the basic Java example

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9852 Change subject: [examples] Improve the basic Java example .. [examples] Improve the basic Java example This improves the Java example

[kudu-CR] [examples] Improve loadgen example

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9853 Change subject: [examples] Improve loadgen example .. [examples] Improve loadgen example This is a grab bag of improvements to the

[kudu-CR] KUDU-2303: Add ignoreNull option to upsertRows

2018-03-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: KUDU-2303: Add ignoreNull option to upsertRows .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9753 ) Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups .. Patch Set 3: (2 comments)

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9760 ) Change subject: meta_cache: improve multi-threaded scalability .. Patch Set 2: (1 comment)

[kudu-CR] make shared: fix build for newer libc++

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9847 ) Change subject: make_shared: fix build for newer libc++ .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9783 to look at the new patch set (#7). Change subject: KUDU-16 pt 1: add server-side limits on scanners

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-03-28 Thread Fengling Wang (Code Review)
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9849 Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. [docs] Update kudu-spark section and add

[kudu-CR] make shared: fix build for newer libc++

2018-03-28 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9847 to look at the new patch set (#3). Change subject: make_shared: fix build for newer libc++ ..

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-28 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9760 to look at the new patch set (#2). Change subject: meta_cache: improve multi-threaded scalability

[kudu-CR] KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups

2018-03-28 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9753 to look at the new patch set (#3). Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups

[kudu-CR] KUDU-2378. Fix unaligned loads of int128 from rows

2018-03-28 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9848 to look at the new patch set (#2). Change subject: KUDU-2378. Fix unaligned loads of int128 from rows ..

[kudu-CR] make shared: fix build for newer libc++

2018-03-28 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9847 to look at the new patch set (#2). Change subject: make_shared: fix build for newer libc++ ..

[kudu-CR] KUDU-2378. Fix unaligned loads of int128 from rows

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9848 ) Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration .. Patch Set 10: As discussed on Slack I'm going to split

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-28 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8312 to look at the new patch set (#10). Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration .. Patch Set 9: (52 comments)

[kudu-CR] make shared: fix build for newer libc++

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9847 ) Change subject: make_shared: fix build for newer libc++ .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2378. Fix unaligned loads of int128 from rows

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9848 Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. KUDU-2378. Fix unaligned loads of int128 from rows Our row format

[kudu-CR] make shared: fix build for newer libc++

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9847 Change subject: make_shared: fix build for newer libc++ .. make_shared: fix build for newer libc++ Previously, we used friendship with

[kudu-CR] KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9753 ) Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-28 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9835 to look at the new patch set (#2). Change subject: KUDU-2384. Don't collect thread stacks when running under debugger

[kudu-CR] util: use uint64 t values for resource limits and adjust usages

2018-03-28 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9806 to look at the new patch set (#3). Change subject: util: use uint64_t values for resource limits and adjust usages

[kudu-CR] util: use uint64 t values for resource limits and adjust usages

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9806 ) Change subject: util: use uint64_t values for resource limits and adjust usages .. Patch Set 2: (2 comments)

[kudu-CR] Improve the C++ client example

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client example .. Improve the C++ client example This does some small things to improve the

[kudu-CR] Introduce examples directory

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce examples directory .. Introduce examples directory This introduces the top-level examples directory,

[kudu-CR] util: use uint64 t values for resource limits and adjust usages

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9806 ) Change subject: util: use uint64_t values for resource limits and adjust usages .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 1: (1 comment)

[kudu-CR] Improve the C++ client example

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client example .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9838 To

[kudu-CR] Introduce examples directory

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce examples directory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9837 To

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 5: Rebased. Failures were flakes that Alexey fixed in

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9840 To unsubscribe,

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. KUDU-2385: Fix typo in KinitContext::DoRenewal() On

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#5). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 3: Added some units and fixed a typo. -- To view, visit

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#4). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: Many tests failed with: Runtime error: Failed to start

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 14: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#14). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 13: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: (1 comment) Hi Todd, good suggestion. It'd be better if

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#3). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9840 to look at the new patch set (#2). Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 13: > Patch Set 12: Code-Review+2 > > Thanks for

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: > Patch Set 1: > > Todd, we use this macro here: >

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Todd, we use this macro here:

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+2 lgtm. Wonder if there is a better #ifdef

[kudu-CR] Improve the C++ client example

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client example .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9838 To

[kudu-CR] Introduce examples directory

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce examples directory .. Patch Set 2: Code-Review+2 The only downside to renaming the test itself is losing

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Build failure doesn't look relevant:

[kudu-CR] Improve the C++ client example

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client example .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 12: Code-Review+2 Thanks for accepting the scope creep

[kudu-CR] Improve the C++ client example

2018-03-28 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9838 to look at the new patch set (#2). Change subject: Improve the C++ client example

[kudu-CR] Improve the C++ client example

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client example .. Patch Set 1: (6 comments)

[kudu-CR] Introduce examples directory

2018-03-28 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9837 to look at the new patch set (#2). Change subject: Introduce examples directory

[kudu-CR] Improve the C++ client sample

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client sample .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 12: (1 comment) I changed the tests to check for

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#12). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] Introduce samples directory

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce samples directory .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG Commit

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9840 Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. KUDU-2385: Fix typo in KinitContext::DoRenewal() On platforms without

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 11: Code-Review+1 (1 comment) Will probably wants to

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 11: (8 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#11). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 10: (8 comments)

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9839 ) Change subject: [java] Fix javadoc issues .. [java] Fix javadoc issues Fixes some javadoc warnings: - Removed @link and @see to

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 10: (16 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#10). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9839 ) Change subject: [java] Fix javadoc issues .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG Commit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 9: (16 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#9). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] Improve the C++ client sample

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client sample .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#8). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] Introduce samples directory

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce samples directory .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG Commit

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9839 ) Change subject: [java] Fix javadoc issues .. Patch Set 2: Code-Review+2 (2 comments)

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9839 ) Change subject: [java] Fix javadoc issues .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9839 To

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [java] Fix javadoc issues .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9839 To unsubscribe, visit

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9839 to look at the new patch set (#2). Change subject: [java] Fix javadoc issues .. [java] Fix javadoc

[kudu-CR] [java] Fix javadoc issues

2018-03-28 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9839 Change subject: [java] Fix javadoc issues .. [java] Fix javadoc issues Fixes some javadoc warnings: - Removed @link and @see to external

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 8: > Patch Set 8: Verified-1 > > Build Failed > >

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-03-28 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#8). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 7: (10 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-03-28 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#7). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] Improve the C++ client sample

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client sample .. Patch Set 1: (1 comment)

[kudu-CR] Improve the C++ client sample

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9838 Change subject: Improve the C++ client sample .. Improve the C++ client sample This does some small things to improve the C++ client

[kudu-CR] Introduce samples directory

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9837 Change subject: Introduce samples directory .. Introduce samples directory This introduces the top-level samples directory, which will