[kudu-CR] [ranger] validate the JAR file path of the subprocess

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 ) Change subject: [ranger] validate the JAR file path of the subprocess .. Patch Set 5: (1 comment)

[kudu-CR] [ranger] validate the JAR file path of the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15435 to look at the new patch set (#5). Change subject: [ranger] validate the JAR file path of the subprocess

[kudu-CR] [ranger] validate the JAR file path of the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 ) Change subject: [ranger] validate the JAR file path of the subprocess .. Patch Set 5: (2 comments)

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: (1 comment) > Patch Set 7: Code-Review+2 > >

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. [ranger] parameterize the Java binary path for the

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: Code-Review+2 (1 comment)

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: Verified+1 Unrelated flaky test. -- To

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [ranger] parameterize the Java binary path for the subprocess .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15415 To

[kudu-CR] thread: simplify Thread::Create API

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: thread: simplify Thread::Create API .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15448 To unsubscribe, visit

[kudu-CR] thread: simplify Thread::Create API

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15448 ) Change subject: thread: simplify Thread::Create API .. Patch Set 4: Verified+1 Unrelated flake:

[kudu-CR] thread: simplify Thread::Create API

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15448 ) Change subject: thread: simplify Thread::Create API .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: Code-Review+2 (1 comment)

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] thread: simplify Thread::Create API

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15448 ) Change subject: thread: simplify Thread::Create API .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: (1 comment)

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 7: (2 comments)

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-17 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15415 to look at the new patch set (#7). Change subject: [ranger] parameterize the Java binary path for the subprocess

[kudu-CR] remove kudu::Thread from tests

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15447 ) Change subject: remove kudu::Thread from tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15447

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 25: (6 comments)

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 25: (5 comments) Test failure looks relevant. Maybe a flaky

[kudu-CR] remove kudu::Thread from tests

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15447 ) Change subject: remove kudu::Thread from tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15447

[kudu-CR] remove kudu::Thread from tests

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15447 ) Change subject: remove kudu::Thread from tests .. Patch Set 3: (13 comments)

[kudu-CR] remove kudu::Thread from tests

2020-03-17 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15447 to look at the new patch set (#4). Change subject: remove kudu::Thread from tests ..

[kudu-CR] [build] Fix buildSrc lock timeout

2020-03-17 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15470 ) Change subject: [build] Fix buildSrc lock timeout .. [build] Fix buildSrc lock timeout I have seen a few instances where the

[kudu-CR] [build] Fix buildSrc lock timeout

2020-03-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 ) Change subject: [build] Fix buildSrc lock timeout .. Patch Set 1: (1 comment)

[kudu-CR] [build] Fix buildSrc lock timeout

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 ) Change subject: [build] Fix buildSrc lock timeout .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (2 comments) Would it be possible to add some

[kudu-CR] [build] Fix buildSrc lock timeout

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 ) Change subject: [build] Fix buildSrc lock timeout .. Patch Set 1: (1 comment)

[kudu-CR] [build] Fix buildSrc lock timeout

2020-03-17 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15470 Change subject: [build] Fix buildSrc lock timeout .. [build] Fix buildSrc lock timeout I have seen a few instances where the `make`

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (1 comment)

[kudu-CR] [tools] add test coverage for flags categories in ksck

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15458 ) Change subject: [tools] add test coverage for flags categories in ksck .. [tools] add test coverage for flags categories in

[kudu-CR] remove kudu::Thread from tests

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15447 ) Change subject: remove kudu::Thread from tests .. Patch Set 3: Code-Review+2 (13 comments)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-17 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tools] add test coverage for flags categories in ksck

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15458 ) Change subject: [tools] add test coverage for flags categories in ksck .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] build: fix linker error in BloomFileTestBase

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15459 ) Change subject: build: fix linker error in BloomFileTestBase .. build: fix linker error in BloomFileTestBase I saw this when

[kudu-CR] build: fix linker error in BloomFileTestBase

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15459 ) Change subject: build: fix linker error in BloomFileTestBase .. Patch Set 1: Code-Review+2 Sorry about that. -- To view, visit

[kudu-CR] WIP [release notes] supported NTP servers and time source

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 ) Change subject: WIP [release notes] supported NTP servers and time source .. Patch Set 2: Code-Review+2 Seems good to me. -- To view,

[kudu-CR] KUDU-3068 Add atomic operations for aarch64

2020-03-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 ) Change subject: KUDU-3068 Add atomic operations for aarch64 .. Patch Set 1: (1 comment)

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15414 To

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. [java] fix Kudu Ranger plugin when Ranger is Kerberized

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 7: Verified+1 Unrelated flaky test -- To view, visit

[kudu-CR] build: fix linker error in BloomFileTestBase

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15459 ) Change subject: build: fix linker error in BloomFileTestBase .. Patch Set 1: Verified+1 Unrelated test flake in

[kudu-CR] build: fix linker error in BloomFileTestBase

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15459 ) Change subject: build: fix linker error in BloomFileTestBase .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] build: fix linker error in BloomFileTestBase

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: build: fix linker error in BloomFileTestBase .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15459 To unsubscribe,

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15460 Change subject: tablet: cache delta stats when flushing a DMS .. tablet: cache delta stats when flushing a DMS This allows us to GC

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-17 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 25: (4 comments)

[kudu-CR] build: fix linker error in BloomFileTestBase

2020-03-17 Thread Andrew Wong (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15459 to review the following change. Change subject: build: fix linker error in BloomFileTestBase .. build: fix linker

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-17 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14177 to look at the new patch set (#25). Change subject: KUDU-2780: create thread for auto-rebalancing

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#4). Change subject: KUDU-1625: background op to GC ancient, fully deleted

[kudu-CR] WIP [release notes] supported NTP servers and time source

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 ) Change subject: WIP [release notes] supported NTP servers and time source .. Patch Set 2: (4 comments)

[kudu-CR] WIP [release notes] supported NTP servers and time source

2020-03-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15456 to look at the new patch set (#2). Change subject: WIP [release notes] supported NTP servers and time source

[kudu-CR] [tools] add test coverage for flags categories in ksck

2020-03-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15458 Change subject: [tools] add test coverage for flags categories in ksck .. [tools] add test coverage for flags categories in ksck This

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 7: (2 comments)

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-17 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15414 to look at the new patch set (#7). Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 24: (3 comments)

[kudu-CR] KUDU-3068 Add atomic operations for aarch64

2020-03-17 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 ) Change subject: KUDU-3068 Add atomic operations for aarch64 .. Patch Set 1: (1 comment) @Adar, Or is there newer file of

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-17 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#3). Change subject: KUDU-1625: background op to GC ancient, fully deleted