[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15600 to look at the new patch set (#2). Change subject: [util] Add special handling for nullptr in fast hash

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 1: (4 comments)

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15600 Change subject: [util] Add special handling for nullptr in fast hash .. [util] Add special handling for nullptr in fast hash

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15549 ) Change subject: Use popcnt instruction for Bits::Count .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15549 ) Change subject: Use popcnt instruction for Bits::Count .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [rpc] Add RPC feature flag for Bloom filter predicate

2020-03-24 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15540 ) Change subject: [rpc] Add RPC feature flag for Bloom filter predicate .. Patch Set 2: (1 comment)

[kudu-CR] [rpc] Add RPC feature flag for Bloom filter predicate

2020-03-24 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15540 to look at the new patch set (#3). Change subject: [rpc] Add RPC feature flag for Bloom filter predicate

[kudu-CR] [rpc] Add RPC feature flag for Bloom filter predicate

2020-03-23 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15540 to look at the new patch set (#2). Change subject: [rpc] Add RPC feature flag for Bloom filter predicate

[kudu-CR] [rpc] Add RPC feature flag for Bloom filter predicate

2020-03-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15540 ) Change subject: [rpc] Add RPC feature flag for Bloom filter predicate .. Patch Set 1: (1 comment)

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15539 ) Change subject: bitmap: faster implementation of iteration over a bitmap .. Patch Set 1: (8 comments)

[kudu-CR] [rpc] Add RPC feature flag for Bloom filter predicate

2020-03-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15540 Change subject: [rpc] Add RPC feature flag for Bloom filter predicate .. [rpc] Add RPC feature flag for Bloom filter predicate If a

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize getters by outlining cold path .. Patch Set 1: Code-Review+1 TIL: Outlining can improve

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 2: (3 comments) Thanks for addressing this issue, Adar.

[kudu-CR] [client] Mark the Bloom filter predicate method as experimental

2020-03-18 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15486 Change subject: [client] Mark the Bloom filter predicate method as experimental .. [client] Mark the Bloom filter predicate method as

[kudu-CR] metrics: replace kudu::Bind usage with lambdas in FunctionGauge

2020-03-18 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15474 ) Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] block bloom filter: quell warning in release build

2020-03-18 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15478 ) Change subject: block_bloom_filter: quell warning in release build .. Patch Set 2: Code-Review+1 Thanks for fixing this, Andrew!

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (2 comments) Would it be possible to add some

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (1 comment)

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: (3 comments)

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15450 to look at the new patch set (#2). Change subject: [util] Minor changes in BlockBloomFilter requested by Impala

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15424 to look at the new patch set (#4). Change subject: [client] Add C++ API to accept BlockBloomFilter directly

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 1: (2 comments)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 3: (1 comment)

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15450 Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. [util] Minor changes in BlockBloomFilter requested by

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 2: (1 comment)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15424 to look at the new patch set (#3). Change subject: [client] Add C++ API to accept BlockBloomFilter directly

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-13 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15424 to look at the new patch set (#2). Change subject: [client] Add C++ API to accept BlockBloomFilter directly

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 1: (2 comments)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 1: > Patch Set 1: Verified-1 > > Build Failed

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15424 Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. [client] Add C++ API to accept BlockBloomFilter directly

[kudu-CR] [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format

2020-03-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15396 ) Change subject: [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format .. Patch Set 1: (1 comment)

[kudu-CR] [quickstart] Add an Apache Impala quickstart guide

2020-03-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15397 ) Change subject: [quickstart] Add an Apache Impala quickstart guide .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [quickstart] Add an Apache Impala quickstart guide

2020-03-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15397 ) Change subject: [quickstart] Add an Apache Impala quickstart guide .. Patch Set 1: (6 comments) Thanks for adding this guide,

[kudu-CR] [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format

2020-03-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15396 Change subject: [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format .. [util] Changes to allow

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 3: (1 comment)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 5: > Patch Set 5: Verified-1 > > Build

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-09 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Tim Armstrong, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15373 to look at the new patch set (#3). Change subject: [util] Import "Or" function to BlockBloomFilter from Impala

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 2: (1 comment)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 4: (1 comment)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-09 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15372 to look at the new patch set (#5). Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-09 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Tim Armstrong, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15373 to look at the new patch set (#2). Change subject: [util] Import "Or" function to BlockBloomFilter from Impala

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-09 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15372 to look at the new patch set (#4). Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 3: (1 comment)

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 1: (8 comments)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-07 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15372 to look at the new patch set (#3). Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-06 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15372 to look at the new patch set (#2). Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-06 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 1: (9 comments)

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15373 Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. [util] Import "Or" function to BlockBloomFilter from

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15372 Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. [util] Add support for 32 & 64 byte alignment to

[kudu-CR] [cmake] add project(Kudu) to avoid warning

2020-03-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15354 ) Change subject: [cmake] add project(Kudu) to avoid warning .. Patch Set 1: Code-Review+1 Thanks for fixing! -- To view, visit

[kudu-CR] KUDU-3063: Set a ratio to reserve some nvm memory

2020-02-28 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 ) Change subject: KUDU-3063: Set a ratio to reserve some nvm memory .. Patch Set 1: (3 comments)

[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone

2020-02-24 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15286 ) Change subject: [webserver] HtmlOutputSchemaTable() is gone .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [test] Fix flaky BloomFilterPredicate test

2020-02-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15257 Change subject: [test] Fix flaky BloomFilterPredicate test .. [test] Fix flaky BloomFilterPredicate test min, max values need to be

[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.

2020-02-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 ) Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried. .. Patch Set 1: (1 comment)

[kudu-CR] [util] fix debug builds in macOS

2020-02-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 1: Code-Review+1 (1 comment) Thanks for fixing this, Alexey!

[kudu-CR] [client] Remove range bounds in Bloom filter predicate

2020-02-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15247 Change subject: [client] Remove range bounds in Bloom filter predicate .. [client] Remove range bounds in Bloom filter predicate

[kudu-CR] [build] Specify Bloom filter protobuf dependency in kudu common proto

2020-02-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15246 Change subject: [build] Specify Bloom filter protobuf dependency in kudu_common_proto .. [build] Specify Bloom filter protobuf

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 13: Could the reviewers take

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 8: (1 comment)

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-12 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#8). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 13: > Patch Set 13:

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-12 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#7). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 6: (3 comments)

[kudu-CR] [java] Fix various build warnings

2020-02-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15191 ) Change subject: [java] Fix various build warnings .. Patch Set 3: (4 comments)

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15196 ) Change subject: [java] Use Assert.assertThrows .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [Java] Upgrade dependencies

2020-02-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15193 ) Change subject: [Java] Upgrade dependencies .. Patch Set 1: Code-Review+1 Curious is there a reason for these upgrades or in general

[kudu-CR] [thirdparty] stip more features from libcurl

2020-02-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15195 ) Change subject: [thirdparty] stip more features from libcurl .. Patch Set 2: (1 comment)

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 5: (3 comments)

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-10 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#6). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#5). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#13). Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15121 to look at the new patch set (#5). Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15166 to look at the new patch set (#2). Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15166 ) Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .. Patch Set 1: (4 comments)

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 4: (5 comments)

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 12: (4 comments)

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15166 Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .. [util] Add a function to generate random

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#12). Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#4). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15121 to look at the new patch set (#4). Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 3: (7 comments)

[kudu-CR] Add cloning support to BlockBloomFilter and associated allocator

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 11: (1 comment)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 11: (1 comment)

[kudu-CR] Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

2020-01-31 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has abandoned this change. ( http://gerrit.cloudera.org:8080/15120 ) Change subject: Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate .. Abandoned No need to store the allocator ptr in

[kudu-CR] Add cloning support to BlockBloomFilter and associated allocator

2020-01-31 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15121 to look at the new patch set (#3). Change subject: Add cloning support to BlockBloomFilter and associated allocator

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-01-31 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#3). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-31 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#11). Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

[kudu-CR] [client] KUDU-2483 Add InBloomFilter predicate to C++ client

2020-01-31 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add InBloomFilter predicate to C++ client .. Patch Set 2: (12 comments)

[kudu-CR] Add cloning support to BlockBloomFilter and associated allocator

2020-01-31 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 2: (3 comments)

[kudu-CR] Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

2020-01-28 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15120 Change subject: Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate .. Store the base BlockBloomFilterAllocatorIf ptr

[kudu-CR] Add cloning support to BlockBloomFilter and associated allocator

2020-01-28 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15121 Change subject: Add cloning support to BlockBloomFilter and associated allocator .. Add cloning support to BlockBloomFilter and

[kudu-CR] [client] KUDU-2483 Add InBloomFilter predicate to C++ client

2020-01-28 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15122 Change subject: [client] KUDU-2483 Add InBloomFilter predicate to C++ client .. [client] KUDU-2483 Add InBloomFilter predicate to C++

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: [utility] auto-detection of cloud VM instance type .. Patch Set 4: Code-Review+1 (6 comments)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 8: > Patch Set 8: Verified-1

[kudu-CR] [spark] Replace bad Guava import

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15084 ) Change subject: [spark] Replace bad Guava import .. Patch Set 1: Code-Review+1 -- To view, visit

<    4   5   6   7   8   9   10   11   >