[kudu-CR] Clarify error for permitted max tablets at creation time

2017-05-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Clarify error for permitted max tablets at creation time .. Clarify error for permitted max tablets at creation time Several users have been confused

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-09 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#6). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] Improve error message when trying to switch block managers

2017-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Improve error message when trying to switch block managers .. Improve error message when trying to switch block managers Change-Id:

[kudu-CR] KUDU-1056 and KUDU-1020 Safe time for ksck checksum

2017-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6843 Change subject: KUDU-1056 and KUDU-1020 Safe time for ksck checksum .. KUDU-1056 and KUDU-1020 Safe time for ksck checksum Now that

[kudu-CR] KUDU-1056 and KUDU-1020 Safe time for ksck checksum

2017-05-10 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6843 to look at the new patch set (#2). Change subject: KUDU-1056 and KUDU-1020 Safe time for ksck checksum ..

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-17 Thread Will Berkeley (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#15). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-17 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6772 to look at the new patch set (#7). Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-15 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6772 to look at the new patch set (#5). Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6850/5//COMMIT_MSG Commit Message: Line 12:

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 10: (1 comment)

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-16 Thread Will Berkeley (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#11). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-16 Thread Will Berkeley (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#12). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 7: > KUDU-1736 I mean the test failure is KUDU-1736. -- To view, visit

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-16 Thread Will Berkeley (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#13). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 7: KUDU-1736 -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-16 Thread Will Berkeley (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6850 to look at the new patch set (#6). Change subject: KUDU-2001 Add UNDO size to tablet on-disk size

[kudu-CR] KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue()

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue() .. KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue() The Java client was setting

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-15 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6772 to look at the new patch set (#6). Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 4: (8 comments)

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [webui] Improvements for when there's many tablets & cleanup .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG Commit

[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2005: actionable error messages from webserver .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6861 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2005: actionable error messages from webserver .. KUDU-2005: actionable error messages from webserver As it turned out, squeasel outputs only

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-12 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6850 to look at the new patch set (#5). Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. KUDU-2001 Add

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 5: > Huh. It occurs to me that this needs tests. :) Done. -- To view, visit

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [webui] Improvements for when there's many tablets & cleanup .. Patch Set 3: It is a bit more work- either rolling some javascript or picking and integrating

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [webui] Improvements for when there's many tablets & cleanup .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6870/1//COMMIT_MSG Commit

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-12 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6870 to look at the new patch set (#2). Change subject: [webui] Improvements for when there's many tablets & cleanup ..

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-12 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6870 to look at the new patch set (#3). Change subject: [webui] Improvements for when there's many tablets & cleanup ..

[kudu-CR] KUDU-1056 and KUDU-1020 Safe time for ksck checksum

2017-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1056 and KUDU-1020 Safe time for ksck checksum .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6843/2/src/kudu/tools/ksck_remote-test.cc

[kudu-CR] [webui] Fix placement of tombstone tablet blurb

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [webui] Fix placement of tombstone tablet blurb .. [webui] Fix placement of tombstone tablet blurb In b492d8ed3c, some text explaining what a

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [tools] Rename `kudu test` to `kudu perf` .. [tools] Rename `kudu test` to `kudu perf` This renames the `kudu test` action to `kudu perf`, for the

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7143 Change subject: Use the same replica selection when adding a server as table creation .. Use the same replica selection when adding a

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Use the same replica selection when adding a server as table creation .. Patch Set 1: (6 comments) Want some feedback from Adar before submitting the next PS

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Use the same replica selection when adding a server as table creation .. Patch Set 1: (1 comment)

[kudu-CR] [python] Fix undefined TimeoutError in tests

2017-06-12 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [python] Fix undefined TimeoutError in tests .. [python] Fix undefined TimeoutError in tests The tests use TimeoutError, which is not defined in Python

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-12 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7143 to look at the new patch set (#2). Change subject: Use the same replica selection when adding a server as table creation

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-12 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Use the same replica selection when adding a server as table creation .. Use the same replica selection when adding a server as table creation When

[kudu-CR] [python] Fix undefined TimeoutError in tests

2017-06-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [python] Fix undefined TimeoutError in tests .. Patch Set 2: Code-Review+2 Forwarding Todd's +2 (no changes; just rebase) -- To view, visit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7235 Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. [java] Replace interface-annotations with Apache

[kudu-CR] [java] Rename interface-annotations to kudu-interface-annotations

2017-06-20 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. Change subject: [java] Rename interface-annotations to kudu-interface-annotations .. Abandoned Superseded by http://gerrit.cloudera.org:8080/7235 -- To view, visit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#6). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] [java] Rename interface-annotations to kudu-interface-annotations

2017-06-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7234 Change subject: [java] Rename interface-annotations to kudu-interface-annotations .. [java] Rename interface-annotations to

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#2). Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. [java] Replace interface-annotations with Apache Yetus annotations Apache Yetus, like our

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#5). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#7). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] tools: refactor table-printing code a bit

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: tools: refactor table-printing code a bit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7259 To unsubscribe, visit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7235/6//COMMIT_MSG Commit

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 8: (1 comment) > I don't see Impala depending on interface-annotations, but I

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7260 To unsubscribe,

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#8). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7262 to look at the new patch set (#2). Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit

[kudu-CR] Fix SIGSEGV in ksck

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7261 to look at the new patch set (#4). Change subject: Fix SIGSEGV in ksck .. Fix SIGSEGV in ksck ksck will segfault

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [java] Replace interface-annotations with Apache Yetus annotations .. [java] Replace interface-annotations with Apache Yetus annotations Apache Yetus,

[kudu-CR] Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7262 Change subject: Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Fix too-strict CHECK in

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

2017-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7235 to look at the new patch set (#9). Change subject: [java] Replace interface-annotations with Apache Yetus annotations

[kudu-CR] Fix SIGSEGV in ksck

2017-06-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Fix SIGSEGV in ksck .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7261/3//COMMIT_MSG Commit Message: PS3, Line 9: the > nit: drop Done.

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-23 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-23 Thread Will Berkeley (Code Review)
Hello Andrew Wong, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7262 to look at the new patch set (#3). Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

[kudu-CR] KUDU-2001 Refactor rowset size estimates

2017-05-18 Thread Will Berkeley (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6850 to look at the new patch set (#8). Change subject: KUDU-2001 Refactor rowset size estimates

[kudu-CR] Improve logging during server startup

2017-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Improve logging during server startup .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6913 To unsubscribe, visit

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 8: (5 comments)

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6772 to look at the new patch set (#9). Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 1: I just want a Jenkins run. -- To view, visit http://gerrit.cloudera.org:8080/6967 To

[kudu-CR] KUDU-1755 Part 2: Improve table on-disk size metric

2017-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve table on-disk size metric .. Patch Set 1: I just want a Jenkins run. Needs tests. -- To view, visit

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6967 Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. KUDU-1755 Part 1: Improve tablet on disk size metric This adds

[kudu-CR] KUDU-1755 Part 2: Improve table on-disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve table on-disk size metric .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/1/src/kudu/tablet/tablet_replica.cc

[kudu-CR] KUDU-1755 Part 2: Improve table on-disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#2). Change subject: KUDU-1755 Part 2: Improve table on-disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#2). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 7: (8 comments) Both of your comments about more testing are things

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: (4 comments) I changed the names to - Remove the word "Estimate" because they aren't

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#3). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: > Also, I wonder if we shouldn't introduce an additional metric which > would capture

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6967/7/src/kudu/tablet/tablet_metadata.cc

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#8). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/6967/6/src/kudu/tablet/cfile_set.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#7). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#9). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#5). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/cfile_set.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#4). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 3: Actually I'm switching to "Tablet total size on disk" and "Tablet data size on disk" --

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#6). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6967/5/src/kudu/tablet/rowset.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 6: Unrelated failure in spark tests. I'm looking into the failure. -- To view, visit

[kudu-CR] Disable dense node-itest on OS X

2017-05-19 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6928 Change subject: Disable dense_node-itest on OS X .. Disable dense_node-itest on OS X This test always fails because of too many open

[kudu-CR] KUDU-2001 Refactor rowset size estimates

2017-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2001 Refactor rowset size estimates .. KUDU-2001 Refactor rowset size estimates Currently, Rowset::EstimateOnDiskSize() serves two purposes: 1. An

[kudu-CR] Disable dense node-itest on macOS

2017-05-19 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Disable dense_node-itest on macOS .. Disable dense_node-itest on macOS This test always fails because of too many open files, even with the limit

[kudu-CR] Disable dense node-itest on macOS

2017-05-19 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6928 to look at the new patch set (#3). Change subject: Disable dense_node-itest on macOS .. Disable dense_node-itest

[kudu-CR] Disable dense node-itest on OS X

2017-05-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Disable dense_node-itest on OS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6928/1/src/kudu/integration-tests/dense_node-itest.cc File

[kudu-CR] Disable dense node-itest on OS X

2017-05-19 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6928 to look at the new patch set (#2). Change subject: Disable dense_node-itest on OS X .. Disable dense_node-itest on

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 7: (54 comments)

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6772 to look at the new patch set (#8). Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 11: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/7954/ : FAILURE I

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [webui] Improvements for when there's many tablets & cleanup .. [webui] Improvements for when there's many tablets & cleanup This patch makes several

[kudu-CR] Fix ToolTest.TestFsCheck for Mac

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Fix ToolTest.TestFsCheck for Mac .. Fix ToolTest.TestFsCheck for Mac Stats on total live blocks aren't gathered for the FBM, which caused

[kudu-CR] Fix ToolTest.TestFsCheck for Mac

2017-05-16 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6899 Change subject: Fix ToolTest.TestFsCheck for Mac .. Fix ToolTest.TestFsCheck for Mac Stats on total live blocks aren't gathered for the

<    1   2   3   4   5   6   7   8   9   10   >