David Ribeiro Alves has posted comments on this change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Patch Set 2: Code-Review+2
thanks for adding the additional info
--
To view, visit
Jean-Daniel Cryans has posted comments on this change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3517/2//COMMIT_MSG
Kudu Jenkins has posted comments on this change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2079/
--
To view, visit
Hello Jean-Daniel Cryans, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3517
to look at the new patch set (#2).
Change subject: tablet: change default bloom filter FP rate to 0.01%
Adar Dembo has posted comments on this change.
Change subject: KUDU-1309: [java client] support tables with non-covering
partition-key ranges
..
Patch Set 4:
(7 comments)
Adar Dembo has posted comments on this change.
Change subject: locks: change kudu::shared_lock constructor to pass by ref
..
Patch Set 5: Verified+1
There was a build failure in the RELEASE build:
01:36:24 Linking CXX
Adar Dembo has posted comments on this change.
Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..
Patch Set 5: Verified+1
Overriding Jenkins, flaky ksck timeout test.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: [java-client] refactor AsyncKuduSession
..
Patch Set 3:
(16 comments)
Achievement unlocked: asynchronous programming wizard.
David Ribeiro Alves has posted comments on this change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3517/1/docs/release_notes.adoc
File
Sarah Jelinek has posted comments on this change.
Change subject: Persistent cache support for NVM
..
Patch Set 16:
(1 comment)
Pushed all code review changes.
Kudu Jenkins has posted comments on this change.
Change subject: Persistent cache support for NVM
..
Patch Set 16:
Build Started http://104.196.14.100/job/kudu-gerrit/2078/
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2593
to look at the new patch set (#16).
Change subject: Persistent cache support for NVM
..
Persistent cache support
Jean-Daniel Cryans has posted comments on this change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3517
To unsubscribe,
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3517
to review the following change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Kudu Jenkins has posted comments on this change.
Change subject: locks: add new read-write mutex
..
Patch Set 5: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2075/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: locks: change kudu::shared_lock constructor to pass by ref
..
Patch Set 5: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2076/
--
To view,
Adar Dembo has posted comments on this change.
Change subject: locks: add new read-write mutex
..
Patch Set 4:
(1 comment)
> (1 comment)
>
> LGTM with some concern regarding error detection if something goes
> wrong.
>
Kudu Jenkins has posted comments on this change.
Change subject: locks: switch from boost::shared_lock to kudu::shared_lock
..
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/2070/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2071/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/2069/
--
To view, visit
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3496
to look at the new patch set (#5).
Change subject: locks: add new read-write mutex
..
locks: add
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
KUDU-1496. NoLeaderMasterFoundException are mishandled
This is a regression from
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
Patch Set 1: Verified+1
Forcing +1 due to current messed up workspace.
--
To view, visit
Dan Burkert has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit
Kudu Jenkins has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2066/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2064/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: locks: add new read-write mutex
..
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2063/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: locks: switch from boost::shared_lock to kudu::shared_lock
..
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2065/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: locks: change kudu::shared_lock constructor to pass by ref
..
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2062/
--
To view, visit
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3496
to look at the new patch set (#4).
Change subject: locks: add new read-write mutex
..
locks: add
Dan Burkert has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3500
To unsubscribe, visit
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
Patch Set 1:
(1 comment)
> Oops.
>
> Outside of multi-master, this only manifests when the
Dan Burkert has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
Patch Set 1:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
Patch Set 1: Code-Review+2
Oops.
Outside of multi-master, this only manifests when the sole master is
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2061/
--
To view, visit
Todd Lipcon has posted comments on this change.
Change subject: Add a ToString() method to Proxy
..
Patch Set 1:
would be nice to add a new assertion to one of the RPC layer tests which calls
this
--
To view, visit
Todd Lipcon has posted comments on this change.
Change subject: Add 6/27 weekly update
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3515
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: Add 6/27 weekly update
..
Add 6/27 weekly update
Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2
Reviewed-on: http://gerrit.cloudera.org:8080/3515
Jean-Daniel Cryans has posted comments on this change.
Change subject: Add 6/27 weekly update
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3515
To unsubscribe, visit
Jean-Daniel Cryans has posted comments on this change.
Change subject: Add 6/27 weekly update
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3515/1/_posts/2016-06-27-weekly-update.md
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3500
to look at the new patch set (#2).
Change subject: thirdparty: add boost and switch to header-only build
..
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3497
to look at the new patch set (#3).
Change subject: locks: change kudu::shared_lock constructor to pass by ref
Kudu Jenkins has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2060/
--
To view, visit
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3515
to review the following change.
Change subject: Add 6/27 weekly update
..
Add 6/27 weekly update
Change-Id:
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
yea, ASAN does insert poisoning between variables on the stack:
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3511
To
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
..
Patch Set 1:
A java test failed due to https://issues.apache.org/jira/browse/KUDU-1496
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> Also not sure of the purpose of the extra red zones (ASAN
> would already insert those
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> I would like some careful eyes on this before we merge it, as the
> move semantics
Adar Dembo has posted comments on this change.
Change subject: Allow to force-override color diagnostics
..
Patch Set 1: Code-Review+2
Sounds like there's a reasonable use case for it.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc
File
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3514
to review the following change.
Change subject: ts_recovery-itest: fix flakiness in
TestRestartWithPendingCommitFromFailedOp
Kudu Jenkins has posted comments on this change.
Change subject: ts_recovery-itest: fix flakiness in
TestRestartWithPendingCommitFromFailedOp
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2055/
--
To
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3512/1/src/kudu/util/optional.h
File
Adar Dembo has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> I don't see the purpose of taking on this extra code. Code's a
> liability, not an
Adar Dembo has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
(3 comments)
I only skimmed this; I think a real review requires a level of C++ knowledge
Mike Percy has posted comments on this change.
Change subject: Migrate from boost::optional to kudu::optional
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tablet/memrowset.cc
File
Kudu Jenkins has posted comments on this change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
..
Patch Set 1: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2054/
--
To
Todd Lipcon has posted comments on this change.
Change subject: Allow to force-override color diagnostics
..
Patch Set 1:
I use something like this locally -- when I run 'ninja', it sometimes re-runs
cmake for me, but the
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1: Code-Review-1
I don't see the purpose of taking on this extra code. Code's a liability,
Mike Percy has posted comments on this change.
Change subject: Allow to force-override color diagnostics
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3509/1/CMakeLists.txt
File CMakeLists.txt:
Line 230:
Mike Percy has posted comments on this change.
Change subject: Update docs on how to run gcovr
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc
File README.adoc:
Line 241: $ mkdir cov_html
Kudu Jenkins has posted comments on this change.
Change subject: Migrate from boost::optional to kudu::optional
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2053/
--
To view, visit
Dan Burkert has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc
File
Kudu Jenkins has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2052/
--
To view, visit
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3512
to review the following change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Implement
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3513
to review the following change.
Change subject: Migrate from boost::optional to kudu::optional
..
Migrate from
Adar Dembo has posted comments on this change.
Change subject: Update docs on how to run gcovr
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc
File README.adoc:
Line 241: $ mkdir cov_html
Adar Dembo has posted comments on this change.
Change subject: thirdparty: add boost and switch to header-only build
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3500/1//COMMIT_MSG
Commit Message:
Line
Adar Dembo has submitted this change and it was merged.
Change subject: locks: stop using errno around base::NumCPUs and
base::MaxCPUIndex
..
locks: stop using errno around base::NumCPUs and base::MaxCPUIndex
It's not clear
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3511
to review the following change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
Adar Dembo has posted comments on this change.
Change subject: locks: add new read-write mutex
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc
File src/kudu/util/rw_mutex.cc:
Kudu Jenkins has posted comments on this change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2051/
--
To view,
Ara Ebrahimi has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3510
Change subject: kudu flume sink blog post
..
kudu flume sink blog post
Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A
Kudu Jenkins has posted comments on this change.
Change subject: Integrate the result tracker with writes
..
Patch Set 7: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2050/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the
client and ResultTracker with the server
..
Patch Set 6: -Verified
Build Started
Kudu Jenkins has posted comments on this change.
Change subject: Integrate the request tracker with the client
..
Patch Set 14:
Build Started http://104.196.14.100/job/kudu-gerrit/2047/
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3192
to look at the new patch set (#16).
Change subject: Integrate the ResultTracker into the rpc subsystem
..
Kudu Jenkins has posted comments on this change.
Change subject: Integrate the ResultTracker into the rpc subsystem
..
Patch Set 16:
Build Started http://104.196.14.100/job/kudu-gerrit/2049/
--
To view, visit
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Avoid missing 'override' keyword warnings in
raft_consensus-test.cc
..
Avoid missing 'override' keyword warnings in raft_consensus-test.cc
In
Kudu Jenkins has posted comments on this change.
Change subject: Allow to force-override color diagnostics
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2046/
--
To view, visit
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3508
Change subject: Update docs on how to run gcovr
..
Update docs on how to run gcovr
Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b
Todd Lipcon has posted comments on this change.
Change subject: Avoid missing 'override' keyword warnings in
raft_consensus-test.cc
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3289
To
Adar Dembo has posted comments on this change.
Change subject: locks: change kudu::shared_lock constructor to pass by ref
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3497/2/src/kudu/util/locks.h
File
Kudu Jenkins has posted comments on this change.
Change subject: Integrate the request tracker with the client
..
Patch Set 13: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2044/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: Disable exactly once semantics by default and add a flag to
enable it for tests
..
Patch Set 4: -Verified
Build Started
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3449
to look at the new patch set (#7).
Change subject: Integrate the result tracker with writes
..
Integrate the
Adar Dembo has posted comments on this change.
Change subject: Add a ToString() method to Proxy
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3502/1/src/kudu/rpc/proxy.cc
File src/kudu/rpc/proxy.cc:
Line
Kudu Jenkins has posted comments on this change.
Change subject: Integrate the ResultTracker into the rpc subsystem
..
Patch Set 15: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2041/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: Disable exactly once semantics by default and add a flag to
enable it for tests
..
Patch Set 4: -Verified
Build Started
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the
client and ResultTracker with the server
..
Patch Set 5: -Verified
Build Started
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3477
to look at the new patch set (#3).
Change subject: [java-client] refactor AsyncKuduSession
..
[java-client]
Dan Burkert has posted comments on this change.
Change subject: [java-client] refactor AsyncKuduSession
..
Patch Set 2:
(1 comment)
Kudu Jenkins has posted comments on this change.
Change subject: [java-client] refactor AsyncKuduSession
..
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2038/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: Integrate the result tracker with writes
..
Patch Set 6:
Build Started http://104.196.14.100/job/kudu-gerrit/2036/
--
To view, visit
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the
client and ResultTracker with the server
..
Patch Set 5:
Build Started
Kudu Jenkins has posted comments on this change.
Change subject: Disable exactly once semantics by default and add a flag to
enable it for tests
..
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2035/
--
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3505
to look at the new patch set (#5).
Change subject: Add a test for the integration of RequestTracker with the
client and ResultTracker with the server
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the
client and ResultTracker with the server
..
Patch Set 4: -Verified
Build Started
Dan Burkert has posted comments on this change.
Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3499
To
1 - 100 of 126 matches
Mail list logo