---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90031
---
Patch looks great!
Reviews applied: [36077, 36078, 35855, 35856,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36068/#review90033
---
Ship it!
Looks good to me, but I'll let BenH give the final
On July 1, 2015, 11:45 a.m., Till Toenshoff wrote:
When trying to apply locally, I get:
```
$ ./support/apply-review.sh 36071
2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/
[1338/1338] - 36071.patch [1]
36071.patch:15: new blank line at EOF.
+
error:
On July 1, 2015, 5:41 a.m., Kapil Arya wrote:
include/mesos/scheduler/scheduler.proto, lines 298-305
https://reviews.apache.org/r/36078/diff/1/?file=996383#file996383line298
May be I am missing something here, but shouldn't we avoid changing the
numbered tags for the message
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90098
---
Ship it!
Looks good, just one minor comment.
- Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/
---
(Updated July 1, 2015, 6:48 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/
---
(Updated July 1, 2015, 6:52 p.m.)
Review request for mesos, Anand Mazumdar,
On June 1, 2015, 1:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90095
---
src/master/master.cpp (line 2072)
On July 1, 2015, 3:45 p.m., Till Toenshoff wrote:
When trying to apply locally, I get:
```
$ ./support/apply-review.sh 36071
2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/
[1338/1338] - 36071.patch [1]
36071.patch:15: new blank line at EOF.
+
error:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36073/
---
(Updated July 1, 2015, 6:51 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated July 1, 2015, 3:24 p.m.)
Review request for mesos and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review90040
---
Ship it!
Looks good - just a few minor const. suggestions :)
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36071/#review90052
---
When trying to apply locally, I get:
```
$
On July 1, 2015, 1:54 a.m., Vinod Kone wrote:
src/master/master.cpp, line 369
https://reviews.apache.org/r/36036/diff/2/?file=996271#file996271line369
s/Release/Version/
as per @adam comment, I'm removing this from the log
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90120
---
Ship it!
+1 to Anand's comment since it is not a temporary.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90080
---
Looks good overall, mainly curious if 'force' should be optional,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/
---
(Updated July 1, 2015, 7:56 p.m.)
Review request for mesos, Anand Mazumdar,
On July 1, 2015, 7:48 a.m., Adam B wrote:
src/common/protobuf_utils.cpp, lines 147-149
https://reviews.apache.org/r/36036/diff/2/?file=996269#file996269line147
Could join these paragraphs. I think they're related enough, and the
first one is short.
Unless you feel strongly, I'd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/
---
(Updated July 1, 2015, 9:43 p.m.)
Review request for mesos, Adam B, Benjamin
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2014
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2014
I don't think we usually define a inline function like this anywhere
else, so curious to see what others think.
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2060
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060
Why add trailing underscore?
Jojy Varghese wrote:
As a member variable(is accepted according to mesos coding style
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/
---
(Updated July 1, 2015, 9:38 p.m.)
Review request for mesos, Ian Downes, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36072/#review90132
---
3rdparty/libprocess/include/process/http.hpp (line 455)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36073/#review90133
---
Ship it!
Ship It!
- Ben Mahler
On July 1, 2015, 6:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/
---
Review request for mesos, Ian Downes, Joris Van Remoortere, and Timothy Chen.
On July 1, 2015, 7:52 p.m., Ben Mahler wrote:
include/mesos/scheduler/scheduler.proto, line 167
https://reviews.apache.org/r/36078/diff/1/?file=996383#file996383line167
Hm.. first in which context? For HTTP, the scheduler has to keep a
working Subscribe connection to receive
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2014
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2014
I don't think we usually define a inline function like this anywhere
else, so curious to see what others think.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/#review90130
---
Ship it!
Ship It!
- Ben Mahler
On July 1, 2015, 6:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90140
---
src/linux/cgroups.hpp (lines 438 - 440)
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/tests/cgroups_tests.cpp, line 1192
https://reviews.apache.org/r/36106/diff/1/?file=997648#file997648line1192
Add using to the top of the tests
Since this is an alias (typedef) and scoped for the function.
- Jojy
On June 1, 2015, 1:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On July 1, 2015, 7:20 a.m., Adam B wrote:
I'm sorry, but I don't understand how LOG(FATAL) was segfaulting before.
Please explain.
Hi Adam,
This was reported as a segfault by a user in IRC. The specific segfault was
fixed by MESOS-2636.
The segfault _was_ happening under an error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/#review90076
---
support/post-reviews.py (lines 170 - 176)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35855/#review90016
---
src/master/master.cpp (line 1672)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/#review90014
---
I'm sorry, but I don't understand how LOG(FATAL) was segfaulting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review90019
---
I haven't looked at the patch itself, but looks like reviewbot is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review90021
---
Patch looks great!
Reviews applied: [36036]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review90024
---
Ship it!
Looks good. Remove the unnecessary logging, and clean up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90110
---
Ship it!
Ship It!
- Isabel Jimenez
On July 1, 2015, 5:28 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review90102
---
Adding some minor test-based comments.
src/tests/call_tests.cpp
On July 1, 2015, 7:20 a.m., Adam B wrote:
I'm sorry, but I don't understand how LOG(FATAL) was segfaulting before.
Please explain.
Joris Van Remoortere wrote:
Hi Adam,
This was reported as a segfault by a user in IRC. The specific segfault
was fixed by MESOS-2636.
The
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/tests/cgroups_tests.cpp, line 1192
https://reviews.apache.org/r/36106/diff/1/?file=997648#file997648line1192
Add using to the top of the tests
Jojy Varghese wrote:
Since this is an alias (typedef) and scoped for the
On July 1, 2015, 9:54 p.m., Marco Massenzio wrote:
src/linux/cgroups.cpp, line 2002
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2002
and, in any event, the variables should have a meaningful name - should
these be `userTime` or something?
(also, if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040/#review90187
---
Ship it!
3rdparty/libprocess/src/http.cpp (lines 778 - 780)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review90188
---
Ship it!
src/master/http.cpp (line 322)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36072/
---
(Updated July 2, 2015, 2:05 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/
---
(Updated July 2, 2015, 2:05 a.m.)
Review request for mesos, Anand Mazumdar,
On June 25, 2015, 8:25 a.m., Marco Massenzio wrote:
src/master/master.cpp, line 2831
https://reviews.apache.org/r/35855/diff/2/?file=991807#file991807line2831
not sure this is allowed in our code style, but this could be a good
place for `nullptr`
Also: shouldn't we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36114/
---
Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/
---
Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/
---
Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36112/
---
Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
Bugs:
On July 1, 2015, 9:54 p.m., Marco Massenzio wrote:
src/linux/cgroups.cpp, line 2002
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2002
and, in any event, the variables should have a meaningful name - should
these be `userTime` or something?
(also, if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/#review90158
---
Ship it!
Ship It!
- Benjamin Hindman
On July 1, 2015, 2:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36112/#review90159
---
src/linux/perf.cpp (line 454)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/
---
(Updated July 1, 2015, 10:20 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/
---
(Updated July 1, 2015, 10:19 p.m.)
Review request for mesos, Anand Mazumdar,
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2014
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2014
I don't think we usually define a inline function like this anywhere
else, so curious to see what others think.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90163
---
Patch looks great!
Reviews applied: [36077, 36078, 35855, 35856,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/#review90164
---
src/tests/perf_tests.cpp (line 87)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review90166
---
include/mesos/mesos.proto (line 1209)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35856/
---
(Updated July 1, 2015, 10:17 p.m.)
Review request for mesos, Anand Mazumdar,
On June 25, 2015, 6:25 p.m., Isabel Jimenez wrote:
src/master/master.hpp, line 1040
https://reviews.apache.org/r/35857/diff/2/?file=991810#file991810line1040
Is the purpose of moving this here to order Call handling methods? if
yes, should we move revive too?
the order matches
On June 25, 2015, 4:12 p.m., Marco Massenzio wrote:
src/tests/scheduler_tests.cpp, line 830
https://reviews.apache.org/r/35858/diff/1/?file=991725#file991725line830
This is a great test (in fact, this looks to me like something we could
extract as example of call sequences in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/
---
(Updated July 1, 2015, 10:18 p.m.)
Review request for mesos, Anand Mazumdar,
On June 25, 2015, 5:20 p.m., Isabel Jimenez wrote:
src/scheduler/scheduler.cpp, line 306
https://reviews.apache.org/r/35858/diff/1/?file=991724#file991724line306
Now that we're sending calls in every case (besides SUBSCRIBE) of this
switch, I suppose it'll be better to move this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90161
---
src/linux/perf.cpp (line 468)
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2060
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060
Why add trailing underscore?
Jojy Varghese wrote:
As a member variable(is accepted according to mesos coding style
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35998/#review90018
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review90017
---
Bad patch!
Reviews applied: [35934, 36073, 35934]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90011
---
include/mesos/scheduler/scheduler.proto (line 188)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/#review90171
---
Ship it!
Ship It!
- Benjamin Hindman
On July 1, 2015, 12:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90174
---
Patch looks great!
Reviews applied: [36106]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/
---
(Updated July 1, 2015, 5:22 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90167
---
src/linux/perf.cpp (lines 471 - 472)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36114/#review90170
---
src/linux/perf.cpp (line 473)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/#review90177
---
src/tests/perf_tests.cpp (lines 76 - 84)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36116/
---
(Updated July 1, 2015, 5:44 p.m.)
Review request for mesos, Artem Harutyunyan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/#review90182
---
Patch looks great!
Reviews applied: [36112, 36113, 36114, 36115]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35919/#review90183
---
3rdparty/libprocess/include/process/firewall.hpp (line 59)
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2060
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060
Why add trailing underscore?
Jojy Varghese wrote:
As a member variable(is accepted according to mesos coding style
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36112/#review90168
---
src/linux/perf.cpp (lines 448 - 458)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90178
---
Ship it!
Ship It!
- Benjamin Hindman
On July 2, 2015, 12:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34142/#review90173
---
src/slave/containerizer/provisioners/appc.cpp (lines 143 - 151)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36114/#review90180
---
src/linux/perf.cpp (line 473)
88 matches
Mail list logo
