Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review150988 --- Bad patch! Reviews applied: [52310, 52309, 52308] Failed

Re: Review Request 52350: Used a separator in nested freezer cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52350/#review150986 --- Ship it! - Jie Yu On Sept. 29, 2016, 11:22 p.m., Benjamin

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- (Updated Sept. 29, 2016, 10:19 p.m.) Review request for mesos, Artem

Review Request 52416: Made 'parse' method in linux launcher take a real cgroup path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52416/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 52415: Extended buildPath to support more modes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52415/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review150983 --- Patch looks great! Reviews applied: [52250, 52251, 52252, 52253]

Re: Review Request 52395: Updated the document link of 'Image Provisioning Design'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52395/#review150980 --- Patch looks great! Reviews applied: [52395] Passed command:

Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 50498: Added --pid_group flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/#review150974 --- src/master/flags.cpp (line 561)

Re: Review Request 50493: Added `base` to PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/#review150971 --- 3rdparty/libprocess/include/process/pid_group.hpp (lines 54 -

Re: Review Request 52406: Marked 'volume/sandbox_path' as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52406/#review150969 --- Ship it! Ship It! - Gilbert Song On Sept. 29, 2016, 1:18

Re: Review Request 50491: Added PIDGroup to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50491/#review150959 --- 3rdparty/libprocess/include/process/pid_group.hpp (lines 57 -

Re: Review Request 52350: Used a separator in nested freezer cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52350/ --- (Updated Sept. 29, 2016, 11:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52350: Used flags.cgroups_root in nested freezer cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52350/ --- (Updated Sept. 29, 2016, 11:14 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51654: Fixed help display for mesos-containerizer subcommands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/#review150964 --- Patch looks great! Reviews applied: [51654] Passed command:

Re: Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52408/#review150962 --- Ship it! src/slave/slave.cpp (line 3395)

Re: Review Request 52329: Fixed logging in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52329/#review150961 --- Ship it! Gotcha, the containerId is included in the agent

Re: Review Request 52329: Fixed logging in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52329/#review150960 --- Ship it! Ship It! - Benjamin Mahler On Sept. 29, 2016, 1:17

Re: Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52408/ --- (Updated Sept. 29, 2016, 10:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52408/#review150956 --- src/slave/slave.hpp (line 328)

Re: Review Request 52407: Added `RecoveryInfo` struct to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52407/#review150955 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2016, 10:08

Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52408/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6274

Review Request 52407: Added `RecoveryInfo` struct to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52407/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6274

Re: Review Request 52364: Added basic support to invoke `docker.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/#review150932 --- src/docker/docker.cpp (lines 62 - 66)

Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer.

> On Sept. 29, 2016, 8:08 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/composing.cpp, lines 534-560 > > > > > > Would it be a bit simpler to do something like this? > > > > ``` > > if

Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52330/ --- (Updated Sept. 29, 2016, 9:09 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

> On Sept. 9, 2016, 11:04 a.m., Gastón Kleiman wrote: > > src/health-check/health_checker.cpp, line 515 > > > > > > nit: I'd call this `tcpHealthCheckerPath` If we update the binary name, yes : ). However, I still

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

> On Sept. 6, 2016, 3:31 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 155-159 > > > > > > I think we need to put this after `MESOS_DOCKER_EXECUTOR` to keep the > >

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

> On Sept. 6, 2016, 6:34 p.m., Avinash sridharan wrote: > > src/health-check/tcp_connect.cpp, line 74 > > > > > > Why tcpThreeway? we are not testing the TCP threeway handshake > > (implicitly we are, but still).

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

> On Sept. 9, 2016, 10:58 a.m., Gastón Kleiman wrote: > > src/Makefile.am, line 1377 > > > > > > I also agree, creating an issue, so that this doesn't fall between the > > cracks =). See my comment above. -

Re: Review Request 52406: Marked 'volume/sandbox_path' as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52406/#review150938 --- Ship it! Ship It! - Joseph Wu On Sept. 29, 2016, 1:18 p.m.,

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

> On Sept. 2, 2016, 4:53 p.m., haosdent huang wrote: > > src/Makefile.am, line 1377 > > > > > > I think the name `mesos-tcp-connect` may be not clear enough. Should we > > add something like `health-check` into

Re: Review Request 52405: Skipped isolator callbacks for nested containers if needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52405/#review150933 --- Fix it, then Ship it!

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

> On Sept. 29, 2016, 4:35 p.m., Benjamin Bannier wrote: > > Why does this need to be an extra commit? It appears it should just be > > folded into https://reviews.apache.org/r/51605/ which adds this target for > > the automake setup. Because it's in libprocess. - Alexander

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/ --- (Updated Sept. 29, 2016, 8:37 p.m.) Review request for mesos, Xiaojian Huang,

Review Request 52406: Marked 'volume/sandbox_path' as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52406/ --- Review request for mesos, Gilbert Song and Joseph Wu. Repository: mesos

Review Request 52405: Skipped isolator callbacks for nested containers if needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52405/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Sept. 29, 2016, 8:09 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52330/#review150917 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp

Re: Review Request 52357: Improved handling of health check failures within the grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review150922 --- src/tests/health_check_tests.cpp (line 1333)

Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/#review150915 --- Ship it! Ship It! - Vinod Kone On Sept. 28, 2016, 6:22

Re: Review Request 52153: Fixed openssl CA location logging.

> On Sept. 22, 2016, 7:58 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/openssl.cpp, line 493 > > > > > > I recall that we prefer `.at(...)` even when there's an existence check > > directly preceeding the map

Re: Review Request 51617: Added the `remove` and `insert` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review150911 --- Patch looks great! Reviews applied: [51736, 51737, 51740, 51767,

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

> On Sept. 28, 2016, 6:03 p.m., Joseph Wu wrote: > > src/slave/slave.cpp, lines 4340-4346 > > > > > > Once you've moved the logic block up to the top of this method, you may > > be able to simplify this logic too

Review Request 52392: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52392/ --- Review request for mesos. Repository: mesos Description --- Switch the

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 29, 2016, 6:47 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 29, 2016, 6:51 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 29, 2016, 6:47 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 29, 2016, 6:47 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

> On Sept. 28, 2016, 6:03 p.m., Joseph Wu wrote: > > This commit should be good-to-go (no further changes needed). I'll commit > > it with the rest of the chain, when the whole chain is ready. Great. Will fix the rest of the comments later today. Thanks. - Sivaram

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 29, 2016, 6:38 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 29, 2016, 6:37 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 29, 2016, 6:37 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Sept. 29, 2016, 5:43 p.m.) Review request for mesos, Alexander

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Sept. 29, 2016, 5:44 p.m.) Review request for mesos, Alexander

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Sept. 29, 2016, 5:44 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Sept. 29, 2016, 5:43 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Sept. 29, 2016, 5:39 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Sept. 29, 2016, 5:40 p.m.) Review request for mesos, Alexander

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Sept. 29, 2016, 5:39 p.m.) Review request for mesos, Alexander

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Sept. 29, 2016, 5:39 p.m.) Review request for mesos, Alexander

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Sept. 29, 2016, 5:35 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/#review150876 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 5, 2016,

Re: Review Request 49906: Add lawrencew to contributors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49906/#review150872 --- Ship it! Ship It! - Alexander Rukletsov On July 11, 2016,

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/#review150869 --- Patch looks great! Reviews applied: [52349, 52379, 52382]

Re: Review Request 52153: Fixed openssl CA location logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52153/#review150868 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 22, 2016,

Re: Review Request 52357: Improved handling of health check failures within the grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review150865 --- src/tests/health_check_tests.cpp (line 1336)

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/#review150867 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 22, 2016,

Re: Review Request 52031: Added openssl error string output to initializing failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52031/#review150866 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 22, 2016,

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/#review150862 --- Why does this need to be an extra commit? It appears it should

Re: Review Request 51654: Fixed help display for mesos-containerizer subcommands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/ --- (Updated Sept. 29, 2016, 6:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51560: Support health check without specifying `type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review150861 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 29, 2016,

Re: Review Request 51930: Introduced Linux capabilities support for Mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51930/ --- (Updated Sept. 29, 2016, 6:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52301: Added test case `HealthCheckTest.HealthyTaskViaHTTPWithoutType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52301/#review150860 --- Fix it, then Ship it! I'll fix the outstanding issues and

Review Request 52395: Updated the document link of 'Image Provisioning Design'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52395/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos

Re: Review Request 52081: Reorganized includes in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52081/ --- (Updated Sept. 29, 2016, 6:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 29, 2016, 6:20 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 29, 2016, 3:55 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 29, 2016, 3:55 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 29, 2016, 3:54 p.m.) Review request for mesos and Joseph Wu.

Review Request 52393: Allowed malformatted docker config file from '--docker_config'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52393/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review150823 --- src/slave/containerizer/fetcher.cpp (lines 755 - 756)

Review Request 51617: Added the `remove` and `insert` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6023

Re: Review Request 52388: Added compile-time check for correct inheritance in Flags hierarchies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52388/#review150857 --- Bad review! Reviews applied: [52388, 46825, 46824, 46823]

Re: Review Request 52357: Improved handling of health check failures within the grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/ --- (Updated Sept. 29, 2016, 3:30 p.m.) Review request for mesos, Alexander

Re: Review Request 44331: Added a test to ensure the allocator does not double account resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44331/#review150851 --- Patch looks great! Reviews applied: [43105, 44331] Passed

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/ --- (Updated Sept. 29, 2016, 10:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/ --- (Updated Sept. 29, 2016, 10:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/ --- (Updated Sept. 29, 2016, 10:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52384: Correctly used variables in test shell scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52384/#review150848 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 29, 2016,

Review Request 52384: Correctly used variables in test shell scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52384/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 52388: Added compile-time check for correct inheritance in Flags hierarchies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52388/ --- Review request for mesos and Michael Park. Bugs: MESOS-3335

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/ --- (Updated Sept. 29, 2016, 2:55 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Sept. 29, 2016, 2:55 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated Sept. 29, 2016, 2:55 p.m.) Review request for mesos, Alexander

Review Request 52390: Fully qualified addresses of Flag members in add calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52390/ --- Review request for mesos. Bugs: MESOS-3335

Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52387/ --- Review request for mesos and Michael Park. Bugs: MESOS-3335

Review Request 52386: Deleted potentially implicitly generated functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52386/ --- Review request for mesos and Michael Park. Bugs: MESOS-3335

Review Request 49829: Consistently used virtual inheritance for Flags classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49829/ --- Review request for mesos and Michael Park. Bugs: MESOS-3335

Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49833/ --- Review request for mesos and Michael Park. Bugs: MESOS-3335

  1   2   >