Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Review Request 52975: Factored out the create port range logic to test utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/#review153028 --- docs/configuration.md (line 1003)

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review153030 --- src/docker/docker.hpp (line 51)

Re: Review Request 52967: Improved documentation for shared persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52967/#review153026 --- Patch looks great! Reviews applied: [52965, 52966, 52967]

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review153025 --- 3rdparty/stout/Makefile.am (line 27)

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review153024 --- 3rdparty/libprocess/src/encoder.hpp (line 291)

Re: Review Request 52625: Replaced POSIX `int` with `FileDesc` abstraction in `libprocess` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Oct. 18, 2016, 2:47 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- (Updated Oct. 18, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu, Alex

Review Request 52972: Replaced POSIX `int` with `FileDesc` abstraction in `stout` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- Review request for mesos. Repository: mesos Description --- Replaced

Re: Review Request 52544: Introduced `FileDesc` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Oct. 18, 2016, 2:45 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153021 --- src/slave/containerizer/docker.hpp (lines 258 - 274)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review153020 --- src/slave/containerizer/docker.hpp (line 76)

Re: Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review153014 --- Patch looks great! Reviews applied: [52780, 52741] Passed

Review Request 52970: Fixed a comment and some style issues in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52970/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6282

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review153013 --- The `MasterTest.MasterFailoverLongLivedExecutor` failing

Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/ --- (Updated Oct. 18, 2016, 1:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

> On Oct. 18, 2016, 12:35 a.m., Vinod Kone wrote: > > src/tests/master_authorization_tests.cpp, line 783 > > > > > > This test looks identical to SlaveRemoved test. Please kill this in a > > different review.

Review Request 52969: Removed redundant test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52969/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- (Updated Oct. 18, 2016, 1:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52953: Added container 'exec' command to the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52953/#review153006 --- src/cli_new/lib/mesos/plugins/container/main.py (line 30)

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/#review153003 --- src/cli_new/bin/tests.py (lines 23 - 25)

Re: Review Request 52943: Updated CLI pylint configuration to disable no-self-use warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52943/#review153005 --- Ship it! I see this warning here:

Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review153009 --- Ship it! Considering how we love TODOs on our codebase, this

Re: Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52658/ --- (Updated Oct. 18, 2016, 1:01 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52941/#review153008 --- src/cli_new/pylint.config (line 15)

Re: Review Request 52940: Updated CLI pylint configuration to allow up to 30 local variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52940/#review152998 --- src/cli_new/pylint.config (line 14)

Re: Review Request 52968: Added `mesos-cni-port-mapper` to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52968/ --- (Updated Oct. 18, 2016, 1 a.m.) Review request for mesos and Jie Yu. Changes

Re: Review Request 52939: Updated CLI pylint configuration to allow 2 character variable names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52939/#review153007 --- src/cli_new/pylint.config (line 13)

Re: Review Request 52968: Added `mesos-cni-port-mapper` to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52968/#review153010 --- Ship it! Ship It! - Jie Yu On Oct. 18, 2016, 12:57 a.m.,

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/#review153004 --- Fix it, then Ship it!

Review Request 52968: Added `mesos-cni-port-mapper` to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52968/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 52967: Improved documentation for shared persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52967/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Review Request 52966: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52966/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Review Request 52965: Added missing titles to documentation pages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52965/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/#review152999 --- Fix it, then Ship it!

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152989 --- Fix it, then Ship it!

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review152997 --- Ship it! Ship It! - Vinod Kone On Oct. 13, 2016, 2:10 p.m.,

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/ --- (Updated Oct. 18, 2016, 12:02 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52809: User Namespaces Initial Implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- (Updated Oct. 17, 2016, 11:59 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 11:58 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52543: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52543/#review152994 --- Patch looks great! Reviews applied: [52939, 52940, 52941, 52942,

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

> On Oct. 17, 2016, 11:30 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1507-1508 > > > > > > Looks like CNI spec does not specify if stdout will be empty or not. > >

Re: Review Request 52771: Captured the `stderr` during execution of CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/#review152988 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52658/#review152986 --- Fix it, then Ship it! src/sched/sched.cpp (line 1305)

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/#review152975 --- Fix it, then Ship it!

Re: Review Request 52657: Clarified a comment that occurs in several tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52657/#review152985 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 11:50 p.m.,

Re: Review Request 52656: Cleaned up a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52656/#review152984 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 11:50 p.m.,

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 10:56 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review152977 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 2858)

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 10:27 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 10:27 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 10:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/#review152971 --- Fix it, then Ship it! Thanks!!! docs/linux_capabilities.md

Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52780/#review152970 --- src/v1/mesos.cpp (lines 517 - 533)

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 10:11 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review152969 --- Fix it, then Ship it! src/cli/execute.cpp (line 690)

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52682/#review152968 --- Fix it, then Ship it!

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 229 > > > > > > This is too many threads. An executor of a

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 186 > > > > > > s/isInterrupted/interrupted/... its a

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java, > > line 88 > > > > > > Why we have a MemStoreSegmentsIterator and not

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 120 > > > > > > Has to be public? This method is used by

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 91 > > > > > > Does this need to be atomic reference or volatile

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java, > > line 93 > > > > > > Why not do this always? Why an option? This

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > Patch looks fine to me. What was the fix? A few comments in the below. How > > to test? Thanks Anastasia. The recent bug was in merging MSLABs. We didn't reference the open scan counters from the old MSLABs to the new merged MSLAB. No we

Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

> On Oct. 17, 2016, 11:22 a.m., Neil Conway wrote: > > The mode of a volume doesn't necessarily have anything to do with whether > > the volume is shared -- perhaps it would be better to document this in the > > persistent-volume doc page, and link to it from here? It makes sense to have a

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java, > > line 398 > > > > > > What is an initiateType? I like

Re: Review Request 52543: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52543/ --- (Updated Oct. 17, 2016, 8:26 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Review Request 52952: Added a 'container' plugin to the CLI with a 'list()' command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52952/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52950: Extended the basic CLI unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52950/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/ --- (Updated Oct. 17, 2016, 8:11 p.m.) Review request for mesos, Haris Choudhary

Review Request 52948: Added a Table abstraction and some utility functions to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52948/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52953: Added container 'exec' command to the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52953/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52951: Introduced the notion of an AGENT_IP in the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52951/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52947: Updated parsing for CLI config to be more dynamic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52947/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52946: Fixed some bugs in the CLI help formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52946/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52941/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52942: Updated CLI pylint configuration to ignore the 'netifaces' module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52942/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52945: Added the ability for a CLI plugin command to have an alias.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52945/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52939: Updated CLI pylint configuration to allow 2 character variable names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52939/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52940: Updated CLI pylint configuration to allow up to 30 local variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52940/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Review Request 52943: Updated CLI pylint configuration to disable no-self-use warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52943/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5676

Re: Review Request 52879: Updated the way in which the default and command executors load options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152940 --- src/launcher/default_executor.cpp (lines 1015 - 1042)

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52934/#review152938 --- Patch looks great! Reviews applied: [52934] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

> On Oct. 14, 2016, 11:23 p.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > >

Re: Review Request 52880: Added "launcher_dir" to the default executor flags.

> On Oct. 14, 2016, 8:25 p.m., Jiang Yan Xu wrote: > > This is conversation carried over from /r/52556/ > > > > Now that we're in the business of (re)naming things for consistency, > > understandability and unambiguity, how about we just follow some widely > > used conventions: > >

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152897 ---

Re: Review Request 51617: Added the logic for installing and removing DNAT rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 17, 2016, 7:12 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Oct. 17, 2016, 6:58 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Oct. 17, 2016, 6:57 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/ --- (Updated Oct. 17, 2016, 6:54 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52934/#review152923 --- The mode of a volume doesn't necessarily have anything to do with

Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52934/ --- Review request for mesos, (Disabled_DoNotUse) Anindya Sinha and Neil Conway.

Re: Review Request 52879: Updated the way in which the default and command executors load options.

> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/default_executor.cpp, line 1034 > > > > > > Let's use `agent_pid` here? Since we rename slave to agent. > > haosdent huang wrote: > hmm, I

Re: Review Request 52879: Updated the way in which the default and command executors load options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152914 --- Do you forget to update the

Re: Review Request 52878: Removed outdated TODO in stout::flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52878/#review152913 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2016, 1:35

  1   2   >