: https://reviews.apache.org/r/67863/diff/3-4/
Testing
---
make
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
: https://reviews.apache.org/r/67863/diff/3/
Changes: https://reviews.apache.org/r/67863/diff/2-3/
Testing
---
make
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
esos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3
include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1
Diff: https://reviews.apache.org/r/67779/diff/4/
Changes: https://reviews.apache.org/r/67779/diff/3-4/
Testing
---
Test done later in chain.
Thanks,
Chun-Hung Hsiao
/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
/storage/provider.cpp
b90a4b81838fec410a97a10ce44a811bb81c87eb
Diff: https://reviews.apache.org/r/67892/diff/1/
Testing
---
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
Diff: https://reviews.apache.org/r/67863/diff/2/
Changes: https://reviews.apache.org/r/67863/diff/1-2/
Testing
---
make
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
lude/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3
include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1
Diff: https://reviews.apache.org/r/67779/diff/3/
Changes: https://reviews.apache.org/r/67779/diff/2-3/
Testing
---
Test done later in chain.
Thanks,
ly, visit:
https://reviews.apache.org/r/67863/#review205961
-------
On July 10, 2018, 3:11 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
ly doesn't matter at all lol. The code this test covers is
basically the same.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205968
------
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67779/#review205965
---
On July 10, 2018, 3:10 a.m., Chun-Hung Hsiao wrote:
>
> --
ll go with it.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67779/#review205966
---
On July 10, 2018
tically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67779/#review205965
---
On July 10, 2018, 3:10 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an autom
//man7.org/linux/man-pages/man3/fts.3.html
Diffs
-
3rdparty/stout/include/stout/os/posix/rmdir.hpp
947bb243ca3ad070497369f8108064d9f4c58b30
Diff: https://reviews.apache.org/r/67881/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
Lines 591-592 (patched)
<https://reviews.apache.org/r/66048/#comment288872>
```
// This test verifies that the agent will provision a persistent volume on
a proper path
// when the volume is created by an offer operation.
```
- Chun-Hung Hsiao
On March 13, 2018, 10:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66048/#review205947
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On March 13, 2018, 10
pache.org/r/67849/#comment288871>
Do we need to make this public? If we're just using the comparison and
output operators, then it seems better to move them directly into `spec.hpp`
and keep this file private.
- Chun-Hung Hsiao
On July 6, 2018, 8:50 p.m., Benjamin B
rk due
to the inconsistent path.
Ditto below.
- Chun-Hung Hsiao
On July 6, 2018, 8:50 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
sudo make check
Thanks,
Chun-Hung Hsiao
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67670/diff/3/
Changes: https://reviews.apache.org/r/67670/diff/2-3/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/67876/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
Thanks,
Chun-Hung Hsiao
95#file2056895line887>
> >
> > Why are changes to the allocator in this file? Should they go somewhere
> > else where we enable a feature or explicitly fix a bug? We should probably
> > also add a test.
>
> Chun-Hung Hsiao wrote:
> We don't
.
Thanks,
Chun-Hung Hsiao
he additional
`toUnreserved()` call.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/#review205911
---
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67663/#review205914
-------
On June 21, 2018, 4:27 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an au
to `first` and
> > `second`.
`foreachpair` does not work for `google::protobuf::Map` hence `foreach`.
Dropping.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/676
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67670/#review205912
---
On June 21, 2018, 5:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/#review205911
---
On July 10, 2018, 5:58 p.m., Chun-Hung Hsiao wrote:
>
> ---
>
mail. To reply, visit:
https://reviews.apache.org/r/67669/#review205911
-------
On July 10, 2018, 5:58 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically gener
e5e86513dc4023d9c471753897635923c6c9203f
src/tests/sorter_tests.cpp 266a9e72597b3aadc9756f61736c0adf0b1a5831
Diff: https://reviews.apache.org/r/67669/diff/4/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
,
Chun-Hung Hsiao
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67864/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/67863/diff/1/
Testing
---
make
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
nks,
Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67847/#review205869
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 6, 2018, 8:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205864
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 6, 2018, 7:37
> On July 5, 2018, 9:55 p.m., Chun-Hung Hsiao wrote:
> > src/master/http.cpp
> > Lines 3821 (patched)
> > <https://reviews.apache.org/r/67693/diff/3/?file=2044470#file2044470line3821>
> >
> > Do we want to:
> > 1. Simply skip such operations
changes for this in rev2? Reopening for easier tracking.
>
> Chun-Hung Hsiao wrote:
> Created https://issues.apache.org/jira/browse/MESOS-9016 for this.
>
> Chun-Hung Hsiao wrote:
> I forgot to sent out the reply yesterday :(
Dropping thi
ch updates. In order to support
> > operations changing the quantity of the stripped resources we need to do
> > additional work.
>
> Chun-Hung Hsiao wrote:
> I added a unit test and updated the description of `Sorter::update`, but
> I'm hesitating to add some more concret
://reviews.apache.org/r/67669/diff/3/
Changes: https://reviews.apache.org/r/67669/diff/2-3/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
---
sudo make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/67664/diff/2-3/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
eeded for a later change? It looks like it should be
> > fine to just remove entries from `profileMatrix` and then drive logic with
> > e.g., `contains` checks.
>
> Chun-Hung Hsiao wrote:
> The profile data is kept in `profileMatrix` even for inactive profiles
> because I
/7/
Changes: https://reviews.apache.org/r/65640/diff/6-7/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67671/#review205816
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 6, 2018, 8:50
tps://reviews.apache.org/r/67671/#comment288680>
Let's do a `CHECK(resourceProviderInfo.has_id())` here. Otherwise this
function may create an invalid
`mesos::resource_provider::registry::ResourceProvider` since `id` is required.
- Chun-Hung Hsiao
On June 20, 2018, 12:35 p.m., Benjamin B
type = 2;
optional string name = 3;
```
- Chun-Hung Hsiao
On June 20, 2018, 12:35 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To r
v1Response = post(agent.get()->pid, v1Call, contentType,
DEFAULT_CREDENTIAL_2);
```
- Chun-Hung Hsiao
On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically gene
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67824/#review205704
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 4, 2018, 12:06
point.
continue;
} else {
break;
}
```
Please feel free to drop this if you think this is not necessary.
- Chun-Hung Hsiao
On July 3, 2018, 10:08 p.m., Zhitao Li wrote:
>
> ---
> This is an automatica
779/diff/1/
Testing
---
Thanks,
Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67778/#review205540
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On June 28, 2018, 11:31
(patched)
<https://reviews.apache.org/r/67501/#comment288239>
Is it because that implementing explicit objects takes significant efforts
and has a lower priority, so we decided to leave it as a TODO?
- Chun-Hung Hsiao
On June 25, 2018, 1:58 p.m., Jan Schlicht
> On June 21, 2018, 3:39 p.m., Chun-Hung Hsiao wrote:
> > include/mesos/authorizer/acls.proto
> > Lines 534 (patched)
> > <https://reviews.apache.org/r/67501/diff/3/?file=2044102#file2044102line534>
> >
> > The patch looks good overall. B
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67670/#review205061
-------
On June 21, 2018, 5:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This i
-mail. To reply, visit:
https://reviews.apache.org/r/67670/#review205061
-------
On June 21, 2018, 5:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67670/
Lines 534 (patched)
<https://reviews.apache.org/r/67501/#comment288120>
The patch looks good overall. But I'd like to raise a discussion about the
object entity. Why are we planning to use resource providers but not roles,
like the other offer operations?
- Chun-Hung Hsiao
On June 21
://reviews.apache.org/r/67670/diff/2/
Changes: https://reviews.apache.org/r/67670/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
/diff/2/
Changes: https://reviews.apache.org/r/67669/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
ously, but I cannot find a good way
to validate that. Suggestions?
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/#review205079
-------
. This patch fixes this bug.
Diffs (updated)
-
src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697
Diff: https://reviews.apache.org/r/67668/diff/2/
Changes: https://reviews.apache.org/r/67668/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
(updated)
-
src/tests/storage_local_resource_provider_tests.cpp
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67667/diff/2/
Changes: https://reviews.apache.org/r/67667/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/67666/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
Diff: https://reviews.apache.org/r/67664/diff/2/
Changes: https://reviews.apache.org/r/67664/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
.
Thanks,
Chun-Hung Hsiao
wondering what actually requires `ROOT` in this test. I see we
> > enable filesystem isolation, but is that required?
>
> Chun-Hung Hsiao wrote:
> The SLRP launches the CSI plugin in a standalone container, and it seems
> safer to enable the isolation. In contrast, I could disable
eeded for a later change? It looks like it should be
> > fine to just remove entries from `profileMatrix` and then drive logic with
> > e.g., `contains` checks.
>
> Chun-Hung Hsiao wrote:
> The profile data is kept in `profileMatrix` even for inactive profiles
> because I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67670/#review205061
---
On June 20, 2018, 5:34 a.m., Chun-Hung Hsiao wr
cy.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67667/#review205059
---
On June 20, 2018, 5:33 a.m., Chun-Hung Hsiao wr
parse this sentence lol. I'll simplify the comment.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67666/#review205056
-------
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review205082
---
On June 20, 2018, 5:37 a.m., Chun-Hung Hsiao wrote:
>
> ---
>
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67663/#review205073
---
On June 20, 2018, 5:32 a.m., Chun-Hung Hsiao wrote:
>
>
9c4da8811cc260bcf3bccfea3036a7964cb75697
Diff: https://reviews.apache.org/r/67668/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
with a disappeared
profile will be recovered with a newly appeared profile.
Diffs
-
src/tests/storage_local_resource_provider_tests.cpp
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67670/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
Diff: https://reviews.apache.org/r/67669/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
/disk_profile_adaptor_tests.cpp
4485f1635f484ce6e1c7c532eedb277f5eee118b
src/tests/disk_profile_server.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/67666/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
k profiles.
Diffs
-
src/tests/storage_local_resource_provider_tests.cpp
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67665/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
8edd652f7f410dbadaf6c2ca3736349065e4340a
src/tests/slave_tests.cpp b46fb8efc524852f62428040ff958bd44e9efe9f
Diff: https://reviews.apache.org/r/67664/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
/67667/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
5db5a8da85f02323a5654c93ac47ec4aa7e711d2
Diff: https://reviews.apache.org/r/65875/diff/3/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
4485f1635f484ce6e1c7c532eedb277f5eee118b
Diff: https://reviews.apache.org/r/67663/diff/1/
Testing
---
sudo make check
A end-to-end test will be added later in the chain.
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/65640/diff/6/
Changes: https://reviews.apache.org/r/65640/diff/5-6/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
.
Diffs (updated)
-
src/resource_provider/storage/provider.cpp
b90a4b81838fec410a97a10ce44a811bb81c87eb
Diff: https://reviews.apache.org/r/65976/diff/6/
Changes: https://reviews.apache.org/r/65976/diff/5-6/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
---
sudo make check
Thanks,
Chun-Hung Hsiao
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/65995/diff/9/
Changes: https://reviews.apache.org/r/65995/diff/8-9/
Testing
---
sudo make check
Ran the two tests in repitition.
Thanks,
Chun-Hung Hsiao
/storage_local_resource_provider_tests.cpp
1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/65995/diff/8/
Changes: https://reviews.apache.org/r/65995/diff/7-8/
Testing
---
sudo make check
Ran the two tests in repitition.
Thanks,
Chun-Hung Hsiao
son to `settle` before we `advance`, we should add a
> > comment, otherwise I would expect a sequence of first `advance`, then
> > `settle`.
> >
> > We don't seem to be very disciplined to _always_ `settle` after and
> > `advance` in this file, we could clean
-------
On June 14, 2018, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65995/
> --
---
sudo make check
Thanks,
Chun-Hung Hsiao
t:
https://reviews.apache.org/r/65640/#review204923
-------
On June 14, 2018, 12:20 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e
://reviews.apache.org/r/67596/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
` is also extended to 180 seconds.
Diffs
-
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
d8c3e6d08a70bd129d8ac9c336be7a2bf7a4b0b2
Diff: https://reviews.apache.org/r/67596/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote:
> > LGTM, but I wonder whether it would make sense to keep the assertions and
> > reject outdated resources more generally based on e.g., resource versions.
>
> Chun-Hung Hsiao wrote:
> Hmm good point.
or old profiles.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/#review201631
---
On June 14, 2018, 12:07 a.m., Chun-H
5db5a8da85f02323a5654c93ac47ec4aa7e711d2
Diff: https://reviews.apache.org/r/65875/diff/3/
Changes: https://reviews.apache.org/r/65875/diff/2-3/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
/disk_profile_adaptor_tests.cpp
4485f1635f484ce6e1c7c532eedb277f5eee118b
Diff: https://reviews.apache.org/r/65640/diff/5/
Changes: https://reviews.apache.org/r/65640/diff/4-5/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
-Hung Hsiao
-Hung Hsiao
in repitition.
Thanks,
Chun-Hung Hsiao
801 - 900 of 1959 matches
Mail list logo
