(updated)
-
src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b
Diff: https://reviews.apache.org/r/41959/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
isCreateError in
> > this case).
>
> Jojy Varghese wrote:
> Jie, thanks for looking at this.
>
> This change is two parts - one is simply replacing the initialization of
> `creators` hashmap. Initialization using universal `{` initialization is the
> preferr
--
On Jan. 13, 2016, 11:08 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41959/
> ---
make check.
Thanks,
Jojy Varghese
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/42157/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner/appc/store.cpp
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4
Diff: https://reviews.apache.org/r/42557/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
-CREATION
Diff: https://reviews.apache.org/r/42274/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/42157/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/42156/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/command_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/42274/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
2945c5abbd
src/slave/containerizer/mesos/provisioner/appc/spec.cpp
324cdfec3766da4a8e324378a6e413477fa2b5d9
Diff: https://reviews.apache.org/r/42556/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/42557/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
This change will enable image fetcher to resolve dependencies.
Diffs
-
include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd
Diff: https://reviews.apache.org/r/42554/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/common/command_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/42274/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/command_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/42274/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
sit:
https://reviews.apache.org/r/42274/#review114510
---
On Jan. 13, 2016, 11:13 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To re
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and
> Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
tps://reviews.apache.org/r/42238/#comment175183>
Why not use Path here instead of string? Here and other places.
src/uri/fetchers/docker.cpp (line 375)
<https://reviews.apache.org/r/42238/#comment175184>
recursive mkdir?
- Jojy Varghese
On Jan. 13, 2016, 11:14 p.m.,
tps://reviews.apache.org/r/42238/#comment175180>
Can be refactored to common function (and avoid duplicate code at L124).
- Jojy Varghese
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail.
/command_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/42274/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
make check.
Thanks,
Jojy Varghese
)
-
src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b
Diff: https://reviews.apache.org/r/41959/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42263/#review114274
---
Ship it!
Ship It!
- Jojy Varghese
On Jan. 13, 2016, 8:38 p.m
)
-
src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5
Diff: https://reviews.apache.org/r/41959/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
Diff: https://reviews.apache.org/r/42157/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
,
Jojy Varghese
---
This change will enable other tests to reuse the common test image creation
logic.
Diffs
-
src/tests/containerizer/provisioner_appc_tests.cpp
98d5a46149ef63cedcbf4915b5b6e9842ac67dbb
Diff: https://reviews.apache.org/r/42156/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
> On Jan. 6, 2016, 7:32 p.m., Jojy Varghese wrote:
> > src/tests/container_logger_tests.cpp, line 158
> > <https://reviews.apache.org/r/41962/diff/1/?file=1183514#file1183514line158>
> >
> > Can we have this as :
> >
> >
> On Jan. 6, 2016, 7:21 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/docker.cpp, line 701
> > <https://reviews.apache.org/r/41963/diff/1/?file=1183475#file1183475line701>
> >
> > Do you need all the variables on the stack to be passed to the capt
/containerizer.md PRE-CREATION
docs/home.md d929838206817a6c49cc2343b4de82fa085da682
Diff: https://reviews.apache.org/r/41657/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review113148
---
On Dec. 29, 2015, 4:36 p.m., Jojy Varghese wrote:
>
> ---
> This is an
w MockDocker(...));
```
- Jojy Varghese
On Jan. 6, 2016, 2:19 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/41963/#comment173615>
Do you need all the variables on the stack to be passed to the capture?
Maybe just executorInfo ?
- Jojy Varghese
On Jan. 6, 2016, 2:19 a.m., Joseph Wu wrote:
>
> ---
> This is a
)
-
src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5
Diff: https://reviews.apache.org/r/41959/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/41959/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
Removed unwanted forward declaration in Fetcher header.
Diffs
-
include/mesos/uri/fetcher.hpp 4223f9e1f304b167d0fe7c2f914f3d3e897033c0
Diff: https://reviews.apache.org/r/41958/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41906/#review112977
---
Ship it!
Ship It!
- Jojy Varghese
On Jan. 5, 2016, 4:47 a.m
urn the token or create a new item in the cache (after getting the token
from realm).
What do you think?
- Jojy Varghese
On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To
```
Try realmUrl = http::URL::parse(attributes.at("realm"));
```
- Jojy Varghese
On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
operator to achieve the same semantics?
Couple of reasons:
- Expresses the semantics in simple manner.
- Efficient in terms if number of instructions (1 DIV operation vs a DIV +
MUL)
- Jojy Varghese
On Dec. 30, 2015, 1:30 a.
org/r/41283/#comment172665>
Why not ``` backoff = ::random() % maxBackoff + 1 ```?
In the current form, wouldnt backoff could always be 0(when env variable
for max backoff is not present)?
- Jojy Varghese
On Dec. 29, 2015, 3:11 a.m., Anand Mazumdar
> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 221
> > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line221>
> >
> > "else" case?
>
> Anand Mazumdar wrote:
> Nothing needs
> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 221
> > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line221>
> >
> > "else" case?
>
> Anand Mazumdar wrote:
> Nothing needs
/containerizer.md PRE-CREATION
docs/home.md d929838206817a6c49cc2343b4de82fa085da682
Diff: https://reviews.apache.org/r/41657/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
---
On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> -
gt;
> > In that case the term 'same environment' seems a little misleading.
This was inspired from Docker's website which says ```This guarantees that it
will always run the same, regardless of the environment it is running in```
- Jojy
-----
org/r/41283/#comment172458>
What is the purpose of mutex? It looks like we do the callbacks
asynchronously. Which means, we have the lock only till its dispatched. We dont
know when its executed. So wouldnt that mean two callbacks can be executed
asyncronously at the same time?
- Jojy Va
> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 221
> > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line221>
> >
> > "else" case?
>
> Anand Mazumdar wrote:
> Nothing needs
e.org/r/41283/#comment172439>
Why not use universal initialization ({})?
- Jojy Varghese
On Dec. 29, 2015, 12:11 a.m., Anand Mazumdar wrote:
>
> ---
> This is an au
: https://reviews.apache.org/r/41754/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
d929838206817a6c49cc2343b4de82fa085da682
docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23
Diff: https://reviews.apache.org/r/41656/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
/containerizer.md PRE-CREATION
docs/home.md d929838206817a6c49cc2343b4de82fa085da682
Diff: https://reviews.apache.org/r/41657/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
tps://reviews.apache.org/r/41715/#comment172369>
Have we considered using a regex parser for doing this? C++11 regex support
is added since gcc 4.9 and has been in clang for sometime now.
- Jojy Varghese
On Dec. 26, 2015, 8:24 p.m., Timothy Chen
> On Dec. 27, 2015, 3:25 a.m., Jojy Varghese wrote:
> > docs/versioning.md, line 62
> > <https://reviews.apache.org/r/41661/diff/3/?file=1174978#file1174978line62>
> >
> > This section could use some formatting.
> >
> > Also, would be
)
-
docs/containerizer.md PRE-CREATION
docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9
Diff: https://reviews.apache.org/r/41657/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
ly, visit:
https://reviews.apache.org/r/41657/#review111927
---
On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically gen
-----
On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
>
https://reviews.apache.org/r/41657/#review111947
-------
On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> -
docs/versioning.md (line 78)
<https://reviews.apache.org/r/41661/#comment172210>
Blank line here. You might have to test the rendering of this document
using website docker.
- Jojy Varghese
On Dec. 23, 2015, 2:09 a.m., Anand Mazumdar wrote:
>
> ---
3rdparty/libprocess/src/http.cpp (line 205)
<https://reviews.apache.org/r/41715/#comment172206>
s/Domain/Host as it could be a IP address also?
- Jojy Varghese
On Dec. 26, 2015, 8:24 p.m., Timothy Chen wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41728/#review111917
---
Ship it!
Ship It!
- Jojy Varghese
On Dec. 26, 2015, 8:28 p.m
(line 79)
<https://reviews.apache.org/r/41731/#comment172203>
You might have to validate the flag for its format and maybe valid path.
- Jojy Varghese
On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41697/#review111915
---
Ship it!
Ship It!
- Jojy Varghese
On Dec. 23, 2015, 10:22 p.m
/containerizer.md PRE-CREATION
docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9
Diff: https://reviews.apache.org/r/41657/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
also provides the criteria for selecting a
> particular type of containerizer.
>
>
> Diffs
> -
>
> docs/containerizer.md PRE-CREATION
> docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9
>
> Diff: https://reviews.apache.org/r/41657/diff/
>
>
> Testing
> ---
>
> mesos website docker.
>
>
> Thanks,
>
> Jojy Varghese
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
-------
On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
>
> -
51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9
docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23
Diff: https://reviews.apache.org/r/41656/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
Diff: https://reviews.apache.org/r/41657/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
/diff/
Testing
---
mesos website docker.
Thanks,
Jojy Varghese
Diffs (updated)
-
3rdparty/libprocess/src/libevent_ssl_socket.cpp
55b91dd47bb5bd5e97147d0af91c7899fd42702c
Diff: https://reviews.apache.org/r/41026/diff/
Testing
---
make check
Thanks,
Jojy Varghese
hooks/post-rewrite af907de7c6dd44fd6a7f34f52aaaed4460c44bc1
support/hooks/pre-commit bdc12af4c2e3f1c32c6b7763c791e41d7e9d72d4
support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87
Diff: https://reviews.apache.org/r/41026/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/libevent_ssl_socket.hpp
2669b1a1d8f275b89c75d5f12fc696be2b277220
3rdparty/libprocess/src/libevent_ssl_socket.cpp
55b91dd47bb5bd5e97147d0af91c7899fd42702c
Diff: https://reviews.apache.org/r/41253/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/libevent_ssl_socket.hpp
2669b1a1d8f275b89c75d5f12fc696be2b277220
3rdparty/libprocess/src/libevent_ssl_socket.cpp
55b91dd47bb5bd5e97147d0af91c7899fd42702c
Diff: https://reviews.apache.org/r/41253/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/libevent_ssl_socket.hpp
2669b1a1d8f275b89c75d5f12fc696be2b277220
3rdparty/libprocess/src/libevent_ssl_socket.cpp
55b91dd47bb5bd5e97147d0af91c7899fd42702c
Diff: https://reviews.apache.org/r/41253/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
2669b1a1d8f275b89c75d5f12fc696be2b277220
3rdparty/libprocess/src/libevent_ssl_socket.cpp
55b91dd47bb5bd5e97147d0af91c7899fd42702c
Diff: https://reviews.apache.org/r/41253/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
> On Dec. 16, 2015, 11:59 p.m., Jojy Varghese wrote:
> > docs/getting-started.md, line 127
> > <https://reviews.apache.org/r/41371/diff/2/?file=1165243#file1165243line127>
> >
> > I would enclose libserf-1 i backticks.
>
> Kevin Klues wrote:
>
g/r/41372/#comment170800>
I would emphaise versions with backtics.
- Jojy Varghese
On Dec. 16, 2015, 11:07 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
g/r/41371/#comment170794>
I would enclose libserf-1 i backticks.
- Jojy Varghese
On Dec. 16, 2015, 11:06 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41383/#review110800
---
Ship it!
Ship It!
- Jojy Varghese
On Dec. 16, 2015, 11:06 p.m
/39456/diff/
Testing
---
Thanks,
Jojy Varghese
s://github.com/apache/mesos/blob/master/docs/containerizer.md#mesos-containerizer
>
> Jojy Varghese wrote:
> This was added as per review comments from other reviewers. The idea was
> to add a little note about what containerizers are.
droppi
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/39456/#review110340
---
On Dec. 15, 2015, 6:22 p.m., Jojy Varghese wrote:
>
> ---
> This is an automati
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote:
> > docs/containerizer-internals.md, lines 15-23
> > <https://reviews.apache.org/r/39456/diff/4/?file=1163799#file1163799line15>
> >
> > What about moveing this after ### Type of containerizers
>
>
://reviews.apache.org/r/39456/diff/
Testing
---
Thanks,
Jojy Varghese
in the
documentation now or update the documentation when the change goes in?
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39456/#review110340
----
/
Testing
---
make check.
Thanks,
Jojy Varghese
/r/39456/diff/
Testing
---
Thanks,
Jojy Varghese
https://reviews.apache.org/r/41253/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
Thanks,
Jojy Varghese
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117
> > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line117>
> >
> > If the future is not expected to be ready when
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117
> > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line117>
> >
> > If the future is not expected to be ready when
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96
> > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line96>
> >
> > The pattern I have seen in the code is that we d
<https://reviews.apache.org/r/41235/#comment169731>
If the future is not expected to be ready when we reach here, should we do
a .then on it instead of expecting it to be ready and returning failure?
- Jojy Varghese
On Dec. 11, 2015, 1:35 a.m.,
gt;
Are we always expecting the future to be ready when we get here?
- Jojy Varghese
On Dec. 11, 2015, 1:35 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
://reviews.apache.org/r/41252/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
both send and receive
sides of the socket are terminated.
Diffs
-
3rdparty/libprocess/src/libevent_ssl_socket.cpp
55b91dd47bb5bd5e97147d0af91c7899fd42702c
Diff: https://reviews.apache.org/r/41253/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
Added explicit content-length header so that the client can close the
connection.
Diffs
-
src/tests/containerizer/provisioner_docker_tests.cpp
31e7a31a23397eedf22d1360e37bde8339a3c7b9
Diff: https://reviews.apache.org/r/41252/diff/
Testing
---
make check.
Thanks,
Jojy
rated e-mail. To reply, visit:
https://reviews.apache.org/r/41078/#review109288
---
On Dec. 8, 2015, 7:03 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically gene
check.
Thanks,
Jojy Varghese
201 - 300 of 781 matches
Mail list logo
