Re: Review Request 65997: Added `PROTOC_SPEC_GENERATE` helper for cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199104 --- src/CMakeLists.txt Lines 106 (patched)

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199105 --- PASS: Mesos patch 66037 was successfully built and tested.

Re: Review Request 65997: Added `PROTOC_SPEC_GENERATE` helper for cmake.

> On March 13, 2018, 6:54 p.m., Andrew Schwartzmeyer wrote: > > src/cmake/MesosProtobuf.cmake > > Lines 125-163 (patched) > > > > > > Most of this function looks duplicated from `function(PROTOC_GENERATE)` > > but

Re: Review Request 66025: Converted `JSON::String` to bool and numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66025/#review199102 --- Fix it, then Ship it!

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review199103 --- Ship it! Ship It! - Chun-Hung Hsiao On March 13, 2018, 9:13

Re: Review Request 66015: Built CSI spec proto files with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66015/#review199106 --- 3rdparty/CMakeLists.txt Lines 260 (patched)

Re: Review Request 66043: Renamed a variable in allocator to be consistent with others.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66043/#review199111 --- PASS: Mesos patch 66043 was successfully built and tested.

Re: Review Request 66010: Windows: Switched to default CRT linkage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66010/ --- (Updated March 13, 2018, 1:45 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65886: Do not realpath executables from launcher_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/ --- (Updated March 13, 2018, 6:33 a.m.) Review request for mesos. Bugs:

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199068 --- Patch looks great! Reviews applied: [66034] Passed command:

Re: Review Request 66025: Converted `JSON::String` to bool and numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66025/ --- (Updated March 13, 2018, 2:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools & numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66026/ --- (Updated March 13, 2018, 3:09 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66025: Converted `JSON::String` to bool and integers.

> On March 13, 2018, 9:22 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 454-538 (patched) > > > > > > As Ben mentioned, this is to match the "Notes" column of Google's JSON >

Re: Review Request 66025: Converted `JSON::String` to bool and integers.

> On March 13, 2018, 5:53 a.m., Benjamin Mahler wrote: > > Can we clarify in the commit message that we're doing this to match > > Google's json -> protobuf behavior? Sure. - Qian --- This is an automatically generated e-mail. To

Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools.

> On March 13, 2018, 9:41 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Line 108 (original), 108 (patched) > > > > > > Would you mind using the C++-style string literals to avoid the

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

> On March 13, 2018, 10:07 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 807-810 (patched) > > > > > > How about making this a lambda inside `protobuf()` so we don't expose >

Re: Review Request 65994: Made the master forward operation status updates to the schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65994/#review199075 --- Patch looks great! Reviews applied: [65362, 65300, 64618, 65993,

Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66035/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66035/#review199079 --- PASS: Mesos patch 66035 was successfully built and tested.

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated March 13, 2018, 5:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66035/#review199081 --- Patch looks great! Reviews applied: [66035] Passed command:

Review Request 66039: Check both disk and inode usage when slaves schedule gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8665

Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/#review199083 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 13, 2018, 1:45 p.m.) Review request for mesos and James Peach.

Re: Review Request 66038: Add usageWithInode to check both disk and inode usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/ --- (Updated March 13, 2018, 2:08 p.m.) Review request for mesos and Gilbert Song.

Review Request 66038: Add usageWithInode to check both disk and inode usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8665

Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/ --- (Updated March 13, 2018, 2:05 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199087 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

> On March 9, 2018, 10:16 p.m., Greg Mann wrote: > > src/common/http.hpp > > Lines 198 (patched) > > > > > > See the comment I left on https://reviews.apache.org/r/65313/ - I > > wonder if `action` really needs to

Re: Review Request 65313: Refactored authorization logic in the agent.

> On March 9, 2018, 5:30 a.m., Greg Mann wrote: > > src/slave/http.cpp > > Lines 2641-2665 (original), 2431-2469 (patched) > > > > > > Why did you opt for a new templated method instead of the pre-existing > >

Re: Review Request 65313: Refactored authorization logic in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65313/#review199091 --- Fix it, then Ship it! src/slave/http.cpp Lines 2199-2218

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199092 --- Patch looks great! Reviews applied: [66001] Passed command:

Re: Review Request 63991: Added helpers to create and forward offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/ --- (Updated March 13, 2018, 4:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 13, 2018, 4:39 p.m.) Review request for mesos, Benjamin

Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/#review199093 --- PASS: Mesos patch 66039 was successfully built and tested.

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 13, 2018, 4:38 p.m.) Review request for mesos, Benjamin

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > > > > > If the operation has an operation ID, we'll always land on this > > `continue`

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 13, 2018, 4:41 p.m.) Review request for mesos, Benjamin

Review Request 66048: Added missing comment on a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66048/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965

Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965

Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/ --- (Updated March 13, 2018, 11:10 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/#review199122 --- src/tests/storage_local_resource_provider_tests.cpp Lines 2892

Review Request 66045: Renamed `resources` in allocator to `toAllocate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66045/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 66050: Implement grow and shrink of persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199125 --- PASS: Mesos patch 63994 was successfully built and tested.

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

> On March 9, 2018, 11:40 p.m., Jie Yu wrote: > > Looking good! Is it possible to add some test? Working on the unit tests. - Sagar --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66030: Fixed perf stat output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66030/#review199127 --- Ship it! Ship It! - James Peach On March 13, 2018, 12:03

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199128 --- Fix it, then Ship it! src/master/master.cpp Lines 5960

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199121 --- src/master/master.cpp Lines 4075-4082 (original), 4111-4117

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/ --- (Updated March 13, 2018, 9:45 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 13, 2018, 9:48 p.m.) Review request for mesos, Benjamin

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199123 --- Ship it! Ship It! - Gaston Kleiman On March 13, 2018, 2:48

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199124 --- Ship it! Ship It! - Gaston Kleiman On March 13, 2018, 2:49

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/ --- (Updated March 13, 2018, 9:58 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199116 --- Patch looks great! Reviews applied: [63991, 63992, 63994]

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

> On March 7, 2018, 11:21 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > > > > > If the operation has an operation ID, we'll always land on this > > `continue`

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199119 --- src/tests/scheduler_tests.cpp Lines 1080 (patched)

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 13, 2018, 9:49 p.m.) Review request for mesos, Benjamin

Review Request 66044: Refactored resources chopping logic in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66044/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Joseph Wu, Michael Park,

Review Request 66046: CMake: Patched Boost to remove spurious warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66046/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John

Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65833/#review199099 --- I'm also unable to view the protobuf utils diff in RB, strange.

Review Request 66043: Renamed a variable in allocator to be consistent with others.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66043/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review199095 --- Ship it! Ship It! - Greg Mann On March 7, 2018, 11:36 a.m.,

Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/#review199100 --- This API change looks good to me. Since this is a public API

Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8647

Re: Review Request 66008: CMake: Enabled compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66008/#review199096 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:38

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199097 --- PASS: Mesos patch 63994 was successfully built and tested.

Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/#review199101 --- Patch looks great! Reviews applied: [66038, 66039] Passed

Re: Review Request 66015: Built CSI spec proto files with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66015/ --- (Updated March 14, 2018, 2:57 a.m.) Review request for mesos, Andrew

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review199149 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

> On March 2, 2018, 9:33 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Lines 675-676 (patched) > > > > > > Do you want to use a raw string literal here to avoid all the escaping? > >

Re: Review Request 65997: Added `PROTOC_SPEC_GENERATE` helper for cmake.

> On March 13, 2018, 6:54 p.m., Andrew Schwartzmeyer wrote: > > src/cmake/MesosProtobuf.cmake > > Lines 174-176 (patched) > > > > > > This is probably something for later, but these essentially hard-coded > >

Re: Review Request 66048: Added missing comment on a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66048/#review199141 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66046/#review199145 --- PASS: Mesos patch 66046 was successfully built and tested.

Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.

> On March 14, 2018, 12:21 a.m., Jeff Coffler wrote: > > 3rdparty/boost-1.65.0.patch > > Lines 12 (patched) > > > > > > I'm thinking the other way around. That is, if the compiler version < > > 1910, issue the

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/ --- (Updated March 14, 2018, 2:56 a.m.) Review request for mesos, Andrew

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/#review199152 --- PASS: Mesos patch 65987 was successfully built and tested.

Re: Review Request 66048: Added missing comment on a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66048/#review199144 --- Patch looks great! Reviews applied: [66048] Passed command:

Re: Review Request 66045: Renamed `resources` in allocator to `toAllocate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66045/#review199137 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66025: Converted `JSON::String` to bool and numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66025/ --- (Updated March 14, 2018, 9:30 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.

> On March 13, 2018, 5:21 p.m., Jeff Coffler wrote: > > 3rdparty/boost-1.65.0.patch > > Lines 12 (patched) > > > > > > I'm thinking the other way around. That is, if the compiler version < > > 1910, issue the

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

> On March 9, 2018, 6:54 p.m., James Peach wrote: > > This also needs to be documented in `docs/monitoring.md`. Will do in a follow up patch after receiving shipit. - Zhitao --- This is an automatically generated e-mail. To reply,

Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66046/#review199133 --- 3rdparty/boost-1.65.0.patch Lines 12 (patched)

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199129 --- Patch looks great! Reviews applied: [66037] Passed command:

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

> On March 9, 2018, 6:53 p.m., James Peach wrote: > > src/slave/metrics.cpp > > Lines 259 (patched) > > > > > > I don't know that I like the idea of a metric that is absent and then > > present. I'd prefer that we