Re: Review Request 47805: Add authorization to GET /weights.

> On May 27, 2016, 2:39 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 88 > > > > > > Neat trick, but I think we're better off just specifying > > DEFAULT_CREDENTIAL at those call sites > > zhou

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- (Updated May 28, 2016, 5:11 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.

> On May 25, 2016, 9:02 p.m., Joris Van Remoortere wrote: > > src/launcher/fetcher.cpp, lines 76-80 > > > > > > can we use the updated `paths::join` here to simplify this? > > > > Can you add a JIRA to add

Re: Review Request 48004: Windows: Added `src/executor/executor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48004/#review135374 --- Bad review! Reviews applied: [48004, 48003, 48002] Error: No

Review Request 48004: Windows: Added `src/executor/executor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48004/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 48000: Windows MVP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48000/ --- (Updated May 28, 2016, 3:15 a.m.) Review request for mesos. Repository:

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135371 --- docs/cni.md (line 332)

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review135370 --- Patch looks great! Reviews applied: [47972, 47973] Passed

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 28, 2016, 2:22 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/ --- (Updated May 28, 2016, 2:22 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- (Updated May 28, 2016, 2:21 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/ --- (Updated May 28, 2016, 2:21 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/ --- (Updated May 28, 2016, 2:20 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47842: Point slave flags at programmatic temp path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/ --- (Updated May 28, 2016, 2:20 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47843/ --- (Updated May 28, 2016, 2:19 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/ --- (Updated May 28, 2016, 2:19 a.m.) Review request for mesos, Daniel Pravat,

Review Request 48002: Windows: Added new Windows.hpp defines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48002/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 48003: Remove SASL dependency from agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48003/ --- Review request for mesos. Repository: mesos Description --- Remove SASL

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 28, 2016, 2:17 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/ --- (Updated May 28, 2016, 2:16 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47470: Stout: Added `os::temp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/ --- (Updated May 28, 2016, 2:15 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135368 --- Patch looks great! Reviews applied: [47891] Passed command:

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/ --- (Updated May 28, 2016, 1:27 a.m.) Review request for mesos. Repository:

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135367 --- Can you rebase? This patch does not look correct. - Jie Yu On

Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated 五月 28, 2016, 12:53 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

> On May 27, 2016, 11:17 p.m., Jie Yu wrote: > > HUm, i got confused. Why this patch has so many new additions? Do you need > > a rebase? It's hard to review this one. > > Guangya Liu wrote: > This patch is splitting the test case of >

Re: Review Request 47805: Add authorization to GET /weights.

> On 五月 27, 2016, 9:39 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 88 > > > > > > Neat trick, but I think we're better off just specifying > > DEFAULT_CREDENTIAL at those call sites > > zhou

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/#review135361 --- Patch looks great! Reviews applied: [47986, 47987, 47988, 47989,

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/ --- (Updated May 27, 2016, 5:17 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47805: Add authorization to GET /weights.

> On May 27, 2016, 9:39 a.m., Adam B wrote: > > src/master/weights_handler.cpp, line 85 > > > > > > Technically, this lambda should be indented to align with its fellow > > defer() parameter `master->self()`, or

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47150/#review135358 --- Ship it! Ship It! - Kapil Arya On May 27, 2016, 6:07 p.m.,

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review135356 --- Ship it! Ship It! - Kapil Arya On May 25, 2016, 10:02 p.m.,

Re: Review Request 47805: Add authorization to GET /weights.

> On May 27, 2016, 9:39 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 88 > > > > > > Neat trick, but I think we're better off just specifying > > DEFAULT_CREDENTIAL at those call sites Adam, not

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/ --- (Updated May 28, 2016, 12:02 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/ --- (Updated May 28, 2016, 12:01 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/ --- (Updated May 28, 2016, 12:01 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

> On 五月 27, 2016, 11:17 p.m., Jie Yu wrote: > > HUm, i got confused. Why this patch has so many new additions? Do you need > > a rebase? It's hard to review this one. This patch is splitting the test case of `DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes` to two cases: one for

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/#review135352 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

> On 五月 27, 2016, 11:13 p.m., Jie Yu wrote: > > The container Id is already printed. Why print it again? I see, will discard this. Thanks. - Guangya --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 47633: Checked if IPv6 module was loaded before disabling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/#review135350 --- Ship it! Ship It! - Jie Yu On May 23, 2016, 7:55 a.m.,

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/#review135347 --- Patch looks great! Reviews applied: [47149, 47205, 47212, 47215,

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/#review135345 --- HUm, i got confused. Why this patch has so many new additions? Do

Re: Review Request 47447: Some cleanup for watchdog logic in subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47447/#review135344 --- Ship it! Ship It! - Jie Yu On May 17, 2016, 8:39 a.m.,

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/#review135343 --- The container Id is already printed. Why print it again? - Jie

Re: Review Request 45377: Made "driver" as optional for DockerVolume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review135342 --- Ship it! Ship It! - Jie Yu On May 26, 2016, 8:33 p.m.,

Re: Review Request 47895: Renamed 'posix/disk' isolator as 'disk/du'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47895/#review135339 --- Ship it! Ship It! - Jie Yu On May 26, 2016, 3:08 p.m.,

Re: Review Request 47894: Renamed 'xfs/disk' isolator to 'disk/xfs'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47894/#review135338 --- Ship it! Ship It! - Jie Yu On May 26, 2016, 3:05 p.m.,

Re: Review Request 47971: Remove subnet prefix length from IP address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47971/#review135337 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Review Request 47991: Passed `Request` object by ptr instead of copying it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.

Review Request 47988: Added move constructor/assignment to `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47988/ --- Review request for mesos, Michael Park and Vinod Kone. Repository: mesos

Review Request 47989: Added move semantics to `Future::set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47989/ --- Review request for mesos, Michael Park and Vinod Kone. Repository: mesos

Review Request 47987: Constrained constructible types constructor for `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47987/ --- Review request for mesos, Michael Park and Vinod Kone. Repository: mesos

Review Request 47990: Added move semantics to `Pipe::write()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135335 --- src/authorizer/local/authorizer.cpp (line 141)

Review Request 47986: Added move constructor/assignment operator to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47986/ --- Review request for mesos, Michael Park and Vinod Kone. Repository: mesos

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/ --- (Updated May 27, 2016, 3:10 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

> On May 25, 2016, 6:50 p.m., Jie Yu wrote: > > include/mesos/hook.hpp, lines 108-116 > > > > > > Any reason why all the fields here are needed? For instance, > > 'containerInfo' is part of either taskInfo or

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47150/ --- (Updated May 27, 2016, 3:07 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47971: Remove subnet prefix length from IP address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47971/#review135333 --- Patch looks great! Reviews applied: [47971] Passed command:

Re: Review Request 47891: Added RUN_TASK authorization action.

> On May 27, 2016, 10:52 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.proto, line 56 > > > > > > Is this deprecated or unused now? I changed `RUN_TASK` to alias `RUN_TASK_WITH_USER` and added a

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/ --- (Updated May 27, 2016, 11:51 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47894: Renamed 'xfs/disk' isolator to 'disk/xfs'.

> On May 27, 2016, 2:21 p.m., James Peach wrote: > > I guess not many people are using this, but consider whether you should > > keep the old name at well for backwards compatibility. This is pre-release feature so I think we shuold be fine if this rename lands before 0.29.0 is cut. For

Re: Review Request 47894: Renamed 'xfs/disk' isolator to 'disk/xfs'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47894/#review135326 --- I guess not many people are using this, but consider whether you

Re: Review Request 47977: Added tests for VIEW_* authorization actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47977/#review135313 --- Bad patch! Reviews applied: [47977, 47736, 47704, 47559, 47558,

Re: Review Request 47971: Remove subnet prefix length from IP address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47971/ --- (Updated May 27, 2016, 8:42 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 47921: Enabled authorization for Mesos log access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47921/#review135304 --- Patch looks great! Reviews applied: [47794, 47795, 47921]

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 27, 2016, 8:13 p.m.) Review request for mesos, Adam B and Michael

Review Request 47977: Added tests for VIEW_* authorization actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47977/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 47971: Remove subnet prefix length from IP address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47971/#review135284 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 47921: Enabled authorization for Mesos log access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47921/ --- (Updated May 27, 2016, 8:07 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 47921: Enabled authorization for Mesos log access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47921/ --- (Updated May 27, 2016, 8:08 p.m.) Review request for mesos, Adam B, Joerg

Review Request 47971: Remove subnet prefix length from IP address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47971/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5453

Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/ --- Review request for mesos. Bugs: MESOS-5196

Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5196

Re: Review Request 47952: Added a stout test for missing required flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47952/#review135231 --- Patch looks great! Reviews applied: [46620, 46814, 46621, 47078,

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/#review135226 --- Patch looks great! Reviews applied: [37989] Passed command:

Review Request 47952: Added a stout test for missing required flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47952/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-5064

Re: Review Request 45562: Edited `--work_dir` configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated May 27, 2016, 11:52 a.m.) Review request for mesos and Michael Park.

Re: Review Request 46004: Updated master '--work_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- (Updated May 27, 2016, 11:51 a.m.) Review request for mesos and Michael Park.

Re: Review Request 46003: Removed the default value for agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated May 27, 2016, 11:47 a.m.) Review request for mesos, Michael Park and

Re: Review Request 47078: Added checking for required flags to FlagsBase.

> On May 11, 2016, 10:39 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 149 > > > > > > make this `const Option&` instead? Per our discussion, I'm going to stick

Re: Review Request 47078: Added checking for required flags to FlagsBase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/ --- (Updated May 27, 2016, 11:29 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/#review135217 --- Ship it! Ship It! - Bernd Mathiske On May 27, 2016, 3:55

Re: Review Request 47944: Set timestamp when updating task status from long lived framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47944/#review135214 --- Patch looks great! Reviews applied: [47944] Passed command:

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/ --- (Updated May 27, 2016, 10:55 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

> On May 27, 2016, 9:36 a.m., Bernd Mathiske wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 1011 > > > > > > In the above case, this part is within the scope block, here it is not. > > Please

Re: Review Request 47522: Added creator principal to persistent volume tests.

> On May 27, 2016, 9:47 a.m., Bernd Mathiske wrote: > > src/tests/persistent_volume_tests.cpp, line 1448 > > > > > > As we have "volume and subsequent statements in a scope block above, > > can we have the same

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/#review135204 --- Bad patch! Reviews applied: [47603, 47602, 47576, 47536, 47472,

Re: Review Request 47516: Added creator principal to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47516/#review135203 --- Ship it! Ship It! - Bernd Mathiske On May 26, 2016, 11:28

Re: Review Request 47522: Added creator principal to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47522/#review135200 --- src/tests/persistent_volume_tests.cpp (line 1448)

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

> On 五月 25, 2016, 4:41 p.m., Shuai Lin wrote: > > src/slave/slave.cpp, line 3454 > > > > > > Should we also search in in `termiantedTasks`? > > > > ```cpp > > // Terminated but pending updates. > >

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review135198 --- Srini, please add MESOS-4135 to `Bugs` filed at right-top of the

Re: Review Request 47805: Add authorization to GET /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review135190 --- Great job! Fix these nits and we should be ready to ship.

Re: Review Request 47805: Add authorization to GET /weights.

> On May 26, 2016, 3:30 a.m., Adam B wrote: > > src/master/weights_handler.cpp, line 85 > > > > > > s/=/request, weightInfos/ > > s/list/list&/ > > zhou xing wrote: > Adam, this function also requires to

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/#review135194 --- src/tests/persistent_volume_endpoints_tests.cpp (line 660)

Re: Review Request 47516: Added creator principal to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47516/#review135196 --- Patch looks great! Reviews applied: [47515, 47528, 47519, 47520,

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

> On 五月 27, 2016, 8:41 a.m., haosdent huang wrote: > > src/slave/containerizer/docker.cpp, line 1195 > > > > > > How about change those VLOG to LOG(INFO) instead of add a tricky hack > > here? > > > > We

Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/#review135189 --- Shall we discard this patch in favor of

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135182 --- Please update `Master::authorizeTask` to call your new/aliased

  1   2   >