Re: Review Request 51446: Fixed typo in health_checker.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/#review146918 --- Patch looks great! Reviews applied: [51446] Passed command:

Re: Review Request 51097: Added a `PortMapper` class.

2016-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 26, 2016, 5:21 a.m.) Review request for mesos, Jie Yu and Qian

Review Request 51450: Fixed a capabilities test failure on Fedora 23.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51450/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 51097: Added a `PortMapper` class.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146913 --- Bad patch! Reviews applied: [51097, 51096, 51095] Failed

Review Request 51447: Killed a line in master/validation.cpp.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51447/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51405: Updated some tests to use the CreateSlaveFlags() helper.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/ --- (Updated Aug. 26, 2016, 1:53 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 26, 2016, 1:52 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51446: Fixed typo in health_checker.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/#review146908 --- Ship it! Ship It! - haosdent huang On Aug. 26, 2016, 1:33

Review Request 51446: Fixed typo in health_checker.

2016-08-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review146903 --- Bad patch! Reviews applied: [46187] Failed command:

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review146901 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 504)

Re: Review Request 51420: Added provisioner appc unit test for provisioning nested container.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/#review146900 --- Fix it, then Ship it!

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

2016-08-25 Thread Jie Yu
> On Aug. 26, 2016, 12:31 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 215-218 > > > > > > Can you call CreateSlaveFlags instead? > > Kevin Klues wrote: > I tried doing this and it

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

2016-08-25 Thread Kevin Klues
> On Aug. 26, 2016, 12:31 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 215-218 > > > > > > Can you call CreateSlaveFlags instead? I tried doing this and it gave me the error: ```

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 26, 2016, 12:34 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
> On Aug. 25, 2016, 5:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 502 > > > > > > I'd avoid using subprocess here. Using subprocess here means that we'll > > initialize libprocess,

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/#review146896 --- src/tests/containerizer/isolator_tests.cpp (lines 215 - 218)

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

2016-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 26, 2016, 12:29 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

2016-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/ --- (Updated Aug. 26, 2016, 12:26 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51442: Added missing Launcher mock for getExitStatusCheckpointPath.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51442/#review146893 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2016, 11:35 p.m.,

Re: Review Request 51434: Use `continue` when breaking out of LAUNCH_GROUP case due to errors.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51434/#review146891 --- Patch looks great! Reviews applied: [51434] Passed command:

Re: Review Request 51217: Added `os::execvp' in `stout` library.

2016-08-25 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- (Updated Aug. 25, 2016, 11:59 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51213: Used `os::execvp` instead of `::execvp`.

2016-08-25 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51213/ --- (Updated Aug. 25, 2016, 11:59 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-25 Thread Daniel Pravat
> On Aug. 22, 2016, 6:39 p.m., Joseph Wu wrote: > > Note: Your summary/description says `execlp`, but the code is for `execvp` > > :P I will change the summary. - Daniel --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51210: Update mesos-executor name for Windows.

2016-08-25 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51210/ --- (Updated Aug. 25, 2016, 11:50 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146888 --- src/tests/master_validation_tests.cpp (line 1811)

Review Request 51442: Added missing Launcher mock for getExitStatusCheckpointPath.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51442/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6051

Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/ --- (Updated Aug. 25, 2016, 11:34 p.m.) Review request for mesos and Jie Yu.

Review Request 51443: Updated 'launcher' to properly reap checkpointed exit status.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6088

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 25, 2016, 11:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146887 --- Fix it, then Ship it! src/master/validation.cpp (line 1003)

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/ --- (Updated Aug. 25, 2016, 11:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

2016-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50868/#review146878 --- I don't know. Making such distinction feels like splitting hairs

Re: Review Request 46822: Avoided slicing of flags in subprocess.

2016-08-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/#review146877 --- Fix it, then Ship it!

Re: Review Request 46821: Avoided slicing of flags in subprocess in libprocess and stout.

2016-08-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/#review146876 --- Fix it, then Ship it! 3rdparty/libprocess/src/subprocess.cpp

Re: Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/#review146874 --- src/slave/containerizer/mesos/isolators/network/cni/spec.proto

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146873 --- Patch looks great! Reviews applied: [51437] Passed command:

Re: Review Request 51097: Added a `PortMapper` class.

2016-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 25, 2016, 10:04 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/#review146854 --- src/slave/containerizer/docker.cpp (lines 1028 - 1034)

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

2016-08-25 Thread Kevin Klues
> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1055 > > > > > > We should use a `continuation` here, you can refer to > >

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Aug. 25, 2016, 9 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review146859 --- Patch looks great! Reviews applied: [51009] Passed command:

Re: Review Request 50661: Documentation: fix broken links.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50661/#review146856 --- Pierre, still working on this? If yes, can you please address

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Aug. 25, 2016, 8:43 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51434: Use `continue` when breaking out of LAUNCH_GROUP case due to errors.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51434/#review146853 --- Ship it! Ship It! - Vinod Kone On Aug. 25, 2016, 5:58 p.m.,

Re: Review Request 51433: Added test case MasterAuthorizationTest, UnauthorizedTaskGroup.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51433/#review146850 --- Fix it, then Ship it! I'll fix the issues while committing.

Re: Review Request 51412: Add offeredResources to Allocator::updateAllocation() API.

2016-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51412/#review146789 --- Fix it, then Ship it! > This is being added to allow for

Re: Review Request 51043: Added support for reading out the bounding capability set.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/#review146847 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2016, 3:18 p.m.,

Re: Review Request 51428: Removed friendship between ProcessCapabilities and Capabilities.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51428/#review146846 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2016, 3:17 p.m.,

Re: Review Request 51402: Added nested container check in provisioner destroy.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51402/#review146845 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line

Review Request 51437: Added validation test for task group task using NetworkInfos.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/ --- Review request for mesos, Anand Mazumdar and Guangya Liu. Repository: mesos

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review146841 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines

Re: Review Request 51393: Added unit test for provisioner recursive listContainers().

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/#review146839 --- Fix it, then Ship it!

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

2016-08-25 Thread Gilbert Song
> On Aug. 25, 2016, 12:04 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/paths.hpp, line 83 > > > > > > What does 'parentId' mean here? I'd suggest we don't expose that > > parameter to the

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review146831 --- src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines

Re: Review Request 51257: Add external process container logger.

2016-08-25 Thread Joseph Wu
> On Aug. 22, 2016, 11:03 a.m., Joseph Wu wrote: > > src/CMakeLists.txt, line 171 > > > > > > Can you un-remove all these un-related `cpuacct` changes? > > Will Rouesnel wrote: > Weird, my local branch history

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51392/#review146825 --- src/slave/containerizer/mesos/provisioner/paths.hpp (line 83)

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146833 --- Patch looks great! Reviews applied: [51124] Passed command:

Re: Review Request 51343: Refactored the redundant logic in provisioner recover().

2016-08-25 Thread Gilbert Song
> On Aug. 25, 2016, 10:57 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 204 > > > > > > Why this change? Where is the error checking? I removed the error check because it

Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-25 Thread Joseph Wu
> On Aug. 24, 2016, 4:49 p.m., Joseph Wu wrote: > > Looks like the same code in the docker containerizer is missing the same > > check. > > Jie Yu wrote: > Can you create a ticket to track? :) https://issues.apache.org/jira/browse/MESOS-6092 - Joseph

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review146823 --- src/docker/executor.hpp (lines 80 - 83)

Re: Review Request 51409: Printed all the isolator cleanup errors during destory.

2016-08-25 Thread Jie Yu
> On Aug. 25, 2016, 8:22 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1768-1769 > > > > > > We should still keep the `ContainerID`, right? Nope, caller will (and should)

Re: Review Request 51416: Fixed a TODO in the MesosContainerizer.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51416/#review146826 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1641 -

Review Request 51433: Added test case MasterAuthorizationTest, UnauthorizedTaskGroup.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51433/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6087

Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review146824 --- src/slave/containerizer/docker.cpp (lines 230 - 249)

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Vinod Kone
> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review146816 --- src/slave/containerizer/docker.hpp (line 509)

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review146821 --- qian, sorry for the delay on getting back on this one. are you

Review Request 51434: Use `continue` when breaking out of LAUNCH_GROUP case due to errors.

2016-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51434/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Repository: mesos

Re: Review Request 51343: Refactored the redundant logic in provisioner recover().

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51343/#review146820 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/#review146819 --- src/slave/containerizer/mesos/launcher.cpp (lines 91 - 114)

Re: Review Request 51432: Added test case for TaskGroupValidationTest.ExecutorWithoutFrameworkId.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51432/#review146815 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/#review146791 --- Can you split the Launcher::wait support to a separate patch?

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146814 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Review Request 51432: Added test case for TaskGroupValidationTest.ExecutorWithoutFrameworkId.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51432/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6087

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote: > > src/health-check/health_checker.cpp, line 452 > > > > > > Will it work on all supported systems? Windows also have bash now but require external

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-25 Thread Kevin Klues
> On Aug. 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 1555 > > > > > > I wouldn't just blindly call this function here. It should be wrapped > > in some logic that makes

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review146801 --- Ship it! Ship It! - haosdent huang On Aug. 22, 2016, 7:15

Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

2016-08-25 Thread Rajat Phull
> On Aug. 21, 2016, 3:15 p.m., Guangya Liu wrote: > > Why not merge this with https://reviews.apache.org/r/50523 ? Agreed, this is now merged with https://reviews.apache.org/r/50523. Can be dropped from review. - Rajat --- This is an

Review Request 51431: Added health check support to mesos-execute.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51431/ --- Review request for mesos. Repository: mesos Description --- Only used

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Aug. 25, 2016, 4:22 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Aug. 25, 2016, 4:13 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146749 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 50956: Added name to uri fetcher plugins.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50956/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50957: Added fetch method based on plugin name.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50957/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50960: Added appc uri fetcher tests.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50958/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

2016-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 25, 2016, 3:21 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51410: Enabled meta discovery using appc labels.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Aug. 25, 2016, 3:21 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51043: Added support for reading out the bounding capability set.

2016-08-25 Thread Benjamin Bannier
> On Aug. 17, 2016, 8:20 p.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 229-231 > > > > > > Hum, this is not very performant. If lastCap == 37, a single get() here > > will issue 37 system calls. Can you

Re: Review Request 51042: Added function to apply capabilities to process exec'd next.

2016-08-25 Thread Benjamin Bannier
> On Aug. 19, 2016, 1:36 a.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 297-313 > > > > > > Should this just be a `set`? > > > > Also, we should just assume we have SETPCAP as agent is typically

Re: Review Request 50269: Added basic tests for capabilities API.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- (Updated Aug. 25, 2016, 5:20 p.m.) Review request for mesos and Jie Yu.

Review Request 51429: Added proper constructor for internal SyscallPayload class and used it.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51429/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 51043: Added support for reading out the bounding capability set.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51042: Added function to apply capabilities to process exec'd next.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Review Request 51428: Removed friendship between ProcessCapabilities and Capabilities.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51428/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45964: Add unit tests for sharing of resources.

2016-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/#review146219 --- src/tests/hierarchical_allocator_tests.cpp (lines 1269 - 1270)

  1   2   >