Re: Review Request 52190: Removed deprecated compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156822 --- Patch looks great! Reviews applied: [52190] Passed command:

Review Request 54053: Updated 'io::redirect()' to take an optional vector of callback hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54053/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-6639

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review156819 --- Fix it, then Ship it! docs/nested-container-and-task-group.md

Re: Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/ --- (Updated Nov. 24, 2016, 5:07 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53936: Added agent flags to enable/disable launching an io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/ --- (Updated Nov. 24, 2016, 5:07 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 54038: Added new hook for covering executor and task environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156809 --- Fix it, then Ship it! Looks good. I've got some

Re: Review Request 52364: Added basic support to invoke `docker.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/#review156808 --- Patch looks great! Reviews applied: [52364] Passed command:

Re: Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156807 --- Ship it! Ship It! - haosdent huang On Nov. 23, 2016, 1:11

Re: Review Request 53954: Made Zk error message more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53954/#review156806 --- Patch looks great! Reviews applied: [53954] Passed command:

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53995/ --- (Updated Nov. 23, 2016, 11:55 p.m.) Review request for mesos, Anand Mazumdar

Review Request 54049: Cleaned up includes in tests/api_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54049/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/ --- (Updated Nov. 23, 2016, 11:54 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 23, 2016, 11:53 p.m.) Review request for mesos, Anand Mazumdar

Review Request 54048: Fixed a minor bug in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54048/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 54039: Added `recordio::transform` helper.

> On Nov. 23, 2016, 9:15 p.m., Anand Mazumdar wrote: > > src/common/recordio.hpp, lines 101-103 > > > > > > You might want to reorder the arguments based on the comments above > > i.e., `Reader`, `func`

Re: Review Request 53626: Add net::setDomainname() helper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/#review156800 --- Ship it! Looks good to me. Although, I am not sure about the

Re: Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/#review156799 --- src/slave/containerizer/mesos/utils.cpp (line 68)

Re: Review Request 53936: Added agent flags to enable/disable launching an io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/#review156796 --- Fix it, then Ship it! src/slave/flags.cpp (line 261)

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156769 --- We should probably split the server code out and add unit test

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53559/#review156788 --- Ship it! Double checked to make sure this doesn't break any of

Re: Review Request 53560: LOG(FATAL) transformed into EXIT(EXIT_FAILURE) in process::initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53560/#review156789 --- Ship it! Ship It! - Joseph Wu On Nov. 17, 2016, 6:10 a.m.,

Re: Review Request 54017: Changed implementation of LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54017/ --- (Updated Nov. 23, 2016, 9:33 p.m.) Review request for mesos and Michael Park.

Re: Review Request 53558: Added net::IP parsing template to the flags parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/#review156787 --- Ship it! Ship It! - Joseph Wu On Nov. 8, 2016, 6:57 a.m.,

Re: Review Request 52190: Removed deprecated compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156785 --- cmake/CompilationConfigure.cmake (lines 97 - 98)

Re: Review Request 53755: CMake: Added example frameworks and executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53755/ --- (Updated Nov. 23, 2016, 1:25 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53473: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/#review156770 --- Ship it! Modulo a couple of things I'll tweak before

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/#review156767 --- Ship it! src/slave/container_loggers/logrotate.hpp (line 116)

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/#review156772 --- Fix it, then Ship it! Modulo a couple of things I'll tweak

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review156768 --- Ship it! This review has changed quite a bit over time. At

Re: Review Request 53706: Implemented `os::user' on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/#review156784 --- 3rdparty/stout/include/stout/os/windows/su.hpp (lines 61 - 63)

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156776 --- Fix it, then Ship it! LGTM, just a few minor style nits to

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/#review156783 --- This change should be replaced by these two:

Re: Review Request 54038: Added new hook for covering executor and task environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156778 --- Fix it, then Ship it! include/mesos/hook.hpp (line 136)

Re: Review Request 54038: Added new hook for covering executor and task environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156777 --- Ship it! Ship It! - Kapil Arya On Nov. 23, 2016, 2:26 p.m.,

Re: Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156773 --- Patch looks great! Reviews applied: [52863, 52864, 52865, 54004,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156684 --- This is a partial review. Will continue to review the rest while

Review Request 54038: Added new hook for covering executor and task environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/ --- Review request for mesos, Adam B, Gastón Kleiman, Kapil Arya, and Joseph Wu.

Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- Review request for mesos, Anand Mazumdar and Benjamin Mahler. Bugs: MESOS-6473

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Nov. 23, 2016, 6:34 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 53805: Updated libprocess test to use new 'Socket::shutdown' parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53805/ --- (Updated Nov. 23, 2016, 6:27 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Nov. 23, 2016, 6:26 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50969: Made use of SSL flags to determine scheduler/executor scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/ --- (Updated Nov. 23, 2016, 6:19 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 53803: Added a new libprocess HTTP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/ --- (Updated Nov. 23, 2016, 6:18 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53803: Added a new libprocess HTTP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/ --- (Updated Nov. 23, 2016, 6:17 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53803: Added a new libprocess HTTP test.

> On Nov. 23, 2016, 1:26 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 203-204 > > > > > > A lot of these comments seem to have a really long line followed by a > > really

Re: Review Request 53990: Added POSIX socket shutdown types to Windows header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53990/ --- (Updated Nov. 23, 2016, 6:13 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53990: Added POSIX socket shutdown types to Windows header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53990/ --- (Updated Nov. 23, 2016, 6:14 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54015: Added V1 API protos to python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54015/#review156763 --- Patch looks great! Reviews applied: [54014, 53825, 54015]

Re: Review Request 52364: Added basic support to invoke `docker.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/ --- (Updated Nov. 23, 2016, 5:19 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52544: Introduced `int_fd` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 23, 2016, 5:20 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Nov. 23, 2016, 5:13 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52190: Removed deprecated compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 5:12 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 53803: Added a new libprocess HTTP test.

> On Nov. 23, 2016, 1:26 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 203-205 > > > > > > This should be a SocketTest.ReceiveEOF within socket_tests.cpp? There > > doesn't

Re: Review Request 53610: Added health checks documentation.

> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote: > > docs/health-checks.md, line 21 > > > > > > Isn't a major advantage of Mesos-native health checks is that you avoid > > the scalability problems of having a

Review Request 54036: Fixed WebUI error on Firefox 45.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54036/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-6624

Re: Review Request 53610: Added health checks documentation.

> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote: > > docs/health-checks.md, line 21 > > > > > > Isn't a major advantage of Mesos-native health checks is that you avoid > > the scalability problems of having a

Re: Review Request 53610: Added health checks documentation.

> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote: > > docs/health-checks.md, line 19 > > > > > > The phrase "incorporating network failures in health check information > > is not always desirable" is vague. What is

Review Request 54034: Introduced common fixture to PosixRLimitsIsolatorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54034/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6402

Review Request 54035: Extended test coverage of posix/rlimits isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54035/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6402

Re: Review Request 53954: Made Zk error message more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53954/ --- (Updated Nov. 23, 2016, 4:32 p.m.) Review request for mesos and Alexander

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

> On Nov. 23, 2016, 1:24 a.m., Jason Lai wrote: > > Hi Haosdent! I think the subsystem name for PIDs is `pids` instead of `pid` > > (look at the example below). We should rename it also for the purpose of > > avoiding confusion with the PID namespace isolator. > > > > ``` > > $ cat

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

> On Nov. 23, 2016, 1:20 a.m., Jason Lai wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.cpp, line > > 37 > > > > > > `CpuSetSubsystem`? Should be CpusetSubsystem. For example, we use

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53546/ --- (Updated Nov. 23, 2016, 4:20 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52190: Removed deprecated compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 4:12 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 53954: Made Zk error message more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53954/#review156748 --- Ship it! src/zookeeper/group.cpp (line 604)

Review Request 53954: Made Zk error message more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53954/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/ --- (Updated Nov. 23, 2016, 3:52 p.m.) Review request for mesos and Michael Park.

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review156742 --- Patch looks great! Reviews applied: [54013] Passed command:

Re: Review Request 53877: Added temporary file environment passing towards docker.

> On Nov. 22, 2016, 10:48 p.m., Adam B wrote: > > src/docker/docker.cpp, lines 575-583 > > > > > > Looks like you're doing the close in both the `if(write.isError())` > > above and here below. You could pull it out

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

> On Nov. 23, 2016, 1:20 a.m., Jason Lai wrote: > > src/CMakeLists.txt, line 173 > > > > > > Should be `pids.cpp` instead of `pid.cpp`? My bad, let me update > On Nov. 23, 2016, 1:20 a.m., Jason Lai wrote: > >

Re: Review Request 53610: Added health checks documentation.

> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote: > > docs/health-checks.md, line 231 > > > > > > command or binary? I'll go with 'command' for consitency. - Alexander

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/#review156730 --- src/examples/inverse_offer_framework.cpp (line 529)

Re: Review Request 53610: Added health checks documentation.

> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote: > > docs/health-checks.md, line 204 > > > > > > s/as first/as a first/ ? I think 'the' suits better, no? - Alexander

Re: Review Request 53610: Added health checks documentation.

> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote: > > docs/health-checks.md, line 101 > > > > > > Don't they always enter the network namespace? Not really. Sometimes they don't enter the namespace if it is

Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54019/ --- (Updated Nov. 23, 2016, 2:19 p.m.) Review request for mesos and Michael Park.

Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.

> On Nov. 23, 2016, 1:27 p.m., Gastón Kleiman wrote: > > src/hook/manager.cpp, line 385 > > > > > > s/Resources/Attributes/ Thanks, good catch! - Neil ---

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 23, 2016, 2:42 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

> On Nov. 17, 2016, 10:44 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.proto, line 160 > > > > > > Since LNC, KillNC, and WaitNC already exist, could you wire up the > > authorization check for

Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54019/#review156729 --- Fix it, then Ship it! src/hook/manager.cpp (line 374)

Re: Review Request 53741: Display maintainance info in the webui.

> On Nov. 16, 2016, 8:18 a.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 469 > > > > > > Any reason that remove `pollState();` here? > > Tomasz Janiszewski wrote: > This function

Re: Review Request 54007: Printed complete health check configuration on task launch.

> On Nov. 23, 2016, 4:10 a.m., haosdent huang wrote: > > src/health-check/health_checker.cpp, line 213 > > > > > > No sure if `check.SerializeAsString()` would be better or not. Or we > > could add a `stringify()`

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 23, 2016, 2:20 a.m., haosdent huang wrote: > > src/tests/utils.cpp, line 82 > > > > > > Should we move the comment > > > > ``` > > // Bind to port 0 to obtain a random unused port. > > ```

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review156709 --- include/mesos/authorizer/acls.proto (line 271)