Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182781 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182780 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182779 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182778 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61602: Fixed mesos containerizer to support docker image WORKDIR missing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61602/#review182776 --- Patch looks great! Reviews applied: [61602] Logs available

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182775 --- src/tests/default_executor_tests.cpp Lines 1436 (patched)

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182774 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61546: Created staging dir only when needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61546/#review182773 --- Patch looks great! Reviews applied: [61546] Logs available

Re: Review Request 60525: Fixed the default filter used by the allocator.

> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Line 2257 (original), 2258-2262 (patched) > > > > > > Is there a suitable place in the documentation for us to mention this? > >

Re: Review Request 60525: Fixed the default filter used by the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60525/ --- (Updated Aug. 12, 2017, 1:07 a.m.) Review request for mesos, Alexander

Review Request 61601: Stout: make boundary checking in Duration consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61601/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and

Review Request 61602: Fixed mesos containerizer to support docker image WORKDIR missing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61602/ --- Review request for mesos, Jie Yu, Kevin Klues, and Qian Zhang. Bugs:

Re: Review Request 60721: Stout: Made `Duration::parse()` handle durations out of range.

> On Aug. 11, 2017, 6:32 p.m., Greg Mann wrote: > > 3rdparty/stout/tests/duration_tests.cpp > > Lines 65 (patched) > > > > > > Why the newline? woops, I did it again. - Gastón

Re: Review Request 60721: Stout: Made `Duration::parse()` handle durations out of range.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60721/ --- (Updated Aug. 12, 2017, 1:02 a.m.) Review request for mesos, Alexander

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182770 --- Bad patch! Reviews applied: [61270, 61406, 61428, 61463, 61464,

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/#review182768 --- Ship it! Ship It! - Greg Mann On Aug. 10, 2017, 9:10 p.m.,

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182766 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182765 --- Patch looks great! Reviews applied: [61588] Logs available

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/ --- (Updated Aug. 11, 2017, 4:27 p.m.) Review request for mesos, Jeff Coffler and

Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.

> On Aug. 11, 2017, 2:45 p.m., Mesos Reviewbot Windows wrote: > > Bad review! > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or the > > mailing list. Oh, I know why. There are some dependent reviews without a reviewer (as I used `support/post-reviews.py`

Re: Review Request 61291: Imported `glog` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61291/ --- (Updated Aug. 11, 2017, 4:20 p.m.) Review request for mesos. Changes ---

Re: Review Request 61565: Stout: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61565/#review182763 --- Ship it! Woohoo!! Thx Gaston! - Greg Mann On Aug. 10, 2017,

Re: Review Request 61564: Libprocess: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61564/#review182762 --- Ship it! Ship It! - Greg Mann On Aug. 10, 2017, 5:51 p.m.,

Re: Review Request 61565: Stout: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61565/#review182761 --- Ship it! Thanks for this, Gaston!! - Greg Mann On Aug. 10,

Re: Review Request 61546: Created staging dir only when needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61546/#review182760 --- Ship it! Ship It! - Gilbert Song On Aug. 10, 2017, 2:28

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182757 --- src/tests/default_executor_tests.cpp Lines 1580 (patched)

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182755 --- src/tests/default_executor_tests.cpp Lines 1538-1542 (patched)

Re: Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61466/#review182754 --- Fix it, then Ship it!

Re: Review Request 61465: Added test `NamespacesIsolatorTest.ROOT_SharePidNamespaceWhenDisallow`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61465/#review182752 --- Fix it, then Ship it!

Re: Review Request 61464: Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61464/#review182751 --- Ship it! Ship It! - Gilbert Song On Aug. 7, 2017, 8:13

Re: Review Request 61464: Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61464/#review182750 --- src/tests/containerizer/isolator_tests.cpp Lines 160-165

Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182749 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/ --- (Updated Aug. 11, 2017, 9:03 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182747 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182746 --- Patch looks great! Reviews applied: [61262] Logs available

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182745 --- Patch looks great! Reviews applied: [61588] Logs available

Re: Review Request 60525: Fixed the default filter used by the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60525/#review182730 --- include/mesos/mesos.proto Line 2257 (original), 2258-2262

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182742 --- Fix it, then Ship it! Thanks for the patch. I am sure this

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61463/#review182741 --- Ship it! Ship It! - Gilbert Song On Aug. 8, 2017, 2:43

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182739 --- Ship it! Ship It! - Gilbert Song On Aug. 8, 2017, 2:40

Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.

> On Aug. 11, 2017, 12:09 p.m., Mesos Reviewbot Windows wrote: > > Bad review! > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or the > > mailing list. Weird, it had reviewers before it was posted. - Andrew

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182735 --- Patch looks great! Reviews applied: [61262] Logs available

Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182736 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61270: Added container PID namespace control protobuf field in LinuxInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61270/ --- (Updated Aug. 11, 2017, 11:52 a.m.) Review request for mesos, Avinash

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/ --- (Updated Aug. 11, 2017, 6:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60721: Stout: Made `Duration::parse()` handle durations out of range.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60721/#review182728 --- Fix it, then Ship it!

Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/ --- Review request for mesos, Jeff Coffler and Joseph Wu. Bugs: MESOS-7704

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182718 --- docs/health-checks.md Line 29 (original), 29 (patched)

Re: Review Request 61261: Documented agent garbage collection metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61261/#review182726 --- Bad patch! Reviews applied: [61259, 61260, 61261] Logs

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182719 --- Patch looks great! Reviews applied: [61434] Logs available

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review182655 --- src/tests/api_tests.cpp Lines 2905-2906 (patched)

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

> On Aug. 11, 2017, 11:02 a.m., Benjamin Bannier wrote: > > support/apply-reviews.py > > Line 364 (original), 371-373 (patched) > > > > > > Since this prevents running any (pre-)commit hooks, I wonder if we > >

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

> On Aug. 11, 2017, 9:02 a.m., Benjamin Bannier wrote: > > support/apply-reviews.py > > Line 364 (original), 371-373 (patched) > > > > > > Since this prevents running any (pre-)commit hooks, I wonder if we > >

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61580/#review182710 --- Patch looks great! Reviews applied: [61579, 61580] Logs

Re: Review Request 61118: WIP: Building gRPC support in libprocess with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/#review182707 --- Patch looks great! Reviews applied: [61488, 61489, 61508, 61509,

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182697 --- Patch looks great! Reviews applied: [61531] Logs available

Re: Review Request 61565: Stout: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61565/#review182696 --- Patch looks great! Reviews applied: [61511, 61564, 61565] Logs

Re: Review Request 60494: Exposed LinuxLauncher cgroups helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60494/#review182695 --- src/slave/containerizer/mesos/linux_launcher.hpp Lines 64

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61580/#review182687 --- Patch looks great! Reviews applied: [61579, 61580] Passed

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review182686 --- Bad patch! Reviews applied: [61473] Logs available here:

Re: Review Request 61575: Added a test for verifying signal escalation on the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61575/#review182685 --- Bad patch! Reviews applied: [61569, 61570, 61571, 61572, 61573,

Re: Review Request 61575: Added a test for verifying signal escalation on the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61575/#review182680 --- Patch looks great! Reviews applied: [61569, 61570, 61571, 61572,

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182679 --- Patch looks great! Reviews applied: [61588] Logs available

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review182678 --- Bad patch! Reviews applied: [61222, 61408] Logs available here:

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182670 --- support/apply-reviews.py Lines 263-266 (original), 269-273

Re: Review Request 60495: Added network ports isolator listen socket utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review182665 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines