ading flags.
- Joseph Wu
On April 18, 2016, 7:52 p.m., Andy Pang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
framework were compiled outside of Mesos.
Diffs
-
src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3
Diff: https://reviews.apache.org/r/46411/diff/
Testing
---
make check
Thanks,
Joseph Wu
src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c
Diff: https://reviews.apache.org/r/46407/diff/
Testing
---
See next review in this chain.
Thanks,
Joseph Wu
/
Testing
---
```
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```
Thanks,
Joseph Wu
sk_memory=256MB
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review129187
---
On April 19, 2016, 2:51 p.m., Joseph Wu wrote:
>
>
> On April 12, 2016, 3:46 p.m., Vinod Kone wrote:
> > src/examples/balloon_executor.cpp, lines 143-153
> > <https://reviews.apache.org/r/45604/diff/2/?file=1337947#file1337947line143>
> >
> > Why the change here?
>
> Joseph Wu wrote:
> I coup
(line 303)
<https://reviews.apache.org/r/46456/#comment193372>
Nit: The rest of the document capitalizes the first letter of each mode.
- Joseph Wu
On April 20, 2016, 2:41 p.m., Neil Conway wrote:
>
> ---
> This is a
-checked conversion of Path to string.
Thanks,
Joseph Wu
a4afdad0b5f053186ace4d6a37b41cd02e7d415b
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
3211a0d6b88d06b396678eaf20128698f576d198
Diff: https://reviews.apache.org/r/36116/diff/
Testing
---
One unit test to demonstrate statically-checked conversion of Path to string.
Thanks,
Joseph Wu
it in the associated review (36141), but it isn't mentioned in the
Doxygen style guide.
- Joseph Wu
On July 6, 2015, 2:01 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On July 6, 2015, 11:39 a.m., Joseph Wu wrote:
> > docs/mesos-doxygen-style-guide.md, line 102
> > <https://reviews.apache.org/r/36193/diff/1/?file=999588#file999588line102>
> >
> > This isn't part of the diff, but should this `@note` tag be replac
tps://reviews.apache.org/r/36193/#comment143645>
This isn't part of the diff, but should this `@note` tag be replaced with a
`**NOTE:**`?
- Joseph Wu
On July 6, 2015, 2:01 a.m., Joerg Schad wrote:
>
> ---
> This is an automatica
tps://reviews.apache.org/r/36193/#comment143651>
It might be worthwhile to emphasize that markdown syntax can/should be used
in with the comment blocks. I think Javadocs generally use plain HTML for
links, tables, etc.
- Joseph Wu
On July 6, 2015, 2:01 a.m., Joerg Schad
---
`doxygen ../Doxyfile` and visually verified the HTML output.
Thanks,
Joseph Wu
/
Testing
---
`doxygen ../Doxyfile` and visually verified the HTML output.
Thanks,
Joseph Wu
/
Testing
---
Checked rendered markdown.
Thanks,
Joseph Wu
s://reviews.apache.org/r/36273/#review91096
-----------
On July 7, 2015, 5:24 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. T
ss/include/process/process.hpp
59b50af86e059463a01f3c83701bc5fd143d51a4
Diff: https://reviews.apache.org/r/36273/diff/
Testing
---
`doxygen ../Doxyfile` and visually verified the HTML output.
Thanks,
Joseph Wu
501/#comment145460>
* Tab size = 2 spaces.
* Parameters are indented by 4 spaces.
* Comments start with a capital letter and end with a period.
* Logical blocks have the opening "{" on the same line.
- Joseph Wu
On July 14, 2015, 7:59 p.m.
/libprocess/3rdparty/stout/include/stout/linux/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows/abort.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing
---
`make` and `make check`
Thanks,
Joseph Wu
? Or just
implementing the templated send function after the Master has been defined?
i.e.
```
struct Framework {
...
template
void send(const Message& message);
...
}
class Master { ... }
template
void Framework::send(const Message& message) {
...
}
```
- Joseph Wu
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92800
---
Ship it!
- Joseph Wu
On July 22, 2015, 12:07 p.m., Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36672/#review92801
---
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 9:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92802
---
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 10:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36674/#review92804
---
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 10:56 p.m
stout/tests/thread_tests.cpp), why not remove the ThreadLocal struct entirely?
- Joseph Wu
On July 22, 2015, 1:23 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
t/windows/thread.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows/unreachable.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing (updated)
---
`make` and `make check` (Mac OSX)
Thanks,
Joseph Wu
/windows/unreachable.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing
---
`make` and `make check` (Mac OSX)
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/#review93144
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93145
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93146
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:19 a.m
/thread_local.hpp (line 25)
<https://reviews.apache.org/r/36845/#comment147404>
`TLS` might be a bit too short for readable code. (And people that google
it will come up with Transport Layer Security, instead of Thread Local Storage.)
Maybe `THREAD_LOCAL` would be better.
- Joseph Wu
O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93187
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 2:15 p.m
CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows/thread.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing
---
`make` and `make check` (Mac OSX)
Thanks,
Joseph Wu
rise 2015 [thanks to Alex (hausdorff)].
Thanks,
Joseph Wu
/stout/windows/preprocessor.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36783/diff/
Testing (updated)
---
`make` and `make check` (Mac OSX).
Build with MSVC Enterprise 2015 [thanks to Alex (hausdorff)].
Thanks,
Joseph Wu
36864/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
se to just `typename...` .
Diffs (updated)
-
3rdparty/libprocess/include/process/help.hpp
316ed21b5300496f283d0c331fa6d9dad441d332
Diff: https://reviews.apache.org/r/36865/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
.
Repository: mesos
Description
---
For more detail on why this is bad, see MESOS-2629.
Diffs
-
src/master/registrar.hpp 6bc78c4904effde8e4108cf226467419dd014e2f
Diff: https://reviews.apache.org/r/36959/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
de/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36783/#review94159
-------
On July 29, 2015, 4:24 p.m., Joseph Wu wrote:
>
> ---
>
/master/master.cpp (line 3649)
<https://reviews.apache.org/r/37170/#comment149936>
Ditto.
src/master/master.cpp (line 3855)
<https://reviews.apache.org/r/37170/#comment149938>
Ditto.
- Joseph Wu
On Aug. 10, 2015, 12:04 a.
y like:
```
struct MaintenanceInfo {
Unavailability unavailability;
mesos::maintenance::mode mode;
}
hashmap maintenanceInfos;
```
- Joseph Wu
On Aug. 10, 2015, 12:04 a.m., Joris Van Remoortere wrote:
>
> ---
straightforward route to pass the new schedule info along.
Instead, I think adding another method for passing unavailabilities along
would be better. We could call that method after agent registration or after
hitting the maintenance endpoints.
- Joseph Wu
On Aug. 10, 2015, 12:05
> On Aug. 12, 2015, 12:01 p.m., Joseph Wu wrote:
> > include/mesos/master/allocator.hpp, lines 96-101
> > <https://reviews.apache.org/r/37173/diff/2/?file=1035790#file1035790line96>
> >
> > I'm not convinced that `addSlave` is the appropriate
ration =
Druation::create(unavailability.get().duration());`
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review95160
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m
Isn't `offerable[frameworkId]` always undefined?
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/#review95167
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/#review95168
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m
/master/master.cpp (lines 4795 - 4796)
<https://reviews.apache.org/r/37180/#comment150011>
This second sentence might be better placed in the InverseOffer protobuf.
src/master/master.cpp (line 5667)
<https://reviews.apache.org/r/37180/#comment150014>
`callled`
- Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/#review95177
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:06 a.m
https://reviews.apache.org/r/36321/ .
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review95179
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:06 a.m
g/r/37284/#comment150020>
This `continue` seems extraneous.
src/master/master.cpp (line 3162)
<https://reviews.apache.org/r/37284/#comment150019>
Is this `continue` necessary?
(Same question for the other instances below.)
- Joseph Wu
On Aug. 10, 2015, 12:06 a.m
JIRAs,
see MESOS-1474).
Diffs (updated)
-
include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37415/
> -----------
>
> (Updated Aug. 13, 2015, 9:49 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
>
>
> Bugs:
:
https://issues.apache.org/jira/browse/MESOS-3264
Since this change makes the test less flaky, I say it LGTM.
- Joseph Wu
On Aug. 13, 2015, 9:49 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To rep
:
https://issues.apache.org/jira/browse/MESOS-3264
Since this change makes the test less flaky, I say it LGTM.
- Joseph Wu
On Aug. 13, 2015, 9:56 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To rep
CXXFLAGS=\"${GMOCK_CONFIG_CXXFLAGS}\" "
^ ^ ^
```
- Joseph Wu
On Aug. 15, 2015, 5:07 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
tps://reviews.apache.org/r/37170/#comment150904>
Note: There might be a rebase conflict with
https://reviews.apache.org/r/37314/diff/4#3 since both have the same text.
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere
modes as pronouns [Normal, Draining, Deactivated]. We
could change them all to be `screaming`-case. Or to pronoun-case.
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/#review95782
---
Ship it!
LGTM
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris
(line 478)
<https://reviews.apache.org/r/37175/#comment150913>
Why is this return type `Nothing`, instead of `void`?
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review95785
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m
tps://reviews.apache.org/r/37180/#comment150914>
Typo still present.
- Joseph Wu
On Aug. 18, 2015, 11:58 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review95788
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2015, 11:58 a.m
tps://reviews.apache.org/r/37172/#comment151021>
s/machines/machine_infos/
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Duration.
Diffs
-
include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
Diff: https://reviews.apache.org/r/37655/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96073
---
On Aug. 12, 2015, 3:07 p.m., Joseph Wu wrote:
>
>
ents (that part is tracked in separate JIRAs,
see MESOS-1474).
Diffs (updated)
-
include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
ssed by `unavailability.start`.
> > Given we don't need duration in this case, the name can be misleading for
> > users.
>
> Joseph Wu wrote:
> A while ago, I posted a few diffs where this object was called `Interval`
> (https://reviews.apache.org/r/36321/diff/7
9fd71d1ddf442712977596e7a13969ff5c1d68db
src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6
Diff: https://reviews.apache.org/r/36571/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
lists.
Schedules some machines. Deactivates some. Tests some valid and invalid
lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
point with some valid and invalid schedules.
Only tests a subset of invalid schedules (requires other endpoints to fully
test).
Thanks,
Joseph Wu
/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37364/diff/
Testing
---
`make check`
New Tests:
MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
Extra test case for the /maintenance.schedule endpoint, which requires all
three endpoints to work.
MasterMaintenanceTest.MachineStatus
Schedules, starts, and stops maintenance. Checks machine statuses after
each step.
Thanks,
Joseph Wu
> On Aug. 12, 2015, 10:31 a.m., Joseph Wu wrote:
> > src/master/maintenance.cpp, lines 126-130
> > <https://reviews.apache.org/r/37325/diff/2/?file=1037747#file1037747line126>
> >
> > Note: Considering the "machine" field in the master's loca
-
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
---
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
Thanks,
Joseph Wu
,
Joseph Wu
/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
Diff: https://reviews.apache.org/r/37314/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
.
Repository: mesos
Description
---
Some refactoring in https://reviews.apache.org/r/36763 missed these lines.
Diffs
-
include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06
Diff: https://reviews.apache.org/r/37729/diff/
Testing
---
`make check`
Thanks,
Joseph
iff/
Testing
---
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
Thanks,
Joseph Wu
`
Thanks,
Joseph Wu
correctness.
Thanks,
Joseph Wu
concept of time (i.e. "When
are you available?").
- Joseph
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96259
-
/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
bufs, we will add it
to the V1 API when it is necessary to do so.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96301
----------
re put into Draining mode. Removes machines.
MasterMaintenanceTest.UpdateSchedule
Hits the new endpoint with some valid and invalid schedules.
Only tests a subset of invalid schedules (requires other endpoints to fully
test).
Thanks,
Joseph Wu
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358/#review96309
-------
On Aug. 24, 2015, 11:54 a.m., Joseph Wu wrote:
>
> ---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/#review96313
---
On Aug. 24, 2015, 12:08 p.m., Joseph Wu wrote:
>
>
ts the new endpoint with some valid and invalid schedules.
Only tests a subset of invalid schedules (requires other endpoints to fully
test).
Thanks,
Joseph Wu
.
Thanks,
Joseph Wu
invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid
lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37364/diff/
Testing
---
`make check`
New Tests:
MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
Extra test case for the /maintenance.schedule endpoint, which requires all
three endpoints to work.
MasterMaintenanceTest.MachineStatus
Schedules, starts, and stops maintenance. Checks machine statuses after
each step.
Thanks,
Joseph Wu
(line 258)
<https://reviews.apache.org/r/37172/#comment151695>
Might need a `static_cast` here.
src/tests/master_maintenance_tests.cpp (line 277)
<https://reviews.apache.org/r/37172/#comment151694>
Should be changed to an int comparison.
- Joseph Wu
On Aug. 24, 20
.." << start.secs();
```
- Joseph Wu
On Aug. 24, 2015, 7:12 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
chain.
Diffs (updated)
-
src/tests/hierarchical_allocator_tests.cpp
9748ca0b3fee25dcec51c64d8ba84dbd4aaf
Diff: https://reviews.apache.org/r/37582/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
izer/docker.cpp (line 129)
<https://reviews.apache.org/r/37114/#comment151750>
Extra newline.
src/tests/flags.hpp (line 83)
<https://reviews.apache.org/r/37114/#comment151745>
Extra space before `\n`.
- Joseph Wu
On Aug.
> On Aug. 24, 2015, 4:56 p.m., Vinod Kone wrote:
> > This review is a bit hard to follow because it's doing multiple things. I
> > would recommend you to split this into multiple reviews
> >
> > #1) Expose framework user in state.json
> > #2) Update framework user on re-registration (need a tes
201 - 300 of 2923 matches
Mail list logo
