/40375/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
> On Oct. 7, 2015, 8:42 a.m., Klaus Ma wrote:
> > src/common/resources.cpp, line 879
> > <https://reviews.apache.org/r/39056/diff/3/?file=1092072#file1092072line879>
> >
> > This fix is ok for this ticket; but how to handle other part about
> > cpu()?
---
make
make check
Thanks,
Klaus Ma
or
// class in .h files.
using ::foo::bar;
```
Diffs (updated)
-
src/slave/containerizer/fetcher.hpp 78e7d14
src/tests/mesos.hpp a2a76f5
Diff: https://reviews.apache.org/r/40631/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
tps://reviews.apache.org/r/40431/#comment167228>
I'm thinke whether we need to enhance weight to `int`. Any case that we has
to use `double` as weight? If we want to control the scope, TODO is OK.
- Klaus Ma
On Nov. 25, 2015, 9:57 a.m., Yong Qiao
tps://reviews.apache.org/r/40690/#comment167229>
Should we also handle the same issue in other files?
```
$grep -rn "> >" src/* | wc -l
893
```
- Klaus Ma
On Nov. 25, 2015, 10:32 a.m., Neil Conway wrote:
>
>
(updated)
-
include/mesos/mesos.proto 27971fe
include/mesos/v1/mesos.proto 9acefd5
src/common/resources.cpp b4abf54
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
---
make && make check
Thanks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107929
---
Ship it!
Ship It!
- Klaus Ma
On Nov. 25, 2015, 10:32 a.m
> On Nov. 25, 2015, 10:52 a.m., Klaus Ma wrote:
> > src/tests/authentication_tests.cpp, line 55
> > <https://reviews.apache.org/r/40690/diff/1/?file=1139599#file1139599line55>
> >
> > Should we also handle the same issue in other files?
> >
> &g
k is on-going)
Thanks,
Klaus Ma
nager will also help to it. I have add a comment
to its design doc to propose a role manager plugin.
- Klaus Ma
On Nov. 24, 2015, 10:39 a.m., Yong Qiao Wang wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/40544/#comment167464>
I think whether we need a general url tools for suck similar action for
API? for example, for the `tokenize`, what's the behavior if there are two '/'?
- Klaus Ma
On Nov. 26, 2015, 5:26 a.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40730/#review108136
---
Ship it!
Ship It!
- Klaus Ma
On Nov. 26, 2015, 2:52 p.m
tps://reviews.apache.org/r/40732/#comment167498>
We can not change this to `EXPECT_DOUBLE_EQ` because it's used to check
`operator==` in `Resources`. I think we can check the source code of
`CHECK_NEAR` and re-use it in `Scalar::operator==`.
- Klaus Ma
On Nov. 26, 2015, 2:52 p.m., Avinash srid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40721/#review108172
---
Ship it!
Ship It!
- Klaus Ma
On Nov. 27, 2015, 6:42 a.m., Neil
g/r/40755/#comment167507>
Any UT cases for it?
- Klaus Ma
On Nov. 27, 2015, 1:37 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108175
---
Ship it!
Ship It!
- Klaus Ma
On Nov. 27, 2015, 1:38 a.m
247/#comment167511>
Shoud '\' align with other line?
- Klaus Ma
On Nov. 27, 2015, 6:42 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/#review108183
---
Can you translate your test cases into GTest?
- Klaus Ma
On Nov
master.hpp 96951e7
src/master/master.cpp b918ae4
src/slave/constants.hpp bcbb140
src/slave/slave.hpp 5ee133a
src/slave/slave.cpp 9055f2a
Diff: https://reviews.apache.org/r/40759/diff/
Testing (updated)
-------
only `make` passwd for now.
Thanks,
Klaus Ma
> On Nov. 27, 2015, 8:34 a.m., Klaus Ma wrote:
> > src/common/resources.cpp, line 775
> > <https://reviews.apache.org/r/40755/diff/1/?file=1147692#file1147692line775>
> >
> > Any UT cases for it?
>
> Alexander Rukletsov wrote:
> What
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40767/#review108227
---
Ship it!
Ship It!
- Klaus Ma
On Nov. 27, 2015, 9:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40755/#review108248
---
Ship it!
Ship It!
- Klaus Ma
On Nov. 27, 2015, 10:46 p.m
---------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review108438
---
On Nov. 25, 2015, 2:16 p.m., Klaus Ma wrote:
>
> --
(updated)
-
include/mesos/mesos.proto 27971fe
include/mesos/v1/mesos.proto 9acefd5
src/common/resources.cpp 98804a4
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
---
make && make check
Thanks
tempt of e.g., mocking
> > `FetcherInfo` anywhere much harder.
> >
> > Either pull this into the internal namespace, or just do the extra
> > typing here and pull it in in the corresponding `mesos.cpp`.
>
> Klaus Ma wrote:
> @Guangya/Ben, I'm thinking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review108440
-------
On Nov. 25, 2015, 2:41 p.m., Klaus Ma wrote:
>
> -
`
Diffs (updated)
-
include/mesos/mesos.proto 27971fe
include/mesos/v1/mesos.proto 9acefd5
src/common/resources.cpp 98804a4
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40631/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/#review108486
---
On Dec. 1, 2015, 8:51 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated
-
src/slave/containerizer/fetcher.hpp 78e7d14
src/tests/mesos.hpp a2a76f5
Diff: https://reviews.apache.org/r/40631/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
mp; make check
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/#review108487
---
On Dec. 1, 2015, 9:13 p.m., Klaus Ma wrote:
>
> ---
> This is
://reviews.apache.org/r/40379/diff/
Testing
---
make (make check is on-going)
Thanks,
Klaus Ma
ated)
-
src/slave/containerizer/fetcher.hpp 78e7d14
src/slave/containerizer/fetcher.cpp 26df3d5
src/tests/fetcher_cache_tests.cpp fb0b3ba
src/tests/mesos.hpp 8d2d919
src/tests/mesos.cpp d42dab5
Diff: https://reviews.apache.org/r/40631/diff/
Testing
---
make && m
diff/
Testing
---
only `make` passwd for now.
Thanks,
Klaus Ma
ew RR#41066 to address.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/#review109207
---
On Sept. 18
Description
---
Missed containerId in v1 API when fixing MESOS-2875.
Diffs
-
include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068
Diff: https://reviews.apache.org/r/41066/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
src/tests/monitor_tests.cpp a848d14
src/tests/reservation_endpoints_tests.cpp c3833d0
src/tests/slave_recovery_tests.cpp c0e4ff7
src/tests/slave_tests.cpp 4975bea
Diff: https://reviews.apache.org/r/40759/diff/
Testing
-------
only `make` passwd for now.
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40903/#review109672
---
Ship it!
Ship It!
- Klaus Ma
On Dec. 3, 2015, 7:09 p.m., Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review109894
---
Ship it!
Ship It!
- Klaus Ma
On Dec. 10, 2015, 10:26 p.m
)
-
include/mesos/mesos.proto 8ca2130
include/mesos/v1/mesos.proto 8f357b0
src/common/resources.cpp 5a79817
src/tests/resources_tests.cpp ce47bac
src/v1/resources.cpp d300842
Diff: https://reviews.apache.org/r/40375/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
c0e4ff7
src/tests/slave_tests.cpp 4975bea
Diff: https://reviews.apache.org/r/40759/diff/
Testing (updated)
-------
`make && make check` in OS
Thanks,
Klaus Ma
proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41302/diff/
Testing
---
Thanks,
Klaus Ma
9bd86e122c070cd072a54d4de8097f844bd95bb0
Diff: https://reviews.apache.org/r/41305/diff/
Testing
---
Thanks,
Klaus Ma
6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0
Diff: https://reviews.apache.org/r/41306/diff/
Testing
---
Thanks,
Klaus Ma
: https://reviews.apache.org/r/41308/diff/
Testing
---
Thanks,
Klaus Ma
check is on-going)
Thanks,
Klaus Ma
(updated)
-
include/mesos/mesos.proto 8ca2130
include/mesos/v1/mesos.proto 8f357b0
src/common/resources.cpp 5a79817
src/tests/resources_tests.cpp ce47bac
src/v1/resources.cpp d300842
Diff: https://reviews.apache.org/r/40375/diff/
Testing
---
make && make check
Thanks
. To reply, visit:
https://reviews.apache.org/r/40375/#review109993
-------
On Dec. 12, 2015, 11:19 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
9762f85
src/examples/dynamic_reservation_framework.cpp PRE-CREATION
src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
src/tests/examples_tests.cpp 5211f54
Diff: https://reviews.apache.org/r/37168/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
tps://reviews.apache.org/r/40632/#comment169923>
Honestly, I'd like to separate optimistic resources into other counter in
allocator; it's a litte different with oversubscription: here, one reserved
resources are counting twice in total.
- Klaus Ma
On Dec. 13, 2015, 7:35 p.m., G
g/r/41337/#comment169982>
For this one, I'm thinking your working on MESOS-3891, right? And I don't
think get total/used resources by REST API is a good way :).
- Klaus Ma
On Dec. 14, 2015, 5:25 p.m., Guangya Liu wrote:
>
> --
> On Dec. 14, 2015, 10:14 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 431
> > <https://reviews.apache.org/r/40632/diff/6/?file=1161883#file1161883line431>
> >
> > Honestly, I'd like to separate optimistic resources into o
s?
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41306/#review110172
---
On Dec. 12, 2015, 5:55 p.m., Klaus Ma wrote:
>
>
ust slave's resource if lots of executor in slave.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review110166
--------
d framework run?
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review110166
---
On Dec. 12, 2015, 5:54 p.m., Klaus Ma wrote:
&g
://reviews.apache.org/r/41345/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
)
-
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review110233
-------
On Dec. 12, 2015, 5:54 p.m., Klaus Ma wrote:
>
>
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/#review110230
-------
On Dec. 12, 2015, 5:52 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-
executor's resources, right? But I think we should always add
> > DEFAULT_EXECUTOR_CPUS to executor's resources in this case.
>
> Klaus Ma wrote:
> The purpose of this code is not to overcommit resources; for example,
> only CPU or memory in cluster, master can not as
offered, revocable resources.
Diffs (updated)
-
include/mesos/type_utils.hpp b370b51
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
urces.cpp 5a7981744726a0544435cbbd5007487a43a01211
Diff: https://reviews.apache.org/r/41501/diff/
Testing
---
Thanks,
Klaus Ma
e.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0
Diff: https://reviews.apache.org/r/41503/diff/
Testing
---
Thanks,
Klaus Ma
hanks,
Klaus Ma
done to `noRevoable`
- Klaus Ma
On Dec. 17, 2015, 5:43 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41334/
> --
g/r/41250/#comment170937>
So we are going to only cover `SCALAR` resources? Is that necessary?
- Klaus Ma
On Dec. 14, 2015, 3:13 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
g/r/41337/#comment170938>
Honestly, I'd suggest to update `shutdownExecutor` to return future; so
slave'll wait all future finished before `runTask`. LaunchTask periodic does
not make sense :).
- Klaus Ma
On Dec. 17, 2015, 5:22 p.m., G
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41539/#review19
---
Ship it!
Ship It!
- Klaus Ma
On Dec. 18, 2015, 1:38 p.m
can not use ALLOCATION_SLACK mixed with other resources,
allocator need to check seperatly.
src/master/allocator/mesos/hierarchical.cpp (line 1334)
<https://reviews.apache.org/r/40632/#comment172747>
In this check, it seems allocator send offer when both !allocation &
allocation are eno
rces that can be ALLOCATION_SLACK
to other framework.
- Klaus Ma
On Dec. 30, 2015, 3:02 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
> On Dec. 30, 2015, 8:46 p.m., Klaus Ma wrote:
> > src/common/resources.cpp, line 854
> > <https://reviews.apache.org/r/41772/diff/1/?file=1177401#file1177401line854>
> >
> > I'd suggest to only return `stateless.reserved` resources; allocator
check is on-going)
Thanks,
Klaus Ma
/
Testing
---
Thanks,
Klaus Ma
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41850/diff/
Testing
---
Thanks,
Klaus Ma
e.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
/41856/diff/
Testing
---
Thanks,
Klaus Ma
---
Thanks,
Klaus Ma
/
Testing
---
Thanks,
Klaus Ma
g/r/41857/#comment172909>
It should use idle (total - pending - occupied) to check
- Klaus Ma
On Jan. 3, 2016, 10:23 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41858/diff/
Testing
---
Thanks,
Klaus Ma
/diff/
Testing
---
Thanks,
Klaus Ma
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41850/diff/
Testing
---
Thanks,
Klaus Ma
d not send evicting unreserved resources (allocationSlack -
stateless.reserved)
4. In Allocator::recoverResources, if total allocation slack is smaller than
stateless.reserved, shrink total allocation slack.
- Klaus Ma
On Jan. 3, 2016, 5:22 p.m., Guangya
/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41856/diff/
Testing
---
Thanks,
Klaus Ma
from
pendingExecutor list.
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
launching, it's removed from
pendingExecutor list.
Diffs
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
not, why should
we add that? I'd suggest to add this on demand.
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
tps://reviews.apache.org/r/41334/#comment173563>
Add comments on `role`.
- Klaus Ma
On Jan. 2, 2016, 9:14 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
g/r/41333/#comment173564>
This's not necessary; the default value of `RevocableInfo::type` is
`USAGE_SLACK`, so return `type() == USAGE_SLACK` is OK.
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
>
> ---
less`.
include/mesos/v1/resources.hpp (line 243)
<https://reviews.apache.org/r/40529/#comment173562>
ditto
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated
/41850/diff/
Testing
---
Thanks,
Klaus Ma
utors
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
---
Thanks,
Klaus Ma
utors
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
---
Thanks,
Klaus Ma
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
---
Thanks,
Klaus Ma
,
Klaus Ma
/diff/
Testing
---
Thanks,
Klaus Ma
from
pendingExecutor list.
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/41856/diff/
Testing
---
Thanks,
Klaus Ma
90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
---
Thanks,
Klaus Ma
301 - 400 of 661 matches
Mail list logo
