2dd306497ba01e0f387c3862456cdcac6f863
Diff: https://reviews.apache.org/r/42289/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
test in Mac OS,
I'll re-check it in Ubuntu for `./bin/mesos-tests.sh`; it seems perf did not
support no-Linux system.
- Klaus
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42289/
ke
make check
./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose
--gtest_repeat=100 --gtest_shuffle
Thanks,
Klaus Ma
/bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose
--gtest_repeat=100 --gtest_shuffle
Thanks,
Klaus Ma
eviews.apache.org/r/42289/#review115143
---
On Jan. 19, 2016, 8:03 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To re
irst one of Quota is considered to be high priority?
- Klaus Ma
On Jan. 19, 2016, 8:38 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
ke check
Mac & Ubuntu: ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*"
--verbose --gtest_repeat=100 --gtest_shuffle
Thanks,
Klaus Ma
t; error.get();`.
@Joseph, good suggestion. I'll move the common part into a function.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
--
ync up to merge them.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review115294
---
On Jan. 7, 2016, 8:04 p.m., Klaus Ma wrote:
>
> ---
e case that `allocationSlack` is empty;
this case is also true when flag is enable by no `statless.reserved` resources.
Update test on `allocationSlack` in `totalResource`.
- Klaus Ma
On Jan. 13, 2016, 10:37 p.m., Guangya Liu wrote:
>
> ---
tically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41772/
> ---
>
> (Updated Jan. 20, 2016, 11:40 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van
> Remoortere, Joseph Wu, and Klaus Ma.
&g
--
>
> (Updated Jan. 20, 2016, 11:40 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van
> Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4267
> https://issues.apac
tps://reviews.apache.org/r/42535/#comment176352>
Suggest to add some tests for this case.
- Klaus Ma
On Jan. 20, 2016, 10:09 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
k that we cannot rename it to `flatten` as the compiler will not
> know what does `flatten()` mean.
>
> Klaus Ma wrote:
> Regarding from `RevocableInfo::Type` to `RevocableInfo`, do you mean
> change `RevocableInfo` from `message` to `enum`? I think it's better to
>
/41856/diff/
Testing
---
Thanks,
Klaus Ma
> On Jan. 20, 2016, 3:11 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1048
> > <https://reviews.apache.org/r/42535/diff/1/?file=1202461#file1202461line1048>
> >
> > Suggest to add some tests for this case.
>
> Alexander
> On Jan. 20, 2016, 8:25 a.m., Joseph Wu wrote:
> > Can you talk to Guangya and merge this patch with
> > https://reviews.apache.org/r/42123/ ? Logically, they're touching the same
> > things.
>
> Klaus Ma wrote:
> Sure, we'll sync up to merge
tps://reviews.apache.org/r/42559/#comment176433>
Who will kill this `revocable` resources? So we'll have a patch for
evicting?
- Klaus Ma
On Jan. 21, 2016, 1:01 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an aut
> On Jan. 21, 2016, 1:20 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1313
> > <https://reviews.apache.org/r/42559/diff/1/?file=1203488#file1203488line1313>
> >
> > Who will kill this `revocable` resources? So we&
> On Jan. 21, 2016, 1:20 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1313
> > <https://reviews.apache.org/r/42559/diff/1/?file=1203488#file1203488line1313>
> >
> > Who will kill this `revocable` resources? So we&
="HierarchicalAllocatorTest.RecoverWithQuota"
Thanks,
Klaus Ma
> On Jan. 20, 2016, 3:11 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1048
> > <https://reviews.apache.org/r/42535/diff/1/?file=1202461#file1202461line1048>
> >
> > Suggest to add some tests for this case.
>
> Alexander
://reviews.apache.org/r/42589/diff/
Testing (updated)
---
make
make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK()
failed without fix)
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115825
---
Ship it!
Ship It!
- Klaus Ma
On Jan. 22, 2016, 2:11 a.m
/browse/MESOS-4442
Repository: mesos
Description
---
Added test case for MESOS-4442.
Diffs
-
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
Diff: https://reviews.apache.org/r/42678/diff/
Testing
---
Thanks,
Klaus Ma
6f43103e81303015fb614653e3bfece55009d1bf
Diff: https://reviews.apache.org/r/42678/diff/
Testing (updated)
---
make check GTEST_FILTER="OversubscriptionTest.OverOffered"
Thanks,
Klaus Ma
tps://reviews.apache.org/r/42476/#comment177018>
Do we need to check `has_role()`?
- Klaus Ma
On Jan. 22, 2016, 11:43 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
k that we cannot rename it to `flatten` as the compiler will not
> know what does `flatten()` mean.
>
> Klaus Ma wrote:
> Regarding from `RevocableInfo::Type` to `RevocableInfo`, do you mean
> change `RevocableInfo` from `message` to `enum`? I think it's better to
>
ecutor. In
this patch, I'd like to focus on moving the executor info into master.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
-----
k that we cannot rename it to `flatten` as the compiler will not
> know what does `flatten()` mean.
>
> Klaus Ma wrote:
> Regarding from `RevocableInfo::Type` to `RevocableInfo`, do you mean
> change `RevocableInfo` from `message` to `enum`? I think it's better to
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116333
---
Ship it!
Ship It!
- Klaus Ma
On Jan. 26, 2016, 4:12 p.m
> On Jan. 26, 2016, 3:05 p.m., Klaus Ma wrote:
> > I agree to include `reserved` reosurces in DRF; but just one question, why
> > are we going to have this patch now?
>
> Qian Zhang wrote:
> My understanding is, we are going to include reserved resources in the
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42876/#review116661
---
Ship it!
Ship It!
- Klaus Ma
On Jan. 28, 2016, 6:50 a.m
/#comment177757>
Add a case for `tar/untar` failure.
- Klaus Ma
On Jan. 28, 2016, 4:29 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42877/#review116670
---
Ship it!
Ship It!
- Klaus Ma
On Jan. 28, 2016, 6:56 a.m
allocator recover
with Quota?
- Klaus Ma
On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
nd the offer maybe wrong in about cases.
- Klaus Ma
On Jan. 23, 2016, 11:18 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tabs with spaces in configure.ac.
Diffs
-
configure.ac cb39c7f
Diff: https://reviews.apache.org/r/42946/diff/
Testing
---
Thanks,
Klaus Ma
/diff/
Testing (updated)
---
../configure
make
Thanks,
Klaus Ma
tps://reviews.apache.org/r/42936/#comment177994>
Move "By" to the next line.
- Klaus Ma
On Jan. 29, 2016, 12:30 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
configure.ac.
Diffs
-
configure.ac cb39c7f
Diff: https://reviews.apache.org/r/42946/diff/
Testing
---
../configure
make
Thanks,
Klaus Ma
apache.org/r/42908/#comment178000>
```
driver.stop();
driver.join();
```
- Klaus Ma
On Jan. 28, 2016, 8:20 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail.
> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 957
> > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957>
> >
> > Just check the code on `setQuota-->rescindOffer`, why not let allocat
> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 957
> > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957>
> >
> > Just check the code on `setQuota-->rescindOffer`, why not let allocat
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review117796
-------
On Jan. 7, 2016, 11:43 a.m., Klaus Ma wrote:
>
> ---
> This is an autom
tps://reviews.apache.org/r/43149/#comment179067>
Check negative and zero value.
3rdparty/libprocess/src/process.cpp (line 2205)
<https://reviews.apache.org/r/43149/#comment179068>
Add test for this patch.
- Klaus Ma
On Feb. 4, 2016, 8:40 a.m., James
tps://reviews.apache.org/r/43144/#comment179070>
blank line before.
3rdparty/libprocess/src/process.cpp (line 2211)
<https://reviews.apache.org/r/43144/#comment179069>
Just `os::getenv("LIB...")` is OK.
- Klaus Ma
On Feb. 4, 2016, 4:57 a.m
> On Feb. 4, 2016, 9:38 p.m., Klaus Ma wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2211
> > <https://reviews.apache.org/r/43144/diff/1/?file=1231709#file1231709line2211>
> >
> > Just `os::getenv("LIB...")` is OK.
>
> Maged Mich
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/#review118142
---
ping @Joris, any comments on this?
- Klaus Ma
On Jan. 29, 2016
t;
```
driver.stop()
driver.join()
```
- Klaus Ma
On Feb. 6, 2016, 6:46 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43159/#review118166
---
Ship it!
Ship It!
- Klaus Ma
On Feb. 4, 2016, 7:11 a.m
> On Feb. 7, 2016, 11:29 a.m., Klaus Ma wrote:
> > Ship It!
Add test case for duplicated keys in our output: did not prase json, just
`std::count` should be OK.
- Klaus
---
This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review118237
---
Ship it!
Ship It!
- Klaus Ma
On Feb. 8, 2016, 11:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118332
---
Ship it!
Ship It!
- Klaus Ma
On Feb. 7, 2016, 4:18 p.m
On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42589/
> --
g/r/42516/#comment180148>
Also check whether `network_name()` is empty string `""`.
please add unit test cases for this patches; refer to `bridge` test cases.
- Klaus Ma
On Feb. 10, 2016, 4:34 p.m., Ezra Silvera wrote:
>
> ---
> On Feb. 11, 2016, 5:34 p.m., Klaus Ma wrote:
> > src/docker/docker.cpp, line 529
> > <https://reviews.apache.org/r/42516/diff/9/?file=1239370#file1239370line529>
> >
> > Also check whether `network_name()` is empty string `""`.
>
> Ezra Sil
--
On Jan. 19, 2016, 10:55 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41305/
>
old slave did not report `slaveInfo`, right?
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
-------
On Feb. 12, 2016, 11:02 p.m., Klaus Ma wrote:
>
> --
Diff: https://reviews.apache.org/r/42589/diff/
Testing
---
make
make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK()
failed without fix)
Thanks,
Klaus Ma
://reviews.apache.org/r/43561/diff/
Testing
---
make
make check GTEST_FILTER="ResourcesTest.*"
Thanks,
Klaus Ma
/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff
src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354
Diff: https://reviews.apache.org/r/43561/diff/
Testing (updated)
---
make
make check GTEST_FILTER=~"*"
./src/mesos-test
Thanks,
Klaus Ma
---
Add indent to comments in protobuf_tests.cpp.
Diffs
-
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82
Diff: https://reviews.apache.org/r/43580/diff/
Testing
---
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43587/#review119254
---
Ship it!
Ship It!
- Klaus Ma
On Feb. 16, 2016, 5:19 a.m
or_tests.cpp (line 2513)
<https://reviews.apache.org/r/43588/#comment180566>
ditto
- Klaus Ma
On Feb. 16, 2016, 5:23 a.m., Joerg Schad wrote:
>
> ---
> This i
> On Feb. 16, 2016, 11:28 a.m., Klaus Ma wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2400
> > <https://reviews.apache.org/r/43588/diff/1/?file=1241757#file1241757line2400>
> >
> > Move to HierarchicalAllocatorTest.
>
> Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41950/#review119268
---
Ship it!
Ship It!
- Klaus Ma
On Jan. 28, 2016, 9:12 p.m
180599>
ditto
src/tests/oversubscription_tests.cpp (line 588)
<https://reviews.apache.org/r/43041/#comment180595>
`EXPECT_EQ(offer1.slaveID(), offer2.slaveID())`
- Klaus Ma
On Feb. 16, 2016, 4:52 p.m., Yongqiao Wang wrote:
>
> ---
&
org/r/43488/#comment180619>
Do you mean framework can filter `killing` state? I thinke this's not
necessary.
- Klaus Ma
On Feb. 16, 2016, 4:25 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically genera
> On Feb. 16, 2016, 6:24 p.m., Klaus Ma wrote:
> > include/mesos/mesos.proto, line 261
> > <https://reviews.apache.org/r/43488/diff/2/?file=1241816#file1241816line261>
> >
> > Do you mean framework can filter `killing` state? I thinke this's not
>
dc12bd8f1e2da6972bc8aed598811c55d664036e
Diff: https://reviews.apache.org/r/49381/diff/
Testing
---
Thanks,
Klaus Ma
for Resources class (cpu, mem & port)
Diffs (updated)
-
src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e
Diff: https://reviews.apache.org/r/49381/diff/
Testing
---
Thanks,
Klaus Ma
)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4
Took 1405us to `mem()` "[1-2, 3-4, ... , 199-200]" 1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (2 ms)
[--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (44301
ms total)
Thanks,
Klaus Ma
1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (129 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4
Took 1405us to `mem()` "[1-2, 3-4, ... , 199-200]" 1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (2 ms)
[--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (44301
ms total)
Thanks,
Klaus Ma
uot;cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100"
1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4
Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms)
[--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070
ms total)
Thanks,
Klaus Ma
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review141756
-------
On April 19, 2016, 3:31 p.m., Klaus Ma wrote:
>
> ---
> This
84dbb2db41bd9849ab1245969884675d9d16555b
Diff: https://reviews.apache.org/r/46298/diff/
Testing
---
1. make && make check
2. e2e test:
```
$ ./src/mesos-slave --work_dir=aa --master=aa
The required option `--work_dir` must be absolute path.
```
Thanks,
Klaus Ma
ptional validate lambda to be passed in.
>
> Klaus Ma wrote:
> @jie, thanks for the comments. Try to use validated lamba today, but
> there some issues:
>
> 1. The `work_dir` is required without default value; if using validate
> lamba, a "default" value is
perator_MEM/3
Took 134330us to `mem()` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100"
1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4
Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms)
[--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070
ms total)
Thanks,
Klaus Ma
0; ... cpus(r99):1;mem(r99):100"
1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4
Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 1 times.
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms)
[--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070
ms total)
Thanks,
Klaus Ma
ptional validate lambda to be passed in.
>
> Klaus Ma wrote:
> @jie, thanks for the comments. Try to use validated lamba today, but
> there some issues:
>
> 1. The `work_dir` is required without default value; if using validate
> lamba, a "default" value is
tps://reviews.apache.org/r/50044/#comment207883>
This's not necessary, `sorter/sorter.hpp` had included it.
- Klaus Ma
On July 15, 2016, 3:35 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50044/#review142309
---
Ship it!
Ship It!
- Klaus Ma
On July 15, 2016, 3:35 a.m
> On July 15, 2016, 7:49 a.m., Klaus Ma wrote:
> > src/master/allocator/sorter/drf/sorter.hpp, line 22
> > <https://reviews.apache.org/r/50044/diff/1/?file=1444158#file1444158line22>
> >
> > This's not necessary, `sorter/sorter.hpp` had included it.
>
.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8
src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba
src/v1/values.cpp 3e0f739b69e680f9eb29ed36d4501c393758c861
Diff: https://reviews.apache.org/r/49223/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
://reviews.apache.org/r/46298/diff/
Testing
---
1. make && make check
2. e2e test:
```
$ ./src/mesos-slave --work_dir=aa --master=aa
The required option `--work_dir` must be absolute path.
```
Thanks,
Klaus Ma
ptional validate lambda to be passed in.
>
> Klaus Ma wrote:
> @jie, thanks for the comments. Try to use validated lamba today, but
> there some issues:
>
> 1. The `work_dir` is required without default value; if using validate
> lamba, a "default" value is
think we can check name,type, role firstly, then check SharedInfo.
src/common/resources.cpp (line 882)
<https://reviews.apache.org/r/45959/#comment208557>
one `isShared()` is enough. `isShared` is checked in `subtractable`.
- Klaus Ma
On July
Thanks,
Klaus Ma
---
Replaced boost::lexical_cast with numify when paring Value.
Diffs
-
src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8
Diff: https://reviews.apache.org/r/50285/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
Diff: https://reviews.apache.org/r/50285/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
---
Returned empty vector if string is empty.
Diffs
-
3rdparty/stout/include/stout/strings.hpp
7f7f1cffcebfe16cb986917b1d90c1ae4a480989
Diff: https://reviews.apache.org/r/50290/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
7f7f1cffcebfe16cb986917b1d90c1ae4a480989
Diff: https://reviews.apache.org/r/50290/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
empty vector if string is empty.
Diffs
-
Diff: https://reviews.apache.org/r/50295/diff/
Testing
---
Thanks,
Klaus Ma
values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e
Diff: https://reviews.apache.org/r/49223/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
so, why did you keep tokenizing on newlines? AFAICT they are not part
> > of the canonical format?
Replaced tokenize with split, also add related test cases.
- Klaus
---
This is an automatically generated
t
Thanks,
Klaus Ma
2f12e
Diff: https://reviews.apache.org/r/49223/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
---
make && make check
Thanks,
Klaus Ma
alues.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e
Diff: https://reviews.apache.org/r/49223/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
501 - 600 of 661 matches
Mail list logo
