Re: Review Request 34137: Add support for container image provisioners.

On July 8, 2015, 11:34 p.m., Vinod Kone wrote: can you please set the dependency for this review correctly? it's hard to understand which reviews introduced the code that this review depends on. none of the dropped issues have comments. did you forget to hit publish on your comments

Re: Review Request 34137: Add support for container image provisioners.

/provisioner.cpp (lines 41 - 44) https://reviews.apache.org/r/34137/#comment145206 Why do you need foreach loop here if you were going to return error anyway? - Vinod Kone On July 12, 2015, 4:47 a.m., Ian Downes wrote

Re: Review Request 36510: Update .gitignore with intermediate build artifacts.

? - Vinod Kone On July 15, 2015, 4:11 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36510/ --- (Updated

Re: Review Request 35752: Implemented the ERROR Event handler in the scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35752/#review91798 --- Ship it! Ship It! - Vinod Kone On July 15, 2015, 1:47 a.m., Ben

Re: Review Request 36450: Introduced Address and URL protobufs.

/36450/#comment145445 s/ip/IP/ src/common/type_utils.cpp (line 131) https://reviews.apache.org/r/36450/#comment145447 Is the order of query parameters important? Aren't these URLs equivalent? http://a.b.c/?k1=ak2=b http://a.b.c/?k2=bk1=a - Vinod Kone On July 15

Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

/36494/#comment145458 instead of calling into frameworkMessage() here can you have frameworkMessage() call into a new message(const Event event) method? this is how we did it in the master and i think it will make deprecating old message handlers easy. - Vinod Kone On July 15

Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

://reviews.apache.org/r/36494/#comment145658 Can you add a comment here saying that you are simulating master sending the event? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e

Re: Review Request 36495: Implemented the RESCIND Event handler in the scheduler driver.

://reviews.apache.org/r/36495/#comment145661 Add a TODO here to refactor. src/tests/scheduler_event_call_tests.cpp (line 85) https://reviews.apache.org/r/36495/#comment145659 ditto. comment. - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote

Re: Review Request 36498: Implemented the OFFERS Event handler in the scheduler driver.

/scheduler_event_call_tests.cpp (line 237) https://reviews.apache.org/r/36498/#comment145695 Why capture the executor driver when it's not used? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically

Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities

://reviews.apache.org/r/35797/#comment145736 s/famework_/framework/ new line after this. src/tests/fault_tolerance_tests.cpp (line 1831) https://reviews.apache.org/r/35797/#comment145737 Nice test! - Vinod Kone On July 16, 2015, 6:46 p.m., Aditi Dixit wrote

Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

On July 16, 2015, 6:20 p.m., Vinod Kone wrote: src/tests/scheduler_event_call_tests.cpp, line 91 https://reviews.apache.org/r/36494/diff/1/?file=1011987#file1011987line91 Can you add a comment here saying that you are simulating master sending the event? Ben Mahler wrote

Re: Review Request 36496: Implemented the FAILURE Event handler in the scheduler driver.

/#comment145663 TODO for refactor. src/tests/scheduler_event_call_tests.cpp (line 170) https://reviews.apache.org/r/36496/#comment145664 comment. - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote

Re: Review Request 36499: Implemented the UPDATE Event handler in the scheduler driver.

for driver.stop() and driver.join()? Shutdown()? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36499

Re: Review Request 36497: Implemented the SUBSCRIBE Event handler in the scheduler driver.

/#comment145679 comment. src/tests/scheduler_event_call_tests.cpp (line 145) https://reviews.apache.org/r/36497/#comment145678 ditto. split this into its own test. src/tests/scheduler_event_call_tests.cpp (line 158) https://reviews.apache.org/r/36497/#comment145680 comment. - Vinod Kone

Re: Review Request 36463: Updated scheduler driver to send Kill Call.

--- On July 13, 2015, 11:58 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36463/ --- (Updated July

Re: Review Request 36463: Updated scheduler driver to send Kill Call.

1070ccf17f98f6b3800684a5edd6517d90631c3e src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc Diff: https://reviews.apache.org/r/36463/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 36464: Updated scheduler driver to send ACCEPT call.

767c86cbde31eeb49d110d04bfb5a3eb5d469afc Diff: https://reviews.apache.org/r/36464/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 36467: Updated scheduler driver to send ACKNOWLEDGE call.

89cc7f68b33b037626ca6056647c360b5a6d5901 src/tests/status_update_manager_tests.cpp 440b07475e28dc491ab640acaca8ee20db8411f8 Diff: https://reviews.apache.org/r/36467/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 36469: Updated scheduler driver to send MESSAGE call.

1070ccf17f98f6b3800684a5edd6517d90631c3e src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88 Diff: https://reviews.apache.org/r/36469/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 36469: Updated scheduler driver to send MESSAGE call.

14, 2015, 12:30 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36469/ --- (Updated July 14, 2015, 12:30 a.m

Re: Review Request 36470: Updated scheduler driver to send TEARDOWN call.

49d907b0be45ccfed8af5c8fda89ad560e012c1e src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88 Diff: https://reviews.apache.org/r/36470/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

--- On July 13, 2015, 11:55 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36461

Re: Review Request 36462: Added FUTURE_CALL, DROP_CALL, DROP_CALLS and EXPECT_NO_FUTURE_CALLS.

9157ac079808d2686592e54ea26a26e6a0825ed3 Diff: https://reviews.apache.org/r/36462/diff/ Testing --- Tested in subsequent reviews. Thanks, Vinod Kone

Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

/process/gmock.hpp e8781610f636954b39611fcb1de310a78ceea7cb Diff: https://reviews.apache.org/r/36461/diff/ Testing --- Tested in subsequent reviews. Thanks, Vinod Kone

Re: Review Request 36464: Updated scheduler driver to send ACCEPT call.

with you? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36464/#review91764 --- On July 13, 2015, 11:59 p.m., Vinod Kone wrote

Re: Review Request 36465: Updated scheduler driver to send REVIVE call.

. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36465/#review91765 --- On July 14, 2015, midnight, Vinod Kone wrote

Re: Review Request 36450: Introduced Address and URL protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review92118 --- Ship it! Ship It! - Vinod Kone On July 17, 2015, 1:36 a.m., Ben

Re: Review Request 36498: Implemented the OFFERS Event handler in the scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/#review92119 --- Ship it! Ship It! - Vinod Kone On July 17, 2015, 1:36 a.m., Ben

Re: Review Request 36562: Store MasterInfo instead of UPID in the scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36562/#review92115 --- Ship it! Ship It! - Vinod Kone On July 17, 2015, 1:36 a.m., Ben

Re: Review Request 36497: Implemented the SUBSCRIBE Event handler in the scheduler driver.

://reviews.apache.org/r/36497/#comment146054 there is no master UPID anymore. update the comment? src/sched/sched.cpp (line 465) https://reviews.apache.org/r/36497/#comment146055 s/required/relied/ ? - Vinod Kone On July 17, 2015, 1:36 a.m., Ben Mahler wrote

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

1e934c4b168a0afabd5065e2c8ffa131362ed29b src/tests/rate_limiting_tests.cpp 6a93df086bc0f256c7750d06f950d61f2dfb7b5c src/tests/slave_recovery_tests.cpp de2fc280abae98a5fbbeae6e230a1bfdaf0fc86e Diff: https://reviews.apache.org/r/36586/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

6a93df086bc0f256c7750d06f950d61f2dfb7b5c src/tests/slave_recovery_tests.cpp de2fc280abae98a5fbbeae6e230a1bfdaf0fc86e Diff: https://reviews.apache.org/r/36586/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 35687: Added capabilities to state.json

. - Vinod Kone On July 12, 2015, 6:25 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated

Review Request 36464: Updated scheduler driver to send ACCEPT call.

--- make check Thanks, Vinod Kone

Review Request 36469: Updated scheduler driver to send MESSAGE call.

/ Testing --- make check Thanks, Vinod Kone

Review Request 36470: Updated scheduler driver to send TEARDOWN call.

/ Testing --- make check Thanks, Vinod Kone

Review Request 36465: Updated scheduler driver to send REVIVE call.

the revive workflow, but it didn't need any update) Thanks, Vinod Kone

Review Request 36463: Updated scheduler driver to send Kill Call.

57721b788d0c70f4c6f5cc44d87465f52a70b6c2 Diff: https://reviews.apache.org/r/36463/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 36467: Updated scheduler driver to send ACKNOWLEDGE call.

440b07475e28dc491ab640acaca8ee20db8411f8 Diff: https://reviews.apache.org/r/36467/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 36466: Updated scheduler driver to send RECONCILE call.

/ Testing --- make check Thanks, Vinod Kone

Review Request 36462: Added FUTURE_CALL, DROP_CALL, DROP_CALLS and EXPECT_NO_FUTURE_CALLS.

/ Testing --- Tested in subsequent reviews. Thanks, Vinod Kone

Re: Review Request 34881: let libprocess to compile on arm64 servers

On June 22, 2015, 3:48 a.m., Cody Maloney wrote: 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch, line 18 https://reviews.apache.org/r/34881/diff/1/?file=975553#file975553line18 Where did this header come from? If we were to just update protobuf to a newer version would it just

Re: Review Request 37501: Add support for removing capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/#review96232 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2015, 4:35 p.m

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

/FrameworkWebUIUrlCapabilitiesAndUser/FrameworkState/ - Vinod Kone On Aug. 15, 2015, 8:03 a.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500

Re: Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103810 --- Ship it! Ship It! - Vinod Kone On Oct. 23, 2015, 9:05 a.m

Re: Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

tps://reviews.apache.org/r/39516/#comment161515> i'll remove this comment when committing. - Vinod Kone On Oct. 21, 2015, 1:19 p.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39421: Add agent version to /master/slaves endpoint

tps://reviews.apache.org/r/39421/#comment161724> if (slave.version.isSome()) { object.values["version" = slave.version.get(); } - Vinod Kone On Oct. 18, 2015, 1:29 p.m., Guangya Liu wrote: > > --- > This is an autom

Re: Review Request 39548: SchedulerTest.Suppress is flaky

rocess::suppressOffers() and do a clock::settle() on that future before you advance the clock. Does that make sense? - Vinod Kone On Oct. 22, 2015, 9:12 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

summary] elif len (review.depends) == 1: return review_list(review.depends.id) + [review_id, review.summary] else: error() ``` - Vinod Kone On Oct. 20, 2015, 7:28 a.m., Artem Harutyunyan wrote: > > --- > This

Re: Review Request 39432: Add /master/frameworks to master endpoint

g/r/39432/#comment161726> Can you add a test for this in master_tests similar to what we did for /slaves endpoint? - Vinod Kone On Oct. 19, 2015, 6:31 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

-- > > (Updated Oct. 25, 2015, 2:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

(line 57) <https://reviews.apache.org/r/38705/#comment162328> log the id of the violating review? - Vinod Kone On Oct. 23, 2015, 6:16 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 38844: Added unit tests for Call validation in Agent

2380> s/valid// src/tests/executor_http_api_tests.cpp (line 693) <https://reviews.apache.org/r/38844/#comment162381> ditto. just call it 'response' - Vinod Kone On Oct. 27, 2015, 12:37 a.m., Isabel Jimenez wrote: > > --- > This is

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

> On Oct. 22, 2015, 9:20 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 25 > > <https://reviews.apache.org/r/38705/diff/8-9/?file=1100640#file1100640line25> > > > > s/extract_// > > Artem Harutyunyan wrote: > Marco commented

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

it can amend or not. i would've imagined the caller to do that. support/apply-reviews.py (line 173) <https://reviews.apache.org/r/38883/#comment162337> typically "-n" is used as a short argument for dry run. but i see why couldn't use i

Re: Review Request 38577: Added synchronous validation for Call in Agent

2) <https://reviews.apache.org/r/38577/#comment162373> kill this? src/tests/executor_http_api_tests.cpp (line 504) <https://reviews.apache.org/r/38577/#comment162374> make sure this pattern is consistent everywhere else in this file. - Vinod Kone On Oct.

Re: Review Request 39754: Set the UUID of the expected ACK.

is a bit involved and i would like to cleanup some tech debt in the process. If you are ok with that, please discard this review. - Vinod Kone On Oct. 29, 2015, 12:25 p.m., Yong Qiao Wang wrote: > > --- > This is an auto

Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a Diff: https://reviews.apache.org/r/39791/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 39792: Updated master and slave to properly set task status uuid.

9f4586e668a2141f4937497d42853fbdea7751a5 src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 Diff: https://reviews.apache.org/r/39792/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 39410: Added support for github to apply-reviews.py.

/#comment162482> indentation? support/apply-reviews.py (line 268) <https://reviews.apache.org/r/39410/#comment162349> s/mututally/mutually/ ? - Vinod Kone On Oct. 23, 2015, 11:13 p.m., Artem Harutyunyan wrote: > > --

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75> > > > > also print status.source() > > Isabel Jimenez wrote: > We don't have

Review Request 39707: Minor code refactor for fetcher.cpp.

Thanks, Vinod Kone

Re: Review Request 39709: Added logic to ensure the during a HTTP to PID scheduler downgrade, the previous HTTP instance gets an error message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39709/#review104335 --- Ship it! Ship It! - Vinod Kone On Oct. 28, 2015, 4:54 a.m

Re: Review Request 39708: Removed redundant code for conversion from PID to HTTP based frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39708/#review104332 --- Ship it! Ship It! - Vinod Kone On Oct. 28, 2015, 4:51 a.m

Re: Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers

, maybe lets not mention it? src/tests/scheduler_http_api_tests.cpp (line 579) <https://reviews.apache.org/r/39710/#comment162588> s/the/PID based/ - Vinod Kone On Oct. 28, 2015, 4:54 a.m., Anand Mazumdar wrote: > > --- &g

Re: Review Request 39285: Added Quota Request Validation.

joerg, can you please make sure these reviews have linear dependencies? i'm seeing some reviews that block multiple reviews!? are you not using the post-reviews script? On Tue, Nov 10, 2015 at 10:20 AM, Joerg Schad wrote: > >

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

g/r/40129/#comment164642> do we even need this script anymore? is this for backwards compatiblity with existing tooling? is that plan to kill this eventually? worth adding some comments/TODO/JIRA for this. - Vinod Kone On Nov. 10, 2015, 8:02 a.m., Artem Harutyunyan

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

tps://reviews.apache.org/r/39420/#comment164641> not always right? want to update this comment? support/apply-reviews.py (line 321) <https://reviews.apache.org/r/39420/#comment164640> pull this comment inside? - Vinod Kone On Nov. 10, 2015, 8:03 a.m., Artem Harut

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

> On Nov. 10, 2015, 8:23 p.m., Vinod Kone wrote: > > support/apply-review.sh, line 5 > > <https://reviews.apache.org/r/40129/diff/1/?file=1121350#file1121350line5> > > > > do we even need this script anymore? is this for backwards compatiblity > > with

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this?

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

and the other updating apply-review.sh to use apply-reviews.py? - Vinod Kone On Nov. 9, 2015, 3:31 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39410: Added support for github to apply-reviews.py.

/#comment164378> indentation. support/apply-reviews.py (line 275) <https://reviews.apache.org/r/39410/#comment164377> why the temp variable? - Vinod Kone On Nov. 9, 2015, 3:32 p.m., Artem Harutyunyan wrote: > > -

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/#review106305 --- Ship it! Ship It! - Vinod Kone On Nov. 12, 2015, 7:12 p.m

Re: Review Request 40241: Fixed a bug with hanging editor reported by Ben Mahler.

g/r/40241/#comment165163> i don't think CalledProcessError is raised for subprocess.call? don't you want to print the output in case of error? also, what exactly was the bug? can you add that to the description of this review? - Vinod Kone On Nov. 12, 2015, 6:10 p.m.,

Re: Review Request 40251: Style fixes for Java and Python protobuf generation rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40251/#review106482 --- Ship it! Ship It! - Vinod Kone On Nov. 12, 2015, 8:18 p.m

Re: Review Request 40252: Consistency fixes on style in src/Makefile.am

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40252/#review106483 --- Ship it! Ship It! - Vinod Kone On Nov. 13, 2015, 1:09 a.m

Re: Review Request 40250: Consolidated all the CXX protobuf generation rules in src/Makefile.am.

org/r/40250/#comment165194> why the distinction between public and private? looks like they are always used together. src/Makefile.am (lines 232 - 250) <https://reviews.apache.org/r/40250/#comment165193> kill the white space while you are at it? - Vinod Kone On Nov. 12, 20

Re: Review Request 40253: Added URI protobuf definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/#review106761 --- Ship it! Ship It! - Vinod Kone On Nov. 16, 2015, 8:09 p.m

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

g/r/40225/#comment165031> s/ui_// What's a UI URL? - Vinod Kone On Nov. 12, 2015, 5:56 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

org/r/39914/#comment164822> there is no --enable-libev option. i will change this to --verbose when committing. - Vinod Kone On Nov. 11, 2015, 12:14 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review106125 --- Ship it! - Vinod Kone On Nov. 11, 2015, 12:14 a.m., Jojy

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/#review106139 --- can you rebase? - Vinod Kone On Nov. 7, 2015, 7:08 p.m

Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

tps://reviews.apache.org/r/40214/#comment165023> just curious why we had LOG_PROTOS and STATE_PROTOS pointing to the C files instead of LOG_PROTO and STATE_PROTO pointing to the proto files? - Vinod Kone On Nov. 12, 2015, 1:31 a.m., Jie Yu

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

tedExecutors(MAX_COMPLETED_EXECUTORS_PER_FRAMEWORK) {} ``` src/slave/slave.cpp (line 4934) <https://reviews.apache.org/r/40177/#comment164839> This should be the responsibility of the caller, i.e., the caller should call this only when checkpointing is enabled. - Vinod Kone O

Re: Review Request 40162: Updated docker build script to install libev package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40162/#review106128 --- Ship it! Ship It! - Vinod Kone On Nov. 10, 2015, 11:47 p.m

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

> On Nov. 12, 2015, 6 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 23 > > <https://reviews.apache.org/r/40225/diff/2/?file=1124332#file1124332line23> > > > > s/ui_// > > > > What's a UI URL? > > Artem Harutyunya

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

org/r/40375/#comment165704> I don't think adding a required field to a protobuf that is sent across the wire is backwards compatible. This should be optional with default as USAGE_SLACK. - Vinod Kone On Nov. 17, 2015, 3:30 a.m., Klaus Ma

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

> On Nov. 17, 2015, 6:11 p.m., Vinod Kone wrote: > > Also needs updating of resources.cpp - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#rev

Re: Review Request 39862: Add documentation for newer metrics

line 900) <https://reviews.apache.org/r/39862/#comment162992> s/4891/5051/ - Vinod Kone On Nov. 2, 2015, 4:23 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

not immediately obvious to me why we set the status uuid from the > > update uuid, should we spell that out here? expanded the comment. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

://reviews.apache.org/r/39792/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

(updated) - src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a Diff: https://reviews.apache.org/r/39791/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 39827: Made slave version required in master.cpp.

/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 Diff: https://reviews.apache.org/r/39827/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

check Ran the "RecoverCompletedExecutor" test 100 times as it was failing most of the time without this fix. Thanks, Vinod Kone

Re: Review Request 39953: Renamed jenkins_build.sh to docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39953/#review105133 --- Ship it! Ship It! - Vinod Kone On Nov. 4, 2015, 8:43 p.m

Re: Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/#review105135 --- the diff is empty? - Vinod Kone On Nov. 4, 2015, 8:44 p.m

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

org/r/39914/#comment163531> have you verified this change locally? the docker_build.sh script expects certain environment variables to be set. - Vinod Kone On Nov. 4, 2015, 8:47 p.m., Jojy Varghese

Re: Review Request 39914: Added enable-ssl and enable-libevent to reviewbot builds

> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote: > > would this only test libevent and skip libev? if yes, we can't do this. > > Jojy Varghese wrote: > Would it help to add libev also? I was trying to make this look like the > jenkins mesos builds. Console logs there

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 16 > > <https://reviews.apache.org/r/39908/diff/2/?file=1114943#file1114943line16> > > > > this should also be mentioned in the CHANGELOG. > > Michael Park wrote: > Th

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

. Diffs (updated) - src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 Diff: https://reviews.apache.org/r/39873/diff/ Testing --- make check Ran the "RecoverCompletedExecutor" test 100 times as it was failing most of the time without this fix. Thanks, Vinod Kone

<    1   2   3   4   5   6   7   8   9   10   >