Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 422 (patched) > > <https://reviews.apache.org/r/68591/diff/6/?file=2089056#file2089056line422> > > > > Is this redundant? since we already checked > > `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance` > > Kapil Arya wrote: > This is tracking total tasks across all frameworks as opposed to total > tasks per framework. Fixed now. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208632 --- On Sept. 14, 2018, 3:22 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68591/ > --- > > (Updated Sept. 14, 2018, 3:22 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > This benchmark launches frameworks with different profiles (number of > tasks, task sizes and etc.) and prints out statistics such as total > tasks launched, cluster utilization and allocation latency. The test has > a timeout of 30 seconds > > > Diffs > - > > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68591/diff/8/ > > > Testing > --- > > ``` > [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations > Added 80 agents in 2.727787ms > Added 554 frameworks in 33.126141ms > Start allocation > Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation > round generated 80 offers and took 18.470138ms > Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation > round generated 79 offers and took 12.000794ms > Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation > round generated 78 offers and took 19.469854ms > Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation > round generated 77 offers and took 20.271342ms > Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation > round generated 76 offers and took 20.172579ms > Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation > round generated 75 offers and took 19.731885ms > Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation > round generated 74 offers and took 19.9954ms > Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation > round generated 73 offers and took 18.969235ms > Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation > round generated 72 offers and took 11.915086ms > Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation > round generated 71 offers and took 19.106293ms > ... > Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current > allocation round generated 0 offers and took 11.747351ms > Failed to launch all tasks: Timed out after 30secs > Resource statistics: > Cluster capacity: cpus:5120; mem:3904 > Cluster allocation: cpus:1147.6; mem:1864000 > Target allocation: cpus:2370; mem:1740 > [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms) > ``` > > > Thanks, > > Kapil Arya > >
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 14, 2018, 3:22 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This benchmark launches frameworks with different profiles (number of tasks, task sizes and etc.) and prints out statistics such as total tasks launched, cluster utilization and allocation latency. The test has a timeout of 30 seconds Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/8/ Changes: https://reviews.apache.org/r/68591/diff/7-8/ Testing --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 2.727787ms Added 554 frameworks in 33.126141ms Start allocation Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation round generated 80 offers and took 18.470138ms Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation round generated 79 offers and took 12.000794ms Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation round generated 78 offers and took 19.469854ms Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation round generated 77 offers and took 20.271342ms Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation round generated 76 offers and took 20.172579ms Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation round generated 75 offers and took 19.731885ms Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation round generated 74 offers and took 19.9954ms Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation round generated 73 offers and took 18.969235ms Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation round generated 72 offers and took 11.915086ms Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation round generated 71 offers and took 19.106293ms ... Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current allocation round generated 0 offers and took 11.747351ms Failed to launch all tasks: Timed out after 30secs Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1147.6; mem:1864000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms) ``` Thanks, Kapil Arya
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 422 (patched) > > <https://reviews.apache.org/r/68591/diff/6/?file=2089056#file2089056line422> > > > > Is this redundant? since we already checked > > `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance` This is tracking total tasks across all frameworks as opposed to total tasks per framework. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208632 --- On Sept. 14, 2018, 3:17 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68591/ > --- > > (Updated Sept. 14, 2018, 3:17 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > This benchmark launches frameworks with different profiles (number of > tasks, task sizes and etc.) and prints out statistics such as total > tasks launched, cluster utilization and allocation latency. The test has > a timeout of 30 seconds > > > Diffs > - > > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68591/diff/7/ > > > Testing > --- > > ``` > [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations > Added 80 agents in 2.727787ms > Added 554 frameworks in 33.126141ms > Start allocation > Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation > round generated 80 offers and took 18.470138ms > Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation > round generated 79 offers and took 12.000794ms > Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation > round generated 78 offers and took 19.469854ms > Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation > round generated 77 offers and took 20.271342ms > Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation > round generated 76 offers and took 20.172579ms > Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation > round generated 75 offers and took 19.731885ms > Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation > round generated 74 offers and took 19.9954ms > Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation > round generated 73 offers and took 18.969235ms > Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation > round generated 72 offers and took 11.915086ms > Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation > round generated 71 offers and took 19.106293ms > ... > Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current > allocation round generated 0 offers and took 11.747351ms > Failed to launch all tasks: Timed out after 30secs > Resource statistics: > Cluster capacity: cpus:5120; mem:3904 > Cluster allocation: cpus:1147.6; mem:1864000 > Target allocation: cpus:2370; mem:1740 > [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms) > ``` > > > Thanks, > > Kapil Arya > >
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 306 (patched) > > <https://reviews.apache.org/r/68548/diff/8/?file=2089055#file2089055line306> > > > > const ? The value is computed during initialize() call. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208633 --- On Sept. 14, 2018, 3:16 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68548/ > --- > > (Updated Sept. 14, 2018, 3:16 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > The test harness encapsulates the common logic in the allocator > benchmarks such has adding frameworks and agents. One only > needs to customize the various options in the `Benchmarkconfig` > to set up the test cluster. > > > Diffs > - > > src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68548/diff/9/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 14, 2018, 3:17 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description (updated) --- This benchmark launches frameworks with different profiles (number of tasks, task sizes and etc.) and prints out statistics such as total tasks launched, cluster utilization and allocation latency. The test has a timeout of 30 seconds Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/7/ Changes: https://reviews.apache.org/r/68591/diff/6-7/ Testing (updated) --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 2.727787ms Added 554 frameworks in 33.126141ms Start allocation Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation round generated 80 offers and took 18.470138ms Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation round generated 79 offers and took 12.000794ms Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation round generated 78 offers and took 19.469854ms Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation round generated 77 offers and took 20.271342ms Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation round generated 76 offers and took 20.172579ms Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation round generated 75 offers and took 19.731885ms Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation round generated 74 offers and took 19.9954ms Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation round generated 73 offers and took 18.969235ms Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation round generated 72 offers and took 11.915086ms Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation round generated 71 offers and took 19.106293ms ... Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current allocation round generated 0 offers and took 11.747351ms Failed to launch all tasks: Timed out after 30secs Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1147.6; mem:1864000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms) ``` Thanks, Kapil Arya
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 14, 2018, 3:16 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- The test harness encapsulates the common logic in the allocator benchmarks such has adding frameworks and agents. One only needs to customize the various options in the `Benchmarkconfig` to set up the test cluster. Diffs (updated) - src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/9/ Changes: https://reviews.apache.org/r/68548/diff/8-9/ Testing --- Thanks, Kapil Arya
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 14, 2018, 2 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- The test harness encapsulates the common logic in the allocator benchmarks such has adding frameworks and agents. One only needs to customize the various options in the `Benchmarkconfig` to set up the test cluster. Diffs (updated) - src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/8/ Changes: https://reviews.apache.org/r/68548/diff/7-8/ Testing --- Thanks, Kapil Arya
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 14, 2018, 2:01 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/6/ Changes: https://reviews.apache.org/r/68591/diff/5-6/ Testing --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 17.162452ms Added 554 frameworks in 220.842289ms Start allocation Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms ... Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms Failed to launch all tasks: Timed out after 1mins Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1093.4; mem:1688000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms) ``` Thanks, Kapil Arya
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 13, 2018, 7:08 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/5/ Changes: https://reviews.apache.org/r/68591/diff/4-5/ Testing --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 17.162452ms Added 554 frameworks in 220.842289ms Start allocation Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms ... Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms Failed to launch all tasks: Timed out after 1mins Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1093.4; mem:1688000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms) ``` Thanks, Kapil Arya
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 13, 2018, 7:05 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/4/ Changes: https://reviews.apache.org/r/68591/diff/3-4/ Testing --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 17.162452ms Added 554 frameworks in 220.842289ms Start allocation Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms ... Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms Failed to launch all tasks: Timed out after 1mins Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1093.4; mem:1688000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms) ``` Thanks, Kapil Arya
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 13, 2018, 7:04 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- The test harness encapsulates the common logic in the allocator benchmarks such has adding frameworks and agents. One only needs to customize the various options in the `Benchmarkconfig` to set up the test cluster. Diffs (updated) - src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/7/ Changes: https://reviews.apache.org/r/68548/diff/6-7/ Testing --- Thanks, Kapil Arya
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
> On Sept. 11, 2018, 8:17 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 378 (patched) > > <https://reviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line378> > > > > As I mentioned in the previous patch, it is confusing here that the > > test needs to resume the allocator even it did not pause it. The test will > > control the clock, and that should be enough for it to dictate the test > > progress. That was an oversight. Thanks for the catch > On Sept. 11, 2018, 8:17 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 409-411 (patched) > > <https://reviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line409> > > > > We might as well `unallocate` the offered resources instead of > > allocating the `taskResources`, both are not ideal, but with the former, we > > at least save some writes: > > > > ``` > > Resources remainingResources = offer.resources; > > const Resources& taskResources = > > frameworkTaskResources.at(offer.frameworkId); > > > > // We strip allocation information of `remainingResources` so that we > > // can compare/subtract with `taskResources`. > > remainingResources.unallocate(); > > > > ``` We need to "reallocate" before calling allocator to recover. But yeah, it saves some writes. > On Sept. 11, 2018, 8:17 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 436-437 (patched) > > <https://reviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line436> > > > > in << ... << allocation rounds/cycles That was a weird mix of wordings. I have updated the patch to address some of that. - Kapil ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208533 --- On Sept. 13, 2018, 4:25 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68591/ > --- > > (Updated Sept. 13, 2018, 4:25 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > This tests measures allocation performance with non-uniform framework > characteristics. Each framework profile launches a different number of > tasks with different task sizes. > > > Diffs > - > > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68591/diff/3/ > > > Testing > --- > > ``` > [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations > Added 80 agents in 17.162452ms > Added 554 frameworks in 220.842289ms > Start allocation > Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and > took 171.384046ms > Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and > took 177.912018ms > Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and > took 184.146219ms > Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and > took 189.107347ms > Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and > took 187.070715ms > Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and > took 187.07625ms > Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and > took 186.33422ms > Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and > took 183.589366ms > Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and > took 180.402905ms > Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and > took 180.515393ms > Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and > took 180.966979ms > Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and > took 176.934459ms > Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and > took 187.481368ms > Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and > took 183.099878ms > Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and > took 173.505944ms > Launched 2135 tasks out of 19500 total tasks in round 16
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 13, 2018, 4:25 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/3/ Changes: https://reviews.apache.org/r/68591/diff/2-3/ Testing --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 17.162452ms Added 554 frameworks in 220.842289ms Start allocation Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms ... Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms Failed to launch all tasks: Timed out after 1mins Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1093.4; mem:1688000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms) ``` Thanks, Kapil Arya
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
> On Sept. 11, 2018, 8:14 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 250 (patched) > > <https://reviews.apache.org/r/68548/diff/5/?file=2088299#file2088299line250> > > > > While it does not make a difference, it seems odd to pause the > > allocator here. Let's pause it immediately after the initialization. Allocator can't add agent while paused :/ https://github.com/apache/mesos/blob/91ca8e2b2071f7e4b89702ae7c807b074bdef31b/src/master/allocator/mesos/hierarchical.cpp#L534 - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208530 --- On Sept. 13, 2018, 4:22 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68548/ > --- > > (Updated Sept. 13, 2018, 4:22 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > The test harness encapsulates the common logic in the allocator > benchmarks such has adding frameworks and agents. One only > needs to customize the various options in the `Benchmarkconfig` > to set up the test cluster. > > > Diffs > - > > src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68548/diff/6/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 13, 2018, 4:22 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Changes --- Addressed Meng's comments Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- The test harness encapsulates the common logic in the allocator benchmarks such has adding frameworks and agents. One only needs to customize the various options in the `Benchmarkconfig` to set up the test cluster. Diffs (updated) - src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/6/ Changes: https://reviews.apache.org/r/68548/diff/5-6/ Testing --- Thanks, Kapil Arya
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 11, 2018, 3:22 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/2/ Testing (updated) --- ``` [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations Added 80 agents in 17.162452ms Added 554 frameworks in 220.842289ms Start allocation Launched 790 tasks out of 19500 total tasks in round 1 with 80 offers and took 171.384046ms Launched 1165 tasks out of 19500 total tasks in round 2 with 79 offers and took 177.912018ms Launched 1255 tasks out of 19500 total tasks in round 3 with 78 offers and took 184.146219ms Launched 1340 tasks out of 19500 total tasks in round 4 with 77 offers and took 189.107347ms Launched 1425 tasks out of 19500 total tasks in round 5 with 76 offers and took 187.070715ms Launched 1510 tasks out of 19500 total tasks in round 6 with 75 offers and took 187.07625ms Launched 1595 tasks out of 19500 total tasks in round 7 with 74 offers and took 186.33422ms Launched 1665 tasks out of 19500 total tasks in round 8 with 73 offers and took 183.589366ms Launched 1745 tasks out of 19500 total tasks in round 9 with 72 offers and took 180.402905ms Launched 1815 tasks out of 19500 total tasks in round 10 with 71 offers and took 180.515393ms Launched 1895 tasks out of 19500 total tasks in round 11 with 70 offers and took 180.966979ms Launched 1965 tasks out of 19500 total tasks in round 12 with 69 offers and took 176.934459ms Launched 2005 tasks out of 19500 total tasks in round 13 with 68 offers and took 187.481368ms Launched 2055 tasks out of 19500 total tasks in round 14 with 67 offers and took 183.099878ms Launched 2095 tasks out of 19500 total tasks in round 15 with 66 offers and took 173.505944ms Launched 2135 tasks out of 19500 total tasks in round 16 with 65 offers and took 181.777422ms Launched 2175 tasks out of 19500 total tasks in round 17 with 64 offers and took 175.975485ms Launched 2205 tasks out of 19500 total tasks in round 18 with 63 offers and took 174.766299ms Launched 2225 tasks out of 19500 total tasks in round 19 with 62 offers and took 173.047727ms Launched 2235 tasks out of 19500 total tasks in round 20 with 61 offers and took 178.637012ms Launched 2245 tasks out of 19500 total tasks in round 21 with 60 offers and took 176.6152ms Launched 2255 tasks out of 19500 total tasks in round 22 with 59 offers and took 171.762635ms Launched 2265 tasks out of 19500 total tasks in round 23 with 58 offers and took 173.781849ms Launched 2275 tasks out of 19500 total tasks in round 24 with 57 offers and took 173.308192ms Launched 2285 tasks out of 19500 total tasks in round 25 with 56 offers and took 167.873817ms Launched 2295 tasks out of 19500 total tasks in round 26 with 55 offers and took 167.150833ms Launched 2305 tasks out of 19500 total tasks in round 27 with 54 offers and took 165.603318ms Launched 2315 tasks out of 19500 total tasks in round 28 with 53 offers and took 165.629372ms Launched 2315 tasks out of 19500 total tasks in round 29 with 52 offers and took 163.471809ms ... Launched 2315 tasks out of 19500 total tasks in round 530 with 0 offers and took 110.898635ms Launched 2315 tasks out of 19500 total tasks in round 531 with 0 offers and took 113.201834ms Failed to launch all tasks: Timed out after 1mins Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1093.4; mem:1688000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms) ``` Thanks, Kapil Arya
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 278-279 (patched) > > <https://reviews.apache.org/r/68548/diff/4/?file=2079338#file2079338line278> > > > > I feel there are some ambiguities as to which parameters are > > kept/copied in the benchmark base class, which are kept just in the > > `Benchmarkconfig`, e.g. it is not clear to me why we keep the "profiles" > > here. They are not needed after the initialization phase. > > > > I wonder should we just keep a copy of the benchmarkconfig here? > > > > Any better idea? For now, I moved it into the BenchmarkConfig. I'm not sure if there's a better place for it, but sounds reasonable to me for now. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208321 --- On Sept. 11, 2018, 3:15 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68548/ > --- > > (Updated Sept. 11, 2018, 3:15 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > The test harness encapsulates the common logic in the allocator > benchmarks such has adding frameworks and agents. One only > needs to customize the various options in the `Benchmarkconfig` > to set up the test cluster. > > > Diffs > - > > src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68548/diff/5/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 143 (patched) > > <https://reviews.apache.org/r/68548/diff/4/?file=2079338#file2079338line143> > > > > Let's add a comment here regarding what this is for, and show an > > example of framework/agent id. Just removed this entirely for frameworks/agents. Added a separate flag for unique roles. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208321 ------- On Sept. 11, 2018, 3:15 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68548/ > --- > > (Updated Sept. 11, 2018, 3:15 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > --- > > The test harness encapsulates the common logic in the allocator > benchmarks such has adding frameworks and agents. One only > needs to customize the various options in the `Benchmarkconfig` > to set up the test cluster. > > > Diffs > - > > src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68548/diff/5/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 11, 2018, 3:15 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Changes --- Addressed Meng's comments. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs (updated) - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/2/ Changes: https://reviews.apache.org/r/68591/diff/1-2/ Testing --- Make check with the new test. Thanks, Kapil Arya
Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 11, 2018, 3:15 p.m.) Review request for mesos, Meng Zhu and Till Toenshoff. Changes --- Addressed Meng's comments. Summary (updated) - Introduced a base class for writing allocator benchmarks. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description (updated) --- The test harness encapsulates the common logic in the allocator benchmarks such has adding frameworks and agents. One only needs to customize the various options in the `Benchmarkconfig` to set up the test cluster. Diffs (updated) - src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/5/ Changes: https://reviews.apache.org/r/68548/diff/4-5/ Testing --- Thanks, Kapil Arya
Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/ --- (Updated Sept. 3, 2018, 6:10 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Starting with JDK 10, javah is not available. The substitute is to use `javac -h` for generating headers. Diffs (updated) - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68613/diff/3/ Changes: https://reviews.apache.org/r/68613/diff/2-3/ Testing --- Thanks, Kapil Arya
Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/ --- (Updated Sept. 3, 2018, 6:08 p.m.) Review request for mesos and Till Toenshoff. Changes --- Addressed Till's comments. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Starting with JDK 10, javah is not available. The substitute is to use `javac -h` for generating headers. Diffs (updated) - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68613/diff/2/ Changes: https://reviews.apache.org/r/68613/diff/1-2/ Testing --- Thanks, Kapil Arya
Re: Review Request 68612: Consolidated Java header targets using makefile patterns.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68612/ --- (Updated Sept. 3, 2018, 6:08 p.m.) Review request for mesos and Till Toenshoff. Changes --- Addressed Till's comments. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Consolidated Java header targets using makefile patterns. Diffs (updated) - src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68612/diff/2/ Changes: https://reviews.apache.org/r/68612/diff/1-2/ Testing --- Thanks, Kapil Arya
Re: Review Request 68610: Updated libjvm search logic for newer openjdk versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68610/ --- (Updated Sept. 3, 2018, 3 p.m.) Review request for mesos and Till Toenshoff. Changes --- Added fix for macos as well. Summary (updated) - Updated libjvm search logic for newer openjdk versions. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description (updated) --- Updated libjvm search logic for newer openjdk versions. Diffs (updated) - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 Diff: https://reviews.apache.org/r/68610/diff/2/ Changes: https://reviews.apache.org/r/68610/diff/1-2/ Testing --- Thanks, Kapil Arya
Review Request 68612: Consolidated Java header targets using makefile patterns.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68612/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Consolidated Java header targets using makefile patterns. Diffs - src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68612/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 68610: Updated libjvm.so search logic for newer openjdk versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68610/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Updated libjvm.so search logic for newer openjdk versions. Diffs - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 Diff: https://reviews.apache.org/r/68610/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 68613: Replaced javah with `javac -c` for newer JDKs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Starting with JDK 10, javah is not available. The substitute is to use `javac -h` for generating headers. Diffs - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68613/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 68611: Fixed maven invocation with proper JAVA_HOME.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68611/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921 https://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- On some distros, JAVA_HOME environment variable is not set by default. However, on such systems, our configure script is able to successfully compute the value of JAVA_HOME based on PATH, etc. We use this computed JAVA_HOME to set the environment variable when invoking maven. Diffs - src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68611/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- This tests measures allocation performance with non-uniform framework characteristics. Each framework profile launches a different number of tasks with different task sizes. Diffs - src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/1/ Testing --- Make check with the new test. Thanks, Kapil Arya
Review Request 68549: Added pause and resume helpers to the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68549/ --- Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- Currently these helpers are only used in the allocator tests to prevent event-driven allocations that triggered when adding frameworks and agents. This is the same as Meng's patch in https://reviews.apache.org/r/68049/ with a compilation fix. Diffs - include/mesos/allocator/allocator.hpp fadd4e8e32c9edca4fefa1cd5f8c8720188d3ca5 src/master/allocator/mesos/allocator.hpp e65a9698ffe514b5f129417694190790712de508 src/master/allocator/mesos/hierarchical.hpp e3adb5dbb968684f6f63477f56a6abf4f288c896 src/tests/allocator.hpp 1d844464741b3f40890198e2503593c76de870df Diff: https://reviews.apache.org/r/68549/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 68548: Added allocator benchmark test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187 https://issues.apache.org/jira/browse/MESOS-9187 Repository: mesos Description --- The new harness allows us to run allocators with different framework and agent profiles. Diffs - src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 68393: Fixed grpc compilation for directory paths with symlinks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68393/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description --- Automake variable `abs_builddir` doesn't resolve symlinks so we explicitly call `realpath` on grpc targets. Diffs - 3rdparty/Makefile.am 248d517874c2b34e98446d1e6724078c5c21708c Diff: https://reviews.apache.org/r/68393/diff/1/ Testing --- Thanks, Kapil Arya
Re: Review Request 68370: Updated Zookeeper patch to fix format error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68370/ --- (Updated Aug. 16, 2018, 4:14 p.m.) Review request for mesos, Benjamin Bannier and Vinod Kone. Changes --- Addressed Benjamin's comments. Summary (updated) - Updated Zookeeper patch to fix format error. Repository: mesos Description (updated) --- This is a backport of: https://github.com/apache/zookeeper/pull/559/ Diffs (updated) - 3rdparty/zookeeper-3.4.8.patch edfc3b5cf20568ded024137e3d4f7ab2fe221c2d Diff: https://reviews.apache.org/r/68370/diff/2/ Changes: https://reviews.apache.org/r/68370/diff/1-2/ Testing --- Thanks, Kapil Arya
Review Request 68370: Updated Zookeeper to fix `-Werror-format-overflow` error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68370/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos Description --- The patch is motivated from: https://github.com/apache/zookeeper/pull/559/ Diffs - 3rdparty/zookeeper-3.4.8.patch edfc3b5cf20568ded024137e3d4f7ab2fe221c2d Diff: https://reviews.apache.org/r/68370/diff/1/ Testing --- Thanks, Kapil Arya
Re: Review Request 67780: Removed incorrect symlink handling in archiver utility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67780/#review205547 --- Ship it! Duh! - Kapil Arya On June 28, 2018, 9 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67780/ > --- > > (Updated June 28, 2018, 9 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. > > > Bugs: MESOS-9038 > https://issues.apache.org/jira/browse/MESOS-9038 > > > Repository: mesos > > > Description > --- > > While fixing MESOS-9008, we accidentally assumed that all links needed > to be corrected when extracting to a different directory. This is > necessary for hardlinks because a hardlink must point to a file > extracted earlier in the archive. However, for symlinks, this is not > the case. When extracted with no header modifications, symlinks will > point to their intended target (i.e. relative symlinks will not be > transformed into targetting absolute paths). > > > Diffs > - > > 3rdparty/stout/include/stout/archiver.hpp > 0f249296182172f9b01d53a5f86403689df5a9fa > > > Diff: https://reviews.apache.org/r/67780/diff/1/ > > > Testing > --- > > make check > > Manually tested this change against the archive here: > https://downloads.mesosphere.com/libmesos-bundle/libmesos-bundle-1.11.0.tar.gz > > ^ Specifically looking at items symlinked under `libmesos-bundle/lib/mesos`. > > > Thanks, > > Joseph Wu > >
Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67680/#review205135 --- Ship it! Looks good module a minor comment. Feel free to drop if it's too much. - Kapil Arya On June 20, 2018, 7:55 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67680/ > --- > > (Updated June 20, 2018, 7:55 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. > > > Bugs: MESOS-9008 > https://issues.apache.org/jira/browse/MESOS-9008 > > > Repository: mesos > > > Description > --- > > The archiver utility may fail to extract hardlinks when the destination > target is different than the current working directory. This happens > because hardlinks are generally expressed in relative terms within > an archive, but the target should be changed to point to the extracted > location during extraction. > > This updates the archiver utility to handle links correctly and adds > a regression test. > > > Diffs > - > > 3rdparty/stout/include/stout/archiver.hpp > f66da36de94f46c799cb1028b6e8c0ed26c9f3ae > 3rdparty/stout/tests/archiver_tests.cpp > eddda0872f02a4918cffc22ebc0da2c46b172fd9 > > > Diff: https://reviews.apache.org/r/67680/diff/1/ > > > Testing > --- > > make check > > The tarball was generated with the following: > ``` > echo "I'm a link target" > target > ln target hardlink > ln -s target symlink > tar -czf foo.tar.gz target hardlink symlink > ``` > > > Thanks, > > Joseph Wu > >
Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67680/#review205134 --- 3rdparty/stout/tests/archiver_tests.cpp Lines 388-389 (patched) <https://reviews.apache.org/r/67680/#comment288098> Should we add a short comment on how the contents were generated? Basically, copy-paste commands from the Testing Done section of this RR? - Kapil Arya On June 20, 2018, 7:55 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67680/ > --- > > (Updated June 20, 2018, 7:55 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. > > > Bugs: MESOS-9008 > https://issues.apache.org/jira/browse/MESOS-9008 > > > Repository: mesos > > > Description > --- > > The archiver utility may fail to extract hardlinks when the destination > target is different than the current working directory. This happens > because hardlinks are generally expressed in relative terms within > an archive, but the target should be changed to point to the extracted > location during extraction. > > This updates the archiver utility to handle links correctly and adds > a regression test. > > > Diffs > - > > 3rdparty/stout/include/stout/archiver.hpp > f66da36de94f46c799cb1028b6e8c0ed26c9f3ae > 3rdparty/stout/tests/archiver_tests.cpp > eddda0872f02a4918cffc22ebc0da2c46b172fd9 > > > Diff: https://reviews.apache.org/r/67680/diff/1/ > > > Testing > --- > > make check > > The tarball was generated with the following: > ``` > echo "I'm a link target" > target > ln target hardlink > ln -s target symlink > tar -czf foo.tar.gz target hardlink symlink > ``` > > > Thanks, > > Joseph Wu > >
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated May 9, 2018, 9:15 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Implemented UPDATE_FRAMEWORK call. Diffs (updated) - src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp ea8d54ff198a5529d61a41bcb6e5806378761091 src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/13/ Changes: https://reviews.apache.org/r/66229/diff/12-13/ Testing --- Thanks, Kapil Arya
Re: Review Request 66230: Added test for updating framework info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated May 9, 2018, 9:15 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Summary (updated) - Added test for updating framework info. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- Includes tests to validate UPDATE_FRAMEWORK call as well as specific tests for adding/removing framework roles. Diffs (updated) - src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af Diff: https://reviews.apache.org/r/66230/diff/9/ Changes: https://reviews.apache.org/r/66230/diff/8-9/ Testing --- Thanks, Kapil Arya
Re: Review Request 66228: Added Call for updating framework info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- (Updated May 9, 2018, 9:14 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added Call for updating framework info. Diffs (updated) - include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c Diff: https://reviews.apache.org/r/66228/diff/9/ Changes: https://reviews.apache.org/r/66228/diff/8-9/ Testing --- Thanks, Kapil Arya
Review Request 67049: Modified Master::updateFramework to optionally return an Error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67049/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- If the new FrameworkInfo contains non-updatable fields, the `update` function can now return an Error which can be propagated to the framework. Diffs - src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 Diff: https://reviews.apache.org/r/67049/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 67048: Updated some Master functions to accept repeated fields.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67048/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- This prevents un-necessary copying of suppressed roles that are part of subscribe calls. Diffs - src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 Diff: https://reviews.apache.org/r/67048/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 67047: Consolidated master framework validation at one place.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67047/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Consolidated master framework validation at one place. Diffs - src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/67047/diff/1/ Testing --- Thanks, Kapil Arya
Re: Review Request 66872: Updated FrameworkInfo comparator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66872/ --- (Updated May 9, 2018, 9:11 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- The comparator is more strict and checks for all fields. Also removed some existing un-needed comparisons from test cases that were clashing with the new implementation. This is because the previous implementation's limited comparison (just `name` and `user` fields) succeeded whereas it fails with the newer implementaion due to the stricter/fuller nature. Diffs (updated) - include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66872/diff/3/ Changes: https://reviews.apache.org/r/66872/diff/2-3/ Testing --- Thanks, Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework roles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated May 4, 2018, 1:33 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Changes --- Enhanced tests. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added test for adding/removing framework roles. Diffs (updated) - src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af Diff: https://reviews.apache.org/r/66230/diff/8/ Changes: https://reviews.apache.org/r/66230/diff/7-8/ Testing --- Thanks, Kapil Arya
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated May 3, 2018, 12:05 a.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Changes --- Addressed Till's comments. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Implemented UPDATE_FRAMEWORK call. Diffs (updated) - src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/9/ Changes: https://reviews.apache.org/r/66229/diff/8-9/ Testing --- Thanks, Kapil Arya
Re: Review Request 66872: Updated FrameworkInfo comparator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66872/ --- (Updated May 2, 2018, 6:21 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Changes --- Updated Description. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- We now use the MessageDifferencer protobuf utility for a deep/recursive comparison of FrameworkInfo fields. Also removed some existing un-needed comparisons from test cases that were clashing with the new implementation. This is because the previous implementation's limited comparison (just `name` and `user` fields) succeeded whereas it fails with the newer implementaion due to the stricter/fuller nature. Diffs - include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66872/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 66872: Updated FrameworkInfo comparator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66872/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Updated FrameworkInfo comparator. Diffs - include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66872/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 66864: Updated FrameworkInfo comparator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66864/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Updated FrameworkInfo comparator to use protobuf MessageDifferencer. Diffs - include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66864/diff/1/ Testing --- Thanks, Kapil Arya
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.
> On April 23, 2018, 8:43 p.m., Benjamin Mahler wrote:
> > I'm not sure this approach is tenable, we may in the future have two
> > different `foo` fields with differing equality semantics.
> >
> > I was expecting that this patch would add an equality operator for specific
> > types we want to check. Do we need the `Message&` level equality operator?
>
> Kapil Arya wrote:
> Right now we don't have any differing equality semantics for any of the
> messages. There are four non-standard semantics are captured in the generic
> method. In future, when we need differring techniques for some bar, we can
> overload the `==` operator for that particular type. Does that sound
> reasonable?
>
> Since, MessageDifferencer recurses down to the fields without calling
> `==` itself, if we were to have two message Bar and Baz with with different
> equality semantics for `foo` fields in them , we'd can implement `==` for
> both Bar and Baz to reflect that. For example:
> ```
> operator==(const Bar& left, const Bar& right) {
> MessageDifferencer diff;
>
> // Bar-specific enhancements for Foo.
> diff.TreatAsSet(Foo::descriptor()->FindFieldByName("some_field"));
> ...
> return diff.compare(left, right);
> }
>
> operator==(const Baz& left, const Baz& right) {
> MessageDifferencer diff;
>
> // Baz-speficic enhancements for Foo.
> diff.TreatAsList(Foo::descriptor()->FindFieldByName("some_field"));
> ...
> return diff.compare(left, right);
> }
> ```
>
> However, if Bar and Baz were to have another common field `qux` with a
> non-standard comparator, we'd have to duplicate the qux-specific enhancement
> in both Bar and Baz comparators. This leads to some duplication, but that can
> be fixed with some clever maneuvering.
There is another possibility where we implement some generic
MesosMessageDifferencer like the one in the patch. Any implementations that
need to deviate from the standard then take a copy of MesosMessageDifferencer
and modify it as needed.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66746/#review201799
---
On April 20, 2018, 4:19 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66746/
> ---
>
> (Updated April 20, 2018, 4:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The MessageDifferencer utility has been available since protobuf 3.0.0.
> When comparing most repeated fields, we treat them as sets so the order
> of elements doesn't matter. In some exceptional cases, we treat them as
> list so the order becomes important. Further, fields with default
> purposes are considered to be set for comparison purposes.
>
>
> Diffs
> -
>
> include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa
> include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb
> src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2
> src/tests/master_allocator_tests.cpp
> e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf
>
>
> Diff: https://reviews.apache.org/r/66746/diff/1/
>
>
> Testing
> ---
>
> `make check` currently fails with:
> DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask
> DefaultExecutorCheckTest.MultipleTasksWithChecks
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.
> On April 23, 2018, 8:43 p.m., Benjamin Mahler wrote:
> > I'm not sure this approach is tenable, we may in the future have two
> > different `foo` fields with differing equality semantics.
> >
> > I was expecting that this patch would add an equality operator for specific
> > types we want to check. Do we need the `Message&` level equality operator?
Right now we don't have any differing equality semantics for any of the
messages. There are four non-standard semantics are captured in the generic
method. In future, when we need differring techniques for some bar, we can
overload the `==` operator for that particular type. Does that sound reasonable?
Since, MessageDifferencer recurses down to the fields without calling `==`
itself, if we were to have two message Bar and Baz with with different equality
semantics for `foo` fields in them , we'd can implement `==` for both Bar and
Baz to reflect that. For example:
```
operator==(const Bar& left, const Bar& right) {
MessageDifferencer diff;
// Bar-specific enhancements for Foo.
diff.TreatAsSet(Foo::descriptor()->FindFieldByName("some_field"));
...
return diff.compare(left, right);
}
operator==(const Baz& left, const Baz& right) {
MessageDifferencer diff;
// Baz-speficic enhancements for Foo.
diff.TreatAsList(Foo::descriptor()->FindFieldByName("some_field"));
...
return diff.compare(left, right);
}
```
However, if Bar and Baz were to have another common field `qux` with a
non-standard comparator, we'd have to duplicate the qux-specific enhancement in
both Bar and Baz comparators. This leads to some duplication, but that can be
fixed with some clever maneuvering.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66746/#review201799
---
On April 20, 2018, 4:19 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66746/
> ---
>
> (Updated April 20, 2018, 4:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The MessageDifferencer utility has been available since protobuf 3.0.0.
> When comparing most repeated fields, we treat them as sets so the order
> of elements doesn't matter. In some exceptional cases, we treat them as
> list so the order becomes important. Further, fields with default
> purposes are considered to be set for comparison purposes.
>
>
> Diffs
> -
>
> include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa
> include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb
> src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2
> src/tests/master_allocator_tests.cpp
> e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf
>
>
> Diff: https://reviews.apache.org/r/66746/diff/1/
>
>
> Testing
> ---
>
> `make check` currently fails with:
> DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask
> DefaultExecutorCheckTest.MultipleTasksWithChecks
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework roles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added test for adding/removing framework roles. Diffs (updated) - src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af Diff: https://reviews.apache.org/r/66230/diff/6/ Changes: https://reviews.apache.org/r/66230/diff/5-6/ Testing --- Thanks, Kapil Arya
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Implemented UPDATE_FRAMEWORK call. Diffs (updated) - src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/6/ Changes: https://reviews.apache.org/r/66229/diff/5-6/ Testing --- Thanks, Kapil Arya
Re: Review Request 66228: Added Call for updating framework info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added Call for updating framework info. Diffs (updated) - include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f include/mesos/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491 Diff: https://reviews.apache.org/r/66228/diff/5/ Changes: https://reviews.apache.org/r/66228/diff/4-5/ Testing --- Thanks, Kapil Arya
Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository: mesos Description --- The MessageDifferencer utility has been available since protobuf 3.0.0. When comparing most repeated fields, we treat them as sets so the order of elements doesn't matter. In some exceptional cases, we treat them as list so the order becomes important. Further, fields with default purposes are considered to be set for comparison purposes. Diffs - include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66746/diff/1/ Testing --- `make check` currently fails with: DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask DefaultExecutorCheckTest.MultipleTasksWithChecks Thanks, Kapil Arya
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
> On April 12, 2018, 8:19 p.m., Till Toenshoff wrote: > > src/master/validation.cpp > > Lines 532 (patched) > > <https://reviews.apache.org/r/66229/diff/4/?file=1996013#file1996013line532> > > > > s/is/are/ > > > > How do we make sure the role is "valid" - isn't that implicit when it > > was contained in the framework roles? Updated the comment to reflect that we are validating "suppressed" roles. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review201053 ------- On April 12, 2018, 9:38 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66229/ > --- > > (Updated April 12, 2018, 9:38 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > --- > > Implemented UPDATE_FRAMEWORK call. > > > Diffs > - > > src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 > src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 > src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > > > Diff: https://reviews.apache.org/r/66229/diff/5/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 12, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Changes --- Addressed Till's comments. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Implemented UPDATE_FRAMEWORK call. Diffs (updated) - src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/5/ Changes: https://reviews.apache.org/r/66229/diff/4-5/ Testing --- Thanks, Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework roles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated April 12, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Changes --- Addressed Till's comments. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added test for adding/removing framework roles. Diffs (updated) - src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af Diff: https://reviews.apache.org/r/66230/diff/5/ Changes: https://reviews.apache.org/r/66230/diff/4-5/ Testing --- Thanks, Kapil Arya
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 11, 2018, 1:28 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Implemented UPDATE_FRAMEWORK call. Diffs (updated) - src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/4/ Changes: https://reviews.apache.org/r/66229/diff/3-4/ Testing --- Thanks, Kapil Arya
Re: Review Request 66228: Added Call for updating framework info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- (Updated April 11, 2018, 1:28 p.m.) Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added Call for updating framework info. Diffs (updated) - include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f include/mesos/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491 Diff: https://reviews.apache.org/r/66228/diff/4/ Changes: https://reviews.apache.org/r/66228/diff/3-4/ Testing --- Thanks, Kapil Arya
Re: Review Request 65939: Updated role endpoints for hierarchical accounting.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65939/#review200584
---
Hey Till,
I have added some comments. Most are minor style sthings which you should feel
free to ignore :-).
I have two high-level comments (we already talked about the first one but
thought of putting it in here anyways):
1. Backwards compatibility wrt to the Role proto for /roles endpoint and the
likes.
2. I noticed that we have `master->roles.getRole()`, etc., scattered all over
the code and wondering if we should put some of these methods in the Master
class itself for better readability?
include/mesos/mesos.proto
Line 3407 (original), 3407-3409 (patched)
<https://reviews.apache.org/r/65939/#comment281329>
I wonder how this would affect backwards compatibility. Do we need to keep
`resources` as is and add `allocated` and `total_allocated` in addition? If we
do this, we'd probably need to figure out a way to handle old vs new frameworks.
include/mesos/v1/master/master.proto
Lines 458-459 (original), 458-459 (patched)
<https://reviews.apache.org/r/65939/#comment281328>
Please update the corresponding V0 master.proto as well.
src/master/master.hpp
Lines 139-140 (patched)
<https://reviews.apache.org/r/65939/#comment281362>
Now that we are keeping track of `allocatedResources` and
`totalAllocatedResources`, we can replace this hashmap with a simple hashset.
We don't seem to be using `Framework*` elsewhere.
src/master/master.hpp
Lines 173-174 (patched)
<https://reviews.apache.org/r/65939/#comment281334>
Can we change the third sentence ("An implicit ... active role.") to
something like:
An implicit role is not active - frameworks are connected to its child
roles instead.
src/master/master.hpp
Lines 178 (patched)
<https://reviews.apache.org/r/65939/#comment281337>
I am not sure if I understand what `returned in ["a", "a/b"]` means.
src/master/master.hpp
Lines 181 (patched)
<https://reviews.apache.org/r/65939/#comment281341>
Would this search the framework in child roles as well? Can we expand to
comment to explicitly mention it? Something like:
` Checks if the given framework is being tracked under the given role or
its child roles`
src/master/master.cpp
Lines 495-501 (patched)
<https://reviews.apache.org/r/65939/#comment281345>
Just a minor comment. Would it improve readability if we were to switch the
if condition with the CHECK condition? As in:
```
if (!roleMap.contains(path)) {
CHECK(!parent->children.contains(path));
VLOG(1) ...
...
}
```
src/master/master.cpp
Lines 519 (patched)
<https://reviews.apache.org/r/65939/#comment281347>
s/stop going up the tree/not removing it
Here and below. That way it applies to the top-level roles as well.
src/master/master.cpp
Lines 520 (patched)
<https://reviews.apache.org/r/65939/#comment281346>
s/break/return/ ?
Here and below.
src/master/master.cpp
Lines 529 (patched)
<https://reviews.apache.org/r/65939/#comment281350>
What if we bring this line after VLOG line. Further, we need a
`CHECK_NOTNULL(parent);` here?
src/master/master.cpp
Lines 531 (patched)
<https://reviews.apache.org/r/65939/#comment281349>
s/childless/leaf ?
src/master/master.cpp
Lines 572 (patched)
<https://reviews.apache.org/r/65939/#comment281360>
Wondering if we should use `getRole(role)->frameworks.contains(id)` for
uniformity.
src/master/master.cpp
Lines 587 (patched)
<https://reviews.apache.org/r/65939/#comment281361>
Do we need a CHECK here, or is that too defensive?
src/master/master.cpp
Lines 619 (patched)
<https://reviews.apache.org/r/65939/#comment281363>
This VLOG seems to stand out. Do we need similar log messages in other
functions (`addResources`, etc.)?
- Kapil Arya
On April 5, 2018, 12:15 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65939/
> -------
>
> (Updated April 5, 2018, 12:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya,
> Michael Park, and Meng Zhu.
>
>
> Bugs: MESOS-8069
> https://issues.apache.org/jira/browse/MESOS-8069
>
>
> Repository: mesos
>
>
> Description
> ---
>
> When listing role "a", resources allocated to role "a/b" are added to
> those allocated to role "a". These changes affect both, the "/roles"
> endpoint as well as the V1 HTTP Call
Re: Review Request 65940: Added test validating hierarchical role accounting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review200609 --- Ship it! This looks good to me. I am wondering if we need more test coverage for insertion/deletion of roles implicit roles. Perhaps a TODO? src/tests/api_tests.cpp Lines 1072 (patched) <https://reviews.apache.org/r/65940/#comment281381> For completeness, can we check `roles(0)` as well? - Kapil Arya On April 5, 2018, 12:15 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65940/ > --- > > (Updated April 5, 2018, 12:15 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and > Michael Park. > > > Bugs: MESOS-8069 > https://issues.apache.org/jira/browse/MESOS-8069 > > > Repository: mesos > > > Description > --- > > Added test validating hierarchical role accounting. > > > Diffs > - > > src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 > src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 > > > Diff: https://reviews.apache.org/r/65940/diff/2/ > > > Testing > --- > > make check > > > Thanks, > > Till Toenshoff > >
Review Request 66229: Implemented UPDATE_FRAMEWORK call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Implemented UPDATE_FRAMEWORK call. Diffs - include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b include/mesos/v1/scheduler/scheduler.proto f08fdfbab2a13d1104e7be4b42bf20e9048ab562 src/cli/execute.cpp 729896a4021a3be6dfd41a5f6bc78872170fe68a src/examples/long_lived_framework.cpp 53e3ec99d4081a12e2138e79154b07ad5d5ef503 src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c src/examples/test_http_framework.cpp 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 src/master/http.cpp 6f692e20b0f82dbe5c676739757b9eeaf4d6d49a src/master/master.hpp 92af8520db15465fbe55c187be3945accc436ec3 src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 src/master/validation.cpp b15b75c95bdffc6e62e84532f0457b439046562e src/sched/sched.cpp 613a33b7d3150ad851af674e989a84b3899f2d69 src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d Diff: https://reviews.apache.org/r/66229/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 66230: Added test for adding/removing framework roles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added test for adding/removing framework roles. Diffs - src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d Diff: https://reviews.apache.org/r/66230/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 66228: Added call/event for updating framework info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- Added call/event for updating framework info. Diffs - include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b include/mesos/v1/scheduler/scheduler.proto f08fdfbab2a13d1104e7be4b42bf20e9048ab562 Diff: https://reviews.apache.org/r/66228/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 65696: Allowed base64-decoding with whitespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65696/ --- Review request for mesos, Michael Park and Till Toenshoff. Bugs: MESOS-8569 https://issues.apache.org/jira/browse/MESOS-8569 Repository: mesos Description --- Most base64 decoders do not fail on encountering whitespace characters as several encoders embed newlines to enforce line-width in encoded data. Diffs - 3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f 3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66 Diff: https://reviews.apache.org/r/65696/diff/1/ Testing --- Updated base64 tests and ran make check Thanks, Kapil Arya
Re: Review Request 65416: Enabled gRPC in the RPM spec file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65416/#review196523 --- Ship it! Ship It! - Kapil Arya On Jan. 29, 2018, 10:41 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65416/ > --- > > (Updated Jan. 29, 2018, 10:41 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Kapil Arya, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Enabled gRPC in the RPM spec file. > > > Diffs > - > > support/packaging/centos/mesos.spec > 561c75fdaceb173d04b754e68686fded262251fd > > > Diff: https://reviews.apache.org/r/65416/diff/1/ > > > Testing > --- > > Build the RPM package on the local box. > > > Thanks, > > Jie Yu > >
Re: Review Request 64297: Updated modules documentation with some more details.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review196294 --- Ship it! Ship It! - Kapil Arya On Jan. 25, 2018, 5:16 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64297/ > --- > > (Updated Jan. 25, 2018, 5:16 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya. > > > Bugs: MESOS-8016 > https://issues.apache.org/jira/browse/MESOS-8016 > > > Repository: mesos > > > Description > --- > > Added mention of HTTP authenticatee module. Added mention of > authorizer modules. Added details around hook modules. > > > Diffs > - > > docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3 > > > Diff: https://reviews.apache.org/r/64297/diff/3/ > > > Testing > --- > > > Thanks, > > Till Toenshoff > >
Re: Review Request 64297: Updated modules documentation with some more details.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review196293 --- docs/modules.md Lines 145 (patched) <https://reviews.apache.org/r/64297/#comment275846> s/- Used/Used/ I wonder if there is any value in keeping the TestModule around. - Kapil Arya On Jan. 25, 2018, 4:58 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64297/ > --- > > (Updated Jan. 25, 2018, 4:58 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya. > > > Bugs: MESOS-8016 > https://issues.apache.org/jira/browse/MESOS-8016 > > > Repository: mesos > > > Description > --- > > Added mention of HTTP authenticatee module. Added mention of > authorizer modules. Added details around hook modules. > > > Diffs > - > > docs/hook.md PRE-CREATION > docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3 > > > Diff: https://reviews.apache.org/r/64297/diff/2/ > > > Testing > --- > > > Thanks, > > Till Toenshoff > >
Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.
> On Jan. 16, 2018, 2:30 p.m., Kapil Arya wrote: > > Sorry for jumping so late into the party :(. > > > > I wanted to point out a better procedure to install Mesos packages. It's > > listed in the email I sent out earlier to the dev@ mailing list > > (https://www.mail-archive.com/user@mesos.apache.org/msg09469.html) > > > > Basically, you can just do the following > > > > ``` > > $ cat > /tmp/bintray-mesos-el.repo < > #bintray-mesos-el - packages by mesos from Bintray > > [bintray-mesos-el] > > name=bintray-mesos-el > > baseurl=https://dl.bintray.com/mesos/el/7/x86_64 > > gpgcheck=0 > > repo_gpgcheck=0 > > enabled=1 > > EOF > > > > $ sudo mv /tmp/bintray-mesos-el.repo /etc/yum.repos.d/bintray-mesos-el.repo > > > > $ sudo yum update > > > > $ sudo yum install mesos > > ``` > > Senthil Kumaran wrote: > Thanks for jumping in, Kapil. I can replace the text with your suggestion > above > > * If the installation is for RHEL6, should we assume that the reader will > take care of changing the `baseurl` or should we make a note? I think adding a note would be best. That way they won't miss it. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65116/#review195488 --- On Jan. 11, 2018, 9:36 p.m., Senthil Kumaran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65116/ > --- > > (Updated Jan. 11, 2018, 9:36 p.m.) > > > Review request for mesos, Greg Mann and Kapil Arya. > > > Repository: mesos > > > Description > --- > > Getting Started using the Mesos RPM Binaries. > > > Diffs > - > > docs/using-rpm.md PRE-CREATION > site/source/downloads.html.erb 758a55225b83d3d38c459d365c94b913f56425ae > site/source/getting-started.html.md > b03d80075165020244da9b5f02607355058b9810 > > > Diff: https://reviews.apache.org/r/65116/diff/1/ > > > Testing > --- > > ``` > $ curl -L > "https://dl.bintray.com/mesos/el//7/x86_64/mesos-1.4.1-1.el7.x86_64.rpm"; -o > mesos-1.4.1-1.el7.x86_64.rpm > % Total% Received % Xferd Average Speed TimeTime Time > Current > Dload Upload Total SpentLeft Speed > 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 > 100 43.4M 100 43.4M0 0 49.5M 0 --:--:-- --:--:-- --:--:-- 49.5M > ``` > > And > > ``` > $ sudo yum install mesos-1.4.1-1.el7.x86_64.rpm > Loaded plugins: langpacks, product-id, search-disabled-repos > Examining mesos-1.4.1-1.el7.x86_64.rpm: mesos-1.4.1-1.el7.x86_64 > Marking mesos-1.4.1-1.el7.x86_64.rpm to be installed > Resolving Dependencies > --> Running transaction check > ---> Package mesos.x86_64 0:1.4.1-1.el7 will be installed > --> Processing Dependency: cyrus-sasl-md5 for package: > mesos-1.4.1-1.el7.x86_64 > rhui-microsoft-azure-rhel7 > | 2.9 kB 00:00:00 > rhui-rhel-7-server-dotnet-rhui-debug-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-dotnet-rhui-rpms > | 4.0 kB 00:00:00 > rhui-rhel-7-server-dotnet-rhui-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-debug-rpms > | 3.3 kB 00:00:00 > rhui-rhel-7-server-rhui-extras-debug-rpms > | 3.2 kB 00:00:00 > rhui-rhel-7-server-rhui-extras-rpms > | 3.4 kB 00:00:00 > rhui-rhel-7-server-rhui-extras-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-optional-debug-rpms > | 3.3 kB 00:00:00 > rhui-rhel-7-server-rhui-optional-rpms > | 3.5 kB 00:00:00 > rhui-rhel-7-server-rhui-optional-source-rpms >
Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65116/#review195488 --- Sorry for jumping so late into the party :(. I wanted to point out a better procedure to install Mesos packages. It's listed in the email I sent out earlier to the dev@ mailing list (https://www.mail-archive.com/user@mesos.apache.org/msg09469.html) Basically, you can just do the following ``` $ cat > /tmp/bintray-mesos-el.repo <https://dl.bintray.com/mesos/el/7/x86_64 gpgcheck=0 repo_gpgcheck=0 enabled=1 EOF $ sudo mv /tmp/bintray-mesos-el.repo /etc/yum.repos.d/bintray-mesos-el.repo $ sudo yum update $ sudo yum install mesos ``` - Kapil Arya On Jan. 11, 2018, 9:36 p.m., Senthil Kumaran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65116/ > --- > > (Updated Jan. 11, 2018, 9:36 p.m.) > > > Review request for mesos, Greg Mann and Kapil Arya. > > > Repository: mesos > > > Description > --- > > Getting Started using the Mesos RPM Binaries. > > > Diffs > - > > docs/using-rpm.md PRE-CREATION > site/source/downloads.html.erb 758a55225b83d3d38c459d365c94b913f56425ae > site/source/getting-started.html.md > b03d80075165020244da9b5f02607355058b9810 > > > Diff: https://reviews.apache.org/r/65116/diff/1/ > > > Testing > --- > > ``` > $ curl -L > "https://dl.bintray.com/mesos/el//7/x86_64/mesos-1.4.1-1.el7.x86_64.rpm"; -o > mesos-1.4.1-1.el7.x86_64.rpm > % Total% Received % Xferd Average Speed TimeTime Time > Current > Dload Upload Total SpentLeft Speed > 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 > 100 43.4M 100 43.4M0 0 49.5M 0 --:--:-- --:--:-- --:--:-- 49.5M > ``` > > And > > ``` > $ sudo yum install mesos-1.4.1-1.el7.x86_64.rpm > Loaded plugins: langpacks, product-id, search-disabled-repos > Examining mesos-1.4.1-1.el7.x86_64.rpm: mesos-1.4.1-1.el7.x86_64 > Marking mesos-1.4.1-1.el7.x86_64.rpm to be installed > Resolving Dependencies > --> Running transaction check > ---> Package mesos.x86_64 0:1.4.1-1.el7 will be installed > --> Processing Dependency: cyrus-sasl-md5 for package: > mesos-1.4.1-1.el7.x86_64 > rhui-microsoft-azure-rhel7 > | 2.9 kB 00:00:00 > rhui-rhel-7-server-dotnet-rhui-debug-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-dotnet-rhui-rpms > | 4.0 kB 00:00:00 > rhui-rhel-7-server-dotnet-rhui-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-debug-rpms > | 3.3 kB 00:00:00 > rhui-rhel-7-server-rhui-extras-debug-rpms > | 3.2 kB 00:00:00 > rhui-rhel-7-server-rhui-extras-rpms > | 3.4 kB 00:00:00 > rhui-rhel-7-server-rhui-extras-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-optional-debug-rpms > | 3.3 kB 00:00:00 > rhui-rhel-7-server-rhui-optional-rpms > | 3.5 kB 00:00:00 > rhui-rhel-7-server-rhui-optional-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-rh-common-debug-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-rh-common-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-rh-common-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-rpms > | 3.5 kB 00:00:00 > rhui-rhel-7-server-rhui-source-rpms > | 3.8 kB 00:00:00 > rhui-rhel-7-server-rhui-supplementary-debug-rpms >
Review Request 63889: Use annotated tags in vote.sh and release.sh.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63889/ --- Review request for mesos, James Peach and Vinod Kone. Repository: mesos Description --- See summary. Diffs - docs/release-guide.md d772bcab189f10096806c4ad52768915fb8c8253 support/release.sh 725bee61175e74d9a53aab9e33df1fa8a1a06361 support/vote.sh e9a2347af2d99ed66cabd57845b56323233f50aa Diff: https://reviews.apache.org/r/63889/diff/1/ Testing --- Thanks, Kapil Arya
Re: Review Request 62166: Updated RC tagging+voting mechanism.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/ --- (Updated Nov. 9, 2017, 6:16 p.m.) Review request for mesos, Anand Mazumdar, Till Toenshoff, Vinod Kone, and Zhitao Li. Changes --- Addressed Vinod's comments. Repository: mesos Description (updated) --- Updated RC tagging+voting mechanism. Diffs (updated) - docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a support/tag.sh 0ff90cb935bd719c6b4bca5c94f48df1ada5ded9 support/vote.sh 98643a1ad4ced0bd18cec6bc4488add9acc229fa Diff: https://reviews.apache.org/r/62166/diff/2/ Changes: https://reviews.apache.org/r/62166/diff/1-2/ Testing --- Used the updated script to tag and vote 1.4.0-rc4. Thanks, Kapil Arya
Re: Review Request 63543: Added bintray publishing scripts.
s.cpp 0e1c8b490ebe10bc50b8b6b530fa85128b967584 src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91 src/tests/scheduler_http_api_tests.cpp 80e52fb22dbba4a0703f1b192205acaff89f883b src/tests/scheduler_tests.cpp 60f60ccd721a5362f827e284f6de6d6e80816ed8 src/tests/slave_recovery_tests.cpp 64bba047c6eaee563126a8bd1c6fa048f18172e1 src/tests/slave_tests.cpp cf2fbac4cc53d632c385eb72adb0d80ef942e8a6 src/uri/fetchers/hadoop.cpp 1c861e88a88e066436774cbd2c0575ffd7de4dd0 src/v1/mesos.cpp 44767b1f87ff5d858df890ef75c77736ba969f94 src/v1/resources.cpp 43d9b0f48c345b4574171cffbd1dc07bda1d1546 src/webui/master/static/js/jquery.pailer.js 6c68383cdb318a4d3c78b499a64f7d66cec85d30 support/apply-review.sh PRE-CREATION support/clang-tidy 47a2cad002a9c2ca41a7e43c4649c5adc6cb0030 support/docker-build.sh 9d69fb54bf177ce515edf4e314dcac23fe960bc2 support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b support/mesos-tidy.sh b7e75f04178b62bde231b4abf9fc0c4aa6f8bcf9 support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 support/mesos-tidy/README.md bfa42733a40489f139e01cf7301e32e7e0617f2c support/mesos-tidy/entrypoint.sh dbea146a882510bda4e5868d8c2ced2e97a36d83 support/packaging/Jenkinsfile abfd59dd225814d459e9b26d5cb35797c7404e0e support/packaging/bintray.sh PRE-CREATION support/packaging/centos/build_rpm.sh 3a7a34715c74610e0088ff96dc18ebe434ad support/post-reviews.py 7e3f0f48f7e9019b68c074eb85c17255a3b4390e support/push-commits.py cd751cbf3c7e64005f1da6c96eb33c6fc62c7ae3 Diff: https://reviews.apache.org/r/63543/diff/2/ Changes: https://reviews.apache.org/r/63543/diff/1-2/ Testing --- CI Job: https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/20/console The failure was due to the upload filesize limits. The script has been updated to not upload debuginfo files (~250MB). Thanks, Kapil Arya
Re: Review Request 63543: Added bintray publishing scripts.
> On Nov. 9, 2017, 12:46 p.m., James Peach wrote: > > support/packaging/Jenkinsfile > > Lines 16 (patched) > > <https://reviews.apache.org/r/63543/diff/1/?file=1879887#file1879887line16> > > > > Is `sh -x foo.sh arg` the same as `sh foo.sh arg`? The `-x` was to make shell output verbose -- removed that now. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190618 ------- On Nov. 9, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63543/ > --- > > (Updated Nov. 9, 2017, 2:02 p.m.) > > > Review request for mesos, James Peach and Till Toenshoff. > > > Bugs: MESOS-7985 > https://issues.apache.org/jira/browse/MESOS-7985 > > > Repository: mesos > > > Description > --- > > Added bintray publishing scripts. > > > Diffs > - > > 3rdparty/CMakeLists.txt 7d38a9cba84b86e1e428033ade1bd0ab5d9eaae7 > 3rdparty/README.md a441ac084a6e817573a903409024c6877016af64 > 3rdparty/cmake/Versions.cmake da2d837e327535c793f20929e8c6e9ddaf5ca54a > 3rdparty/concurrentqueue-1.0.0-beta.tar.gz PRE-CREATION > 3rdparty/concurrentqueue-7b69a8f.tar.gz > 63dc94a40aea4f247197b0196483fdf3bc59c7fe > 3rdparty/concurrentqueue.md 1c356216caab2e0e50ebbf55fcc72c213e77799e > 3rdparty/libprocess/include/process/event.hpp > 571ffb1ea5c4787f10c2f4dee249aadc8b904bc6 > 3rdparty/libprocess/include/process/owned.hpp > cc149e78165d42f1243168c34fc64fd121c6c83f > 3rdparty/libprocess/include/process/process.hpp > d88c2f241a04cac3ec2e1d9fd4b323643ad24ae4 > 3rdparty/libprocess/include/process/protobuf.hpp > 5b9794f43fdc93aa3db5c03d614e961a7011a02b > 3rdparty/libprocess/include/process/shared.hpp > 6eb69439d21897398157b2d400a00c49ea720e68 > 3rdparty/libprocess/src/http.cpp 8f95878824210229444ab7e0d2bdc6106c032444 > 3rdparty/libprocess/src/process.cpp > 732aff86bb6f4c56d4eec7107b2cc2aff139c06a > 3rdparty/libprocess/src/tests/benchmarks.cpp > 2c6de626c3fdf5ebd3a7aa5793553215c42dd494 > 3rdparty/libprocess/src/tests/owned_tests.cpp > f82969397b40ad2c8e41ecd682b577ed31b10da7 > 3rdparty/libprocess/src/tests/process_tests.cpp > d1b30b0754c55fd765885ddcfe9f9f68ba509ac1 > 3rdparty/libprocess/src/tests/shared_tests.cpp > 9bb291eeddcf6561c517c6a909bec7c1a99d909c > 3rdparty/versions.am 2fc2f2c3932ff86c348d954bd4d78aa5c75bb052 > CHANGELOG 3d650322aac94ad7dfad9f0161ed589f589b316f > bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c > cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 > docs/app-framework-development-guide.md > e31bffc78daffa9f82ecf5361f91281354f9e466 > docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8 > docs/cni.md c45ce2756df0a8a885738baff45f2323ecfa895e > docs/configuration/agent.md f1e0681be34d194d66e2b2ecd3f76653a54068e2 > docs/configuration/cmake.md 5364b1e0398e8e774c89993bd7404c32abe3bedc > docs/isolators/network-port-mapping.md > 250aa87bb93b1cb8dd04746e121dc1126877fba9 > docs/isolators/network-ports.md ea63968481ce52c46e0a98e242da49baf6962009 > docs/mesos-containerizer.md a194eb05703650dbce6b9e2fb84c9ff4aa9d9522 > docs/nested-container-and-task-group.md > 002636660390e06e2ac23b21e85b9fe3c1c5c4b5 > docs/powered-by-mesos.md 2dd0a328a3e5481d0d6d7639c1d8251162dc19c7 > docs/scheduler-http-api.md 3929c33781a152428338c4cdaf7dbc47da7c875e > docs/upgrades.md 0e4015ac9019b018b29f706790124ad22d8ee87d > docs/working-groups.md df6f0506df9917a567b88b13a07e8805ec38fc12 > include/mesos/allocator/allocator.hpp > ae122003487ca8956573e993cd3993aa8cc286f1 > include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 > include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60 > include/mesos/scheduler/scheduler.proto > f5dda10a076ecae53a56875d0ed4d201a1c92f12 > include/mesos/slave/containerizer.hpp > c34f1296586ea5d26619605f8f6a5ae9444f1a96 > include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 > include/mesos/v1/mesos.hpp 26b4596024f4da987e73efb1cfc03ff97bd2fc5d > include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e > include/mesos/v1/resources.hpp d59fa35d1bcdab30258fd31e483ec6b45578f470 > include/mesos/v1/scheduler/scheduler.proto > 4fa6606b0db701aebe208b962b7768da68b180ab > site/source/blog/2014-03-28-me
Review Request 63543: Added bintray publishing scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/ --- Review request for mesos, James Peach and Till Toenshoff. Bugs: MESOS-7985 https://issues.apache.org/jira/browse/MESOS-7985 Repository: mesos Description --- See summary. Diffs - support/packaging/Jenkinsfile abfd59dd225814d459e9b26d5cb35797c7404e0e support/packaging/bintray.sh PRE-CREATION support/packaging/centos/build_rpm.sh 3a7a34715c74610e0088ff96dc18ebe434ad Diff: https://reviews.apache.org/r/63543/diff/1/ Testing --- CI Job: https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/20/console The failure was due to the upload filesize limits. The script has been updated to not upload debuginfo files (~250MB). Thanks, Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Oct. 30, 2017, 1:49 p.m.) Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. Changes --- Replaced `slave` with `agent` in helper files. Bugs: MESOS-7982 https://issues.apache.org/jira/browse/MESOS-7982 Repository: mesos Description --- Binary packaging for Centos 7. Diffs (updated) - support/packaging/Jenkinsfile PRE-CREATION support/packaging/centos/build_rpm.sh PRE-CREATION support/packaging/centos/centos6.dockerfile PRE-CREATION support/packaging/centos/centos7.dockerfile PRE-CREATION support/packaging/centos/mesos.spec PRE-CREATION support/packaging/common/mesos PRE-CREATION support/packaging/common/mesos-init-wrapper PRE-CREATION support/packaging/common/mesos-master PRE-CREATION support/packaging/common/mesos-master.service PRE-CREATION support/packaging/common/mesos-master.upstart PRE-CREATION support/packaging/common/mesos-slave PRE-CREATION support/packaging/common/mesos-slave.service PRE-CREATION support/packaging/common/mesos-slave.upstart PRE-CREATION Diff: https://reviews.apache.org/r/62616/diff/4/ Changes: https://reviews.apache.org/r/62616/diff/3-4/ Testing --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Building a package locally: 1. cd 2. (Or use mesos/packaging:centos7). docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos 3. mkdir .m2 4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm RPMs will be placed inside /centos7/rpmbuild/RPMs/x86_64 directory. If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree. Thanks, Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Oct. 13, 2017, 2:21 p.m.) Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. Bugs: MESOS-7982 https://issues.apache.org/jira/browse/MESOS-7982 Repository: mesos Description --- Binary packaging for Centos 7. Diffs - support/packaging/Jenkinsfile PRE-CREATION support/packaging/centos/build_rpm.sh PRE-CREATION support/packaging/centos/centos6.dockerfile PRE-CREATION support/packaging/centos/centos7.dockerfile PRE-CREATION support/packaging/centos/mesos.spec PRE-CREATION support/packaging/common/mesos PRE-CREATION support/packaging/common/mesos-init-wrapper PRE-CREATION support/packaging/common/mesos-master PRE-CREATION support/packaging/common/mesos-master.service PRE-CREATION support/packaging/common/mesos-master.upstart PRE-CREATION support/packaging/common/mesos-slave PRE-CREATION support/packaging/common/mesos-slave.service PRE-CREATION support/packaging/common/mesos-slave.upstart PRE-CREATION Diff: https://reviews.apache.org/r/62616/diff/3/ Testing (updated) --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Building a package locally: 1. cd 2. (Or use mesos/packaging:centos7). docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos 3. mkdir .m2 4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm RPMs will be placed inside /centos7/rpmbuild/RPMs/x86_64 directory. If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree. Thanks, Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
> On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote: > > support/packaging/common/mesos-master.service > > Lines 7 (patched) > > <https://reviews.apache.org/r/62616/diff/2/?file=1837912#file1837912line7> > > > > If this is to be common for all packaging, probably it should be > > `mesos-master.service.in` and use `@BINDIR@` instead of `/usr/bin`. (same > > comment applies for the other files under `packaging/common/`) I'm not sure about this. But we can always do it in the second round. I just tried to replicate what we already had for packages generated by Mesosphere. > On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote: > > support/packaging/common/mesos-slave > > Lines 1 (patched) > > <https://reviews.apache.org/r/62616/diff/2/?file=1837914#file1837914line1> > > > > Should this be `ZK` instead of `MASTER`? And do we need a check here if > > mesos was compiled with support for zookeeper? I think we are compiling Mesos with ZK support by default. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review187282 --- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > --- > > (Updated Oct. 13, 2017, 2:02 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7982 > https://issues.apache.org/jira/browse/MESOS-7982 > > > Repository: mesos > > > Description > --- > > Binary packaging for Centos 7. > > > Diffs > - > > support/packaging/Jenkinsfile PRE-CREATION > support/packaging/centos/build_rpm.sh PRE-CREATION > support/packaging/centos/centos6.dockerfile PRE-CREATION > support/packaging/centos/centos7.dockerfile PRE-CREATION > support/packaging/centos/mesos.spec PRE-CREATION > support/packaging/common/mesos PRE-CREATION > support/packaging/common/mesos-init-wrapper PRE-CREATION > support/packaging/common/mesos-master PRE-CREATION > support/packaging/common/mesos-master.service PRE-CREATION > support/packaging/common/mesos-master.upstart PRE-CREATION > support/packaging/common/mesos-slave PRE-CREATION > support/packaging/common/mesos-slave.service PRE-CREATION > support/packaging/common/mesos-slave.upstart PRE-CREATION > > > Diff: https://reviews.apache.org/r/62616/diff/3/ > > > Testing > --- > > The scripts have been tested on an internal Jenkins CI. A buildjob on ASF > Jenkins CI is available at > https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. > > > Thanks, > > Kapil Arya > >
Re: Review Request 62616: Binary packaging for Centos 7.
> On Oct. 3, 2017, 12:57 p.m., James Peach wrote: > > support/packaging/centos/7/mesos.spec > > Lines 33 (patched) > > <https://reviews.apache.org/r/62616/diff/2/?file=1837908#file1837908line33> > > > > Handling the SVN dependency is a bit quirky. If you do what you have > > done here, you end up building against a more recent libsubversion than the > > one available in the distribution. Everything will appear to work due to > > lazy symbol binding, but (I think) that Aurora users will use the registry > > diff APIs that will trigger binding for the missing symbols. I have modified it to specify a version. Do you think it's acceptable now? - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186971 ------- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > --- > > (Updated Oct. 13, 2017, 2:02 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7982 > https://issues.apache.org/jira/browse/MESOS-7982 > > > Repository: mesos > > > Description > --- > > Binary packaging for Centos 7. > > > Diffs > - > > support/packaging/Jenkinsfile PRE-CREATION > support/packaging/centos/build_rpm.sh PRE-CREATION > support/packaging/centos/centos6.dockerfile PRE-CREATION > support/packaging/centos/centos7.dockerfile PRE-CREATION > support/packaging/centos/mesos.spec PRE-CREATION > support/packaging/common/mesos PRE-CREATION > support/packaging/common/mesos-init-wrapper PRE-CREATION > support/packaging/common/mesos-master PRE-CREATION > support/packaging/common/mesos-master.service PRE-CREATION > support/packaging/common/mesos-master.upstart PRE-CREATION > support/packaging/common/mesos-slave PRE-CREATION > support/packaging/common/mesos-slave.service PRE-CREATION > support/packaging/common/mesos-slave.upstart PRE-CREATION > > > Diff: https://reviews.apache.org/r/62616/diff/3/ > > > Testing > --- > > The scripts have been tested on an internal Jenkins CI. A buildjob on ASF > Jenkins CI is available at > https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. > > > Thanks, > > Kapil Arya > >
Re: Review Request 62616: Binary packaging for Centos 7.
> On Oct. 3, 2017, 12:54 p.m., James Peach wrote: > > I accidentally made most of my comments on the CentOS6 spec file, but they > > apply to the CentOS7 one too. I'm not sure how tractable it is to use the > > same spec file for both platforms, but combining them would be helpful if > > you can make the RPM conditionals work for you. > > > > Finally, since I think this is intended to be a general-purpose package, we > > should enable all the optional compile-time features to broaden the set of > > users who can consume these packages. Thanks for the tips, James! I have now addressed most of your issues and have added some response for the others. Please take a look and let me know if we can make it better. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186959 ------- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > --- > > (Updated Oct. 13, 2017, 2:02 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7982 > https://issues.apache.org/jira/browse/MESOS-7982 > > > Repository: mesos > > > Description > --- > > Binary packaging for Centos 7. > > > Diffs > - > > support/packaging/Jenkinsfile PRE-CREATION > support/packaging/centos/build_rpm.sh PRE-CREATION > support/packaging/centos/centos6.dockerfile PRE-CREATION > support/packaging/centos/centos7.dockerfile PRE-CREATION > support/packaging/centos/mesos.spec PRE-CREATION > support/packaging/common/mesos PRE-CREATION > support/packaging/common/mesos-init-wrapper PRE-CREATION > support/packaging/common/mesos-master PRE-CREATION > support/packaging/common/mesos-master.service PRE-CREATION > support/packaging/common/mesos-master.upstart PRE-CREATION > support/packaging/common/mesos-slave PRE-CREATION > support/packaging/common/mesos-slave.service PRE-CREATION > support/packaging/common/mesos-slave.upstart PRE-CREATION > > > Diff: https://reviews.apache.org/r/62616/diff/3/ > > > Testing > --- > > The scripts have been tested on an internal Jenkins CI. A buildjob on ASF > Jenkins CI is available at > https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. > > > Thanks, > > Kapil Arya > >
Re: Review Request 62616: Binary packaging for Centos 7.
> On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote: > > Thanks for the comments, Jie! The updated scripts allow for building from a local tree from a command line. I'd add a README shortly. > On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote: > > support/packaging/centos/6/Dockerfile > > Lines 5 (patched) > > <https://reviews.apache.org/r/62616/diff/2/?file=1837905#file1837905line5> > > > > This is more like dev packages (used for development and building > > Mesos). > > > > I think we probably need to types of Docker images: > > 1) dev image like you have here > > 2) images that are used for running Mesos > > > > For 2), we don't need to pull in dependencies for building Mesos. We > > only need the dependencies for running Mesos. And that dependencies will be > > included automatically by RPM. So the Dockerfile can be as simple as a > > single yum install. These docker images are for building rpms only. Once the RPM is there, we can just have a simple docker file that adds the repo and install the rpm package inside it. But I think that is stage 2 and orthogonal to this RR. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186855 --- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > --- > > (Updated Oct. 13, 2017, 2:02 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7982 > https://issues.apache.org/jira/browse/MESOS-7982 > > > Repository: mesos > > > Description > --- > > Binary packaging for Centos 7. > > > Diffs > - > > support/packaging/Jenkinsfile PRE-CREATION > support/packaging/centos/build_rpm.sh PRE-CREATION > support/packaging/centos/centos6.dockerfile PRE-CREATION > support/packaging/centos/centos7.dockerfile PRE-CREATION > support/packaging/centos/mesos.spec PRE-CREATION > support/packaging/common/mesos PRE-CREATION > support/packaging/common/mesos-init-wrapper PRE-CREATION > support/packaging/common/mesos-master PRE-CREATION > support/packaging/common/mesos-master.service PRE-CREATION > support/packaging/common/mesos-master.upstart PRE-CREATION > support/packaging/common/mesos-slave PRE-CREATION > support/packaging/common/mesos-slave.service PRE-CREATION > support/packaging/common/mesos-slave.upstart PRE-CREATION > > > Diff: https://reviews.apache.org/r/62616/diff/3/ > > > Testing > --- > > The scripts have been tested on an internal Jenkins CI. A buildjob on ASF > Jenkins CI is available at > https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. > > > Thanks, > > Kapil Arya > >
Re: Review Request 62616: Binary packaging for Centos 7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Oct. 13, 2017, 2:02 p.m.) Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. Changes --- Addressed most of Jie and James's comments. Bugs: MESOS-7982 https://issues.apache.org/jira/browse/MESOS-7982 Repository: mesos Description --- Binary packaging for Centos 7. Diffs (updated) - support/packaging/Jenkinsfile PRE-CREATION support/packaging/centos/build_rpm.sh PRE-CREATION support/packaging/centos/centos6.dockerfile PRE-CREATION support/packaging/centos/centos7.dockerfile PRE-CREATION support/packaging/centos/mesos.spec PRE-CREATION support/packaging/common/mesos PRE-CREATION support/packaging/common/mesos-init-wrapper PRE-CREATION support/packaging/common/mesos-master PRE-CREATION support/packaging/common/mesos-master.service PRE-CREATION support/packaging/common/mesos-master.upstart PRE-CREATION support/packaging/common/mesos-slave PRE-CREATION support/packaging/common/mesos-slave.service PRE-CREATION support/packaging/common/mesos-slave.upstart PRE-CREATION Diff: https://reviews.apache.org/r/62616/diff/3/ Changes: https://reviews.apache.org/r/62616/diff/2-3/ Testing --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya
Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186991 --- Ship it! So is the idea to turn on this flag for ASF CI builds? - Kapil Arya On Sept. 28, 2017, 7:37 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62661/ > --- > > (Updated Sept. 28, 2017, 7:37 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kapil > Arya. > > > Bugs: MESOS-7500 > https://issues.apache.org/jira/browse/MESOS-7500 > > > Repository: mesos > > > Description > --- > > This flag is used to force libtool to generate executables instead of > wrapper scripts. A wrapper script might trigger relinking, which takes > quite a while on slow machines, thus causing failure of tests. > > > Diffs > - > > configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > > > Diff: https://reviews.apache.org/r/62661/diff/4/ > > > Testing > --- > > 1. sudo make check (fedora) > 2. Apache CI (centos 7, ubuntu 14.04) > > > Thanks, > > Andrei Budnik > >
Re: Review Request 62616: Binary packaging for Centos 7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Sept. 27, 2017, 5:50 p.m.) Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. Changes --- Removed unused build.sh files. Summary (updated) - Binary packaging for Centos 7. Bugs: MESOS-7982 https://issues.apache.org/jira/browse/MESOS-7982 Repository: mesos Description (updated) --- Binary packaging for Centos 7. Diffs (updated) - support/packaging/Jenkinsfile PRE-CREATION support/packaging/centos/6/Dockerfile PRE-CREATION support/packaging/centos/6/mesos.spec PRE-CREATION support/packaging/centos/7/Dockerfile PRE-CREATION support/packaging/centos/7/mesos.spec PRE-CREATION support/packaging/common/mesos PRE-CREATION support/packaging/common/mesos-init-wrapper PRE-CREATION support/packaging/common/mesos-master PRE-CREATION support/packaging/common/mesos-master.service PRE-CREATION support/packaging/common/mesos-master.upstart PRE-CREATION support/packaging/common/mesos-slave PRE-CREATION support/packaging/common/mesos-slave.service PRE-CREATION support/packaging/common/mesos-slave.upstart PRE-CREATION Diff: https://reviews.apache.org/r/62616/diff/2/ Changes: https://reviews.apache.org/r/62616/diff/1-2/ Testing --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya
Re: Review Request 62616: [WIP] Binary packaging for CentOS.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Sept. 27, 2017, 9:09 a.m.) Review request for mesos, Till Toenshoff and Vinod Kone. Summary (updated) - [WIP] Binary packaging for CentOS. Bugs: MESOS-7982 https://issues.apache.org/jira/browse/MESOS-7982 Repository: mesos Description --- This patch adds helper files to allow one to generate CentOS 6/7 rpm packages. Diffs - support/packaging/Jenkinsfile PRE-CREATION support/packaging/build.sh PRE-CREATION support/packaging/centos/6/Dockerfile PRE-CREATION support/packaging/centos/6/build.sh PRE-CREATION support/packaging/centos/6/mesos.spec PRE-CREATION support/packaging/centos/7/Dockerfile PRE-CREATION support/packaging/centos/7/build.sh PRE-CREATION support/packaging/centos/7/mesos.spec PRE-CREATION support/packaging/common/mesos PRE-CREATION support/packaging/common/mesos-init-wrapper PRE-CREATION support/packaging/common/mesos-master PRE-CREATION support/packaging/common/mesos-master.service PRE-CREATION support/packaging/common/mesos-master.upstart PRE-CREATION support/packaging/common/mesos-slave PRE-CREATION support/packaging/common/mesos-slave.service PRE-CREATION support/packaging/common/mesos-slave.upstart PRE-CREATION Diff: https://reviews.apache.org/r/62616/diff/1/ Testing --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya
Review Request 62616: [WIP] Binary packaging for Centos 7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Bugs: MESOS-7982 https://issues.apache.org/jira/browse/MESOS-7982 Repository: mesos Description --- This patch adds helper files to allow one to generate CentOS 6/7 rpm packages. Diffs - support/packaging/Jenkinsfile PRE-CREATION support/packaging/build.sh PRE-CREATION support/packaging/centos/6/Dockerfile PRE-CREATION support/packaging/centos/6/build.sh PRE-CREATION support/packaging/centos/6/mesos.spec PRE-CREATION support/packaging/centos/7/Dockerfile PRE-CREATION support/packaging/centos/7/build.sh PRE-CREATION support/packaging/centos/7/mesos.spec PRE-CREATION support/packaging/common/mesos PRE-CREATION support/packaging/common/mesos-init-wrapper PRE-CREATION support/packaging/common/mesos-master PRE-CREATION support/packaging/common/mesos-master.service PRE-CREATION support/packaging/common/mesos-master.upstart PRE-CREATION support/packaging/common/mesos-slave PRE-CREATION support/packaging/common/mesos-slave.service PRE-CREATION support/packaging/common/mesos-slave.upstart PRE-CREATION Diff: https://reviews.apache.org/r/62616/diff/1/ Testing --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya
Re: Review Request 62358: Replaced xlocale.h with locale.h.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62358/ --- (Updated Sept. 15, 2017, 2:10 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-7980 https://issues.apache.org/jira/browse/MESOS-7980 Repository: mesos Description --- As of glibc 2.26, xlocale.h has been removed as this was never supposed to be used directly by user programs. They should be including locale.h instead. Diffs - 3rdparty/stout/include/stout/jsonify.hpp 06b18e27672c45a1d6ab93e4595419200c590ae4 Diff: https://reviews.apache.org/r/62358/diff/1/ Testing (updated) --- make with glibc 2.26. Thanks, Kapil Arya
Review Request 62358: Replaced xlocale.h with locale.h.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62358/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-7980 https://issues.apache.org/jira/browse/MESOS-7980 Repository: mesos Description --- As of glibc 2.26, xlocale.h has been removed as this was never supposed to be used directly by user programs. They should be including locale.h instead. Diffs - 3rdparty/stout/include/stout/jsonify.hpp 06b18e27672c45a1d6ab93e4595419200c590ae4 Diff: https://reviews.apache.org/r/62358/diff/1/ Testing --- make check with glibc 2.26. Thanks, Kapil Arya
Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62253/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7969 https://issues.apache.org/jira/browse/MESOS-7969 Repository: mesos Description --- Cgroups v2 hierarchies don't list the "controllers" field (e.g., "0::/user.slice/user-1000.slice/session-5.scope) is empty and hence the cgroup parser failes. We should simply skip over fields with empty controller field. Diffs - src/linux/cgroups.cpp 95c81d90f956e11d23e965dd0d0b83a66220d858 Diff: https://reviews.apache.org/r/62253/diff/1/ Testing --- make check on Fedora 26. Thanks, Kapil Arya
Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62254/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7968 https://issues.apache.org/jira/browse/MESOS-7968 Repository: mesos Description --- Since Linux 4.12, /proc/self/ns/pid_for_children is a handle for the PID namespace of child processes created by this process. Since this is not a namespace type in its own, we should ignore this file when listing namespaces via `ls /proc/self/ns`. Diffs - src/linux/ns.hpp f1792e854e3fb40321a6ad3f7d1f0f9fbd03761a Diff: https://reviews.apache.org/r/62254/diff/1/ Testing --- make check on Fedora 26. Thanks, Kapil Arya
Review Request 62166: Updated RC tagging+voting mechanism.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/ --- Review request for mesos, Anand Mazumdar, Till Toenshoff, Vinod Kone, and Zhitao Li. Repository: mesos Description --- * Stop "releasing" maven artifacts for RC tags. The artificats should only be placed in the staging repository for voting. Once the vote has passed, the staging repository should be released. If the vote fails, the staging repository should be dropped. * tag.sh and vote.sh scripts have been unified into rc_tag_vote.sh script. * Updated tagging/voting instructions in release guide. Diffs - docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a support/tag.sh 0ff90cb935bd719c6b4bca5c94f48df1ada5ded9 support/vote.sh 98643a1ad4ced0bd18cec6bc4488add9acc229fa Diff: https://reviews.apache.org/r/62166/diff/1/ Testing --- Used the updated script to tag and vote 1.4.0-rc4. Thanks, Kapil Arya
Re: Review Request 61725: Added secrets docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 1:29 p.m.) Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff. Bugs: MESOS-7418 https://issues.apache.org/jira/browse/MESOS-7418 Repository: mesos Description --- Added secrets docs. Diffs - docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca docs/secrets.md PRE-CREATION Diff: https://reviews.apache.org/r/61725/diff/4/ Testing --- ./mesos-website-dev.sh Thanks, Kapil Arya
Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/ --- (Updated Aug. 18, 2017, 1:28 p.m.) Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos Description --- Synchronized comment in v1 and unversioned master.proto. Diffs - include/mesos/v1/master/master.proto c3fb31de2509adcdec8204f8bbe46b46a31540e8 Diff: https://reviews.apache.org/r/61733/diff/1/ Testing --- Thanks, Kapil Arya
Review Request 61745: Fixed capitalization and typos in endpoint helps.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61745/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --- Fixed capitalization and typos in endpoint helps. Diffs - src/master/http.cpp 959091c8ec03b6ac7bcb5d21b04d2f7d5aff7d54 src/slave/http.cpp 544a052b8b2c3e70d2d109f3ec4fe6a4ca4a05ee Diff: https://reviews.apache.org/r/61745/diff/1/ Testing --- Thanks, Kapil Arya
Re: Review Request 61732: Updated endpoints help.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61732/ --- (Updated Aug. 18, 2017, 1:24 p.m.) Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos Description --- Updated endpoints help. Diffs (updated) - docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb docs/endpoints/master/frameworks.md 1a7950a935c6ad7b23798e55f65f08d7db671135 docs/endpoints/master/slaves.md f9bb7ef8dfa007a98fa64e00c7ad8fbfb32ea901 docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION Diff: https://reviews.apache.org/r/61732/diff/3/ Changes: https://reviews.apache.org/r/61732/diff/2-3/ Testing --- Thanks, Kapil Arya
Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.
> On Aug. 18, 2017, 12:47 p.m., Till Toenshoff wrote: > > include/mesos/v1/master/master.proto > > Line 362 (original), 362 (patched) > > <https://reviews.apache.org/r/61733/diff/1/?file=1799983#file1799983line362> > > > > Is there any documentation around our deprecation cycles? > > I kind of understand that these pubic promises should be handled with > > very long deprecation but why a 2.0 and not a 1.2 + N (e.g. 3). We need to > > be clear and have this publically documented I believe. > > > > If there was no JIRA around it, we should create one. Dropping the issues since the RR just syncs the two files. We should file a separate JIRA to fix those. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/#review183228 ------- On Aug. 18, 2017, 9:32 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61733/ > --- > > (Updated Aug. 18, 2017, 9:32 a.m.) > > > Review request for mesos, Anand Mazumdar and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Synchronized comment in v1 and unversioned master.proto. > > > Diffs > - > > include/mesos/v1/master/master.proto > c3fb31de2509adcdec8204f8bbe46b46a31540e8 > > > Diff: https://reviews.apache.org/r/61733/diff/1/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 61725: Added secrets docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 11:46 a.m.) Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff. Bugs: MESOS-7418 https://issues.apache.org/jira/browse/MESOS-7418 Repository: mesos Description --- Added secrets docs. Diffs - docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca docs/secrets.md PRE-CREATION Diff: https://reviews.apache.org/r/61725/diff/4/ Testing (updated) --- ./mesos-website-dev.sh Thanks, Kapil Arya
Re: Review Request 61725: Added secrets docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 11:45 a.m.) Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff. Bugs: MESOS-7418 https://issues.apache.org/jira/browse/MESOS-7418 Repository: mesos Description --- Added secrets docs. Diffs (updated) - docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca docs/secrets.md PRE-CREATION Diff: https://reviews.apache.org/r/61725/diff/4/ Changes: https://reviews.apache.org/r/61725/diff/3-4/ Testing --- Thanks, Kapil Arya
Re: Review Request 61735: Removed diacritics from docs/health-checks.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61735/#review183217 --- Ship it! Ship It! - Kapil Arya On Aug. 18, 2017, 10:41 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61735/ > --- > > (Updated Aug. 18, 2017, 10:41 a.m.) > > > Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Kapil Arya. > > > Repository: mesos > > > Description > --- > > see summary. > > > Diffs > - > > docs/health-checks.md 41fc4f8f224115d9a1d634aa0a775a9d01b4e938 > > > Diff: https://reviews.apache.org/r/61735/diff/1/ > > > Testing > --- > > site/mesos-website-dev.sh > > > Thanks, > > Till Toenshoff > >
