Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48265/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco Durai

Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, Sandor

Re: Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48265/#review136231 --- ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/

Re: Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48265/ --- (Updated June 6, 2016, 10:42 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Dmitro Lisnichenko
> On June 3, 2016, 8:16 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml, > > line 32 > > > > > > Why are these mandatory property attributes

Re: Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48265/#review136235 --- Ship it! Ship It! - Oliver Szabo On June 6, 2016, 10:42 a.m.

Re: Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48265/#review136237 --- Ship it! Ship It! - Miklos Gergely On June 6, 2016, 10:42 a.

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136238 --- Ship it! Ship It! - Tim Thorpe On June 3, 2016, 10:47 p.m.,

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136242 --- Ship it! Ship It! - Di Li On June 3, 2016, 10:47 p.m., Aleja

Review Request 48274: Show better error message when VIEW USER can not access CAPACITY SCHEDULER View

2016-06-06 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48274/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshth

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136240 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/servi

Review Request 48276: View config-Custom views are not working after kerberization

2016-06-06 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48276/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshth

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136244 --- ambari-server/src/main/java/org/apache/ambari/server/topology/Top

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136245 --- ambari-server/src/main/java/org/apache/ambari/server/topology/Top

Re: Review Request 48276: View config-Custom views are not working after kerberization

2016-06-06 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48276/#review136249 --- Ship it! Ship It! - Nitiraj Rathore On June 6, 2016, 12:47 p

Review Request 48278: Service stop/start fail after Ambari upgrade due to missing config parameters

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48278/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-17059 https:

Review Request 48279: Visual explain unit tests

2016-06-06 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48279/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.

Re: Review Request 48278: Service stop/start fail after Ambari upgrade due to missing config parameters

2016-06-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48278/#review136256 --- Ship it! Ship It! - Dmitro Lisnichenko On June 6, 2016, 5:14

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 6, 2016, 2:48 p.m.) Review request for Ambari, Andrew Onischuk, O

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
> On June 2, 2016, 4:23 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 129 > > > > > > This cannot assume the directory will be /us

Review Request 48281: [ambari] ambari-agent restart is failing due to unsupported locale setting

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48281/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-17061 https:

Re: Review Request 48281: [ambari] ambari-agent restart is failing due to unsupported locale setting

2016-06-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48281/#review136263 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 6, 2016, 2

Re: Review Request 48281: [ambari] ambari-agent restart is failing due to unsupported locale setting

2016-06-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48281/#review136264 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 6, 2016, 2

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 6, 2016, 3 p.m.) Review request for Ambari, Andrew Onischuk, Oliv

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 6, 2016, 3:01 p.m.) Review request for Ambari, Andrew Onischuk, O

Re: Review Request 48274: Show better error message when VIEW USER can not access CAPACITY SCHEDULER View

2016-06-06 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48274/#review136269 --- Ship it! Ship It! - Nitiraj Rathore On June 6, 2016, 12:23 p

Re: Review Request 48274: Show better error message when VIEW USER can not access CAPACITY SCHEDULER View

2016-06-06 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48274/#review136270 --- Ship it! Ship It! - Nitiraj Rathore On June 6, 2016, 12:23 p

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 6, 2016, 3:15 p.m.) Review request for Ambari, Andrew Onischuk, O

Review Request 48282: YARN service check fails if there is no queue named "default"

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48282/ --- Review request for Ambari and Dmytro Sen. Bugs: AMBARI-15557 https://issues

Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-06 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48273/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Srimanth Guntur

Review Request 48283: Namenode failed to start while installing a cluster from UI

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48283/ --- Review request for Ambari and Dmytro Sen. Bugs: AMBARI-17062 https://issues

Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48284/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-17063 https:

Re: Review Request 48283: Namenode failed to start while installing a cluster from UI

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48283/#review136274 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 3:31 п.п., A

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/ --- (Updated June 6, 2016, 4:04 p.m.) Review request for Ambari and Dmitro Lisniche

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/ --- (Updated June 6, 2016, 4:13 p.m.) Review request for Ambari and Dmitro Lisniche

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Sumit Mohanty
> On June 3, 2016, 8:15 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 290 > > > > > > Restarting is dangerous to do, especially if it happens during > > kerberiza

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
> On June 3, 2016, 8:15 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 290 > > > > > > Restarting is dangerous to do, especially if it happens during > > kerberiza

Re: Review Request 48282: YARN service check fails if there is no queue named "default"

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48282/#review136282 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 3:18 п.п., A

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136283 --- ambari-agent/conf/unix/ambari-agent.ini (line 37)

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/ --- (Updated June 6, 2016, 4:29 p.m.) Review request for Ambari and Dmitro Lisniche

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
> On June 6, 2016, 4:21 p.m., Sumit Mohanty wrote: > > ambari-agent/conf/unix/ambari-agent.ini, line 37 > > > > > > Whats the default behavior - looks like by default it should be > > disabled. > > > > What

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#review136288 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 6:26 д.п., Q

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#review136289 --- Ship it! Ship It! - Aravindan Vijayan On June 6, 2016, 6:26

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136291 --- Ship it! Ship It! - Sumit Mohanty On June 6, 2016, 4:29 p.m.

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/ --- (Updated June 6, 2016, 4:43 p.m.) Review request for Ambari and Dmitro Lisniche

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136298 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 6, 2016, 4

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Dmytro Sen
> On Июнь 6, 2016, 4:32 п.п., Dmytro Sen wrote: > > Ship It! Committed to trunk and branch-2.4. Please close this review board - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Qin Liu
> On June 6, 2016, 4:32 p.m., Dmytro Sen wrote: > > Ship It! > > Dmytro Sen wrote: > Committed to trunk and branch-2.4. > Please close this review board Thank you so much Dmytro! - Qin --- This is an automatically generated e-m

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Qin Liu
> On June 6, 2016, 4:34 p.m., Aravindan Vijayan wrote: > > Ship It! Thank you so much Aravindan! - Qin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#review136289

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48284/#review136310 --- ambari-server/src/main/java/org/apache/ambari/server/controller/j

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/ --- (Updated June 6, 2016, 8:20 p.m.) Review request for Ambari, Jonathan Hurley an

Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-17068

Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48288/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Srimanth Gunturi,

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Lav Jain
> On June 6, 2016, 12:43 p.m., Tim Thorpe wrote: > > ambari-server/src/main/resources/stacks/service_advisor.py, line 67 > > > > > > I originally had implemented the service advisor like this. I had > > modified it

Re: Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48288/ --- (Updated June 6, 2016, 5:30 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136319 --- I only see two changes here, and it's just logging. Was there som

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48273/#review136305 --- ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 5:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. no, as you can see, self.status(env) would be skipped and this is goal of t

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? Same - only 2 changes and they are for logging. - Jonathan --- This is an automatically generated

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-06 Thread Nahappan Somasundaram
> On June 2, 2016, 7:42 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/RecoveryManager.py, lines 323-334 > > > > > > This logic is getting a bit "if-elsy". Perhaps a state machine might be

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-06 Thread Jonathan Hurley
> On June 2, 2016, 10:42 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/RecoveryManager.py, lines 323-334 > > > > > > This logic is getting a bit "if-elsy". Perhaps a state machine might b

Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/ --- Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, and

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no, as you can see, self.status(env) would

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no, as you can see, self.status(env) would

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136331 --- Ship it! ambari-common/src/main/python/resource_management/lib

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/#review136330 --- Fix it, then Ship it! Any screenshots on the Jira? ambari-web

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 5:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no, as you can see, self.status(env) would

Re: Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48288/#review136333 --- Fix it, then Ship it! contrib/management-packs/microsoft-r_mpa

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 6:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > > > > > I know this isn't a part of your change - but can

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review136336 --- Fix it, then Ship it! ambari-common/src/main/python/resource_m

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/ --- (Updated June 6, 2016, 6:22 p.m.) Review request for Ambari, Ajit Kumar, Jaimin

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/ --- (Updated June 6, 2016, 6:40 p.m.) Review request for Ambari, Alexander Denissov

Re: Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48242/#review136341 --- Ship it! Thank you for making this change Richard - Alejandro

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136342 --- Ship it! Ship It! - Alejandro Fernandez On June 6, 2016, 6:4

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136343 --- Ship it! Ship It! - Tim Thorpe On June 6, 2016, 6:40 p.m., L

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136344 --- Ship it! Ship It! - Matt On June 6, 2016, 11:40 a.m., Lav Ja

Review Request 48290: Change HAWQ DFS Url from hawq_default to hawq_data

2016-06-06 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48290/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136347 --- Ship it! Ship It! - Nate Cole On June 6, 2016, 1:20 p.m., Dm

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 2:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > > > > > I know this isn't a part of your change - but can

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/ --- (Updated June 6, 2016, 8:04 p.m.) Review request for Ambari, Andrew Onischuk, D

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Alejandro Fernandez
> On June 3, 2016, 11:34 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py, > > line 94 > > > > > > How could upgrade_type be None in

Re: Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"

2016-06-06 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48242/ --- (Updated June 6, 2016, 8:29 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48290: Change HAWQ DFS Url from hawq_default to hawq_data

2016-06-06 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48290/#review136358 --- Ship it! Ship It! - Alexander Denissov On June 6, 2016, 7:17

Re: Review Request 48258: Fix description of SERVICE.ADD_DELETE_SERVICES permission

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48258/#review136359 --- Ship it! Ship It! - Nate Cole On June 6, 2016, 3:54 p.m., Ro

Review Request 48292: VDF: exception when trying to register -> add versions

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48292/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-06 Thread bhuvnesh chaudhary
> On June 3, 2016, 11:05 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 185 > > > > > > better to move these lines higher to after line 1

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-06 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/ --- (Updated June 6, 2016, 9:23 p.m.) Review request for Ambari, Alexander Denissov

Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

2016-06-06 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48293/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako. Bugs:

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/#review136366 --- Ship it! Ship It! - Jayush Luniya On June 3, 2016, 4:55 p.m.

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Jayush Luniya
> On June 3, 2016, 5:16 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml, > > line 32 > > > > > > Why are these mandatory property attributes

Re: Review Request 48292: VDF: exception when trying to register -> add versions

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48292/ --- (Updated June 6, 2016, 5:34 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

2016-06-06 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48293/#review136377 --- ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/con

Re: Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

2016-06-06 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48293/#review136378 --- Ship it! Ship It! - Yusaku Sako On June 6, 2016, 9:24 p.m.,

Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo

2016-06-06 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Y

Re: Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48288/#review136385 --- Ship it! Ship It! - Srimanth Gunturi On June 6, 2016, 5:30 p

Review Request 48301: AMBARI-17075. Set 'hive.server2.tez.default.queues' config value to be the one used by config hive.llap.daemon.queue.name for 'llap' app.

2016-06-06 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48301/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-

Re: Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo

2016-06-06 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/ --- (Updated June 7, 2016, 12:36 a.m.) Review request for Ambari, Jaimin Jetly, Nat

Re: Review Request 48301: AMBARI-17075. Set 'hive.server2.tez.default.queues' config value to be the one used by config hive.llap.daemon.queue.name for 'llap' app.

2016-06-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48301/#review136394 --- Ship it! Ship It! - Sumit Mohanty On June 7, 2016, 12:24 a.m

Review Request 48306: AMBARI-17077 - Unable to change user role in list view

2016-06-06 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48306/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17077 https://is

Re: Review Request 48290: Change HAWQ DFS Url from hawq_default to hawq_data

2016-06-06 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48290/#review136395 --- Ship it! Ship It! - Lav Jain On June 6, 2016, 7:17 p.m., Mat

  1   2   >