Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Nate Cole
/ambari/server/controller/internal/AbstractProviderModule.java (line 1175) <https://reviews.apache.org/r/48221/#comment201118> one day we'll support multi-cluster, so maybe this should combine cluster name + component - Nate Cole On June 3, 2016, 4:56 p.m., Jonathan Hurley

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136112 --- Ship it! Ship It! - Nate Cole On June 3, 2016, 5:30 p.m

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-08 Thread Nate Cole
/PropertyInfo.java (lines 53 - 54) <https://reviews.apache.org/r/48403/#comment201756> Is this being removed to focus only on Ambari Upgrade - Nate Cole On June 8, 2016, 6:06 a.m., Dmitro Lisnichenko

Re: Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-09 Thread Nate Cole
/ambari/server/alerts/StaleAlertRunnable.java (lines 76 - 81) <https://reviews.apache.org/r/48436/#comment201885> Should this be a parameter of the alert definition? - Nate Cole On June 8, 2016, 2:24 p.m., Jonathan Hurley

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48403/#review136808 --- Ship it! Ship It! - Nate Cole On June 9, 2016, 9:12 a.m

Re: Review Request 48392: Deadlock While Updating Stale Configuration Cache During Upgrade

2016-06-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48392/#review136627 --- Ship it! Ship It! - Nate Cole On June 7, 2016, 11:49 p.m

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136347 --- Ship it! Ship It! - Nate Cole On June 6, 2016, 1:20 p.m

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
. Was there some missed files? - Nate Cole On June 6, 2016, 1:20 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 48292: VDF: exception when trying to register -> add versions

2016-06-06 Thread Nate Cole
, Nate Cole

Re: Review Request 48258: Fix description of SERVICE.ADD_DELETE_SERVICES permission

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48258/#review136359 --- Ship it! Ship It! - Nate Cole On June 6, 2016, 3:54 p.m

Re: Review Request 48292: VDF: exception when trying to register -> add versions

2016-06-06 Thread Nate Cole
] Finished at: Mon Jun 06 17:26:34 EDT 2016 [INFO] Final Memory: 35M/569M [INFO] Thanks, Nate Cole

Re: Review Request 48557: Fixed implementation of on-ambari-upgrade support. Patch 2: add logic for ambari-upgrade

2016-06-10 Thread Nate Cole
. - Nate Cole On June 10, 2016, 1:10 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-10 Thread Nate Cole
kar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48549/ > --- > > (Updated June 10, 2016, 8:47 a.m.) >

Review Request 48562: Allow option to skip duplicate URL checking when creating VDF

2016-06-10 Thread Nate Cole
/VersionDefinitionResourceProvider.java c18d722 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java e0ff2b3 Diff: https://reviews.apache.org/r/48562/diff/ Testing --- Manual. Automated pending Thanks, Nate Cole

Re: Review Request 48562: Allow option to skip duplicate URL checking when creating VDF

2016-06-10 Thread Nate Cole
] Final Memory: 35M/661M [INFO] Thanks, Nate Cole

Re: Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Nate Cole
) <https://reviews.apache.org/r/48498/#comment201921> This was an annoyance as I tried to run an agent that was upgraded after I changed ambari.ini. - Nate Cole On June 9, 2016, 12:49 p.m., Nate Cole

Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Nate Cole
Memory: 33M/689M [INFO] ---- Thanks, Nate Cole

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136145 --- Ship it! Ship It! - Nate Cole On June 3, 2016, 6:47 p.m

Re: Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48205/#review136118 --- Ship it! Ship It! - Nate Cole On June 3, 2016, 9:56 a.m

Re: Review Request 48181: Service admin and cluster operator can't modify service configs through API

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48181/#review136058 --- Ship it! Ship It! - Nate Cole On June 2, 2016, 2:34 p.m

Review Request 48204: HDP-UTILs Repo URL validation/save fails

2016-06-03 Thread Nate Cole
2119413 Diff: https://reviews.apache.org/r/48204/diff/ Testing --- No automated testing, it's just XML change. Manual tested following: - Default Install of 2.5.0.0 (make no URL changes, just "click through"). - Install 2.5.0.0, but change the URL to the version previous Tha

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-03 Thread Nate Cole
/services/stack_advisor.py (line 209) <https://reviews.apache.org/r/48162/#comment201043> %s % syntax is not the standard anymore, use "".format(...) - Nate Cole On June 2, 2016, 12:38 p.m.,

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-25 Thread Nate Cole
> On May 24, 2016, 4:41 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java, > > lines 190-194 > > <https://reviews.apache.org/r/47783/diff/1/?file=1392703#file1392703line190> > > &

Re: Review Request 47785: Ambari install of Atlas should use external HBase and Logsearch SOLR

2016-05-25 Thread Nate Cole
ply, visit: > https://reviews.apache.org/r/47785/ > --- > > (Updated May 25, 2016, 6:06 p.m.) > > > Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi. > > > Bugs: AMBARI-16853 and ATLAS-823 > https://issue

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

2016-06-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48516/#review136989 --- Ship it! Ship It! - Nate Cole On June 9, 2016, 7 p.m., Josh

Review Request 48657: Allow option to skip duplicate URL checking when creating VDF (part 2)

2016-06-13 Thread Nate Cole
/RepositoryVersionResourceProvider.java 62568cf ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 3bc4aec Diff: https://reviews.apache.org/r/48657/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

2016-06-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48516/#review137497 --- What is the status of this review? - Nate Cole On June 9, 2016

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Nate Cole
ambari/server/api/services/RequestFactory.java (line 69) <https://reviews.apache.org/r/48702/#comment202729> createReadRequest() ? - Nate Cole On June 14, 2016, 2:57 p.m., Robert Levas wrote: > > --- > This is an automatic

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Nate Cole
> On June 14, 2016, 3:24 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java, > > line 69 > > <https://reviews.apache.org/r/48702/diff/1/?file=1418983#file1418983line69> > > > > create

Re: Review Request 48702: Add ability to set GET request directives

2016-06-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137720 --- Ship it! Ship It! - Nate Cole On June 14, 2016, 7:12 p.m

Re: Review Request 48557: Fixed implementation of on-ambari-upgrade support. Patch 2: add logic for ambari-upgrade

2016-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48557/#review137357 --- Ship it! Ship It! - Nate Cole On June 13, 2016, 9:22 a.m

Re: Review Request 48655: ATLAS conf dir needs to be present in all ATLAS hook deployed hosts

2016-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48655/#review137359 --- Ship it! Ship It! - Nate Cole On June 13, 2016, 1:51 p.m

Re: Review Request 48640: Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to SERVICE.ADMINISTRATOR role and above

2016-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48640/#review137358 --- Ship it! Ship It! - Nate Cole On June 13, 2016, 2:50 p.m

Re: Review Request 48415: Authorizations given to role-based principals must be dereferenced upon user login

2016-06-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48415/#review136644 --- Ship it! Ship It! - Nate Cole On June 8, 2016, 9:53 a.m

Review Request 48088: Stack VDF should ignore unsupported OS

2016-05-31 Thread Nate Cole
://reviews.apache.org/r/48088/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-27 Thread Nate Cole
query framework or something)? - Nate Cole On May 27, 2016, 6:01 a.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47933/#review135256 --- Ship it! Ship It! - Nate Cole On May 27, 2016, 6:01 a.m

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-27 Thread Nate Cole
> On May 24, 2016, 4:41 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java, > > lines 190-194 > > <https://reviews.apache.org/r/47783/diff/1/?file=1392703#file1392703line190> > > &

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47961/#review135261 --- Ship it! Ship It! - Nate Cole On May 27, 2016, 12:26 p.m

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Nate Cole
/#comment200288> nit: you have two Runnables that do nearly the identical thing except how to parse the resulting InputStream. Could push most of the run() to MetricsRunnable and just have your subclasses parse. - Nate Cole On May 27, 2016, 1:27 p.m., Jon

Re: Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47933/#review135300 --- Ship it! Ship It! - Nate Cole On May 27, 2016, 3:58 p.m

Re: Review Request 47979: Deploy: UI: Hive_metastore not started

2016-05-27 Thread Nate Cole
- > > (Updated May 27, 2016, 4:15 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Nate Cole, and Sumit > Mohanty. > > > Bugs: AMBARI-16938 > https://issues.apache.org/jira/browse/AMBARI-16938 > > > Repository: ambari > >

Review Request 47978: VDF should use package-version for the os, not the release

2016-05-27 Thread Nate Cole
69eb39d ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 237eed2 ambari-server/src/test/resources/hbase_version_test.xml 183da8c Diff: https://reviews.apache.org/r/47978/diff/ Testing --- Manual. Automated pending. Thanks, Nate

Review Request 47913: VDF builder script and XSD should be updated for package-version changes

2016-05-26 Thread Nate Cole
org.apache.ambari.server.state.repository.VersionDefinitionTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - in org.apache.ambari.server.state.repository.VersionDefinitionTest Results : Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 Thanks, Nate Cole

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

2016-05-26 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

2016-05-26 Thread Nate Cole
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/47867/#review134902 --- On May 25, 2016, 8:54 p.m., Nate Cole wrote: > > --- > This is an automatically generated e

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Nate Cole
/upgrades/upgrade-2.5.xml (lines 897 - 899) <https://reviews.apache.org/r/47871/#comment199970> Why does downgrade get this message but not upgrade? - Nate Cole On May 25, 2016, 9:54 p.m., Alejandro Fernandez

Re: Review Request 47785: Ambari install of Atlas should use external HBase and Logsearch SOLR

2016-05-26 Thread Nate Cole
Just wanted to make sure if this always be true? > > Nate Cole wrote: > I think this assumption should be ok - we are already doing the symlink > magic to point to the right spot. > > Tom Beerbower wrote: > Thanks for the review Srimanth and Nat

Re: Review Request 47785: Ambari install of Atlas should use external HBase and Logsearch SOLR

2016-05-26 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47785/#review134975 --- Ship it! Ship It! - Nate Cole On May 25, 2016, 6:06 p.m

Re: Review Request 48036: Service name shown instead of Host name on popup

2016-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48036/#review135840 --- Ship it! Ship It! - Nate Cole On June 1, 2016, 12:01 p.m

Re: Review Request 47978: VDF should use package-version for the os, not the release

2016-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47978/#review135789 --- On May 31, 2016, 4:13 p.m., Nate Cole wrote: > > --

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/#review135792 --- Ship it! Ship It! - Nate Cole On May 27, 2016, 6:48 p.m

Re: Review Request 48036: Service name shown instead of Host name on popup

2016-05-31 Thread Nate Cole
eleted). Maybe just make the host name where it was found to be informational rather than the getFailedOn(). And in fact, getFailedOn() would be HDFS, not SNN since it's a service and SNN is a component. Either way, should make sure a test covers this appropriately. - Nate Cole On

Re: Review Request 48041: SERVICE_CHECK Upgrade pre-check does not throw error when its expected to

2016-05-31 Thread Nate Cole
f fail messages to see how to do it. - Nate Cole On May 30, 2016, 9:30 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47978: VDF should use package-version for the os, not the release

2016-05-31 Thread Nate Cole
] Finished at: Fri May 27 18:08:19 EDT 2016 [INFO] Final Memory: 33M/672M [INFO] Thanks, Nate Cole

Re: Review Request 47018: "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-31 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/#review135643 --- Ship it! Ship It! - Nate Cole On May 26, 2016, 12:15 p.m

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

2016-06-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48708/#review137599 --- Ship it! Ship It! - Nate Cole On June 14, 2016, 5:33 p.m

Re: Review Request 48041: SERVICE_CHECK Upgrade pre-check does not throw error when its expected to

2016-06-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48041/#review137961 --- Hi Dmitry, what's the status of this review/patch? - Nate Cole

Re: Review Request 48812: Use customized display name as version string

2016-06-16 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Nate Cole
- > > (Updated June 16, 2016, 5:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-17284 > https://issues.apache.org/jira/browse/AMBARI-17284 > > > Repository: ambari > > >

Re: Review Request 44931: Use Version Definition value for package-version when installing

2016-03-18 Thread Nate Cole
[INFO] Finished at: Thu Mar 17 08:26:54 EDT 2016 [INFO] Final Memory: 38M/566M [INFO] Thanks, Nate Cole

Re: Review Request 44986: AMBARI-15474: Listen for changes to auto-start configuration and send them to the agent during heartbeats

2016-03-18 Thread Nate Cole
/HeartBeatHandler.java (lines 287 - 289) <https://reviews.apache.org/r/44986/#comment186680> Use {} format for log statements like so: LOG.info("Recovery configuration set to {}", response.getRecoveryConfig()); - Nate Cole On March 17, 2016, 7 p.m., Nahappan So

Re: Review Request 45035: Restarting HDFS Before Upgrade Finalizing Does Not Supply the rollingUpgrade Flag

2016-03-18 Thread Nate Cole
/controller/internal/UpgradeResourceProvider.java (line 461) <https://reviews.apache.org/r/45035/#comment186677> formatting :) - Nate Cole On March 18, 2016, 11:20 a.m., Jonathan Hurley wrote: > > --- > This is a

Re: Review Request 44352: AMBARI-15230: Move default recovery properties from ambari.properties to cluster-env.xml

2016-03-15 Thread Nate Cole
ld be doing this. If it's enabled, it's enabled. - Nate Cole On March 14, 2016, 6 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 44831: After EU Some Services Fail To Start Because of Missing JKS Files

2016-03-15 Thread Nate Cole
> On March 15, 2016, 8:19 a.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, > > line 526 > > <https://reviews.apache.org/r/44831/diff/1/?file=1299166#file1299166line526> > > > > Maybe a bi

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Nate Cole
g. We can then keep HDP-specific in the HDP stack directories. - Nate Cole On March 15, 2016, 2:32 a.m., Jayush Luniya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review123708 --- Ship it! Ship It! - Nate Cole On March 15, 2016, 2:32 a.m

Review Request 44983: Service version display should be based on Version Definition

2016-03-19 Thread Nate Cole
/VersionDefinitionTest.java f2939c7 ambari-server/src/test/resources/version_definition_test.xml 69ea581 Diff: https://reviews.apache.org/r/44983/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 44986: AMBARI-15474: Listen for changes to auto-start configuration and send them to the agent during heartbeats

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44986/#review124222 --- Ship it! Ship It! - Nate Cole On March 17, 2016, 7 p.m

Re: Review Request 44352: AMBARI-15230: Move default recovery properties from ambari.properties to cluster-env.xml

2016-03-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44352/#review123723 --- Ship it! Ship It! - Nate Cole On March 14, 2016, 6 p.m

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-28 Thread Nate Cole
rg/r/45347/ > --- > > (Updated March 27, 2016, 5:51 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, > Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-15592 > http

Re: Review Request 45390: Database Changes to Support Alert Repeat Tolerance

2016-03-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45390/#review125714 --- Ship it! Ship It! - Nate Cole On March 28, 2016, 1:21 p.m

Re: Review Request 45321: Ambari calculates stack downgrade as ABORTED under incorrect conditions. UI shows 'Downgrade paused' and button to resume downgrade even when progress is happening

2016-03-28 Thread Nate Cole
/orm/entities/UpgradeEntity.java (lines 203 - 205) <https://reviews.apache.org/r/45321/#comment188591> I see this in trunk already as isSuspended() ? - Nate Cole On March 24, 2016, 6:28 p.m., Alejandro Fernandez

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-29 Thread Nate Cole
remember to have to come here. - Nate Cole On March 24, 2016, 8:20 a.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review126138 --- Ship it! Ship It! - Nate Cole On March 30, 2016, 11:20 a.m

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-30 Thread Nate Cole
ent189033> setSettings(...) (plural) ? - Nate Cole On March 29, 2016, 10:17 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite option out of experimental

2016-04-06 Thread Nate Cole
> On April 6, 2016, 9:59 a.m., Nate Cole wrote: > > Is this hooked in anywhere? I don't see any API calls (but that's probably > > ok for this review). Any ambari-admin view changes? > > Zhe (Joe) Wang wrote: > I thought the requirement for this issue is to expose

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-04-06 Thread Nate Cole
> On March 29, 2016, 8:49 a.m., Nate Cole wrote: > > I think you need a more concrete way of ordering here. What if two > > services are marked as YARN? Which one takes precedence? You may > > want to introduce an in order to > > specifically state how it happe

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

2016-04-07 Thread Nate Cole
/709M [INFO] Thanks, Nate Cole

Review Request 45877: Add "services" element to compatible_repository_versions endpoint

2016-04-07 Thread Nate Cole
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 48eeaf8 Diff: https://reviews.apache.org/r/45877/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 45834: Create Alert For Reporting Potential Issues With Slow REST Responses

2016-04-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45834/#review127610 --- Ship it! Ship It! - Nate Cole On April 7, 2016, noon

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

2016-04-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127647 --- Ping - Nate Cole On April 7, 2016, 1:55 p.m., Nate Cole wrote

Re: Review Request 46100: Support option to not create a version definition resource but return the structured JSON only

2016-04-12 Thread Nate Cole
:07:01 EDT 2016 [INFO] Final Memory: 36M/670M [INFO] Thanks, Nate Cole

Re: Review Request 45896: Atlas Integration : Support Atlas HA

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45896/#review127780 --- Ship it! Look at you, back in the mix :) - Nate Cole

Re: Review Request 45857: RU/EU PreCheck to ensure dfs.client.retry.policy.enable is set to false

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45857/#review12 --- Ship it! Ship It! - Nate Cole On April 7, 2016, 5:47 p.m

Review Request 46100: Support option to not create a version definition resource but return the structured JSON only

2016-04-12 Thread Nate Cole
/diff/ Testing --- Manual. Automated in progress. Thanks, Nate Cole

Re: Review Request 45811: Compatible Stacks not returning correctly

2016-04-06 Thread Nate Cole
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45811/#review127353 --- On April 6, 2016, 10:03 a.m., Nate Cole wrote: > > --- > This is an automatically g

Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite option out of experimental

2016-04-06 Thread Nate Cole
calls (but that's probably ok for this review). Any ambari-admin view changes? - Nate Cole On April 5, 2016, 6:50 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/#review127818 --- Ship it! Ship It! - Nate Cole On April 7, 2016, 8:36 p.m

Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Nate Cole
6/#review128218 --- On April 11, 2016, 3:27 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 44926: [DRAFT] Auto-retry on failure during RU/EU

2016-03-19 Thread Nate Cole
I think you know why this and others like it can't go into a commit :) - Nate Cole On March 16, 2016, 4:41 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 44931: Use Version Definition value for package-version when installing

2016-03-19 Thread Nate Cole
/ClusterStackVersionResourceProviderTest.java dea83a1 ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80 ambari-server/src/test/resources/hbase_version_test.xml 9df07ed Diff: https://reviews.apache.org/r/44931/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 44931: Use Version Definition value for package-version when installing

2016-03-19 Thread Nate Cole
at: Wed Mar 16 17:50:32 EDT 2016 [INFO] Final Memory: 35M/776M [INFO] Thanks, Nate Cole

Re: Review Request 44878: Atlas Integration : Rename Atlas Configurations

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44878/#review123865 --- Ship it! Ship It! - Nate Cole On March 15, 2016, 8:57 p.m

Re: Review Request 44983: Service version display should be based on Version Definition

2016-03-19 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 44926: [DRAFT] Auto-retry on failure during RU/EU

2016-03-20 Thread Nate Cole
t, let's add an ambari.properties CSV for it. ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 1123) <https://reviews.apache.org/r/44926/#comment186610> NumberUtils.toInt() can be your friend :) - Nate Cole On March 17, 2016, 7:07 p.m., Alejand

Re: Review Request 45215: HDFS Alerts for AMS Throw 'invalid literal for int() with base 10: '50.0''

2016-03-23 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45215/#review125061 --- Ship it! Ship It! - Nate Cole On March 23, 2016, 11:08 a.m

Re: Review Request 45218: Atlas Integration : Rename Atlas Configurations (2.5 stack definition)

2016-03-23 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45218/#review125063 --- Ship it! Ship It! - Nate Cole On March 23, 2016, 12:07 p.m

  1   2   3   4   5   6   7   8   9   10   >