[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-14 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: (4 comments) A couple of minor nits. Also, let me make sure I didn't accidentally introduce

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7627 To unsubscribe,

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7643/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPALA-4794: Grouping distinct agg plan robust to data skew This patch changes the query plan for

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#12). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ..

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2422: Fix escaping in LIKE clause .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7660/2/be/src/exprs/like-predicate.cc File

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 3: Code-Review+2 One business day has elapsed and it looks like

[Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status

2017-08-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7253 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7642 to look at the new patch set (#9). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar ..

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 19: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1051/ -- To

[Impala-ASF-CR] IMPALA-5787: Dropped status in KuduTableSink::Send()

2017-08-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7667/1/be/src/exec/kudu-table-sink.cc

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 8: Code-Review+2 (2 comments) Looks good. If you fix the last couple of nits and rebase I can

[Impala-ASF-CR] IMPALA-5787: Dropped status in KuduTableSink::Send()

2017-08-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7667 Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send() .. IMPALA-5787: Dropped status in KuduTableSink::Send()

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-14 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5717 to look at the new patch set (#19). Change subject: IMPALA-4669: [SECURITY] Add security library to build

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPALA-4794: Grouping distinct agg plan robust to data skew This patch changes the query plan for

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7606 To

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7606 To

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 10: > (2 comments) > > Looks good. If you fix the last couple of nits and rebase I can > start

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1050/ -- To

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 3: (7 comments) I like the new solution, it's easier to understand.

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 5: (9 comments) This looks good! Just needs to merge with the recent

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/2/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5109: Increase range of backend latency histogram

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7676 Change subject: IMPALA-5109: Increase range of backend latency histogram .. IMPALA-5109: Increase range of backend latency histogram

[Impala-ASF-CR] IMPALA-5796: CTAS for Kudu fails with expr rewrite

2017-08-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7666 Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite .. IMPALA-5796: CTAS for Kudu fails with expr rewrite When

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 3: Code-Review+2 Carrying forward -- To view, visit

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-08-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil .. Patch Set 5: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 6: Code-Review+2 Fix a couple of clang-tidy warnings. -- To view, visit

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7606 to look at the new patch set (#6). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-08-14 Thread Kim Jin Chul (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7414 to look at the new patch set (#5). Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ..

[Impala-ASF-CR] IMPALA-5787: Dropped status in KuduTableSink::Send()

2017-08-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. IMPALA-5598: Fix excessive dumping in MemLimitExceeded ExecQueryFInstances RPC timeouts in stress tests

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 1: (3 comments) Rebased all the way.

[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.

2017-08-14 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new change for review. http://gerrit.cloudera.org:8080/7671 Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. .. IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 10: This failed in

[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.

2017-08-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7671 To

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Patch Set 5: Code-Review+2 +2'ing since the patch is simple.

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7658 To unsubscribe, visit

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port broke the minidump-2-core tool

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 10: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1050/

[Impala-ASF-CR] Fix link to Hadoop ADLS page

2017-08-14 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7672 Change subject: Fix link to Hadoop ADLS page .. Fix link to Hadoop ADLS page At the time I added the original link, the URL with

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7597 to look at the new patch set (#3). Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded ..

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7597 To unsubscribe,

[Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup

2017-08-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5769: Add periodic minidump cleanup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7605/1/be/src/util/minidump.cc File

[Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup

2017-08-14 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7605 to look at the new patch set (#2). Change subject: IMPALA-5769: Add periodic minidump cleanup .. IMPALA-5769: Add

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 19: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5717 To

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 17: > Verified by build:

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup

2017-08-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5769: Add periodic minidump cleanup .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7605/1/be/src/util/minidump.cc File

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Patch Set 5: Build started:

[Impala-ASF-CR] Fix link to Hadoop ADLS page

2017-08-14 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: Fix link to Hadoop ADLS page .. Patch Set 1: Code-Review+1 I built the documentation and the link works perfectly. -- To view, visit

[Impala-ASF-CR] Fix link to Hadoop ADLS page

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix link to Hadoop ADLS page .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7672 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Fold some lines

2017-08-14 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Fold some lines .. Patch Set 1: Code-Review+1 PDF build looks good. -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 17: That build included this patch. Or do you have reason to believe it

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7673 Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. IMPALA-4786: Clean up how ImpalaServers are created

[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.

2017-08-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7671 To

[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1055/

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7658/2/buildall.sh File

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 17: > That build included this patch. Or do you have reason to believe it >

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7606 to look at the new patch set (#5). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 2: Code-Review+1 (1 comment) Will let MJ take a look too.

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 2: (1 comment) Fix long line and fix a backend test I had missed.

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 16: Code-Review+2 Verified+1 Verified by build:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 The

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Add krb5 as a

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 20: Code-Review+2 Verified+1 Rebase, carry +1 and +2. -- To view, visit

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. IMPALA-1478: Improve error message when subquery is

[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7671 To

[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. .. IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET. Fix: If the

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. IMPALA-2689: Log why codegen is disabled in

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7675 Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7675 to look at the new patch set (#2). Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 ..

[Impala-ASF-CR] IMPALA-5772: also fix TestScratchLimit

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5772: also fix TestScratchLimit .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7664 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5772: also fix TestScratchLimit

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5772: also fix TestScratchLimit .. IMPALA-5772: also fix TestScratchLimit This reduces the scratch limit to the same value as used in

[Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status

2017-08-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt File be/CMakeLists.txt: Line

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1049/ -- To

[Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-2615: support [[nodiscard]] on Status .. IMPALA-2615: support [[nodiscard]] on Status This is the set of changes required to get Impala to compile on GCC 7

[Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt File be/CMakeLists.txt:

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7581 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5612: join inversion should factor in parallelism

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5612: join inversion should factor in parallelism .. Patch Set 5: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7351 To

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5681: release reservation from blocking operators .. Patch Set 5: Code-Review+1 carry -- To view, visit http://gerrit.cloudera.org:8080/7619 To

  1   2   >