Michael Brown has posted comments on this change.
Change subject: IMPALA-4359: qgen: add UPSERT support
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/statement_generator.py
File
Michael Brown has posted comments on this change.
Change subject: Add nested testdata flattener
..
Patch Set 1:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/5787/1//COMMIT_MSG
Commit Message:
Line 22:
How was this
Michael Brown has posted comments on this change.
Change subject: IMPALA-4359: qgen: add UPSERT support
..
Patch Set 2:
(3 comments)
Thanks for the review, Taras. Please see patch set 2.
Michael Brown has uploaded a new patch set (#2).
Change subject: IMPALA-4359: qgen: add UPSERT support
..
IMPALA-4359: qgen: add UPSERT support
UPSERTs are very similar to INSERTs, so the UPSERT support is simply
folded into
Michael Brown has posted comments on this change.
Change subject: IMPALA-4359: qgen: add UPSERT support
..
Patch Set 3:
rebase + fix 1 typo
--
To view, visit http://gerrit.cloudera.org:8080/5795
To unsubscribe, visit
Hello David Knupp, Taras Bobrovytsky,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5795
to look at the new patch set (#3).
Change subject: IMPALA-4359: qgen: add UPSERT support
..
Michael Brown has posted comments on this change.
Change subject: Add .pep8rc for Impala's Python style
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc
File .pep8rc:
PS1, Line 2: # E101 -
Michael Brown has posted comments on this change.
Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS
..
Patch Set 6: Code-Review+1
(2 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4853: Skip test_kudu_dml_reporting if Kudu is not
supported.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5854
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2.
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5640
To
Michael Brown has posted comments on this change.
Change subject: Add nested testdata flattener
..
Patch Set 1:
Nice! I'll be taking a look at this today.
--
To view, visit http://gerrit.cloudera.org:8080/5787
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2.
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5640/7/tests/run-tests.py
File
Michael Brown has posted comments on this change.
Change subject: IMPALA-4818: Ensure the same number of tests are run every time
..
Patch Set 2:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4818: Ensure the same number of tests are run every time
..
Patch Set 2: Code-Review+1
(1 comment)
Maybe this is a candidate for upvoting?
Michael Brown has posted comments on this change.
Change subject: [DOCS] Add several items to "known issues" page
..
Patch Set 1: Code-Review+1
..for IMPALA-4513
--
To view, visit http://gerrit.cloudera.org:8080/5809
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test
classes.
..
Patch Set 2:
(1 comment)
I did my own survey for this renaming and feel you have
Michael Brown has posted comments on this change.
Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2.
..
Patch Set 6:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5640/6/tests/run-tests.py
File
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
..
Patch Set 7: Code-Review+1
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
..
Patch Set 6:
http://jenkins.impala.io:8080/job/pre-review-test/21/
--
To view, visit
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
..
Patch Set 3:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress"
for exhaustive tests
..
Patch Set 4: Code-Review+1
(9 comments)
Thanks for the review, Jim.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress"
for exhaustive tests
..
Patch Set 3:
(1 comment)
Hello David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6002
to look at the new patch set (#4).
Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress"
for exhaustive tests
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6002/3//COMMIT_MSG
Commit
Hello David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6002
to look at the new patch set (#5).
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
Michael Brown has posted comments on this change.
Change subject: IMPALA-4848: Add WIDHT_BUCKET() function
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6023/3//COMMIT_MSG
Commit Message:
PS3, Line 7:
Michael Brown has posted comments on this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a
network.
..
Patch Set 1:
I have some questions, but they're about the bug, not this fix, so the
Michael Brown has posted comments on this change.
Change subject: IMPALA-4990: fix run_tests.py --update_results
..
Patch Set 1:
Is it possible for you to add a test to tests/unittests to catch this?
--
To view, visit
Michael Brown has posted comments on this change.
Change subject: Add .pep8rc for Impala's Python style
..
Patch Set 1:
> Any news with this?
I should point out we had a discussion here:
Michael Brown has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
..
Patch Set 7:
Thanks Jim. Could you please rebase and GVO this?
--
To view, visit
Hello David Knupp, Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6002
to look at the new patch set (#7).
Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
Michael Brown has posted comments on this change.
Change subject: A blog post about IMPALA-4916
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5746
Change subject: IMPALA-4775: minor adjustments to python test infra logging
..
IMPALA-4775: minor adjustments to python test infra
Michael Brown has posted comments on this change.
Change subject: IMPALA-3980: qgen: re-enable Hive as a target database
..
Patch Set 4:
I'd like you to run the small suite of cluster tests, but you can't yet until
you rebase
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4404
Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests
..
IMPALA-4122: qgen: fix bitrotted cluster unit tests
There's a
Michael Brown has posted comments on this change.
Change subject: IMPALA-3739: Enable stress tests on Kudu
..
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py
File
Michael Brown has posted comments on this change.
Change subject: IMPALA-3739: Enable stress tests on Kudu
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py
File
Michael Brown has posted comments on this change.
Change subject: Make gen_build_version.py resilient to a failing git rev-parse
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4411/4/bin/gen_build_version.py
Michael Brown has posted comments on this change.
Change subject: Make gen_build_version.py resilient to a failing git rev-parse
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4411
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py
..
Patch Set 1:
Hello hewenting, any updates?
Regarding this comment of mine:
> Fix underlying
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 3:
(3 comments)
Thanks for adding a test!
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 3:
(3 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-3980: qgen: re-enable Hive as a target database
..
Patch Set 7: Code-Review+1
This needs a committer's look.
--
To view, visit
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 5: Code-Review+1
A committer needs to look at this for +2
--
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
..
Patch Set 1: Code-Review+1
> Let me run the Leopard front end and do a sanity test.
It's fine. +1
Michael Brown has posted comments on this change.
Change subject: IMPALA-3980: qgen: re-enable Hive as a target database
..
Patch Set 6:
> The hive-default.xml file under
> fe/src/test/resources/ is not a valid XML file. It
Michael Brown has posted comments on this change.
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
..
Patch Set 1:
Lots of testing to do yet.
--
To view, visit
Michael Brown has posted comments on this change.
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
..
Patch Set 3: Code-Review+1
(2 comments)
done; carry +1
Trying to fix a build
Michael Brown has posted comments on this change.
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
..
Patch Set 3:
Private data load is green after 6.5 hours
Hello Sahil Takiar, David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4555
to look at the new patch set (#3).
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
Michael Brown has posted comments on this change.
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
..
Patch Set 3:
Oh and the diff is much larger now due to having made requested
Michael Brown has posted comments on this change.
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
..
Patch Set 1:
> Just curious, what are the other modules that use cli_options?
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4555
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
..
IMPALA-4207: test infra: move Hive
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4846
Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher
..
IMPALA-4340: explain how to install postgresql-9.5 or
Michael Brown has posted comments on this change.
Change subject: IMPALA-3872: allow providing PyPi mirror for python packages
..
Patch Set 3: Code-Review+1
(2 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher
..
Patch Set 1:
Thanks for the review, Alex. I didn't notice it until today.
--
To view, visit
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4873
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
IMPALA-4352: test infra: store Impala/Kudu
Michael Brown has posted comments on this change.
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
Patch Set 7: Code-Review+1
(1 comment)
Thanks for the review. I made the rename and
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4873
to look at the new patch set (#7).
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
Michael Brown has posted comments on this change.
Change subject: IMPALA-4338: test infra data migrator: include tables' primary
keys in PostgreSQL
..
Patch Set 2:
Note this patched is based on
Michael Brown has posted comments on this change.
Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
..
Patch Set 3:
Thanks! Do you mind submitting this in the Gerrit WebUI since
1. GVO won't touch paths
Michael Brown has posted comments on this change.
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
Patch Set 7:
Thanks for the review, Taras. This *does* need GVO, which I'll make
Michael Brown has posted comments on this change.
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py
File
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5034
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
IMPALA-4450: qgen: use string
Michael Brown has uploaded a new patch set (#4).
Change subject: IMPALA-4338: test infra data migrator: include tables' primary
keys in PostgreSQL
..
IMPALA-4338: test infra data migrator: include tables' primary keys in
Michael Brown has posted comments on this change.
Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4967/1//COMMIT_MSG
Michael Brown has posted comments on this change.
Change subject: IMPALA-4338: test infra data migrator: include tables' primary
keys in PostgreSQL
..
Patch Set 4:
(3 comments)
Thanks for the review. Please see patch set 4.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 5:
(7 comments)
Michael Brown has uploaded a new patch set (#4).
Change subject: IMPALA-4188: Leopard: support external Docker volumes
..
IMPALA-4188: Leopard: support external Docker volumes
To be able to run the Random Query Generator with
Michael Brown has uploaded a new patch set (#5).
Change subject: IMPALA-4188: Leopard: support external Docker volumes
..
IMPALA-4188: Leopard: support external Docker volumes
To be able to run the Random Query Generator with
Michael Brown has posted comments on this change.
Change subject: IMPALA-4188: Leopard: support external Docker volumes
..
Patch Set 4:
(2 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4771
To unsubscribe,
Michael Brown has posted comments on this change.
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py
Michael Brown has posted comments on this change.
Change subject: IMPALA-3872: allow providing PyPi mirror for python packages
..
Patch Set 2:
(2 comments)
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5162
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
IMPALA-4343,IMPALA-4354: qgen: model
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 2: Code-Review+1
--
To view, visit
Michael Brown has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 2:
(8 comments)
I understand the problem, and I think I see what you're doing
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1: Code-Review+1
(3 comments)
Thanks for the review. Carry +1
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5135
To
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5162
to look at the new patch set (#4).
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1:
(1 comment)
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5162
to look at the new patch set (#3).
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
Michael Brown has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5135
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 4: Code-Review+1
I've simply chosen different names for the objects,
Michael Brown has posted comments on this change.
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
Patch Set 4: Code-Review+1
rebase
--
To view, visit
Michael Brown has uploaded a new patch set (#3).
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
IMPALA-4450: qgen: use string concatenation operator for postgres queries
The random
Michael Brown has posted comments on this change.
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5034/2//COMMIT_MSG
Michael Brown has posted comments on this change.
Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes.
..
Patch Set 2:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: Preview: IMPALA-4467: Add support for CRUD operations in stress
test
..
Patch Set 1:
(7 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher
..
Patch Set 1:
> Is this ready to merge? I can manually verify it since pre-commit
> tests won't
Michael Brown has posted comments on this change.
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
Patch Set 1:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
Patch Set 3:
(4 comments)
Thanks Matthew. Please see patch set 3.
Michael Brown has uploaded a new patch set (#3).
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
IMPALA-4352: test infra: store Impala/Kudu primary keys in object model
Test
Michael Brown has uploaded a new patch set (#4).
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
IMPALA-4352: test infra: store Impala/Kudu primary keys in object model
Test
Michael Brown has posted comments on this change.
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
Patch Set 4:
Patch set 4 adds Table object properties for the names of the columns
Michael Brown has posted comments on this change.
Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in
object model
..
Patch Set 5: Code-Review+1
rebase
--
To view, visit
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4936
Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
..
IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
This
Michael Brown has uploaded a new patch set (#2).
Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
..
IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
This patch now requires users of the Leopard
Michael Brown has posted comments on this change.
Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
..
Patch Set 2:
(2 comments)
Thanks. See patch set 2.
1 - 100 of 403 matches
Mail list logo
