[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/statement_generator.py File

[Impala-ASF-CR] Add nested testdata flattener

2017-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add nested testdata flattener .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/5787/1//COMMIT_MSG Commit Message: Line 22: How was this

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 2: (3 comments) Thanks for the review, Taras. Please see patch set 2.

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-01 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#2). Change subject: IMPALA-4359: qgen: add UPSERT support .. IMPALA-4359: qgen: add UPSERT support UPSERTs are very similar to INSERTs, so the UPSERT support is simply folded into

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 3: rebase + fix 1 typo -- To view, visit http://gerrit.cloudera.org:8080/5795 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Michael Brown (Code Review)
Hello David Knupp, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5795 to look at the new patch set (#3). Change subject: IMPALA-4359: qgen: add UPSERT support ..

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-01-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 2: # E101 -

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 6: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4853: Skip test kudu dml reporting if Kudu is not supported.

2017-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4853: Skip test_kudu_dml_reporting if Kudu is not supported. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5854 To

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5640 To

[Impala-ASF-CR] Add nested testdata flattener

2017-01-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add nested testdata flattener .. Patch Set 1: Nice! I'll be taking a look at this today. -- To view, visit http://gerrit.cloudera.org:8080/5787 To

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5640/7/tests/run-tests.py File

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 2: Code-Review+1 (1 comment) Maybe this is a candidate for upvoting?

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: Code-Review+1 ..for IMPALA-4513 -- To view, visit http://gerrit.cloudera.org:8080/5809 To

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 2: (1 comment) I did my own survey for this renaming and feel you have

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5640/6/tests/run-tests.py File

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests .. Patch Set 6: http://jenkins.impala.io:8080/job/pre-review-test/21/ -- To view, visit

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 4: Code-Review+1 (9 comments) Thanks for the review, Jim.

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-17 Thread Michael Brown (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6002 to look at the new patch set (#4). Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6002/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-17 Thread Michael Brown (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6002 to look at the new patch set (#5). Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

[Impala-ASF-CR] IMPALA-4848: Add WIDHT BUCKET() function

2017-02-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4848: Add WIDHT_BUCKET() function .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/3//COMMIT_MSG Commit Message: PS3, Line 7:

[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.

2017-02-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network. .. Patch Set 1: I have some questions, but they're about the bug, not this fix, so the

[Impala-ASF-CR] IMPALA-4990: fix run tests.py --update results

2017-02-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4990: fix run_tests.py --update_results .. Patch Set 1: Is it possible for you to add a test to tests/unittests to catch this? -- To view, visit

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-02-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: > Any news with this? I should point out we had a discussion here:

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests .. Patch Set 8: Sorry Jim. This needs a +2 after the rebase, and a submit. -- To view, visit

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests .. Patch Set 7: Thanks Jim. Could you please rebase and GVO this? -- To view, visit

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

2017-02-21 Thread Michael Brown (Code Review)
Hello David Knupp, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6002 to look at the new patch set (#7). Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-14 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive

[Impala-ASF-CR] IMPALA-4920: custom cluster tests: fix generation of py.test options

2017-02-14 Thread Michael Brown (Code Review)
Hello David Knupp, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5978 to look at the new patch set (#2). Change subject: IMPALA-4920: custom cluster tests: fix generation of py.test options

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md

[Impala-ASF-CR] IMPALA-4920: custom cluster tests: fix generation of py.test options

2017-02-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4920: custom cluster tests: fix generation of py.test options .. Patch Set 1: (1 comment) Thanks Jim. Please see patch set 2.

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: This is interesting. How would I see the rendered blog? -- To view, visit http://gerrit.cloudera.org:8080/5995

[Impala-ASF-CR] IMPALA-4920: custom cluster tests: fix generation of py.test options

2017-02-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4920: custom cluster tests: fix generation of py.test options .. Patch Set 2: > Would you like me to kick off the Jenkins merge job? Yes please; thanks

[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging

2017-01-19 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5746 Change subject: IMPALA-4775: minor adjustments to python test infra logging .. IMPALA-4775: minor adjustments to python test infra

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: I'd like you to run the small suite of cluster tests, but you can't yet until you rebase

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4404 Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. IMPALA-4122: qgen: fix bitrotted cluster unit tests There's a

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. Patch Set 5: Code-Review+1 Thanks for the review. Patch set 5 adds an ASF license notice to a file that

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 4: (3 comments) I took a look at the TPC-H and DS specs for more primary key inconsistencies. If the

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4411/4/bin/gen_build_version.py

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4411 To

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 5: Sahil, can you take another look at the tests? I get a failure when I check out your

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py

2016-09-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py .. Patch Set 1: Hello hewenting, any updates? Regarding this comment of mine: > Fix underlying

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 3: (3 comments) Thanks for adding a test!

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 7: Code-Review+1 This needs a committer's look. -- To view, visit

[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.

2016-09-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2. .. Patch Set 1: Let me run the Leopard front end and do a sanity test. -- To view, visit

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: Code-Review+1 A committer needs to look at this for +2 -- To

[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.

2016-09-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2. .. Patch Set 1: Code-Review+1 > Let me run the Leopard front end and do a sanity test. It's fine. +1

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 6: > The hive-default.xml file under > fe/src/test/resources/ is not a valid XML file. It

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 5: (2 comments) It seems regardless of database, Kudu tables live in the same Kudu namespace. In order

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Lots of testing to do yet. -- To view, visit

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Code-Review+1 (2 comments) done; carry +1 Trying to fix a build

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Private data load is green after 6.5 hours

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Hello Sahil Takiar, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4555 to look at the new patch set (#3). Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Oh and the diff is much larger now due to having made requested

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Hello Sahil Takiar, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4555 to look at the new patch set (#2). Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: > Just curious, what are the other modules that use cli_options?

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4555 Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. IMPALA-4207: test infra: move Hive

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-25 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4846 Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. IMPALA-4340: explain how to install postgresql-9.5 or

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 3: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. Patch Set 1: Thanks for the review, Alex. I didn't notice it until today. -- To view, visit

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-10-27 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4873 Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. IMPALA-4352: test infra: store Impala/Kudu

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Code-Review+1 (1 comment) Thanks for the review. I made the rename and

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4873 to look at the new patch set (#7). Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 2: Note this patched is based on

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Thanks! Do you mind submitting this in the Gerrit WebUI since 1. GVO won't touch paths

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Thanks for the review, Taras. This *does* need GVO, which I'll make

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5040 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py File

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-10 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5034 Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. IMPALA-4450: qgen: use string

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. IMPALA-4338: test infra data migrator: include tables' primary keys in

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

2016-11-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Don't overwrite user's .ssh/config file when bootstrapping .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4967/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 4: (3 comments) Thanks for the review. Please see patch set 4.

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be able to run the Random Query Generator with

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#5). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be able to run the Random Query Generator with

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5162 Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. IMPALA-4343,IMPALA-4354: qgen: model

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. Patch Set 2: (8 comments) I understand the problem, and I think I see what you're doing

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 1: Code-Review+1 (3 comments) Thanks for the review. Carry +1

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5135 To

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5162 to look at the new patch set (#4). Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5162 to look at the new patch set (#3). Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5135 To

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 4: Code-Review+1 I've simply chosen different names for the objects,

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. Patch Set 4: Code-Review+1 rebase -- To view, visit

  1   2   3   4   5   >