[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. Patch Set 4: (15 comments) I think this is looking pretty good. It turns out to hit a lot of interesting

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 9: Code-Review+1 (1 comment) I'm happy that the issue I mentioned is fixed. I

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. IMPALA-3748: Part 1: Clean up resource estimation in planner This is in preparation to use this

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-03 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#14). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs ..

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 15: (6 comments)

[Impala-ASF-CR] IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs

2017-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5876 To

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-02-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5811/5//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/scalar-fn-call.h File

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. IMPALA-3909: Populate min/max statistics in Parquet writer Change-Id:

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5611 To

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 9: I added logging just to double-check that the deep copy flag was present - it

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 4: (37 comments)

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of BufferedTupleStream that

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5848/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5850 Change subject: IMPALA-4808: old hash join can reference invalid memory .. IMPALA-4808: old hash join can reference invalid memory The

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4808: old hash join can reference invalid memory .. Patch Set 1: It looks like on the original CR there was some discussion about whether this was

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 18: The full test run caught a gap in my pre-review testing - the input argument types

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#18). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. Patch Set 4: (5 comments) Some minor cleanup and tests fixes

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. IMPALA-3748: Part 1: Clean up resource estimation in planner This is in preparation to use this

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. IMPALA-3748: Part 1: Clean up resource estimation in planner This is in preparation to use this

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5940 Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky The test

[Impala-ASF-CR] IMPALA-4895: Memory limit exceeded in test outer joins

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#20). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 22: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5161 To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#21). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 20: (2 comments)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 16: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/5161 To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 17: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5161 To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#16). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5914/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Download and signature links for 2.8.0 release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5638 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 2: (4 comments) Looking better, just some minor things

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 5: Removed the unnecessary call to Prepare() as discussed. -- To view, visit

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5739 to look at the new patch set (#5). Change subject: IMPALA-3748: add query-wide resource acquisition step ..

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 4: Talked offline with Marcel - he pointed out that we shouldn't need to call Prepare() from

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5772 Change subject: IMPALA-4801: fix heap use after free for MemTracker .. IMPALA-4801: fix heap use after free for MemTracker This is a

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 13: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe,

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5161/12/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#13). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430:

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 6: (13 comments) Thanks , I think this will be easier to move forward. I think to make

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 2: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/5772 To

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5772 to look at the new patch set (#2). Change subject: IMPALA-4801: fix heap use after free for MemTracker ..

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 8: I believe the current patchset still has the resource transfer bug (unless I

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMPALA-3748: add query-wide resource acquisition step This adds a Prepare() method to

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5739 To

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5772 To

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5788 Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. IMPALA-4820: avoid writing unencrypted data

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: Code-Review+1 (4 comments) Just a few minor things from my point of view.

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5584 to look at the new patch set (#18). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of BufferedTupleStream that

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5809 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5788/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of BufferedTupleStream that

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. IMPALA-4820: avoid writing unencrypted data during write cancellation The bug was that

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. IMPALA-4820: avoid writing unencrypted data during write cancellation The bug

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 4: I think it may have been accidentally disabled by the single node

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 10: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5415 To unsubscribe,

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5611 To unsubscribe,

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 7: Code-Review+1 (9 comments)

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4617: remove IsConstant() analysis from be .. IMPALA-4617: remove IsConstant() analysis from be This change avoids the need to duplicate the logic in

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. Patch Set 2: (6 comments) Need to look at fe and tests, but had some comments on the backend.

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 13: (10 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5584 to look at the new patch set (#17). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool ..

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment) It seems like we really need to talk through the big picture of what to

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5801 Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool Create global BufferPool at startup.

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 12: (22 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 6: (1 comment) One final issue. I'm assuming that we're going to rename

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5683 to look at the new patch set (#4). Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/5161/10/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 11: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5630 To

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5683 to look at the new patch set (#6). Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 6: Code-Review+2 There was a mistake in merging when I rebased. Fixed it. -- To

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 1: (8 comments) The general approach looks good - mainly the comments are

  1   2   3   4   5   6   7   8   9   10   >