Alexey Serbin has posted comments on this change.
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Patch Set 3: Verified+1
Unrelated failure in DEBUG configuration:
kudu/tests/test_scantoken.py
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5872
to review the following change.
Change subject: thirdparty: Revert build dir cleanup changes
..
thirdparty: Revert
Alexey Serbin has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5845/4/src/kudu/security/tls_context.cc
File
Sailesh Mukil has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 3:
> (1 comment)
We will still be using Kerberos + TLS for now. I went over the change and the
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5874
Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
and archive.cloudera
..
KUDU-1854 Fixed broken links to
Alexey Serbin has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5865/3/src/kudu/rpc/sasl_common.h
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5873
Change subject: tablet copy: Include local peer UUID in TabletCopyService log
messages
..
tablet copy: Include local peer UUID in
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
and archive.cloudera
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
and archive.cloudera
..
KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
and
Todd Lipcon has posted comments on this change.
Change subject: Update Impala docs for Impala 2.8 release
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5875
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: Update Impala docs for Impala 2.8 release
..
Update Impala docs for Impala 2.8 release
* No longer needs to document the special 'IMPALA_KUDU' build.
*
Alexey Serbin has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5846
To unsubscribe, visit
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5865
to look at the new patch set (#3).
Change subject: [security] adjust TLS certificate verification
..
Dan Burkert has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 2:
(1 comment)
OK - I think the thing to do here is implement mutual cert authentication, then
merge
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5875
Change subject: Update Impala docs for Impala 2.8 release
..
Update Impala docs for Impala 2.8 release
* No longer needs to document the
David Ribeiro Alves has posted comments on this change.
Change subject: exactly_once_rpc-test: properly propagate sleep parameter
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5883
To
Adar Dembo has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 9:
(20 comments)
I didn't review the changes to master_cert_authority since I have no context
for
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5880
to review the following change.
Change subject: [security] Simplify MakeSignature and VerifySignature impls
Todd Lipcon has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5865
To unsubscribe, visit
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5867
to look at the new patch set (#2).
Change subject: Fix some clang-tidy errors for std::move
..
Fix
Todd Lipcon has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 1:
(1 comment)
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5883
Change subject: exactly_once_rpc-test: properly propagate sleep parameter
..
exactly_once_rpc-test: properly propagate sleep parameter
Alexey Serbin has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5867
To unsubscribe, visit
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5878
Change subject: Update docs from branch-1.2.x
7fa56a53ae40fd89bcd79426386dbd004547b305
..
Update docs from branch-1.2.x
Todd Lipcon has submitted this change and it was merged.
Change subject: Update docs from branch-1.2.x
7fa56a53ae40fd89bcd79426386dbd004547b305
..
Update docs from branch-1.2.x 7fa56a53ae40fd89bcd79426386dbd004547b305
Todd Lipcon has posted comments on this change.
Change subject: Update docs from branch-1.2.x
7fa56a53ae40fd89bcd79426386dbd004547b305
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: [security] adjust TLS certificate verification
..
[security] adjust TLS certificate verification
This commit adjusts when TLS certificate verification is
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 4:
Thanks Todd. As Todd fixed in the patch, the issue was that the client had a
Dan Burkert has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5865/3/src/kudu/rpc/sasl_common.h
File
Todd Lipcon has posted comments on this change.
Change subject: thirdparty: Revert build dir cleanup changes
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5872
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: thirdparty: Revert build dir cleanup changes
..
thirdparty: Revert build dir cleanup changes
This patch reverts the following patches due to issues with
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5882
Change subject: Make reduce flake from KUDU-1642 tests in client-test
..
Make reduce flake from KUDU-1642 tests in client-test
This ups
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5868
to look at the new patch set (#2).
Change subject: client: rename various function calls and classes to
ConnectToCluster
Adar Dembo has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5867
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Move 'master_rpc.{h,cc}' into the client/ module
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5864
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/client/master_rpc.cc
File
Todd Lipcon has posted comments on this change.
Change subject: [security] Simplify MakeSignature and VerifySignature impls
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5880
To unsubscribe,
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#4).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Adar Dembo has posted comments on this change.
Change subject: Make reduce flake from KUDU-1642 tests in client-test
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5882
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 2: Code-Review+2
(1 comment)
Dan Burkert has submitted this change and it was merged.
Change subject: [security] Simplify MakeSignature and VerifySignature impls
..
[security] Simplify MakeSignature and VerifySignature impls
Change-Id:
Dan Burkert has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 2:
(1 comment)
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5884
to review the following change.
Change subject: [security] add channel binding to krpc
..
[security]
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#9).
Change subject: [master] store CA information in the system table
..
[master]
Adar Dembo has posted comments on this change.
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5870
To unsubscribe, visit
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5892
to review the following change.
Change subject: master_rpc: pass back more details from ConnectToCluster
Alexey Serbin has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6: Code-Review+2
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: master_rpc: pass back more details from ConnectToCluster
..
Patch Set 1:
(3 comments)
Callback chains make my brain hurt...
Hello Mike Percy, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5885
to review the following change.
Change subject: [tools] Add missing help text from few tools
..
[tools]
Todd Lipcon has submitted this change and it was merged.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
client: rename various function calls and classes to ConnectToCluster
This is a
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Include local peer UUID in TabletCopyService log
messages
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5873
To
Todd Lipcon has submitted this change and it was merged.
Change subject: tablet copy: Include local peer UUID in TabletCopyService log
messages
..
tablet copy: Include local peer UUID in TabletCopyService log messages
Also,
Adar Dembo has posted comments on this change.
Change subject: KUDU-1856: always truncate containers when they get full
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5852/1//COMMIT_MSG
Commit Message:
PS1,
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5869
to look at the new patch set (#3).
Change subject: Add new ConnectToMaster RPC, implement client fallback
Adar Dembo has posted comments on this change.
Change subject: Add new ConnectToMaster RPC, implement client fallback
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5869
To unsubscribe, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5857
to look at the new patch set (#2).
Change subject: thirdparty: patch cmake on SLES 12 SP0 to avoid hanging
..
Todd Lipcon has posted comments on this change.
Change subject: thirdparty: patch cmake on SLES 12 SP0 to avoid hanging
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5857
To unsubscribe,
Dan Burkert has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/cert.cc
File
Dan Burkert has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5845
To unsubscribe, visit
Hello Todd Lipcon, Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5884
to look at the new patch set (#2).
Change subject: [security] add channel binding to krpc
..
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 4:
So the ASAN build fails because the renew thread is leaking all its
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 4:
(4 comments)
Todd Lipcon has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5845/4/src/kudu/security/tls_context.cc
File
Alexey Serbin has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5884/2/src/kudu/security/cert.cc
File
Todd Lipcon has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6:
Failure was unrelated (some tsan hang - emailed the tsan mailing list about it)
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5852
to look at the new patch set (#2).
Change subject: KUDU-1856: always truncate containers when they get full
..
Adar Dembo has posted comments on this change.
Change subject: Add new ConnectToMaster RPC, implement client fallback
..
Patch Set 2: Code-Review+2
(1 comment)
Todd Lipcon has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 2:
(19 comments)
http://gerrit.cloudera.org:8080/#/c/5884/2//COMMIT_MSG
Commit Message:
Line 7: [security]
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5845
to look at the new patch set (#6).
Change subject: Allow configuring TlsContext with key wrappers
..
Alexey Serbin has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5884/2/src/kudu/security/cert.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5884
to look at the new patch set (#4).
Change subject: [security] add channel binding to krpc
..
[security] add
Dan Burkert has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5846
To unsubscribe, visit
Dan Burkert has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 2:
(26 comments)
http://gerrit.cloudera.org:8080/#/c/5884/2//COMMIT_MSG
Commit Message:
Line 7: [security]
Todd Lipcon has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5845/6/src/kudu/security/cert.h
File
Alexey Serbin has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 4: Code-Review+1
(4 comments)
Looks good to me: just a couple of nits. I don't feel confident in SASL, so
Dan Burkert has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5845/6/src/kudu/security/cert.h
File
Todd Lipcon has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5884/4/docs/design-docs/rpc.md
File
Todd Lipcon has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5868
To
Todd Lipcon has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 2:
(2 comments)
Todd Lipcon has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5867
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix some clang-tidy errors for std::move
..
Fix some clang-tidy errors for std::move
Clang-tidy reported a few errors in a recent code review
of moved
Todd Lipcon has submitted this change and it was merged.
Change subject: Add new ConnectToMaster RPC, implement client fallback
..
Add new ConnectToMaster RPC, implement client fallback
This adds a new RPC to the master called
Adar Dembo has posted comments on this change.
Change subject: [tools] Add missing help text from few tools
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5885
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 4:
> So the ASAN build fails because the renew thread is leaking all its
>
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5845
to look at the new patch set (#5).
Change subject: Allow configuring TlsContext with key wrappers
..
Todd Lipcon has posted comments on this change.
Change subject: WIP: Add new ConnectToMaster RPC, implement client fallback
..
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/5869/1/src/kudu/client/master_rpc.cc
Dan Burkert has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5884/2/src/kudu/security/cert.cc
File
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5884
to look at the new patch set (#5).
Change subject: [security] add channel binding to krpc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5871
to look at the new patch set (#2).
Change subject: master: issue authentication tokens and CA certs to clients
..
Dan Burkert has posted comments on this change.
Change subject: master: issue authentication tokens and CA certs to clients
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5871/2/src/kudu/master/master.proto
90 matches
Mail list logo
