[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5677 to look at the new patch set (#7). Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

[kudu-CR] Fix TSAN segfault on Centos 6

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix TSAN segfault on Centos 6 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5924 To unsubscribe, visit

[kudu-CR] Fix TSAN segfault on Centos 6

2017-02-07 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5924 to review the following change. Change subject: Fix TSAN segfault on Centos 6 .. Fix TSAN segfault on Centos 6 The

[kudu-CR] Add KuduTable::formatted range partitions in cpp client.

2017-02-07 Thread zhen.zhang (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5893 to look at the new patch set (#2). Change subject: Add KuduTable::formatted_range_partitions in cpp client. .. Add

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5925 to review the following change. Change subject: java: remove unused parts of SecureRpcHelper ..

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5927 to review the following change. Change subject: Make SecureRpcHelper a Netty pipeline stage ..

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5926 to review the following change. Change subject: java: use a netty frame decoder instead of replaying decoder

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 1: (2 comments) Good on you for addressing this. I'd be curious to see how it

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5925 To unsubscribe, visit

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 1: (1 comment)

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: master_rpc: pass back more details from ConnectToCluster .. master_rpc: pass back more details from ConnectToCluster This plumbs back the

[kudu-CR] master: issue authentication tokens and CA certs to clients

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: master: issue authentication tokens and CA certs to clients .. master: issue authentication tokens and CA certs to clients This adds the code to the

[kudu-CR] client: trust master's cert, adopt authn token

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5899 to look at the new patch set (#6). Change subject: client: trust master's cert, adopt authn token .. client: trust

[kudu-CR] client: trust master's cert, adopt authn token

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5899 to look at the new patch set (#7). Change subject: client: trust master's cert, adopt authn token .. client: trust

[kudu-CR] client: trust master's cert, adopt authn token

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client: trust master's cert, adopt authn token .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5899 To unsubscribe, visit

[kudu-CR] WIP: fixes for java client kerberos against a real cluster

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: fixes for java client kerberos against a real cluster .. Patch Set 2: (6 comments)

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 1: (1 comment)

[kudu-CR] compaction: Flush tablet metadata before updating stores

2017-02-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5920 to look at the new patch set (#2). Change subject: compaction: Flush tablet metadata before updating stores ..

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#30). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5818 To unsubscribe, visit

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#31). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] WIP [security] tailored TokenSigner for system catalog

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5930 Change subject: WIP [security] tailored TokenSigner for system catalog .. WIP [security] tailored TokenSigner for system catalog

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5677 to look at the new patch set (#8). Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 7: (2 comments) Two nits and please add a comment regarding string

[kudu-CR] KUDU-1856: always truncate containers when they get full

2017-02-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full .. Patch Set 3: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1856: always truncate containers when they get full

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5852/3/src/kudu/util/env_posix.cc File

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: compaction: Add additional validation in DeltaTracker .. compaction: Add additional validation in DeltaTracker This adds DEBUG-mode validation to

[kudu-CR] compaction: Flush tablet metadata before updating stores

2017-02-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5920 to look at the new patch set (#3). Change subject: compaction: Flush tablet metadata before updating stores ..

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 1: (1 comment)

[kudu-CR] WIP [security] tailored TokenSigner for system catalog

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: WIP [security] tailored TokenSigner for system catalog .. WIP [security] tailored TokenSigner for system catalog Updated the TokenSigner class in preparation to

[kudu-CR] KUDU-1856: always truncate containers when they get full

2017-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5852/3/src/kudu/util/env_posix.cc File

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 30: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit

[kudu-CR] WIP: enable kerberos support in CSD

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: enable kerberos support in CSD .. Patch Set 1: yea, that's fine. It's useful to have up on gerrit, though -- makes it much easier to test in a kerberized

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 27: (3 comments) http://gerrit.cloudera.org:8080/#/c/5620/27/src/kudu/client/symbols.map File

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 9: (2 comments)

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5677 to look at the new patch set (#9). Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 32: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5926 to look at the new patch set (#2). Change subject: java: use a netty frame decoder instead of replaying decoder

[kudu-CR] java: fix ability to connect to a real Kerberized cluster

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5922 to look at the new patch set (#3). Change subject: java: fix ability to connect to a real Kerberized cluster

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5927 to look at the new patch set (#2). Change subject: Make SecureRpcHelper a Netty pipeline stage

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#35). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 1: (3 comments)

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 34: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/34/src/kudu/util/minidump.h File

[kudu-CR] Add missing pb util proto dependency to token proto

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add missing pb_util_proto dependency to token_proto .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5932 To unsubscribe, visit

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 1: (2 comments)

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5925 to look at the new patch set (#2). Change subject: java: remove unused parts of SecureRpcHelper

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#32). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#34). Change subject: Add Google Breakpad support to Kudu ..

[kudu-CR] Add missing pb util proto dependency to token proto

2017-02-07 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5932 to review the following change. Change subject: Add missing pb_util_proto dependency to token_proto .. Add missing

[kudu-CR] Add missing pb util proto dependency to token proto

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add missing pb_util_proto dependency to token_proto .. Add missing pb_util_proto dependency to token_proto Change-Id:

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 1: (1 comment)

[kudu-CR] WIP: fixes for java client kerberos against a real cluster

2017-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: fixes for java client kerberos against a real cluster .. Patch Set 2: (10 comments)

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 1: (1 comment)

[kudu-CR] [security] clean-up on cert management-test.cc

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5937 Change subject: [security] clean-up on cert_management-test.cc .. [security] clean-up on cert_management-test.cc A minor clean-up on

[kudu-CR] [security] method to check if X509 cert matches key

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5936 Change subject: [security] method to check if X509 cert matches key .. [security] method to check if X509 cert matches key Added a

[kudu-CR] java: fix ability to connect to a real Kerberized cluster

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix ability to connect to a real Kerberized cluster .. Patch Set 3: (4 comments)

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 2: (1 comment)

[kudu-CR] WIP [security] load TSK from system table

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5935 Change subject: WIP [security] load TSK from system table .. WIP [security] load TSK from system table Change-Id:

[kudu-CR] WIP [security] tailored TokenSigner for system catalog

2017-02-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#3). Change subject: WIP [security] tailored TokenSigner for system catalog .. WIP

[kudu-CR] Fix TSAN segfault on Centos 6

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Fix TSAN segfault on Centos 6 .. Fix TSAN segfault on Centos 6 The OpenSSL version shipped with Centos 6 appears to segfault if a nullptr is passed to

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5919 To unsubscribe,

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: Include peer uuid in log prefix .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5918 To unsubscribe, visit

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: tablet: Include peer uuid in log prefix .. tablet: Include peer uuid in log prefix Also, add LogPrefix() to the tablet mm op. Change-Id:

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5919 To

[kudu-CR] client: trust master's cert, adopt authn token

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: client: trust master's cert, adopt authn token .. Patch Set 7: Code-Review+2 restarted verify, I think it was fallout from the workspace issues. -- To view,

[kudu-CR] WIP: enable kerberos support in CSD

2017-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: enable kerberos support in CSD .. Patch Set 1: I think we should hold off on committing this until we review all of the new security flags comprehensively.

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#9). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#10). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] master: issue authentication tokens and CA certs to clients

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master: issue authentication tokens and CA certs to clients .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5871 To

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master_rpc: pass back more details from ConnectToCluster .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5892 To unsubscribe,