[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4363 to look at the new patch set (#20). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Dan Burkert has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6029/3/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#4). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6029/3/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] security: authorize all RPCs against coarse-grained ACLs

Todd Lipcon has posted comments on this change. Change subject: security: authorize all RPCs against coarse-grained ACLs .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5998/6//COMMIT_MSG Commit Message:

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/6112/7/src/kudu/util/flags.cc File

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 3: -Verified > I'm not a fan of setting it to 10 seconds. It's not an issue for > distributed

[kudu-CR] [security] added info on non-renewable authn tokens

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6122 to look at the new patch set (#2). Change subject: [security] added info on non-renewable authn tokens

[kudu-CR] [security] added info on non-renewable authn tokens

Alexey Serbin has posted comments on this change. Change subject: [security] added info on non-renewable authn tokens .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6122/1/src/kudu/master/master.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#6). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#3). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6129 Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893 Ensure evaluation of added columns During a normal scan, a

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Mike Percy has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 20: Verified+1 Overriding "failed to bind" error unrelated to this patch. -- To view,

[kudu-CR] Validate security flags with gflags validators

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6128 to look at the new patch set (#2). Change subject: Validate security flags with gflags validators .. Validate

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: Just want to point out that this potentially breaks the abstraction of only evaluate when

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 18: (13 comments) http://gerrit.cloudera.org:8080/#/c/4363/18//COMMIT_MSG

[kudu-CR] Validate security flags with gflags validators

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6128 to look at the new patch set (#3). Change subject: Validate security flags with gflags validators .. Validate

[kudu-CR] Validate security flags with gflags validators

Dan Burkert has posted comments on this change. Change subject: Validate security flags with gflags validators .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6128/2/src/kudu/rpc/messenger.cc File

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

Dan Burkert has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 3: I'm not a fan of setting it to 10 seconds. It's not an issue for distributed tests, but this

[kudu-CR] master: Do not acquire lock during CatalogManager::Init()

Mike Percy has posted comments on this change. Change subject: master: Do not acquire lock_ during CatalogManager::Init() .. Patch Set 3: OK that's fair. I'll abandon this one since I don't need it anymore. -- To view, visit

[kudu-CR] master: Do not acquire lock during CatalogManager::Init()

Mike Percy has abandoned this change. Change subject: master: Do not acquire lock_ during CatalogManager::Init() .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6100 To unsubscribe, visit

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: One alternative to this would be to have the DefaultColumnValueIterator switch decoder-level

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#2). Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893

[kudu-CR] Validate security flags with gflags validators

Adar Dembo has posted comments on this change. Change subject: Validate security flags with gflags validators .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6128/2/src/kudu/rpc/messenger.cc File

[kudu-CR] security: authorize all RPCs against coarse-grained ACLs

Dan Burkert has posted comments on this change. Change subject: security: authorize all RPCs against coarse-grained ACLs .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5998/6//COMMIT_MSG Commit Message:

[kudu-CR] [security] added info on non-renewable authn tokens

Dan Burkert has posted comments on this change. Change subject: [security] added info on non-renewable authn tokens .. Patch Set 1: Code-Review+1 LGTM modulo Todd's comments. -- To view, visit

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Mike Percy has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 16: (7 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4363 to look at the new patch set (#18). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 20: Code-Review+2 (1 comment)

[kudu-CR] security: authorize all RPCs against coarse-grained ACLs

Todd Lipcon has posted comments on this change. Change subject: security: authorize all RPCs against coarse-grained ACLs .. Patch Set 7: Verified+1 Failures are known flakes -- To view, visit

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6134 Change subject: [catalog manager] fixed deadlock on catalog shutdown .. [catalog manager] fixed deadlock on catalog shutdown Fixed

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Mike Percy has submitted this change and it was merged. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. KUDU-1601. Delete ancient UNDO delta blocks in the background This patch adds a

[kudu-CR] [security] added info on non-renewable authn tokens

Todd Lipcon has posted comments on this change. Change subject: [security] added info on non-renewable authn tokens .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6122/1/src/kudu/master/master.cc File

[kudu-CR] client-test-util: Increase ScanTableToStrings() timeout

Mike Percy has submitted this change and it was merged. Change subject: client-test-util: Increase ScanTableToStrings() timeout .. client-test-util: Increase ScanTableToStrings() timeout This may ease timeouts seen on Jenkins

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Mike Percy has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 18: (12 comments) http://gerrit.cloudera.org:8080/#/c/4363/18//COMMIT_MSG Commit

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4363 to look at the new patch set (#19). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/cfile/binary_dict_block.h File

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

Mike Percy has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 18: Posting an updated patch for review. I'll follow up here with more testing details

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 19: Code-Review+1 code lgtm, just waiting on those dist-test/cluster test

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (2 comments)

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#5). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] Validate security flags with gflags validators

Adar Dembo has posted comments on this change. Change subject: Validate security flags with gflags validators .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6128 To unsubscribe, visit

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

Dan Burkert has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

Dan Burkert has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 3: Code-Review+2 Ah, I missed the bit about KUDU_ALLOW_SLOW_TESTS. In that case I'm fine with

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6117 To unsubscribe, visit

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

Alexey Serbin has submitted this change and it was merged. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. [token-test] fixed TestTokenSignerAddKeys flakiness When running the test, make sure the test

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#4). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] Validate security flags with gflags validators

Dan Burkert has submitted this change and it was merged. Change subject: Validate security flags with gflags validators .. Validate security flags with gflags validators This allows validation to be done early in server

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 3: (4 comments) Based on my experience in the alter code, I think this should "just work" after

[kudu-CR] [security] Add require authentication option to C++ client

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6121 to look at the new patch set (#3). Change subject: [security] Add require_authentication option to C++ client ..

[kudu-CR] [security] Add require authentication option to C++ client

Dan Burkert has posted comments on this change. Change subject: [security] Add require_authentication option to C++ client .. Patch Set 3: (5 comments)

[kudu-CR] master: Do not acquire lock during CatalogManager::Init()

David Ribeiro Alves has posted comments on this change. Change subject: master: Do not acquire lock_ during CatalogManager::Init() .. Patch Set 4: Which follow up patch? Was this related to the "server-wide" op? Now that we

[kudu-CR] client-test-util: Increase ScanTableToStrings() timeout

David Ribeiro Alves has posted comments on this change. Change subject: client-test-util: Increase ScanTableToStrings() timeout .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6104 To

[kudu-CR] [security] Add require authentication option to C++ client

Todd Lipcon has posted comments on this change. Change subject: [security] Add require_authentication option to C++ client .. Patch Set 1: For testing, might be nice to rebase on top of https://gerrit.cloudera.org/#/c/5998/

[kudu-CR] Validate security flags with gflags validators

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6128 to review the following change. Change subject: Validate security flags with gflags validators .. Validate security

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 17: (1 comment)