[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8531 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Patch Set 1: Verified+1 Seems I hit KUDU-1863

[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Removed Verified+1 by Todd Lipcon -- To view, visit

[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8531 To

[kudu-CR] Fix warnings from clang-6.0

2017-11-13 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8538 to review the following change. Change subject: Fix warnings from clang-6.0 .. Fix warnings from clang-6.0 Running

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 5: (1 comment)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 5: (2 comments)

[kudu-CR] Fix warnings from clang-6.0

2017-11-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8538 ) Change subject: Fix warnings from clang-6.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8538 To

[kudu-CR] Fix warnings from clang-6.0

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8538 ) Change subject: Fix warnings from clang-6.0 .. Fix warnings from clang-6.0 Running a nightly clang popped out a few new warnings

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 5: (1 comment)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 23: (17 comments)

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: (4 comments)

[kudu-CR] Add the ability to enable xray instrumentation

2017-11-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 ) Change subject: Add the ability to enable xray instrumentation .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 5: (1 comment)

[kudu-CR] Add the ability to enable xray instrumentation

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 ) Change subject: Add the ability to enable xray instrumentation .. Patch Set 1: (1 comment)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 5: (1 comment)

[kudu-CR] Add the ability to enable xray instrumentation

2017-11-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 ) Change subject: Add the ability to enable xray instrumentation .. Patch Set 1: (1 comment)

[kudu-CR] Strip Hadoop and Hive tarballs of unecessary lib jars

2017-11-13 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8535 ) Change subject: Strip Hadoop and Hive tarballs of unecessary lib jars .. Strip Hadoop and Hive tarballs of unecessary lib jars

[kudu-CR] KUDU-2215. kernel stack watchdog: avoid blocking thread exit

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8536 ) Change subject: KUDU-2215. kernel_stack_watchdog: avoid blocking thread exit .. Patch Set 1: (4 comments) Injection looks good, mostly

[kudu-CR] Add the ability to enable xray instrumentation

2017-11-13 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8537 to review the following change. Change subject: Add the ability to enable xray instrumentation .. Add the ability to

[kudu-CR](branch-1.2.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8532 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. KUDU-2209. HybridClock doesn't handle changes

[kudu-CR] tool: new action for adding to the set of data directories

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new action for adding to the set of data directories .. tool: new action for adding to the set of data

[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8531 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. KUDU-2209. HybridClock doesn't handle changes

[kudu-CR](branch-1.2.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8532 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8531 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Patch Set 1: Verified+1 Code-Review+2 Jenkins

[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8531

[kudu-CR] tool: new action for adding to the set of data directories

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new action for adding to the set of data directories .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 4: (1 comment)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 5: > Patch Set 5: > > (2 comments) Thanks for the proposal!

[kudu-CR](branch-1.2.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8532 Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. KUDU-2209. HybridClock doesn't handle changes in

[kudu-CR](branch-1.4.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8530 to review the following change. Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag ..

[kudu-CR](branch-1.3.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8531 Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. KUDU-2209. HybridClock doesn't handle changes in

[kudu-CR](branch-1.4.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8530 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#4). Change subject: tablet: check for stopped in drivers of IO

[kudu-CR] Updated known limitations to clarify column and row maximum size recommendations.

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8514 ) Change subject: Updated known limitations to clarify column and row maximum size recommendations. .. Patch Set 2: (1 comment)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-11-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#23). Change subject: mvcc: allow tablet shutdown without completing txs

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 4: (8 comments)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#5). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] tablet: check for stopped in drivers of IO

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: check for stopped in drivers of IO .. Patch Set 4: I've changed the part of this patch that tries to enforce

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-11-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 23: (1 comment)

[kudu-CR] KUDU-2191 (5/n): WIP: Hive Metastore notification log event listener

2017-11-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8313 ) Change subject: KUDU-2191 (5/n): WIP: Hive Metastore notification log event listener .. Patch Set 3: This is going to be significantly

[kudu-CR] KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration

2017-11-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration .. Patch Set 3: (14 comments) This is going to be

[kudu-CR] MiniHms: log HMS thread stacks when startup times out

2017-11-13 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8534 ) Change subject: MiniHms: log HMS thread stacks when startup times out .. MiniHms: log HMS thread stacks when startup times out

[kudu-CR](branch-1.4.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8530 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. KUDU-2209. HybridClock doesn't handle changes

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-13 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8533 Change subject: Add initial internal INT128/__int128 support .. Add initial internal INT128/__int128 support This patch adds internal

[kudu-CR] error manager: synchronize/serialize handling

2017-11-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 4: (2 comments)

[kudu-CR] Strip Hadoop and Hive tarballs of unecessary lib jars

2017-11-13 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8535 to review the following change. Change subject: Strip Hadoop and Hive tarballs of unecessary lib jars .. Strip Hadoop

[kudu-CR] MiniHms: log HMS thread stacks when startup times out

2017-11-13 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8534 to review the following change. Change subject: MiniHms: log HMS thread stacks when startup times out .. MiniHms: log

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 ) Change subject: Add initial internal INT128/__int128 support .. Patch Set 2: (2 comments)

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 ) Change subject: Add initial internal INT128/__int128 support .. Patch Set 2: (2 comments)

[kudu-CR] MiniHms: log HMS thread stacks when startup times out

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8534 ) Change subject: MiniHms: log HMS thread stacks when startup times out .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 ) Change subject: Add initial internal INT128/__int128 support .. Patch Set 2: (2 comments)

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-13 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8533 to look at the new patch set (#2). Change subject: Add initial internal INT128/__int128 support .. Add

[kudu-CR] KUDU-2215. kernel stack watchdog: avoid blocking thread exit

2017-11-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8536 to review the following change. Change subject: KUDU-2215. kernel_stack_watchdog: avoid blocking thread exit ..

[kudu-CR] Strip Hadoop and Hive tarballs of unecessary lib jars

2017-11-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8535 ) Change subject: Strip Hadoop and Hive tarballs of unecessary lib jars .. Patch Set 1: Code-Review+2 -- To view, visit