[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9466 to look at the new patch set (#3). Change subject: [docs] Improvements to multi-master migration doc ..

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/946

[kudu-CR] Make metrics name matching case-insensitive

2018-03-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9462 to look at the new patch set (#3). Change subject: Make metrics name matching case-insensitive .

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] dist test: fix the ability to pass flags to the 'run' option

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9502 ) Change subject: dist_test: fix the ability to pass flags to the 'run' option .. dist_test: fix the ability to pass flags to the 'r

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9503 to look at the new patch set (#2). Change subject: build: adjust the number of processors for various tests .

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-721: [Python] Add DECIMAL column type support

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9496 ) Change subject: KUDU-721: [Python] Add DECIMAL column type support .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2312: Scan predicate application ordering is non-deterministic

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9440 ) Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic .. Patch Set 4: Code-Review+2 > No, we put the predi

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.clouder

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-721: [Python] Add DECIMAL column type support

2018-03-06 Thread Grant Henke (Code Review)
Hello a...@phdata.io, David Ribeiro Alves, Wes McKinney, Kudu Jenkins, Jordan Birdsell, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9496 to look at the new patch set (#4). Change subject: KUDU-721: [Python] Add DECIMAL column type support ..

[kudu-CR] KUDU-721: [Python] Add DECIMAL column type support

2018-03-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9496 ) Change subject: KUDU-721: [Python] Add DECIMAL column type support .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9496

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. Patch Set 3: (5 comments) In the vein of "no good deed goes unpunish

[kudu-CR] Make metrics name matching case-insensitive

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9462 ) Change subject: Make metrics name matching case-insensitive .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-2312: Scan predicate application ordering is non-deterministic

2018-03-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9440 ) Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic .. KUDU-2312: Scan predicate application orde

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [tools] Allow move tool to work when uninvolved tserver is down

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9510 Change subject: [tools] Allow move tool to work when uninvolved tserver is down .. [tools] Allow move tool to work when uninvolved tserve

[kudu-CR] [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down

2018-03-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9510 to look at the new patch set (#2). Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down ..

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration .. Patch Set 4: (10 comments) Just responding to your respons

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9510 ) Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down .. Patch Set 2: (3 comments) http://gerrit.cl

[kudu-CR] tablet: remove an ancient TODO about being able to configure storage attributes

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9512 to review the following change. Change subject: tablet: remove an ancient TODO about being able to configure storage attributes ..

[kudu-CR] tablet: remove an ancient TODO about being able to configure storage attributes

2018-03-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9512 ) Change subject: tablet: remove an ancient TODO about being able to configure storage attributes .. Patch Set 1: Code-Review+2 -- To vie

[kudu-CR] KUDU-721: [Python] Add DECIMAL column type support

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9496 ) Change subject: KUDU-721: [Python] Add DECIMAL column type support .. Patch Set 4: leaving open in case wes/cpcloud want to take

[kudu-CR] KUDU-721: [Python] Add DECIMAL column type support

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9496 ) Change subject: KUDU-721: [Python] Add DECIMAL column type support .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] Make metrics name matching case-insensitive

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9462 ) Change subject: Make metrics name matching case-insensitive .. Make metrics name matching case-insensitive Some metrics have mi

[kudu-CR] [webui] Add warning for even number of masters

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9513 Change subject: [webui] Add warning for even number of masters .. [webui] Add warning for even number of masters Preview at https://git

[kudu-CR] tablet: remove an ancient TODO about being able to configure storage attributes

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9512 ) Change subject: tablet: remove an ancient TODO about being able to configure storage attributes .. tablet: remove an ancient TODO

[kudu-CR] tablet: remove an ancient TODO about being able to configure storage attributes

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tablet: remove an ancient TODO about being able to configure storage attributes .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera

[kudu-CR] tablet: remove an ancient TODO about being able to configure storage attributes

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9512 ) Change subject: tablet: remove an ancient TODO about being able to configure storage attributes .. Patch Set 1: Verified+1 -- To view,

[kudu-CR] [webui] Add warning for even number of masters

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9513 ) Change subject: [webui] Add warning for even number of masters .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-2230: java: sync client exception stack traces should make sense

2018-03-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9489 ) Change subject: KUDU-2230: java: sync client exception stack traces should make sense .. Patch Set 1: (1 comment) http://gerrit.cloud

[kudu-CR] KUDU-2230: java: sync client exception stack traces should make sense

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9489 ) Change subject: KUDU-2230: java: sync client exception stack traces should make sense .. Patch Set 1: (1 comment) http://gerrit.clouder

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9503 to look at the new patch set (#3). Change subject: build: adjust the number of processors for various tests .

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [webui] Add warning for even number of masters

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9513 ) Change subject: [webui] Add warning for even number of masters .. [webui] Add warning for even number of masters Preview at ht

[kudu-CR] KUDU-2230: java: sync client exception stack traces should make sense

2018-03-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9489 ) Change subject: KUDU-2230: java: sync client exception stack traces should make sense .. Patch Set 1: (1 comment) http://gerrit.cloud

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. KUDU-2309: /masters can show the wrong list of masters

[kudu-CR] KUDU-1704: add java client support for READ YOUR WRITES mode

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 ) Change subject: KUDU-1704: add java client support for READ_YOUR_WRITES mode .. Patch Set 7: (1 comment) http://gerrit.cloudera.

[kudu-CR] docs: add warning to wait between FS rebuilds

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9279 ) Change subject: docs: add warning to wait between FS rebuilds .. docs: add warning to wait between FS rebuilds Customers who are

[kudu-CR] docs: add warning to wait between FS rebuilds

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9279 ) Change subject: docs: add warning to wait between FS rebuilds .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9466 to look at the new patch set (#4). Change subject: [docs] Improvements to multi-master migration doc ..

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/946

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. Patch Set 4: Verified+1 Docs-only change. -- To view, visit http

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. Removed reviewer Kudu Jenkins. -- To view, visit http://ger

[kudu-CR] [docs] Improvements to multi-master migration doc

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9466 ) Change subject: [docs] Improvements to multi-master migration doc .. [docs] Improvements to multi-master migration doc - Add ex

[kudu-CR] build: adjust the number of processors for various tests

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9503 ) Change subject: build: adjust the number of processors for various tests .. build: adjust the number of processors for various tes

[kudu-CR] build: stop generating md5 file

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9504 ) Change subject: build: stop generating md5 file .. build: stop generating md5 file New guidance from the ASF is to not generate m

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9110 to look at the new patch set (#4). Change subject: docs: update docs for update_dirs tool ..

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9110/4/docs/admini

[kudu-CR] decimal util: do not produce warnings when building with gcc

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9499 ) Change subject: decimal_util: do not produce warnings when building with gcc .. decimal_util: do not produce warnings when building

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9110/4/docs/admin

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9110 to look at the new patch set (#5). Change subject: docs: update docs for update_dirs tool ..

[kudu-CR] Fix python build script print newlines

2018-03-06 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9520 to review the following change. Change subject: Fix python build script print newlines .. Fix python build

[kudu-CR] Fix python build script print newlines

2018-03-06 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9520 to look at the new patch set (#2). Change subject: Fix python build script print newlines ..

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9110

[kudu-CR] Fix python build script print newlines

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9520 ) Change subject: Fix python build script print newlines .. Patch Set 2: Code-Review+2 Can't say I understand, but if it fixes the problem,

[kudu-CR] Fix python build script print newlines

2018-03-06 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9520 to look at the new patch set (#3). Change subject: Fix python build script print newlines ..

[kudu-CR] Fix python build script print newlines

2018-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9520 ) Change subject: Fix python build script print newlines .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/95

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: docs: update docs for update_dirs tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9110 To unsubscribe, visit http:

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9110

[kudu-CR] KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9375 to look at the new patch set (#2). Change subject: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

[kudu-CR] KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9375 to look at the new patch set (#3). Change subject: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

[kudu-CR] KUDU-1913: cap number of threads on server-wide pools

2018-03-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9522 to review the following change. Change subject: KUDU-1913: cap number of threads on server-wide pools

[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support

2018-03-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9521 to review the following change. Change subject: env: generalize resource limits and add RLIMIT_NPROC support .

[kudu-CR] Fix python build script print newlines

2018-03-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9520 ) Change subject: Fix python build script print newlines .. Fix python build script print newlines This is a fixup for 112869cf22c4

[kudu-CR] KUDU-1913: cap number of threads on server-wide pools

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9522 ) Change subject: KUDU-1913: cap number of threads on server-wide pools .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9521 ) Change subject: env: generalize resource limits and add RLIMIT_NPROC support .. Patch Set 1: (2 comments) http://gerrit.cloudera

[kudu-CR] KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9375 to look at the new patch set (#4). Change subject: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

[kudu-CR] KUDU-2297 (part 6): enable periodic stack sampling by default, avoid bias

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9523 to review the following change. Change subject: KUDU-2297 (part 6): enable periodic stack sampling by default, avoid bias .

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 5: rebase -- To view, visit http://gerrit.cloudera.org:8080/9110 To

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9110 to look at the new patch set (#6). Change subject: docs: update docs for update_dirs tool ..

[kudu-CR] build: don't name unsharded tests with a shard suffix

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9524 to review the following change. Change subject: build: don't name unsharded tests with a shard suffix .. build: don't n

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 2: I think we could pretty easily benchmark this by loading a fe

[kudu-CR] [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down

2018-03-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9510 ) Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down .. Patch Set 2: (3 comments) http://gerrit

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 6: Rolling forward Adar's +2 -- To view, visit http://gerrit.cloude

[kudu-CR] docs: update docs for update dirs tool

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. docs: update docs for update_dirs tool The `kudu fs update_dirs` tool n

[kudu-CR] [WIP] updated to use READ YOUR WRITES scan mode for Jepsen tests

2018-03-06 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9526 Change subject: [WIP] updated to use READ_YOUR_WRITES scan mode for Jepsen tests .. [WIP] updated to use READ_YOUR_WRITES scan mode for Jepsen

[kudu-CR] [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down

2018-03-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9510 to look at the new patch set (#3). Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down ..

[kudu-CR] WIP KUDU-2129 make ksck less scary when copying

2018-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9528 Change subject: WIP KUDU-2129 make ksck less scary when copying .. WIP KUDU-2129 make ksck less scary when copying WIP: There should be a

[kudu-CR] KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-03-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9375 to look at the new patch set (#5). Change subject: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

[kudu-CR] [WIP] updated to use READ YOUR WRITES scan mode for Jepsen tests

2018-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: [WIP] updated to use READ_YOUR_WRITES scan mode for Jepsen tests .. Patch Set 1: (5 comments) we'll also need to