[kudu-CR] Add RegexpKuduEventProducer class

2016-08-10 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3883 Change subject: Add RegexpKuduEventProducer class .. Add RegexpKuduEventProducer class This patch adds the RegexpKuduEventProducer

[kudu-CR] Add RegexpKuduEventProducer class

2016-08-10 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3883 to look at the new patch set (#2). Change subject: Add RegexpKuduEventProducer class .. Add

[kudu-CR] Fix ksck-test reliance on unordered map iteration order

2016-08-02 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. Change subject: Fix ksck-test reliance on unordered map iteration order .. Abandoned whoops...already a review out for this -- To view, visit http://gerrit.cloudera.org:8080/3831 To

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/3871/2//COMMIT_MSG Commit Message: Line 13: for

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3871 to look at the new patch set (#3). Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-1533 Spark

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3871 Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-1533 Spark Kudu Rdd/Dataframe upsert This patch adds support for

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Will Berkeley (Code Review)
Hello Chris George, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3871 to look at the new patch set (#5). Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert ..

[kudu-CR] Fix ksck-test reliance on unordered map iteration order

2016-08-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3831 Change subject: Fix ksck-test reliance on unordered map iteration order .. Fix ksck-test reliance on unordered map iteration order

[kudu-CR] Make UTF-8 characters display correctly in the web ui

2016-08-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3830 Change subject: Make UTF-8 characters display correctly in the web ui .. Make UTF-8 characters display correctly in the web ui Some

[kudu-CR] improvements to /table

2016-08-17 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4021 Change subject: improvements to /table .. improvements to /table This is a bunch of improvements to the /table endpoint: 0. The order

[kudu-CR] Fix to KUDU-1642 patch

2017-02-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5856 Change subject: Fix to KUDU-1642 patch .. Fix to KUDU-1642 patch This is a quick fix to the MakePredicate code. It had an unnecessary

[kudu-CR] Fix to KUDU-1642 patch

2017-02-01 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Fix to KUDU-1642 patch .. Fix to KUDU-1642 patch This is a quick fix to the MakePredicate code. It had an unnecessary Schema argument that can be

[kudu-CR] Make reduce flake from KUDU-1642 tests in client-test

2017-02-02 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5882 Change subject: Make reduce flake from KUDU-1642 tests in client-test .. Make reduce flake from KUDU-1642 tests in client-test This ups

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 3: (26 comments) New tests parameterized over column encodings probably needs some

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-31 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#3). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates ..

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-31 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#4). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates ..

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-02-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/client.cc

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-02-01 Thread Will Berkeley (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#7). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-02-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5439/6/src/kudu/client/client.h

[kudu-CR] KUDU-1864 Thirdparty squeasel build fails on macOS 10.12

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1864 Thirdparty squeasel build fails on macOS 10.12 .. Patch Set 2: Also I'm using Homebrew. -- To view, visit http://gerrit.cloudera.org:8080/5907 To

[kudu-CR] [spark] Pushdown IS NULL and IS NOT NULL predicates

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [spark] Pushdown IS NULL and IS NOT NULL predicates .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5912 To unsubscribe, visit

[kudu-CR] KUDU-1864 Thirdparty squeasel build fails on macOS 10.12

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1864 Thirdparty squeasel build fails on macOS 10.12 .. Patch Set 2: Code-Review+2 Verified fixes build on OS X 10.12.2. - Build on master fails without

[kudu-CR] KUDU-1864 Thirdparty squeasel build fails on macOS 10.12

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-1864 Thirdparty squeasel build fails on macOS 10.12 .. KUDU-1864 Thirdparty squeasel build fails on macOS 10.12 This patch fixes build of squeasel

[kudu-CR] [spark] Pushdown IS NULL and IS NOT NULL predicates

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [spark] Pushdown IS NULL and IS NOT NULL predicates .. [spark] Pushdown IS NULL and IS NOT NULL predicates Change-Id:

[kudu-CR] flume sink: use the same hadoop.version as everyone else

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: flume sink: use the same hadoop.version as everyone else .. flume sink: use the same hadoop.version as everyone else I'm not aware of a good reason for

[kudu-CR] flume sink: use the same hadoop.version as everyone else

2017-02-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: flume sink: use the same hadoop.version as everyone else .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5903 To unsubscribe,

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-31 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#5). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates ..

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-31 Thread Will Berkeley (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#6). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-02-01 Thread Will Berkeley (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#8). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5439/4/src/kudu/client/client.cc

[kudu-CR] WIP: KUDU-1848. in-memory dictionary for binary columns

2017-01-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: WIP: KUDU-1848. in-memory dictionary for binary columns .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5780/1/src/kudu/tablet/memrowset.cc

[kudu-CR] Add test for implicit partitions

2017-02-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add test for implicit partitions .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6153/2/src/kudu/client/client-test.cc File

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 3: (4 comments) Based on my experience in the alter code, I think this should "just work" after

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5167 to look at the new patch set (#4). Change subject: KUDU-1493: Implement SchemaRelationProvider .. KUDU-1493:

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider .. Patch Set 4: (7 comments)

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5167 to look at the new patch set (#5). Change subject: KUDU-1493: Implement SchemaRelationProvider .. KUDU-1493:

[kudu-CR] flume: Fix RegexpKuduOperationsProducer javadocs

2017-02-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: flume: Fix RegexpKuduOperationsProducer javadocs .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#2). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4012 To unsubscribe, visit

[kudu-CR] improvements to /table

2016-08-17 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4021 to look at the new patch set (#2). Change subject: improvements to /table .. improvements to /table This is a

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 4: (3 comments)

[kudu-CR] Add State Message column to /tables

2016-08-16 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4014 Change subject: Add State Message column to /tables .. Add State Message column to /tables The state message portion of a table's

[kudu-CR] improvements to /table

2016-08-17 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4021 to look at the new patch set (#3). Change subject: improvements to /table .. improvements to /table This is a

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: > (1 comment) > > Pretty much LGTM. One small docs nit, and it looks like a >

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: (1 comment) Pretty much LGTM. One small docs nit, and it looks like a security-related

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 1: Code-Review+1 LGTM besides Adar's nit. -- To view, visit

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-09-05 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#7). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/4034/6/java/kudu-flume-sink/pom.xml File

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4206 to look at the new patch set (#2). Change subject: KUDU-1113 pushed predicates not displaying on scans web page ..

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 1: (1 comment)

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [WIP] KUDU-861 Support changing default, storage attributes .. Patch Set 3: > (1 comment) > > didn't get to review the patch yet, just a quick comment on >

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4320 Change subject: API and style improvements to the Kudu Flume Sink .. API and style improvements to the Kudu Flume Sink This patch

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: (8 comments) Do we also want something in the release notes about the API change +

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4320 to look at the new patch set (#2). Change subject: API and style improvements to the Kudu Flume Sink .. API and

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4310 Change subject: [WIP] KUDU-861 Support changing default, storage attributes .. [WIP] KUDU-861 Support changing default, storage

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-04 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#2). Change subject: [WIP] KUDU-861 Support changing default, storage attributes ..

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-04 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#3). Change subject: [WIP] KUDU-861 Support changing default, storage attributes ..

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [WIP] KUDU-861 Support changing default, storage attributes .. Patch Set 3: > Build Started http://104.196.14.100/job/kudu-gerrit/3229/ Fixed compilation

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 5: (6 comments)

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-09-04 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#6). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 5: > BTW this producer is starting to look great. :D -- To view, visit

[kudu-CR] compaction policy: fix bound calculation

2016-08-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4152 To unsubscribe, visit

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4303 To unsubscribe, visit

[kudu-CR] Add release notes for tablet history GC

2016-09-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3988 To unsubscribe, visit

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-09-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4184 To

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4206 Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. KUDU-1113 pushed predicates not displaying on scans web

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 5: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/3158/ : FAILURE All the

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#5). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 4: (7 comments) Did a significant rewrite to make it more similar to the DataSet Sink

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4320 to look at the new patch set (#3). Change subject: API and style improvements to the Kudu Flume Sink .. API and

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: > > Do we also want something in the release notes about the API > change > > +

[kudu-CR] Set desiredBlockSize in pbToColumnSchema

2016-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Set desiredBlockSize in pbToColumnSchema .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4407/2//COMMIT_MSG Commit Message: Line 7: Set

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: > > don't forget about RegexpKuduEventProducer, > > which I need to rebase and refactor as

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3883 to look at the new patch set (#4). Change subject: Add RegexpKuduOperationsProducer class .. Add

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3883 to look at the new patch set (#3). Change subject: Add RegexpKuduOperationsProducer class .. Add

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add RegexpKuduOperationsProducer class .. Patch Set 5: Late thought: do we want this in 1.0? If so will make note to Todd to add to his release note rework

[kudu-CR] Add more release notes for new features in 1.0

2016-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add more release notes for new features in 1.0 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4370 To unsubscribe, visit

[kudu-CR] Reorganize and fill out release notes for 1.0

2016-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Reorganize and fill out release notes for 1.0 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4369/1/docs/release_notes.adoc File

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add RegexpKuduOperationsProducer class .. Patch Set 4: (7 comments) > Cool idea! Actually, I was talking to Jeremy Beard and mentioned that you had suggested

[kudu-CR] [WIP] [No-Review] KUDU-861 Support changing default, storage attributes

2016-09-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#4). Change subject: [WIP] [No-Review] KUDU-861 Support changing default, storage attributes

[kudu-CR] Set desiredBlockSize in pbToColumnSchema

2016-09-13 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4407 Change subject: Set desiredBlockSize in pbToColumnSchema .. Set desiredBlockSize in pbToColumnSchema pbToColumnSchema forgets to set

[kudu-CR] Change to UNIXTIME MICROS in RegexpKuduOperationsProducer

2016-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4383 Change subject: Change to UNIXTIME_MICROS in RegexpKuduOperationsProducer .. Change to UNIXTIME_MICROS in RegexpKuduOperationsProducer

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#5). Change subject: [WIP] KUDU-861 Support changing default, storage attributes ..

[kudu-CR] release notes: improve explanation of repartitioning limitation

2016-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: release_notes: improve explanation of repartitioning limitation .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4387 To

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 4: Code-Review+1 LGTM but this is one of my first times looking at the Python code so I will

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3988/4/docs/release_notes.adoc File

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Document Impala and Spark integration known issues & limitations .. Document Impala and Spark integration known issues & limitations Change-Id:

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-861 Support changing default, storage attributes .. Patch Set 6: (10 comments) I'm going to add coverage in alter_table-randomized-test but wanted to post

[kudu-CR] [c++client/samples] added README for the sample

2016-10-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [c++client/samples] added README for the sample .. Patch Set 3: (23 comments) Some style, wording, and grammar nits. Don't have the chance to test out the

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

2016-10-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 3: (5 comments) Looks nice; mostly nits. It's good to be able to use a datetime to set a

[kudu-CR](gh-pages) Add blog post for 1.0.0

2016-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add blog post for 1.0.0 .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4478 To unsubscribe, visit

[kudu-CR](gh-pages) Add blog post for 1.0.0

2016-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add blog post for 1.0.0 .. Patch Set 1: -Code-Review -Verified -- To view, visit http://gerrit.cloudera.org:8080/4478 To unsubscribe, visit

[kudu-CR](gh-pages) Add blog post for 1.0.0

2016-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add blog post for 1.0.0 .. Patch Set 1: > Patch Set 1: -Code-Review -Verified Dan found a typo -- To view, visit http://gerrit.cloudera.org:8080/4478 To

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-09-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#6). Change subject: KUDU-861 Support changing default, storage attributes ..

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Document Impala and Spark integration known issues & limitations .. Patch Set 1: (1 comment) Is there a note anywhere mentioning that the Spark integration is

[kudu-CR] Implement an upgrade test

2016-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Implement an upgrade test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4424/2/src/kudu/integration-tests/upgrade-test.cc File

[kudu-CR] [website] broken link to an adoc

2016-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [website] broken link to an adoc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4504 To unsubscribe, visit

  1   2   3   4   5   6   7   8   9   10   >