Review Request 38124: Add V1 Support for QuiesceOffers

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod

Review Request 38120: Add Java Support for QuiesceOffers

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38120/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 4, 2015, 12:06 p.m.) Review request for mesos, Alexander

Review Request 38126: Add UT for QuiesceOffers

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38126/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod

Review Request 38121: Add Python Support for QuiesceOffers

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38121/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 4, 2015, 12:06 p.m.) Review request for mesos and Vinod Kone.

Review Request 38125: Included hostname in SlaveID.

2015-09-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/ --- Review request for mesos, Jan Schlicht and Till Toenshoff. Bugs: MESOS-115

Re: Review Request 38125: Included hostname in SlaveID.

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97749 --- src/master/master.cpp (line 3672)

Re: Review Request 38126: Add UT for QuiesceOffers

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38126/#review97750 --- Patch looks great! Reviews applied: [37532, 37873, 38119, 38120,

Re: Review Request 38125: Included hostname in SlaveID.

2015-09-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97743 --- Looks very good to me. src/master/master.cpp (lines 5847 - 5849)

Re: Review Request 38125: Included hostname in SlaveID.

2015-09-04 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97744 --- src/master/master.cpp (line 5847)

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-04 Thread haosdent huang
> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 203 > > > > > > We remove the overflow components > > haosdent huang wrote: > Change “remove the rest components here before

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Sept. 4, 2015, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37197: Docker image store.

2015-09-04 Thread Till Toenshoff
> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 135 > > > > > > I am not a big fan of such magic numbers (referring to that '7'). How > > about

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

2015-09-04 Thread haosdent huang
> On Sept. 4, 2015, 3:32 p.m., Michael Park wrote: > > src/webui/master/static/home.html, line 101 > > > > > > Does `number:4` not give us what we want here? could not, if number is small than "0.01", use

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review97766 --- Patch looks great! Reviews applied: [37814] All tests passed. -

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97758 --- Patch looks great! Reviews applied: [37821] All tests passed. -

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-09-04 Thread Greg Mann
> On Sept. 4, 2015, 3:45 p.m., Michael Park wrote: > > docs/configuration.md, lines 1502-1510 > > > > > > Hm, looks like the closing tag, `` is missing here...? It also > > looks like it's missing in all of the

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-09-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/ --- (Updated Sept. 4, 2015, 4:14 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-09-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review97761 --- docs/configuration.md (lines 1502 - 1510)

Re: Review Request 37586: Generate usage help information in libprocess.

2015-09-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37586/ --- (Updated Sept. 4, 2015, 6:43 p.m.) Review request for mesos, Michael Park and

Re: Review Request 37586: Generate usage help information in libprocess.

2015-09-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37586/ --- (Updated Sept. 4, 2015, 6:53 p.m.) Review request for mesos, Michael Park and

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

2015-09-04 Thread haosdent huang
> On Sept. 4, 2015, 3:32 p.m., Michael Park wrote: > > src/webui/master/static/home.html, line 101 > > > > > > Does `number:4` not give us what we want here? > > haosdent huang wrote: > could not, if number is

Re: Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

2015-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/#review97784 --- Ship it! Ship It! - Ben Mahler On Sept. 3, 2015, 3:08 p.m.,

Re: Review Request 38003: MESOS-3351

2015-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97785 --- src/master/master.cpp (lines 306 - 312)

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-04 Thread Vinod Kone
> On Sept. 4, 2015, 7:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4118 > > > > > > Instead of not calling updateTask() the logic should be inside > > updateTask() to do the right thing. Note that

Re: Review Request 38040: Refactor docker provisioner store to act as read-through cache.

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38040/#review97801 --- Bad patch! Reviews applied: [37196, 37197] Failed command:

Re: Review Request 38003: MESOS-3351

2015-09-04 Thread Vinod Kone
> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > Also, please make the summary and description more meaningful than just the ticket ID. - Vinod --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97789 --- Ship it! Looks good. Just a few little nits.

Re: Review Request 37540: Add perf event API

2015-09-04 Thread Cong Wang
> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 791 > > > > > > why is __read() a separate function? can you just pull the logic down > > here? __read() is used by the next patch.

Re: Review Request 37540: Add perf event API

2015-09-04 Thread Cong Wang
> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, line 119 > > > > > > We use "_" prefix for continuation. Since this is just a private > > overload, I would remove "_". Compile failed

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review97790 --- src/master/master.cpp (line 4118)

Re: Review Request 37540: Add perf event API

2015-09-04 Thread Cong Wang
> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, lines 84-89 > > > > > > Do we need this overload considering users can call the overload below? I think it is still useful, because the

Re: Review Request 37540: Add perf event API

2015-09-04 Thread Cong Wang
> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 819 > > > > > > who can discard this future? finalize(). - Cong --- This is

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review97792 --- this review blocks a bunch of reviews? can you make the dependency

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-04 Thread Greg Mann
> On Sept. 4, 2015, 8:14 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2217-2218 > > > > > > Could you change the spacing to: > > ``` > > threads.emplace_back( > > new

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Sept. 4, 2015, 9 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37531: MESOS-3070 (Master CHECK failure if a framework uses duplicated task id)

2015-09-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated Sept. 5, 2015, 3:27 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 --- include/mesos/v1/executor/executor.proto (line 47)

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 5, 2015, 3:14 a.m.) Review request for mesos and Michael Park.

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97847 --- Patch looks great! Reviews applied: [38143] All tests passed. -

Re: Review Request 37586: Generate usage help information in libprocess.

2015-09-04 Thread haosdent huang
> On Aug. 30, 2015, 10:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/profiler.cpp, lines 45-46 > > > > > > Do you happen to know what the deal is with all the instances of `...` > > in this particular

Re: Review Request 37541: Add trace event API

2015-09-04 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 4, 2015, 11:15 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 38074: Calculate schedule latency with trace events

2015-09-04 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/ --- (Updated Sept. 4, 2015, 11:16 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37197: Docker image store.

2015-09-04 Thread Timothy Chen
> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 135 > > > > > > I am not a big fan of such magic numbers (referring to that '7'). How > > about

Re: Review Request 37197: Docker image store.

2015-09-04 Thread Timothy Chen
> On Sept. 3, 2015, 6:59 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/store.hpp, line 100 > > > > > > Does this need to be in the hpp file? It is in the latest review. > On Sept. 3,

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Guangya Liu
> On 九月 4, 2015, 7:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. Thanks Vinod, both 37867 and 37866 are now discared but I do not know how to remove them from depenency

Review Request 38137: Docker provisioner and local store

2015-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- Review request for mesos, Jojy Varghese, Till Toenshoff, and Jiang Yan Xu.

Re: Review Request 38074: Calculate schedule latency with trace events

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97833 --- Patch looks great! Reviews applied: [37540, 37541, 38074] All

Re: Review Request 38137: Docker provisioner and local store

2015-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 5, 2015, 12:20 a.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-09-04 Thread Michael Park
> On Sept. 4, 2015, 3:45 p.m., Michael Park wrote: > > docs/configuration.md, lines 1502-1510 > > > > > > Hm, looks like the closing tag, `` is missing here...? It also > > looks like it's missing in all of the

Review Request 38141: Refactor shared paths in provisioners.

2015-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 38141: Refactor shared paths in provisioners.

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/#review97840 --- Bad patch! Reviews applied: [38141] Failed command: make -j3

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 5, 2015, 2:46 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-04 Thread Klaus Ma
> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > Also, please make the summary and description more meaningful than just > the ticket ID. Yes, both summary & description are updated for this fix > On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > >

Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)

2015-09-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/ --- (Updated Sept. 5, 2015, 3:08 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97817 --- Patch looks great! Reviews applied: [37821] All tests passed. -

Re: Review Request 37540: Add perf event API

2015-09-04 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 4, 2015, 11:13 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-09-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Sept. 4, 2015, 11:19 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-09-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Sept. 4, 2015, 11:20 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-04 Thread Robert Lacroix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97836 --- Ship it! Ship It! - Robert Lacroix On Sept. 4, 2015, 12:06

Re: Review Request 38074: Calculate schedule latency with trace events

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97843 --- include/mesos/mesos.proto (line 915)

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38118/#review97737 --- Patch looks great! Reviews applied: [38118] All tests passed. -

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97731 --- Patch looks great! Reviews applied: [37669] All tests passed. -

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97732 --- Ship it! Ship It! src/docker/docker.cpp (line 203)

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-04 Thread haosdent huang
> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 203 > > > > > > We remove the overflow components Change “remove the rest components here before parsing the docker version” to

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97733 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 2, 2015, 4:34