Re: Review Request 38061: Corrected include order in master.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97733 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 2, 2015, 4:34

Re: Review Request 37669: Ignore overflow docker components in version parsing.

> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 203 > > > > > > We remove the overflow components Change “remove the rest components here before parsing the docker version” to "W

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38118/#review97737 --- Patch looks great! Reviews applied: [38118] All tests passed. - M

Review Request 38125: Included hostname in SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/ --- Review request for mesos, Jan Schlicht and Till Toenshoff. Bugs: MESOS-115

Re: Review Request 38125: Included hostname in SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97744 --- src/master/master.cpp (line 5847)

Re: Review Request 38125: Included hostname in SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97743 --- Looks very good to me. src/master/master.cpp (lines 5847 - 5849) <

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 4, 2015, 12:06 p.m.) Review request for mesos and Vinod Kone. Bug

Review Request 38119: Add metrics of messages_quiesce_offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38119/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kon

Review Request 38124: Add V1 Support for QuiesceOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kon

Review Request 38120: Add Java Support for QuiesceOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38120/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kon

Re: Review Request 37873: Add quiesce logic in allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 4, 2015, 12:06 p.m.) Review request for mesos, Alexander Rukletsov,

Review Request 38126: Add UT for QuiesceOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38126/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kon

Review Request 38121: Add Python Support for QuiesceOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38121/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kon

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38118/#review97748 --- Ship it! Ship It! - Kapil Arya On Sept. 3, 2015, 10:54 p.m., hao

Re: Review Request 38126: Add UT for QuiesceOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38126/#review97750 --- Patch looks great! Reviews applied: [37532, 37873, 38119, 38120, 38

Re: Review Request 38125: Included hostname in SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97749 --- src/master/master.cpp (line 3672)

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38118/ --- (Updated Sept. 4, 2015, 12:54 p.m.) Review request for mesos, Kapil Arya and Mi

Re: Review Request 37197: Docker image store.

> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 135 > > > > > > I am not a big fan of such magic numbers (referring to that '7'). How > > about f

Re: Review Request 38125: Included hostname in SlaveID.

> On Sept. 4, 2015, 5:43 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 5846 > > > > > > I think that we cannot make the assumpation here as the host FQDN name > > may include the underscore, so how to ha

Re: Review Request 37669: Ignore overflow docker components in version parsing.

> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 203 > > > > > > We remove the overflow components > > haosdent huang wrote: > Change “remove the rest components here before pa

Re: Review Request 38125: Included hostname in SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97756 --- src/master/master.cpp (line 5846)

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Sept. 4, 2015, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97758 --- Patch looks great! Reviews applied: [37821] All tests passed. - M

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38118/#review97759 --- src/webui/master/static/home.html (line 101)

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review97761 --- docs/configuration.md (lines 1502 - 1510)

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/ --- (Updated Sept. 4, 2015, 4:14 p.m.) Review request for mesos, Alexander Rojas, h

Re: Review Request 37814: Added documentation for libprocess environment variables

> On Sept. 4, 2015, 3:45 p.m., Michael Park wrote: > > docs/configuration.md, lines 1502-1510 > > > > > > Hm, looks like the closing tag, `` is missing here...? It also > > looks like it's missing in all of the oth

Re: Review Request 37814: Added documentation for libprocess environment variables

> On Sept. 4, 2015, 3:45 p.m., Michael Park wrote: > > docs/configuration.md, lines 1502-1510 > > > > > > Hm, looks like the closing tag, `` is missing here...? It also > > looks like it's missing in all of the oth

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

> On Sept. 4, 2015, 3:32 p.m., Michael Park wrote: > > src/webui/master/static/home.html, line 101 > > > > > > Does `number:4` not give us what we want here? could not, if number is small than "0.01", use number

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review97766 --- Patch looks great! Reviews applied: [37814] All tests passed. - M

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

> On Sept. 4, 2015, 3:32 p.m., Michael Park wrote: > > src/webui/master/static/home.html, line 101 > > > > > > Does `number:4` not give us what we want here? > > haosdent huang wrote: > could not, if number is s

Re: Review Request 37586: Generate usage help information in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37586/ --- (Updated Sept. 4, 2015, 6:43 p.m.) Review request for mesos, Michael Park and V

Re: Review Request 37586: Generate usage help information in libprocess.

> On Aug. 30, 2015, 10:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/profiler.cpp, lines 45-46 > > > > > > Do you happen to know what the deal is with all the instances of `...` > > in this particular help

Re: Review Request 37586: Generate usage help information in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37586/ --- (Updated Sept. 4, 2015, 6:53 p.m.) Review request for mesos, Michael Park and V

Re: Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/#review97784 --- Ship it! Ship It! - Ben Mahler On Sept. 3, 2015, 3:08 p.m., Greg

Re: Review Request 38003: MESOS-3351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97785 --- src/master/master.cpp (lines 306 - 312)

Re: Review Request 38003: MESOS-3351

> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > Also, please make the summary and description more meaningful than just the ticket ID. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 38051: Only update the task status when its old status is not terminal.

> On Sept. 4, 2015, 7:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4118 > > > > > > Instead of not calling updateTask() the logic should be inside > > updateTask() to do the right thing. Note that upd

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review97790 --- src/master/master.cpp (line 4118)

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review97792 --- this review blocks a bunch of reviews? can you make the dependency l

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97789 --- Ship it! Looks good. Just a few little nits. 3rdparty/libprocess

Re: Review Request 38040: Refactor docker provisioner store to act as read-through cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38040/ --- (Updated Sept. 4, 2015, 8:34 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 38040: Refactor docker provisioner store to act as read-through cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38040/#review97801 --- Bad patch! Reviews applied: [37196, 37197] Failed command: ./suppo

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 791 > > > > > > why is __read() a separate function? can you just pull the logic down > > here? __read() is used by the next patch. -

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, lines 84-89 > > > > > > Do we need this overload considering users can call the overload below? I think it is still useful, because the return

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Sept. 4, 2015, 9 p.m.) Review request for mesos, Benjamin Hindman, Art

Re: Review Request 37821: Join threads in libprocess when shutting down.

> On Sept. 4, 2015, 8:14 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2217-2218 > > > > > > Could you change the spacing to: > > ``` > > threads.emplace_back( > > new std::th

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, line 119 > > > > > > We use "_" prefix for continuation. Since this is just a private > > overload, I would remove "_". Compile failed after

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 819 > > > > > > who can discard this future? finalize(). - Cong --- This is

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97817 --- Patch looks great! Reviews applied: [37821] All tests passed. - M

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 4, 2015, 11:13 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37541: Add trace event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 4, 2015, 11:15 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/ --- (Updated Sept. 4, 2015, 11:16 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Sept. 4, 2015, 11:19 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Sept. 4, 2015, 11:20 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

> On 九月 4, 2015, 7:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. Thanks Vinod, both 37867 and 37866 are now discared but I do not know how to remove them from depenency

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 5, 2015, 12:01 a.m.) Review request for mesos and Vinod Kone. Bug

Review Request 38137: Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- Review request for mesos, Jojy Varghese, Till Toenshoff, and Jiang Yan Xu. Repo

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97833 --- Patch looks great! Reviews applied: [37540, 37541, 38074] All test

Re: Review Request 37197: Docker image store.

> On Sept. 3, 2015, 6:59 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/store.hpp, line 100 > > > > > > Does this need to be in the hpp file? It is in the latest review. > On Sept. 3,

Re: Review Request 37197: Docker image store.

> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 135 > > > > > > I am not a big fan of such magic numbers (referring to that '7'). How > > about f

Re: Review Request 38137: Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 5, 2015, 12:20 a.m.) Review request for mesos, Jojy Varghese, Ti

Re: Review Request 37873: Add quiesce logic in allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97836 --- Ship it! Ship It! - Robert Lacroix On Sept. 4, 2015, 12:06 p.m.,

Review Request 38141: Refactor shared paths in provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 38141: Refactor shared paths in provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/#review97840 --- Bad patch! Reviews applied: [38141] Failed command: make -j3 distc

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97843 --- include/mesos/mesos.proto (line 915)

Review Request 38143: Adding executor HTTP API protobuf to V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MES

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 5, 2015, 2:46 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > Also, please make the summary and description more meaningful than just > the ticket ID. Yes, both summary & description are updated for this fix > On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote: > > src/master/m

Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/ --- (Updated Sept. 5, 2015, 3:08 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 5, 2015, 3:14 a.m.) Review request for mesos and Michael Park.

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97847 --- Patch looks great! Reviews applied: [38143] All tests passed. - M

Re: Review Request 37531: MESOS-3070 (Master CHECK failure if a framework uses duplicated task id)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated Sept. 5, 2015, 3:27 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 --- include/mesos/v1/executor/executor.proto (line 47)

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97850 --- Patch looks great! Reviews applied: [38003] All tests passed. - M