Re: Review Request 44902: Update containerizer construction in memory_pressure_tests.cpp.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44902/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated March 16, 2016, 9:14 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-18 Thread Joseph Wu
> On March 16, 2016, 5:48 a.m., Michael Park wrote: > > src/tests/fetcher_cache_tests.cpp, lines 167-169 > > > > > > Could you explain this NOTE? It looks like we do `fetcherProcess = new > > MockFetcherProcess();`

Re: Review Request 44909: Update containerizer construction in docker_containerizer_tests.cpp.

2016-03-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44909/#review123926 --- Patch looks great! Reviews applied: [44798, 44822, 44823, 44824,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-18 Thread Steve Niemitz
> On March 16, 2016, 4:27 p.m., Jie Yu wrote: > > Ship It! > > Jie Yu wrote: > Can you confirm that this patch works in your environment? Actually, it looks like the change to use update() instead of _update introduced a bug (the cgroups no longer get updated because the resources don't

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124038 --- Ship it! The patch looks good to me. Would you like to send an

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review123951 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 44810: Documentation change for the update quota feature.

2016-03-18 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44810/#review123941 --- docs/quota.md (lines 157 - 163)

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-18 Thread Jojy Varghese
> On March 17, 2016, 2:16 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, lines 251-281 > > > > > > What is the behavior of this if with mesos containerizer but without a > > docker/appc image? > > > >

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-18 Thread Benjamin Bannier
> On March 18, 2016, 12:16 a.m., Neil Conway wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Style-wise, do we want all tests to resume if they initially pause it? > > I think we do a mix of

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123894 --- src/tests/containerizer/port_mapping_tests.cpp (line 2086)

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review124001 --- src/tests/containerizer/provisioner_appc_tests.cpp (lines 67 -

Re: Review Request 45040: Added a test for task's kill policy.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45040/#review124343 --- Thanks for the test! Although I wouldn't want to ship this unless

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/#review124359 --- src/launcher/executor.cpp (lines 496 - 499)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 18, 2016, 7:12 p.m.) Review request for mesos, Adam B,

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-18 Thread Qian Zhang
> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > >

Re: Review Request 44851: Renamed an allocator metric.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/#review124053 --- src/master/allocator/mesos/metrics.hpp (lines 40 - 41)

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124374 --- I ran the review by Ben again and sat with him to rework it to

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

2016-03-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/ --- (Updated March 17, 2016, 5:01 p.m.) Review request for mesos, Adam B and Greg

Review Request 44903: Update containerizer construction in port_mapping_tests.cpp.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44903/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44997: Fixed how we detect C++11 compiler support.

2016-03-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44997/#review124132 --- Ship it! Ship It! - Joris Van Remoortere On March 17, 2016,

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-18 Thread Greg Mann
> On March 18, 2016, 9:47 a.m., Adam B wrote: > > "The test is slowed considerably" - Can you provide some stats on how fast > > it is before/after the patch? Good call - timing information has been added, and it actually wasn't as bad as I thought. - Greg

Review Request 44899: Update containerizer construction in slave_recovery_tests.cpp.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44899/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-18 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 17, 2016, 9:08 p.m.) Review request for mesos and Michael Park.

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 18, 2016, 5:14 p.m.) Review request for mesos and Ben Mahler.

Review Request 44907: Remove `Fetcher` in `DockerContainerizer::create`.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44907/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44909: Update containerizer construction in docker_containerizer_tests.cpp.

2016-03-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44909/#review123862 --- Patch looks great! Reviews applied: [44798, 44822, 44823, 44824,

Review Request 45034: Removed superfluous blank line in slave/http.cpp.

2016-03-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45034/ --- Review request for mesos, Adam B and Greg Mann. Repository: mesos

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-18 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 18, 2016, 12:20 a.m.) Review request for mesos, Adam B,

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-03-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review124120 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-18 Thread Michael Park
> On March 18, 2016, 7:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 131 > > > > > > `setenv` in `stout/windows/os.hpp` is commented out and unimplemeneted. > > How

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-18 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124140 --- src/linux/fs.cpp (line 74)

Review Request 44932: Removed unused overload of `model` for `TaskInfo`.

2016-03-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44932/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 44954: Regenerated master endpoint documentation.

2016-03-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44954/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-4934

Re: Review Request 44907: Remove `Fetcher` in `DockerContainerizer::create`.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44907/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

Re: Review Request 44985: Fix the broken ProvisionerDockerPullerTest on Centos7.

2016-03-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44985/ --- (Updated March 17, 2016, 10 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-18 Thread Greg Mann
> On March 16, 2016, 6:27 p.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 119 > > > > > > Could you clarify for me how the slave gets into the RESERVED state the > > first time? It

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-18 Thread Alexander Rukletsov
> On March 15, 2016, 8:11 p.m., Ben Mahler wrote: > > include/mesos/v1/executor/executor.proto, lines 53-55 > > > > > > Now that the period within the Shutdown message was removed, we should > > probably have a TODO

Re: Review Request 44985: Fix the broken ProvisionerDockerPullerTest on Centos7.

2016-03-18 Thread Jie Yu
> On March 17, 2016, 10:12 p.m., Gilbert Song wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 401 > > > > > > `_NonShellCommand`? I'll rename it to SimpleCommand. - Jie

Review Request 44896: Update containerizer construction in disk_quota_tests.cpp.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44896/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44954: Regenerated master endpoint documentation.

2016-03-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44954/ --- (Updated March 18, 2016, 4:48 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 17, 2016, 11:36 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review124039 --- Ship it! Ship It! - Michael Park On March 10, 2016, 9:59

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 17, 2016, 10:56 p.m.) Review request for mesos, Adam B,

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 18, 2016, 5:13 p.m.) Review request for mesos and Ben Mahler.

Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

2016-03-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45015/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

2016-03-18 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/ --- (Updated March 17, 2016, 6:52 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124161 --- Fix it, then Ship it! Minor suggestions

Re: Review Request 44854: Added validation for executor's shutdown grace period.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review124290 --- Ship it! The change looks good but please add a test for this.

Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-18 Thread Michael Browning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/ --- Review request for mesos, Vinod Kone and Zhitao Li. Bugs: MESOS-4735

Re: Review Request 45017: Updated C++ dialect macro in libprocess.

2016-03-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45017/#review124201 --- Ship it! - Joris Van Remoortere On March 18, 2016, 5:39

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/#review124357 --- src/launcher/executor.cpp (lines 489 - 501)

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review124361 --- Ok I misunderstood what the intent was here. Generally when we

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-18 Thread Anurag Singh
> On March 18, 2016, 9:03 p.m., Joseph Wu wrote: > > src/master/contender.cpp, line 91 > > > > > > Another spacing change seems to have snuck in. Apologies ... I forgot to add expandtab in my vimrc. Fixing it. -

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

2016-03-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124366 --- src/slave/containerizer/mesos/containerizer.cpp (line 679)

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124337 --- src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

2016-03-18 Thread Jie Yu
> On March 18, 2016, 7 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 674 > > > > > > Thanks for catching the bug. I think this is a pretty bad bug which > > might worth cutting

Re: Review Request 44854: Added validation for executor's shutdown grace period.

2016-03-18 Thread Ben Mahler
> On March 18, 2016, 9:33 p.m., Ben Mahler wrote: > > The change looks good but please add a test for this. > > > > Ideally there could be a stateless validateExecutorInfo, in addition to the > > one that needs the master state. In the absence of this, you can write a > > test that spins up a

Review Request 45070: Clean up libprocess gtest macros (MESOS-4112).

2016-03-18 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45070/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-03-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated March 18, 2016, 10:46 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44707: Added validation for task's kill policy.

2016-03-18 Thread Ben Mahler
> On March 15, 2016, 8:35 p.m., Ben Mahler wrote: > > Could you add a corresponding test? Having it in the header should make > > this really easy :) > > Alexander Rukletsov wrote: > Sure, but I'll write a more complex test than just unit testing the > validation function. Per the

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-18 Thread Ben Mahler
> On March 19, 2016, 2:16 a.m., Ben Mahler wrote: > > Ok I misunderstood what the intent was here. Generally when we say > > "deprecated" we maintain the old behavior and we plan to remove the support > > in a future version. This doesn't maintain the old behavior, why not leave > > as is and

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-18 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread haosdent huang
> On March 19, 2016, 12:30 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/info.hpp, line 75 > > > > > > Why? Can that be vector? If we make this as a vector and pass it to

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review124299 --- include/mesos/scheduler.hpp (lines 219 - 221)

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- (Updated March 17, 2016, 5:47 p.m.) Review request for mesos, Avinash

Re: Review Request 44824: Remove `SlaveState` in `ComposingContainerizer` during recover.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44824/ --- (Updated March 16, 2016, 11:26 a.m.) Review request for mesos and Till

Review Request 44908: Update `MockDockerContainerizer` construction.

2016-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44908/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44944: Handled chunked responses in docker URI fetcher.

2016-03-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/#review123979 --- Ship it! Ship It! - Timothy Chen On March 17, 2016, 1:50

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124194 --- src/slave/http.cpp (line 54)

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-03-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/ --- (Updated March 18, 2016, 7:39 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 18, 2016, 7:16 p.m.) Review request for mesos, Adam B,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123867 --- Ship it! On my machine, full test-suite remains to take about

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-18 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123977 --- Fix it, then Ship it! Ship It!

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-18 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 17, 2016, 2:15 p.m.) Review request for mesos, Greg Mann, Joerg

Review Request 45004: Fixed a memory leak in the scheduler driver.

2016-03-18 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45004/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-18 Thread Ben Mahler
> On March 15, 2016, 11:21 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 657-663 > > > > > > Hm.. ideally we could ignore the docker stop flag if a kill policy was > > set, because the user is being

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

2016-03-18 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40988/#review124320 --- Can you separate the non-numify() change from the numify() one?

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- (Updated 三月 18, 2016, 4:22 p.m.) Review request for mesos, haosdent huang, Jie

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-03-18 Thread Jiang Yan Xu
> On March 18, 2016, 11:36 a.m., Jiang Yan Xu wrote: > > configure.ac, line 923 > > > > > > Sorry this should have been a continued discussion on > > https://reviews.apache.org/r/44342/#comment184051 but anyways: >

Review Request 45067: Updated the long-lived-framework example.

2016-03-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues.

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124351 --- src/examples/long_lived_framework.cpp (line 102)

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-03-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/#review124314 --- Ship it! Ship It! - Neil Conway On March 18, 2016, 10:49

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

2016-03-18 Thread Neil Conway
> On March 18, 2016, 11:13 p.m., Cong Wang wrote: > > Can you separate the non-numify() change from the numify() one? It is best > > to do one thing per commit. This change was committed a few months ago. - Neil --- This is an

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/#review124308 --- Thanks for the test! Main high level comments are to pull out the

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-18 Thread Anurag Singh
> On March 18, 2016, 9:01 p.m., Joseph Wu wrote: > > Sorry for the delay... > > > > As Vinod suggested, you might want to consider reaching out to another > > shepherd (as far as I can tell, BenH is not likely to have time in the > > foreseeable future). (And in case you don't know, I'm not

Re: Review Request 44854: Added validation for executor's shutdown grace period.

2016-03-18 Thread Ben Mahler
> On March 18, 2016, 9:33 p.m., Ben Mahler wrote: > > The change looks good but please add a test for this. > > > > Ideally there could be a stateless validateExecutorInfo, in addition to the > > one that needs the master state. In the absence of this, you can write a > > test that spins up a

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review124282 --- src/master/detectors/detector.cpp (line 126)

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

2016-03-18 Thread Jie Yu
> On March 18, 2016, 7 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 674 > > > > > > Thanks for catching the bug. I think this is a pretty bad bug which > > might worth cutting

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review124338 --- include/mesos/mesos.proto (line 445)

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124340 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 44707: Added validation for task's kill policy.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review124341 --- Ship it! Please pull out the validation test into a simple

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124316 --- src/master/http.cpp (line 958)

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

2016-03-18 Thread Cong Wang
> On March 18, 2016, 11:13 p.m., Cong Wang wrote: > > Can you separate the non-numify() change from the numify() one? It is best > > to do one thing per commit. > > Neil Conway wrote: > This change was committed a few months ago. I know it, I noticed this one because of 45011. And my

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-18 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review124364 --- src/examples/long_lived_framework.cpp (line 88)

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread haosdent huang
> On March 19, 2016, 12:39 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 363 > > > > > > I think what you can do is to save a future in each Subsystem. > > > > I

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

2016-03-18 Thread Neil Conway
> On March 18, 2016, 11:13 p.m., Cong Wang wrote: > > Can you separate the non-numify() change from the numify() one? It is best > > to do one thing per commit. > > Neil Conway wrote: > This change was committed a few months ago. > > Cong Wang wrote: > I know it, I noticed this one

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/#review124339 --- Fix it, then Ship it! include/mesos/mesos.proto (lines 354 -

Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4885

  1   2   >