Re: Review Request 47258: Make sure 'activate' is a no-op if the client is already active.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47258/#review133054 --- src/master/allocator/sorter/sorter.hpp (line 70)

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47313/ --- (Updated May 13, 2016, 9:25 a.m.) Review request for mesos and Alexander

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47313/#review133065 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 37257: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37257/ --- (Updated 五月 13, 2016, 6:57 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

2016-05-13 Thread Guangya Liu
> On 五月 13, 2016, 6:33 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 375 > > > > > > You seem to only fts_close on error cases, but in the normal case > > skipped to

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-13 Thread Benjamin Bannier
> On May 12, 2016, 6:37 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/logging.cpp, line 97 > > > > > > Strictly speaking, libprocess endpoints can be both > > authentication-enabled and not. This

Re: Review Request 47337: Fixed erroneous `CHECK` in the command executor.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47337/#review133059 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47314: Add authentication documentation to authenticated endpoints.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47314/#review133066 --- Fix it, then Ship it! I'll fix the outstanding issue and

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Abhishek Dasgupta
> On May 12, 2016, 8:51 p.m., Alexander Rukletsov wrote: > > Could you please update `Slave::Http::CONTAINERS_HELP()` as well? Yeah, updated. Added another RR https://reviews.apache.org/r/47340/ for the updated doc for /containers endpoint generated by running support/generate-endpoint.sh.

Re: Review Request 47303: Slave/Agent terminology replacement in documentations.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47303/#review133056 --- Patch looks great! Reviews applied: [47303] Passed command:

Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/ --- Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-13 Thread Benjamin Bannier
> On May 12, 2016, 6:37 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/logging.cpp, line 97 > > > > > > Strictly speaking, libprocess endpoints can be both > > authentication-enabled and not. This

Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-13 Thread Alexander Rukletsov
> On May 12, 2016, 4:37 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/logging.cpp, line 97 > > > > > > Strictly speaking, libprocess endpoints can be both > > authentication-enabled and not. This

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/ --- (Updated May 13, 2016, 9:35 a.m.) Review request for mesos, Adam B, Greg Mann,

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review133068 --- Patch looks great! Reviews applied: [44837, 44838, 44839]

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133075 --- src/slave/http.cpp (line 838)

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
> On May 13, 2016, 12:47 p.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > > > > > `static`? The function uses `slave->this().id` so it would be a bit inconvenient to make it static. - Jan

Review Request 38148: Fixed a typo when run 'mesos slave'.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/ --- Review request for mesos, Jay Guo and Vinod Kone. Summary (updated)

Re: Review Request 44154: Added appc_simple_discovery_uri_prefix to configuration.md.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44154/ --- (Updated 五月 13, 2016, 6:10 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 37257: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37257/#review133047 --- Can you actually create a new reviewboard? The history doesn't

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/#review133040 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/#review133050 --- Patch looks great! Reviews applied: [46964] Passed command:

Re: Review Request 37257: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Guangya Liu
> On 五月 13, 2016, 7:01 a.m., Timothy Chen wrote: > > Can you actually create a new reviewboard? The history doesn't line up at > > all and it's quite confusing. Thanks Tim. Done in https://reviews.apache.org/r/47336/ , I was updating this because I want to reuse the number of discard patches,

Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 47324: Update leveldb.

2016-05-13 Thread Zhiwei Chen
> On May 13, 2016, 12:38 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [47324] > > > > Failed command: ./support/apply-review.sh -n -r 47324 > > > > Error: > > 2016-05-13 04:38:10 URL:https://reviews.apache.org/r/47324/diff/raw/ > > [4739/4739] -> "47324.patch" [1] > >

Re: Review Request 47324: Update leveldb.

2016-05-13 Thread haosdent huang
> On May 13, 2016, 4:38 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [47324] > > > > Failed command: ./support/apply-review.sh -n -r 47324 > > > > Error: > > 2016-05-13 04:38:10 URL:https://reviews.apache.org/r/47324/diff/raw/ > > [4739/4739] -> "47324.patch" [1] > >

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133095 --- Patch looks great! Reviews applied: [47336] Passed command:

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

2016-05-13 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/ --- (Updated May 13, 2016, 2:24 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
> On May 13, 2016, 10:47 a.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > > > > > `static`? > > Jan Schlicht wrote: > The function uses `slave->this().id` so it would be a bit inconvenient

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- (Updated May 13, 2016, 4:12 p.m.) Review request for mesos and Alexander

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133094 --- Looks good. Could you please make this patch self-contained,

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

2016-05-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/#review133117 --- Fix it, then Ship it! Ship It!

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Till Toenshoff
> On May 13, 2016, 2:59 p.m., Till Toenshoff wrote: > > Ship It! Minus the "debugging artefact?" Alex noted. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133120

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133120 --- Ship it! Ship It! - Till Toenshoff On May 13, 2016, 9:50

Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/#review133103 --- Bad patch! Reviews applied: [47340, 47062, 47061] Failed

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
> On May 13, 2016, 1:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > >

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133114 --- Fix it, then Ship it! src/slave/slave.cpp (line 766)

Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/#review133115 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/#review133118 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
> On May 13, 2016, 3:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > >

Re: Review Request 47222: Add authorization to /quota endpoint.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47222/#review133093 --- Let's punt on the coarse-grained authz for now. - Alexander

Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/ --- (Updated May 13, 2016, 2:23 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 38148: Fixed a typo when run 'mesos slave'.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/#review133125 --- Patch looks great! Reviews applied: [38148] Passed command:

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

2016-05-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/#review133126 --- I am not convinced that this test adds anything. libprocess

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/#review133129 --- Fix it, then Ship it! src/slave/slave.cpp (lines 799 - 805)

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47055/#review133122 --- src/webui/master/static/css/mesos.css (line 2)

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-05-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated May 13, 2016, 3:40 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review133136 --- Fix it, then Ship it!

Re: Review Request 38148: Fixed a typo when run 'mesos slave'.

2016-05-13 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/#review133138 --- Ship it! Ship It! - Jay Guo On May 13, 2016, 10:08 a.m.,

Re: Review Request 47221: Windows: Used `os::random` in libprocess.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47221/#review133130 --- Fix it, then Ship it!

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133135 --- Patch looks great! Reviews applied: [47222, 47274] Passed

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

2016-05-13 Thread Alexander Rukletsov
> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 464 > > > > > > If we eliminate intermediate vector, we will be looping thorugh hashmap > > and list simultaneously. I

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- (Updated May 13, 2016, 4:54 p.m.) Review request for mesos and Alexander

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

2016-05-13 Thread Alexander Rukletsov
> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 441-447 > > > > > > Do we really need this copy? Or we can directly use `master->quotas`? After a second thought,

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133139 --- Ship it! Ship It! - Timothy Chen On May 13, 2016, 7:09

Re: Review Request 46424: Windows: Added libprocess to build.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/#review133142 --- Ship it! Ship It! - Joris Van Remoortere On May 12, 2016,

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

2016-05-13 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133164 --- src/master/quota_handler.cpp (line 464)

Re: Review Request 47168: Windows: Implemented `kill`.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review133155 --- 3rdparty/stout/include/stout/os/windows/kill.hpp (lines 47 - 48)

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47162/#review132487 --- 3rdparty/libprocess/src/tests/main.cpp (lines 45 - 63)

Re: Review Request 47169: Windows: Implemented `killtree` using NT job objects.

2016-05-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review133157 --- Fix it, then Ship it!

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133158 --- Ship it! Looks fine. Consider switching to ``unique_ptr``,

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

2016-05-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- (Updated May 13, 2016, 5:22 p.m.) Review request for mesos. Bugs: MESOS-5371

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133162 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/ --- (Updated May 13, 2016, 4:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- (Updated May 13, 2016, 1:49 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133205 --- Ship it! Ship It! - Gilbert Song On May 13, 2016, 12:09

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-05-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review133198 --- This looks good but when you mentioned the consecutive failures

Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Review Request 47365: Moved code from HTTP command executor to command executor.

2016-05-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47365/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Review Request 47366: Made the command executor use the adapter interface.

2016-05-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47366/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-13 Thread Gilbert Song
> On May 12, 2016, 5:25 a.m., Guangya Liu wrote: > > include/mesos/docker/v1.proto, lines 56-57 > > > > > > Why both `optional`? I found that other `Label` definition are defining > > `key` as required but `value`

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/#review133196 --- src/tests/health_check_tests.cpp (line 1015)

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- (Updated May 13, 2016, 1:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47168: Windows: Implemented `kill`.

2016-05-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/ --- (Updated May 13, 2016, 8:42 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 47169: Windows: Implemented `killtree` using NT job objects.

2016-05-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/ --- (Updated May 13, 2016, 8:42 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 47359: Fixed a typo in persistent volume docs.

2016-05-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47359/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-13 Thread Guangya Liu
> On 五月 12, 2016, 12:44 p.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 226-230 > > > > > > Does there are any possiblity that there are duplicat labels in > > `config` and `container_config`? If so, how to

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-13 Thread Guangya Liu
> On 五月 12, 2016, 12:25 p.m., Guangya Liu wrote: > > include/mesos/docker/v1.proto, lines 56-57 > > > > > > Why both `optional`? I found that other `Label` definition are defining > > `key` as required but `value`

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review133249 --- Bad patch! Reviews applied: [47374, 47216, 47150, 47215, 47214,

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/#review133251 --- Patch looks great! Reviews applied: [47265, 47266] Passed

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/#review133243 --- src/slave/slave.cpp (line 1019)

Re: Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133246 --- Bad patch! Reviews applied: [47362] Failed command:

Re: Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

2016-05-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133250 --- 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 736)

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-13 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/ --- (Updated May 14, 2016, 4:20 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

2016-05-13 Thread Guangya Liu
> On 五月 13, 2016, 6:49 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 320 > > > > > > s/bind/bind and overlay > > Gilbert Song wrote: > The overlay backend supports

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

2016-05-13 Thread Guangya Liu
> On 五月 12, 2016, 10:34 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp, line > > 174 > > > > > > since you already have the check above, why dont you return

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Guangya Liu
> On 五月 13, 2016, 5:22 p.m., James Peach wrote: > > Looks fine. Consider switching to ``unique_ptr``, since we only check the > > ``fts_close`` error 1 of 3 times. @James Peach, can you please show more detail for what do you mean? How to switch to `unique_prt`? Do you want me to submit

Review Request 47381: Fixed agent to properly handle killTask of unregistered executor.

2016-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47381/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5380

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated 五月 14, 2016, 1:33 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/#review133232 --- Patch looks great! Reviews applied: [46107] Passed command:

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/ --- (Updated May 14, 2016, 12:39 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- (Updated 五月 14, 2016, 12:58 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/ --- (Updated 五月 14, 2016, 1:29 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 47169: Windows: Implemented `killtree` using NT job objects.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review133239 --- Patch looks great! Reviews applied: [47052, 47053, 47221, 47054,

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-13 Thread Gilbert Song
> On May 12, 2016, 5:44 a.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 226-230 > > > > > > Does there are any possiblity that there are duplicat labels in > > `config` and `container_config`? If so, how to

Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

2016-05-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil

Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/ --- Review request for mesos, Bernd Mathiske and Neil Conway. Bugs: MESOS-5215

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133200 --- Patch looks great! Reviews applied: [47274] Passed command:

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

2016-05-13 Thread Gilbert Song
> On May 12, 2016, 11:49 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 320 > > > > > > s/bind/bind and overlay The overlay backend supports multi-layered images:) -

  1   2   >