Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/#review151458 --- Patch looks great! Reviews applied: [52470, 52520, 52471]

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151381 --- Patch looks great! Reviews applied: [51774, 52515, 52516]

Re: Review Request 52462: Ported ReviewBot script to Windows.

2016-10-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52462/ --- (Updated Oct. 4, 2016, 1:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

2016-10-04 Thread haosdent huang
> On Sept. 6, 2016, 3:31 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 155-159 > > > > > > I think we need to put this after `MESOS_DOCKER_EXECUTOR` to keep the > >

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

2016-10-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/#review151359 --- Ship it! Ship It! - haosdent huang On Oct. 4, 2016, 1:55

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 4, 2016, 6:02 p.m.) Review request for mesos, Anand Mazumdar and

Review Request 52520: Exposed the executor's type in the endpoints.

2016-10-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6283

Re: Review Request 50327: Added scripts to build sample framework executables.

2016-10-04 Thread Srinivas Brahmaroutu
> On Oct. 3, 2016, 11:05 p.m., Joseph Wu wrote: > > src/examples/CMakeLists.txt, lines 84-92 > > > > > > Why are these necessary? I could build a couple of the example > > frameworks after deleting these. You are

Re: Review Request 50327: Added scripts to build sample framework executables.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated Oct. 4, 2016, 4:53 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 4, 2016, 5:59 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

2016-10-04 Thread haosdent huang
> On Sept. 2, 2016, 4:53 p.m., haosdent huang wrote: > > src/Makefile.am, line 1377 > > > > > > I think the name `mesos-tcp-connect` may be not clear enough. Should we > > add something like `health-check` into

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-04 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 4, 2016, 5:54 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52431: Reduced boilerplate from health check tests.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52431/#review151387 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 30, 2016,

Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/#review151397 --- src/tests/health_check_tests.cpp (lines 680 - 682)

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Oct. 4, 2016, 9:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Jacob Janco
> On Sept. 28, 2016, 9:33 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 224 > > > > > > ``` > > // If no run is queued we only update `allocationCandidates` > > ``` > >

Re: Review Request 46228: Create persistent volume with a supplied user.

2016-10-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/#review149834 --- src/common/resources.cpp (line 146)

Re: Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151394 --- src/tests/health_check_tests.cpp (lines 1169 - 1172)

Re: Review Request 52357: Improved handling of health check failures within the grace period.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review151386 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 4, 2016,

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Oct. 4, 2016, 9:12 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

2016-10-04 Thread Alexander Rukletsov
> On Oct. 4, 2016, 9:07 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp, lines 680-682 > > > > > > Can we make it similar to the test you introduce in r/52357? They look > > like they do the

Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Oct. 4, 2016, 9:10 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151408 --- Jacob, two other comments for this: 1) when will you have the

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-04 Thread Guangya Liu
> On 九月 28, 2016, 10:37 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 587-618 > > > > > > No need for the helpers. Just the following is sufficient. > > > > ``` > > Resource resource; >

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/#review151310 --- Patch looks great! Reviews applied: [51999, 52002, 51879, 51880,

Re: Review Request 52081: Reorganized includes in containerizer.

2016-10-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52081/ --- (Updated Oct. 4, 2016, 3:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-10-04 Thread Benjamin Bannier
> On Oct. 2, 2016, 2:22 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, line 378 > > > > > > I suggest we take `Option` here so that the caller > > can do: > > ``` > >

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

2016-10-04 Thread Alexander Rukletsov
> On Sept. 29, 2016, 4:35 p.m., Benjamin Bannier wrote: > > Why does this need to be an extra commit? It appears it should just be > > folded into https://reviews.apache.org/r/51605/ which adds this target for > > the automake setup. > > Alexander Rukletsov wrote: > Because it's in

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-10-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Oct. 4, 2016, 3:08 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 52357: Improved handling of health check failures within the grace period.

2016-10-04 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/ --- (Updated Oct. 4, 2016, 1:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/ --- (Updated Oct. 4, 2016, 1:04 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 52434: Improved handling of tmp file creation in health check test.

2016-10-04 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/ --- (Updated Oct. 4, 2016, 1:40 p.m.) Review request for mesos, Alexander

Re: Review Request 52499: Removed a redundant space from Appc fetcher.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52499/#review151319 --- Patch looks great! Reviews applied: [52499] Passed command:

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/ --- (Updated Oct. 4, 2016, 1:54 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/ --- (Updated Oct. 4, 2016, 1:57 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/ --- (Updated Oct. 4, 2016, 2:44 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 4, 2016, 2:43 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 4, 2016, 2:43 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/ --- (Updated Oct. 4, 2016, 1:55 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 51609: Updated formatting in HealthChecker for consistency.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51609/ --- (Updated Oct. 4, 2016, 1:58 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 51608: Extracted "curl" binary into HTTP_CHECK_COMMAND constant.

2016-10-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51608/ --- (Updated Oct. 4, 2016, 1:58 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

2016-10-04 Thread Alexander Rukletsov
> On Sept. 6, 2016, 6:54 p.m., Avinash sridharan wrote: > > src/health-check/health_checker.cpp, line 117 > > > > > > Shouldn't we check is this directory exists before creating this > > `HealthCheckerProcess`? >

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 4, 2016, 2:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 4, 2016, 2:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 4, 2016, 2:45 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 4, 2016, 2:44 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51752: Add event for `FRAMEWORK_REMOVED`.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51752/ --- (Updated Oct. 4, 2016, 2:44 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- Review request for mesos. Repository: mesos Description --- Add test

Review Request 52515: Implement `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/ --- Review request for mesos. Repository: mesos Description --- Implement

Re: Review Request 52515: Implement `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/ --- (Updated Oct. 4, 2016, 2:45 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52042: Changed error message in pailer if user is unauthorized.

2016-10-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/#review151426 --- Fix it, then Ship it! Looks good except for the typo, but I

Review Request 52537: Added unit test for provisioner 'RecoverNestedContainerNoParentImage'.

2016-10-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52537/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 52536: Refactored the provisioner recover test.

2016-10-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52536/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Jacob Janco
> On Oct. 1, 2016, 12:11 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1311 > > > > > > I think that here we should return `Nothing()` but not > > `allocation.get()`, as

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Jacob Janco
> On Oct. 4, 2016, 9:47 p.m., Guangya Liu wrote: > > Jacob, two other comments for this: > > > > 1) when will you have the patch `SmallOfferFilter` ready for review? > > 2) I think we may need another benchmark test which only do two operations: > > a) add multiple agents first 2) add multiple

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Oct. 4, 2016, 11:45 p.m.) Review request for mesos, Alex Clemmer and

Review Request 52534: Dispatch filter expiration twice.

2016-10-04 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/ --- Review request for mesos. Repository: mesos Description --- - With an

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Oct. 4, 2016, 11:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52520: Exposed the executor's type in the endpoints.

2016-10-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/#review151427 --- Ship it! Ship It! - Vinod Kone On Oct. 4, 2016, 6:01 p.m.,

Re: Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.

2016-10-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52034/#review151428 --- Ship it! LGTM, although I'm no JS expert.

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-10-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review151423 --- Fix it, then Ship it! support/mesos-style.py (lines 270 -

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

2016-10-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/#review151421 --- Fix it, then Ship it! Builds and runs as expected.

Re: Review Request 51108: Added additional parameters to the CLI config.

2016-10-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51108/#review151433 --- src/cli_new/bin/config.py (line 52)

Re: Review Request 50327: Added scripts to build sample framework executables.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/#review151420 --- Patch looks great! Reviews applied: [50064, 50179, 50323, 50324,

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Oct. 4, 2016, 11:46 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49870: Added test executables required to run tests.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Oct. 4, 2016, 11:46 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.

2016-10-04 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Oct. 4, 2016, 11:46 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-04 Thread Vinod Kone
> On Oct. 3, 2016, 10:28 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4339 > > > > > > Mutating TaskInfo should be avoided as much as possible. > > > > I don't follow why we need this. > >

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread Vinod Kone
> On Oct. 3, 2016, 10:35 p.m., Vinod Kone wrote: > > src/webui/master/static/js/app.js, line 42 > > > > > > Is this backwards compatible? What if some one is depending on this > > path to exist? Morever, I think

Re: Review Request 51752: Add event for `FRAMEWORK_REMOVED`.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51752/ --- (Updated Oct. 4, 2016, 3:23 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51299: Fixed memory leak in master during framework teardown.

2016-10-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51299/#review151339 --- Ship it! Ship It! - Greg Mann On Oct. 3, 2016, 8:54 p.m.,

Re: Review Request 52357: Improved handling of health check failures within the grace period.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review151335 --- Patch looks great! Reviews applied: [52357] Passed command:

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-10-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Oct. 4, 2016, 5:03 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-10-04 Thread Benjamin Bannier
> On Oct. 2, 2016, 2:22 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 665-682 > > > > > > I am wondering if we can parameterize this as well? Yes we can :D Updated the RR to this

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151436 --- src/master/allocator/mesos/hierarchical.cpp (lines 1305 - 1310)

Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

2016-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52539/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Review Request 52541: Renamed the filesystem isolator tests file name.

2016-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52541/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Review Request 52540: Converted the SandboxEnvironmentVariable test to an end to end test.

2016-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52540/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Re: Review Request 52534: Dispatch filter expiration twice.

2016-10-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review151442 --- 1) Instead of this fix, can we simply kill

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

2016-10-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/ --- (Updated Oct. 5, 2016, 4:06 a.m.) Review request for mesos, Haris Choudhary

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread haosdent huang
> On Oct. 3, 2016, 10:35 p.m., Vinod Kone wrote: > > src/webui/master/static/js/app.js, line 42 > > > > > > Is this backwards compatible? What if some one is depending on this > > path to exist? Morever, I think

Re: Review Request 52537: Added unit test for provisioner 'RecoverNestedContainerNoParentImage'.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52537/#review151441 --- Patch looks great! Reviews applied: [52536, 52537] Passed

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

2016-10-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151392 --- Ditto comments for the versioned protobuf.

Review Request 52543: Added configure/make options to build the new CLI and run unit tests.

2016-10-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52543/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-6008 and MESOS-6032

Review Request 52538: Reordered filesystem isolator tests.

2016-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52538/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-04 Thread Guangya Liu
> On 十月 5, 2016, 1:02 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1313-1318 > > > > > > The intention of making allocate asynchronous and returning a Future is > > that the

Re: Review Request 52385: Fixed flag stringification bug in Linux filesystem isolator.

2016-10-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52385/#review151438 --- Ship it! Ship It! - Michael Park On Sept. 29, 2016, 12:54

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-10-04 Thread Kevin Klues
> On Oct. 5, 2016, 12:18 a.m., Joseph Wu wrote: > > support/mesos-style.py, lines 270-272 > > > > > > It may help to change the order of reviews (no rebase necessary, just > > the "depends on" field). > > >

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-10-04 Thread Kevin Klues
> On Oct. 5, 2016, 12:18 a.m., Joseph Wu wrote: > > support/mesos-style.py, lines 270-272 > > > > > > It may help to change the order of reviews (no rebase necessary, just > > the "depends on" field). > > >

Re: Review Request 52541: Renamed the filesystem isolator tests file name.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52541/#review151448 --- Patch looks great! Reviews applied: [52538, 52539, 52540, 52541]

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

2016-10-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/ --- (Updated Oct. 5, 2016, 4:05 a.m.) Review request for mesos, Haris Choudhary

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

2016-10-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/ --- (Updated Oct. 5, 2016, 4:11 a.m.) Review request for mesos, Haris Choudhary

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

2016-10-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/ --- (Updated Oct. 5, 2016, 4:12 a.m.) Review request for mesos, Haris Choudhary

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-10-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51946/#review151340 --- Ship it! Thanks Guangya! - Greg Mann On Oct. 3, 2016, 9:53

Re: Review Request 52434: Improved handling of tmp file creation in health check test.

2016-10-04 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/ --- (Updated Oct. 4, 2016, 4:14 p.m.) Review request for mesos, Alexander

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51946/#review151307 --- Patch looks great! Reviews applied: [51946] Passed command: