Review Request 53013: Removed extra 'evolve' implementation from 'api_tests.cpp'.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53013/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Jie Yu.

Review Request 53014: Removed unused tests helper macro 'DEFAULT_CONTAINER_ID'.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53014/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Repository: mesos

Review Request 53012: Fixed usage of 'evolve' in master http endpoints.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53012/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Jie Yu.

Re: Review Request 53009: Add support for task labels to example no_executor_framework.

2016-10-18 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53009/#review153243 --- Ship it! LGTM src/examples/no_executor_framework.cpp (lines

Re: Review Request 53009: Add support for task labels to example no_executor_framework.

2016-10-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53009/#review153246 --- src/examples/no_executor_framework.cpp (line 315)

Re: Review Request 53005: Updated release guide.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53005/#review153241 --- Patch looks great! Reviews applied: [53005] Passed command:

Re: Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/#review153245 --- 3rdparty/libprocess/src/poll_socket.cpp (lines 133 - 141)

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

2016-10-18 Thread Joris Van Remoortere
> On Oct. 18, 2016, 10:09 p.m., Jie Yu wrote: > > src/tests/mesos.hpp, line 500 > > > > > > Can you do > > ``` > > #define EXECUTOR_EXECUTOR_INFO createExecutorInfo("default", "exit 1"); > > ``` Will do

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/ --- (Updated Oct. 19, 2016, 4:49 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/ --- (Updated Oct. 19, 2016, 4:50 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53009: Add support for task labels to example no_executor_framework.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53009/#review153248 --- Patch looks great! Reviews applied: [53009] Passed command:

Re: Review Request 52254: Updated aufs mount with `rw` and `ro+wh` options.

2016-10-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52254/#review153247 --- Ship it! Ship It! - Jie Yu On Sept. 26, 2016, 7:26 a.m.,

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

2016-10-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46227/ --- (Updated Oct. 18, 2016, 7:42 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-10-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52980/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4893

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

2016-10-18 Thread Edward Bortnikov
> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

2016-10-18 Thread Benjamin Bannier
> On Oct. 18, 2016, 6:55 a.m., Avinash sridharan wrote: > > docs/linux_capabilities.md, line 3 > > > > > > s/described/describes > > > > to add support for `Linux Capabilities` I do not understand your

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

2016-10-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52682/ --- (Updated Oct. 18, 2016, 10:48 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-10-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/#review153055 --- Fix it, then Ship it! I'll just make the adjustments below

Re: Review Request 46228: Create persistent volume with a supplied user.

2016-10-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/ --- (Updated Oct. 18, 2016, 7:45 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

2016-10-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46229/ --- (Updated Oct. 18, 2016, 7:46 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-10-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Oct. 18, 2016, 10:39 a.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-10-18 Thread Benjamin Bannier
> On Oct. 18, 2016, 9:54 a.m., Michael Park wrote: > > src/local/main.cpp, lines 48-63 > > > > > > Is there a reason why we don't just add this directly to `local::Flags`? `local::Flags` is used in some other

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-10-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/#review153049 --- src/local/main.cpp (lines 48 - 63)

Re: Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/#review153052 --- Bad patch! Reviews applied: [52624, 52625, 52972, 52544, 52364,

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-10-18 Thread Benjamin Bannier
> On Oct. 18, 2016, 11:22 a.m., Michael Park wrote: > > I'll just make the adjustments below when I commit it. Please let me know > > if you're against any of them. Thanks for the careful review. Your suggested adjustments are needed, +1. - Benjamin

Re: Review Request 52741: Added capabilities support to mesos-execute.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review153065 --- Patch looks great! Reviews applied: [52780, 52741] Passed

Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-18 Thread Benjamin Bannier
> On Oct. 18, 2016, 12:11 a.m., Jie Yu wrote: > > src/v1/mesos.cpp, lines 517-533 > > > > > > Can you follow the same impl in v0? In fact I would have liked to use the same tooling v0 uses here, but could find

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

2016-10-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/ --- (Updated Oct. 18, 2016, 9:51 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 52390: Fully qualified addresses of Flag members in add calls in stout.

2016-10-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52390/#review153053 --- Fix it, then Ship it! 3rdparty/stout/tests/flags_tests.cpp

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

2016-10-18 Thread Anoop Sam John
> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Review Request 52986: Updated endpoint-help in preparation of 1.1.0.

2016-10-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52986/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/#review153073 --- Patch looks great! Reviews applied: [46227, 52980, 46228, 46229,

Review Request 52985: Updated CHANGELOG in preparation for RC1 of 1.1.0.

2016-10-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52985/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-18 Thread haosdent huang
> On Oct. 18, 2016, 4:49 a.m., Jie Yu wrote: > > src/docker/docker.hpp, line 51 > > > > > > Having this as a global knob sounds really weird to me. I know you want > > to work around the Docker::run GMock issue. But

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

2016-10-18 Thread Anoop Sam John
> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52682/#review153081 --- Patch looks great! Reviews applied: [52682] Passed command:

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-10-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/ --- (Updated Oct. 18, 2016, 7:46 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52986: Updated endpoint-help in preparation of 1.1.0.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52986/#review153101 --- Patch looks great! Reviews applied: [52985, 52986] Passed

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

2016-10-18 Thread Aaron Wood
> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 291 > > > > > > It's not obvious to me that this is the right change since the > > surrounding code tries to deal with

Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52967/ --- (Updated Oct. 18, 2016, 4:15 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

2016-10-18 Thread Avinash sridharan
> On Oct. 18, 2016, 4:55 a.m., Avinash sridharan wrote: > > docs/configuration.md, line 1003 > > > > > > s/the agent/that the agent/ > > Benjamin Bannier wrote: > Not a native speaker but to me this seems to

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-18 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Oct. 18, 2016, 4:14 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-18 Thread Neil Conway
> On Oct. 18, 2016, 7:19 a.m., Jiang Yan Xu wrote: > > docs/home.md, line 54 > > > > > > s/tasks/tasks across containers/ > > > > as multiple tasks sharing an executor today can already access the same > >

Review Request 52988: Fixed a typo in a comment.

2016-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52988/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 52985: Updated CHANGELOG in preparation for RC1 of 1.1.0.

2016-10-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52985/#review153094 --- Fix it, then Ship it! CHANGELOG (lines 1 - 2)

Re: Review Request 50380: Added new benchmark test for port resources.

2016-10-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/ --- (Updated 十月 18, 2016, 3:02 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52986: Updated endpoint-help in preparation of 1.1.0.

2016-10-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52986/#review153096 --- Ship it! I assume this is autoimatically generated *without*

Re: Review Request 52985: Updated CHANGELOG in preparation for RC1 of 1.1.0.

2016-10-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52985/ --- (Updated Oct. 18, 2016, 3:24 p.m.) Review request for mesos and Alexander

Re: Review Request 52986: Updated endpoint-help in preparation of 1.1.0.

2016-10-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52986/ --- (Updated Oct. 18, 2016, 3:14 p.m.) Review request for mesos and Alexander

Re: Review Request 52940: Updated CLI pylint configuration to allow up to 30 local variables.

2016-10-18 Thread Kevin Klues
> On Oct. 18, 2016, 1 a.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 14 > > > > > > Looks like `__enter_namespaces` in https://reviews.apache.org/r/52953/ > > is over the default limit of 15 by one

Re: Review Request 52939: Updated CLI pylint configuration to allow 2 character variable names.

2016-10-18 Thread Joseph Wu
> On Oct. 17, 2016, 6 p.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 13 > > > > > > I see a single 2 character variable name `io` here: > > https://reviews.apache.org/r/52953/diff/1#0 -- Line 306 > >

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

2016-10-18 Thread Aaron Wood
> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > > > > > Can you just make ``length`` type ``ssize_t``? `length` is `ssize_t` (set on line 235) -

Re: Review Request 52939: Updated CLI pylint configuration to allow 2 character variable names.

2016-10-18 Thread Kevin Klues
> On Oct. 18, 2016, 1 a.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 13 > > > > > > I see a single 2 character variable name `io` here: > > https://reviews.apache.org/r/52953/diff/1#0 -- Line 306 > >

Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

2016-10-18 Thread Kevin Klues
> On Oct. 18, 2016, 1 a.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 15 > > > > > > Is this used anywhere? I did not encounter a linting error for this in > > your chain. I know I encountered it at

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

2016-10-18 Thread Kevin Klues
> On Oct. 18, 2016, 1:01 a.m., Joseph Wu wrote: > > src/cli_new/bin/tests.py, lines 23-25 > > > > > > This actually failed to lint after applying: > > ``` > > Checking 1 Python file > > *

Re: Review Request 52953: Added container 'exec' command to the CLI.

2016-10-18 Thread Kevin Klues
> On Oct. 18, 2016, 1:01 a.m., Joseph Wu wrote: > > src/cli_new/lib/mesos/plugins/container/main.py, line 30 > > > > > > Hit the same linter-using-old-virtualenv error when applying this patch > > as described in: >

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-18 Thread Zhitao Li
> On Oct. 18, 2016, 4:49 a.m., Jie Yu wrote: > > src/docker/docker.hpp, line 51 > > > > > > Having this as a global knob sounds really weird to me. I know you want > > to work around the Docker::run GMock issue. But

Re: Review Request 52940: Updated CLI pylint configuration to allow up to 30 local variables.

2016-10-18 Thread Joseph Wu
> On Oct. 17, 2016, 6 p.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 14 > > > > > > Looks like `__enter_namespaces` in https://reviews.apache.org/r/52953/ > > is over the default limit of 15 by one

Review Request 52992: Updated configure.ac in preparation of 1.2.0.

2016-10-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52992/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

2016-10-18 Thread Joseph Wu
> On Oct. 17, 2016, 6 p.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 15 > > > > > > Is this used anywhere? I did not encounter a linting error for this in > > your chain. > > Kevin Klues wrote: > I

Review Request 52991: Updated CHANGELOG in preparation of 1.2.0.

2016-10-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52991/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 52953: Added container 'exec' command to the CLI.

2016-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52953/ --- (Updated Oct. 18, 2016, 7:01 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52988: Fixed a typo in a comment.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52988/#review153153 --- Patch looks great! Reviews applied: [52988] Passed command:

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-10-18 Thread Alex Clemmer
> On Oct. 18, 2016, 7:58 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/mkdir.hpp, line 43 > > > > > > Permissions is a bit of a subtle issue in Mesos, which we've largely > > punted on. I'm a bit

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/ --- (Updated Oct. 18, 2016, 8:04 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/ --- (Updated Oct. 18, 2016, 8:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-10-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52980/#review153155 --- 3rdparty/stout/include/stout/os/mkdir.hpp (line 43)

Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52780/#review153162 --- Ship it! Made some adjustment while commit. - Jie Yu On

Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/#review153165 --- Ship it! Ship It! - Vinod Kone On Oct. 15, 2016, 5:06 a.m.,

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-10-18 Thread Anindya Sinha
> On Oct. 18, 2016, 7:58 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/mkdir.hpp, line 43 > > > > > > Permissions is a bit of a subtle issue in Mesos, which we've largely > > punted on. I'm a bit

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-10-18 Thread Anindya Sinha
> On Oct. 18, 2016, 7:58 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/mkdir.hpp, line 43 > > > > > > Permissions is a bit of a subtle issue in Mesos, which we've largely > > punted on. I'm a bit

Re: Review Request 52719: Renamed a function for clarity.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52719/#review153171 --- Ship it! s/reconcileKnownTasks/reconcileKnownSlave/ in the

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- (Updated Oct. 18, 2016, 9:09 p.m.) Review request for mesos and Vinod Kone.

Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/ --- Review request for mesos and Michael Park. Bugs: MESOS-6412

Re: Review Request 52969: Removed redundant test.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52969/#review153166 --- Ship it! Ship It! - Vinod Kone On Oct. 18, 2016, 1:13 a.m.,

Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/#review153168 --- Ship it! Ship It! - Vinod Kone On Oct. 18, 2016, 1:14 a.m.,

Re: Review Request 52719: Renamed a function for clarity.

2016-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52719/ --- (Updated Oct. 18, 2016, 9:07 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52991: Updated CHANGELOG in preparation of 1.2.0.

2016-10-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52991/#review153174 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2016,

Re: Review Request 52992: Updated configure.ac in preparation of 1.2.0.

2016-10-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52992/#review153177 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2016,

Re: Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/ --- (Updated Oct. 18, 2016, 9:37 p.m.) Review request for mesos and Michael Park.

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

2016-10-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/ --- (Updated 十月 18, 2016, 6:17 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52769: Some rename for original resource benchmark test.

2016-10-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52769/ --- (Updated 十月 18, 2016, 6:50 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

2016-10-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52682/ --- (Updated Oct. 18, 2016, 8:59 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

2016-10-18 Thread Benjamin Bannier
> On Oct. 18, 2016, 12:02 a.m., Jie Yu wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 100 > > > > > > const UsaImage& I believe we always pass fundamental types like this enum by

Re: Review Request 51033: Added validation benchmark test for resources.

2016-10-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51033/ --- (Updated 十月 18, 2016, 7:05 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 51505: Replace http::get with http::request in mesos project.

2016-10-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51505/#review153044 --- src/tests/executor_http_api_tests.cpp (lines 310 - 312)

Re: Review Request 51493: Add the query parameter in createRequest.

2016-10-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51493/#review153039 --- Handle the error, and then we'll consider this an appropriate

Re: Review Request 51495: Replace http::get with http::request in libprocess project.

2016-10-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51495/#review153041 --- Looks good besides the wrapping

Re: Review Request 52741: Added capabilities support to mesos-execute.

2016-10-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/ --- (Updated Oct. 18, 2016, 9:07 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 52741: Added capabilities support to mesos-execute.

2016-10-18 Thread Benjamin Bannier
> On Oct. 18, 2016, 12:10 a.m., Jie Yu wrote: > > src/cli/execute.cpp, line 690 > > > > > > Why the extra `()`? Misguided consistency with the check above :/ ... I reordered and reformated the condition. -

Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-18 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52967/#review153036 --- Fix it, then Ship it! docs/home.md (line 54)

Re: Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/#review153179 --- 3rdparty/libprocess/src/poll_socket.cpp (line 114)

Re: Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread James Peach
> On Oct. 18, 2016, 9:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, line 114 > > > > > > Missing reference. I wanted a copy (at least the lambda needs to take a copy), since

Re: Review Request 50380: Added new benchmark test for port resources.

2016-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/#review153183 --- Patch looks great! Reviews applied: [52975, 50551, 52769, 51033,

Re: Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread Joris Van Remoortere
> On Oct. 18, 2016, 9:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, line 114 > > > > > > Missing reference. > > James Peach wrote: > I wanted a copy (at least the lambda

Re: Review Request 52997: Improve Socket::connect error message.

2016-10-18 Thread Joris Van Remoortere
On Oct. 18, 2016, 9:41 p.m., James Peach wrote: > > Can you also follow up with a review to change the logging level in > > libprocess for failing to close the socket if we fail to connect? > > Maybe it should be `VLOG(1)`? Thoughts? > > James Peach wrote: > I actually removed the `VLOG`

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

2016-10-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/#review153167 --- src/tests/api_tests.cpp (line 838)

Review Request 53005: Updated release guide.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53005/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 52721: Fixed typo in log message.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52721/#review153205 --- Ship it! Ship It! - Vinod Kone On Oct. 11, 2016, 1:03 a.m.,

Re: Review Request 52740: Refactored some code into a separate function.

2016-10-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52740/#review153210 --- Ship it! Ship It! - Vinod Kone On Oct. 12, 2016, 7:34 p.m.,

  1   2   >