Re: Review Request 63804: Added protos for operation reconciliation between master and agent.

> On Nov. 14, 2017, 7:18 p.m., Gaston Kleiman wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 72-75 (patched) > > > > > > Isn't the idea to use this message only when the master wants to

Re: Review Request 63804: Added protos for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Nov. 14, 2017, 9:56 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63767: Added a missing protobuf field to the unversioned definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63767/#review190999 --- Ship it! Ship It! - Gaston Kleiman On Nov. 13, 2017, 3:17

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/#review191003 --- src/master/master.cpp Line 2671 (original), 2671 (patched)

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/ --- (Updated Nov. 14, 2017, 9:44 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63810/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 14, 2017, 9:41 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63804: Added protos for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Nov. 14, 2017, 10:37 p.m.) Review request for mesos, Benjamin

Re: Review Request 63804: Added plumbing for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Nov. 14, 2017, 10:38 p.m.) Review request for mesos, Benjamin

Review Request 63818: Added quick start instructions for CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63818/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Repository: mesos

Review Request 63813: Windows: Fixed name of default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63813/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Review Request 63814: Windows: Fixed `os::host_default_path()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63815/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/#review191007 --- Fix it, then Ship it! src/scheduler/scheduler.cpp Lines

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/ --- (Updated Nov. 14, 2017, 1:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63804: Added plumbing for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Nov. 14, 2017, 10:56 p.m.) Review request for mesos, Benjamin

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/ --- (Updated Nov. 14, 2017, 8:48 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 63809: Windows: Fixed symlink code to not need admin privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63809/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Review Request 63823: Initialized and subscribed storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63823/ --- Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Bugs:

Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

> On Nov. 14, 2017, 3:23 p.m., Andrei Budnik wrote: > > 3rdparty/stout/include/stout/os/linux.hpp > > Line 66 (original), 66 (patched) > > > > > > `ErrnoError` is not async-signal-safe as it constructs empty > >

Re: Review Request 63799: Improved log messages of offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63799/#review191020 --- PASS: Mesos patch 63799 was successfully built and tested.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review191026 --- Some suggestions from going over it together: * Maybe add an

Re: Review Request 63022: Imported resources from CSI plugins in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Nov. 15, 2017, 2:42 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Nov. 15, 2017, 2:44 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

> On Nov. 14, 2017, 3:23 p.m., Andrei Budnik wrote: > > 3rdparty/stout/include/stout/os/linux.hpp > > Line 66 (original), 66 (patched) > > > > > > `ErrnoError` is not async-signal-safe as it constructs empty > >

Re: Review Request 63652: Added d_type check in containerizer backend validation.

> On Nov. 14, 2017, 9:32 a.m., James Peach wrote: > > This is looking pretty good. > > > > You should be able to write a test for this using the > > [ROOT_XFS_TestBase](https://github.com/apache/mesos/blob/master/src/tests/containerizer/xfs_quota_tests.cpp) > > fixture. Probably a reasonable

Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/#review191006 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 63811: Windows: Added `get_handle_follow` which follows symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63811/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Review Request 63817: Windows: Enabled more agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63817/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Review Request 63812: Windows: Fixed `os::realpath` to behave like POSIX version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63812/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Re: Review Request 63818: Added quick start instructions for CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63818/#review191023 --- Ship it! This is super helpful, thanks! docs/cmake.md Lines

Re: Review Request 63554: Added a publish function in resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63554/ --- (Updated Nov. 15, 2017, 2:46 a.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63389: Added a mock resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/ --- (Updated Nov. 15, 2017, 2:46 a.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/ --- (Updated Nov. 15, 2017, 2:45 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63804: Added plumbing for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/#review191027 --- PASS: Mesos patch 63804 was successfully built and tested.

Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and

Re: Review Request 63817: Windows: Enabled more agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63817/ --- (Updated Nov. 14, 2017, 3:56 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/ --- (Updated Nov. 15, 2017, 2:40 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63753: Upgraded vendored protobuf to 3.5.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63753/ --- (Updated Nov. 14, 2017, 8:57 p.m.) Review request for mesos and Benjamin

Re: Review Request 63818: Added quick start instructions for CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63818/#review191038 --- PASS: Mesos patch 63818 was successfully built and tested.

Re: Review Request 63801: Windows: Fixed build of Google Test with Visual Studio Preview.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63801/#review191032 --- PASS: Mesos patch 63801 was successfully built and tested.

Re: Review Request 63577: Fixed a task status update race in default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63577/ --- (Updated Nov. 15, 2017, 2:21 p.m.) Review request for mesos, Alexander

Re: Review Request 63766: Clarified log message when selecting backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63766/#review190939 --- PASS: Mesos patch 63766 was successfully built and tested.

Re: Review Request 63753: Upgraded vendored protobuf to 3.5.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63753/ --- (Updated Nov. 14, 2017, 1 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63794/ --- Review request for mesos, Alexander Rukletsov and Avinash sridharan. Bugs:

Re: Review Request 63768: Added 'ReconcileOfferOperations' reponse to scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/#review190942 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/ --- Review request for mesos, Alexander Rukletsov and Avinash sridharan. Bugs:

Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- Review request for mesos, Alexander Rukletsov and Avinash sridharan. Bugs:

Re: Review Request 63791: Handled the resource conversion for new operations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63791/ --- (Updated Nov. 14, 2017, 10:33 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63767: Added a missing protobuf field to the unversioned definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63767/#review190923 --- Ship it! Ship It! - Jan Schlicht On Nov. 14, 2017, 12:17

Review Request 63791: Handled the resource conversion for new operations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63791/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review190925 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63271: Windows: Added `os::set_job_mem_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/#review190955 --- Ship it! Ship It! - Aaron Wood On Nov. 14, 2017, 12:20

Re: Review Request 63791: Handled the resource conversion for new operations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63791/#review190959 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 9:33 a.m., Jan

Review Request 63799: Improved log messages of offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63799/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63730: Passed operations from resource provider to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/#review190948 --- Fix it, then Ship it! Please rebase, the formatting fix in

Re: Review Request 63515: Updated some isolators' usage of ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63515/#review190949 --- FAIL: Mesos tests failed to build. Reviews applied: `['60888',

Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63677/#review190945 --- 3rdparty/stout/include/stout/os/linux.hpp Line 66 (original), 66

Re: Review Request 63678: Improved the signal safety of `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/#review190950 --- src/linux/ns.cpp Lines 457 (patched)

Re: Review Request 63555: Publish resource provider resources before container launch or update.

> On Nov. 9, 2017, 1:52 p.m., Jan Schlicht wrote: > > src/slave/slave.hpp > > Lines 538 (patched) > > > > > > What's the motivation for this `extra` parameter? It isn't used > > anywhere, probably we should remove

Review Request 63798: Added resource provider support for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8218

Review Request 63797: Changed resource checkpointing to no longer failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63797/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8211

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review190952 --- src/master/master.cpp Lines 7093 (patched)

Re: Review Request 63804: Added protos for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/#review190991 --- include/mesos/resource_provider/resource_provider.proto Lines

Re: Review Request 63577: Fixed a task status update race in default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63577/#review190993 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 63277: Windows: Ported CPU and memory isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63277/#review190964 --- src/tests/containerizer/cpu_isolator_tests.cpp Line 251

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review190962 --- This is looking pretty good. You should be able to write a test

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/#review190963 --- src/slave/slave.cpp Line 3720 (original), 3731 (patched)

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

> On Nov. 14, 2017, 5:40 p.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 3720 (original), 3731 (patched) > > > > > > Let's add a CHECK here to test the operation is old operation. > > > > ``` > >

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/#review190966 --- Ship it! Ship It! - Akash Gupta On Nov. 14, 2017, 1:57

Re: Review Request 63277: Windows: Ported CPU and memory isolator tests.

> On Nov. 14, 2017, 9:07 a.m., Akash Gupta wrote: > > src/tests/containerizer/cpu_isolator_tests.cpp > > Line 251 (original), 270 (patched) > > > > > > Personally, I think it makes sense to increase this time on

Review Request 63801: Windows: Fixed build of Google Test with Visual Studio Preview.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63801/ --- Review request for mesos, Akash Gupta, John Kordich, and James Peach. Bugs:

Re: Review Request 63797: Changed resource checkpointing to no longer failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63797/#review190972 --- src/slave/slave.cpp Lines 3568-3574 (original), 3573-3578

Re: Review Request 63753: Upgraded vendored protobuf to 3.5.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63753/#review190979 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 63675: Added a non-allocating variant of `os::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63675/ --- (Updated Nov. 14, 2017, 7:06 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63515: Updated some isolators' usage of ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63515/#review190988 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 1:41 a.m.,

Re: Review Request 63678: Improved the signal safety of `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/ --- (Updated Nov. 14, 2017, 7:11 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63801: Windows: Fixed build of Google Test with Visual Studio Preview.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63801/ --- (Updated Nov. 14, 2017, 10:14 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 63798: Added resource provider support for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/#review190974 --- src/slave/slave.cpp Lines 3756-3765 (patched)

Review Request 63804: Added protos for operation reconciliation between master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8199

Re: Review Request 63555: Publish resource provider resources before container launch or update.

> On Nov. 9, 2017, 12:52 p.m., Jan Schlicht wrote: > > src/slave/slave.cpp > > Lines 6816-6822 (patched) > > > > > > So this will try to publish all RP resources of all executor of all > > frameworks? Or am I

Re: Review Request 63801: Windows: Fixed build of Google Test with Visual Studio Preview.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63801/ --- (Updated Nov. 14, 2017, 10:47 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60891/#review190981 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 1:24 a.m.,

Re: Review Request 62143: Added validation for Standalone Container APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62143/#review190982 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 1:27 a.m.,

Re: Review Request 63056: Parameterized test for nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63056/#review190986 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 1:34 a.m.,

Re: Review Request 62145: Implemented Standalone Container API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62145/#review190983 --- Fix it, then Ship it! src/slave/http.cpp Line 2421

Re: Review Request 63781: Updated Docker path for Containerizer::launch interface change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63781/#review190987 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 1:38 a.m.,

Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63677/ --- (Updated Nov. 14, 2017, 7:11 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

> On Nov. 14, 2017, 3:23 p.m., Andrei Budnik wrote: > > 3rdparty/stout/include/stout/os/linux.hpp > > Line 66 (original), 66 (patched) > > > > > > `ErrnoError` is not async-signal-safe as it constructs empty > >

Re: Review Request 63768: Added 'ReconcileOfferOperations' reponse to scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/#review190989 --- A few minor comments. Also please `s/reponse/response/` in the