Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Benjamin Bannier
/error.hpp (line 34) <https://reviews.apache.org/r/39583/#comment161823> This doesn't use any instance data so could probably be either `const`, `static`, or a free function. - Benjamin Bannier On Oct. 23, 2015, 8:57 a.m., Alex Clemmer

Review Request 39590: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
/zookeeper/zookeeper.hpp c799506f4e64d123b148543ff260d5b567263cbd src/zookeeper/zookeeper.cpp c7c89603e2d0f57013c19a418787469958ea2977 Diff: https://reviews.apache.org/r/39590/diff/ Testing --- Thanks, Benjamin Bannier

Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
: https://reviews.apache.org/r/39591/diff/ Testing --- Thanks, Benjamin Bannier

Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
9130595e82c2b824afb70d9e055ac10aa09cbd11 3rdparty/libprocess/src/timeseries.cpp f5bd65a50a822fd6a774d9d2e458906b7029082c Diff: https://reviews.apache.org/r/39592/diff/ Testing --- Thanks, Benjamin Bannier

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
, Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
bcc1fab912410237dfe903d7a36cad9323d625a0 Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
sit: https://reviews.apache.org/r/39007/#review103486 --- On Oct. 22, 2015, 7:50 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
0c515568880aa6b7a65cfe2955eb7132bdfb3baf 3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b Diff: https://reviews.apache.org/r/39007/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103484 --- On Oct. 9, 2015, 2:24 p.m., Benjamin Bannier wrote: > > --- > This is a

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff Diff: https://reviews.apache.org/r/39005/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-27 Thread Benjamin Bannier
487734316e1f626bac0543d453646555ea51b4b9 src/zookeeper/zookeeper.hpp c799506f4e64d123b148543ff260d5b567263cbd src/zookeeper/zookeeper.cpp c7c89603e2d0f57013c19a418787469958ea2977 Diff: https://reviews.apache.org/r/39590/diff/ Testing (updated) --- make check Thanks, Benjamin Bannier

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-25 Thread Benjamin Bannier
c799506f4e64d123b148543ff260d5b567263cbd src/zookeeper/zookeeper.cpp c7c89603e2d0f57013c19a418787469958ea2977 Diff: https://reviews.apache.org/r/39590/diff/ Testing --- Thanks, Benjamin Bannier

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-25 Thread Benjamin Bannier
15, 12:06 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39590/ > --- > > (Up

Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-10-23 Thread Benjamin Bannier
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b Diff: https://reviews.apache.org/r/39594/diff/ Testing --- make check Thanks, Benjamin Bannier

Review Request 39595: Took mtime into account in the fetcher cache.

2015-10-23 Thread Benjamin Bannier
c7518a36f6344841880dbb11bfce603fd2791fc0 src/slave/containerizer/fetcher.cpp e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b Diff: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
e8f8358f3c113b4e21e30cb5e9d6a3d229191484 Diff: https://reviews.apache.org/r/39591/diff/ Testing --- Thanks, Benjamin Bannier

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
c799506f4e64d123b148543ff260d5b567263cbd src/zookeeper/zookeeper.cpp c7c89603e2d0f57013c19a418787469958ea2977 Diff: https://reviews.apache.org/r/39590/diff/ Testing --- Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-23 Thread Benjamin Bannier
/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff Diff: https://reviews.apache.org/r/39005/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39518: Changed write api.

2015-10-23 Thread Benjamin Bannier
che.org/r/39518/#comment161818> Wouldn't this potentially cause data loss if the called `write` function cannot dump everything in the `fd`? - Benjamin Bannier On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote: > > --- > This is a

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review103482 --- On Oct. 22, 2015, 7:52 a.m., Benjamin Bannier wrote: > > -

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-22 Thread Benjamin Bannier
: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier
60f7) to verify that the patch is still recent. Thanks, Benjamin Bannier

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier
/ Testing (updated) --- make check Please use the add-hoc check for C & C++ source files [here](https://gist.github.com/bbannier/02231787b107b71360f7) to verify that the patch is still recent. Thanks, Benjamin Bannier

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier
iles [here](https://gist.github.com/bbannier/02231787b107b71360f7) to verify that the patch is still recent. Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
Diff: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
0b3245105b4c1efae54f0bc34f672290819a6f0b Diff: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 40187: Fixed and formatted JSON examples.

2015-11-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106059 --- Ship it! - Benjamin Bannier On Nov. 11, 2015, 2:16 p.m., Jan

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Benjamin Bannier
ould suggest to stick to `NULL`. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/#review105488 --- On No

Re: Review Request 40252: Small style fixes for tailing backslashes in src/Makefile.am.

2015-11-12 Thread Benjamin Bannier
252/#comment165067> Since you are at it, why not fix this one as well? That said, any of this only aligns when tabs are displayed as exactly eight spaces. - Benjamin Bannier On Nov. 12, 2015, 8:56 p.m., Jie Yu

Re: Review Request 40136: Updated documentation on fetcher cache internals.

2015-11-12 Thread Benjamin Bannier
://reviews.apache.org/r/40136/diff/ Testing --- Built and served with bundled site docker container, % docker build support/site-docker Thanks, Benjamin Bannier

Re: Review Request 39594: [stout]: Extended os::stat::mtime to optionally follow links.

2015-11-13 Thread Benjamin Bannier
semantics. Thanks, Benjamin Bannier

Re: Review Request 39594: [stout]: Extended os::stat::mtime to optionally follow links.

2015-11-13 Thread Benjamin Bannier
s::stat::mtime` so that users can decide what they wanted? - Benjamin ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/#review106236 -

Review Request 40288: Restored original semantics of garbage collect.

2015-11-13 Thread Benjamin Bannier
ac2d0e0153721a66495cd6539b25f5b3cee9d979 Diff: https://reviews.apache.org/r/40288/diff/ Testing --- make check NOTE TO THE COMMITTER: This should be committed together with RR-39594 (first that, then this one) to not change semantics. Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-13 Thread Benjamin Bannier
: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-13 Thread Benjamin Bannier
/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Benjamin Bannier
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961 Diff: https://reviews.apache.org/r/40349/diff/ Testing --- make check under OS X and ubuntu-trusty. Thanks, Benjamin Bannier

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Benjamin Bannier
/40349/diff/ Testing --- make check under OS X and ubuntu-trusty. Thanks, Benjamin Bannier

Re: Review Request 40349: WIP Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Benjamin Bannier
7060a151f8812e9fef654419377991970ab8b961 Diff: https://reviews.apache.org/r/40349/diff/ Testing --- make check under OS X and ubuntu-trusty. Thanks, Benjamin Bannier

Re: Review Request 39991: fetcher should extract from .tar archive

2015-11-16 Thread Benjamin Bannier
add a third test case; then would definitely be the time to got for a parametrized test. - Benjamin Bannier On Nov. 12, 2015, 1:47 a.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

2015-11-16 Thread Benjamin Bannier
h. This disables compiler warnings inside Boost headers since we have no intention of fixing those. - Benjamin Bannier On Nov. 15, 2015, 10:30 a.m., Neil Conway wrote: > > -

Re: Review Request 40327: mesos: Marked Boost as a "system" header.

2015-11-16 Thread Benjamin Bannier
tps://reviews.apache.org/r/40327/#comment165328> I think it would make sense to also update the mesos `CMakeLists.txt`. - Benjamin Bannier On Nov. 15, 2015, 10:31 a.m., Neil Conway wrote: > > --- > This is an automaticall

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-11-12 Thread Benjamin Bannier
d2280c2430db1e051de4d07bf8b04713723fbeb3 Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-12 Thread Benjamin Bannier
/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-11-12 Thread Benjamin Bannier
Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-11-12 Thread Benjamin Bannier
a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 3rdparty/libprocess/src/subprocess.cpp efe0018d0414c4137fd833c153eb262232e712bc Diff: https://reviews.apache.org/r/39007/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-12 Thread Benjamin Bannier
trong enough a word here. Just delete it. The comment is gone after the rewrite. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review106230 -------

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

2015-11-12 Thread Benjamin Bannier
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40136/#review106274 ------- On Nov. 12, 2015, 6:17 p.m., Benjamin Bannier wrote: > > --- > Th

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

2015-11-12 Thread Benjamin Bannier
378693f57627d68caef07b1b1db1b6e143cb962e docs/images/fetch_state.png PRE-CREATION Diff: https://reviews.apache.org/r/40136/diff/ Testing --- Built and served with bundled site docker container, % docker build support/site-docker Thanks, Benjamin Bannier

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

2015-11-12 Thread Benjamin Bannier
://reviews.apache.org/r/40136/diff/ Testing --- Built and served with bundled site docker container, % docker build support/site-docker Thanks, Benjamin Bannier

Re: Review Request 37266: Style checker checking for { on newline

2015-11-17 Thread Benjamin Bannier
eral `::` so it misses non-inline definitions of member functions. - Benjamin Bannier On Nov. 17, 2015, 10:33 a.m., Jose Guilherme Vanz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2015-11-17 Thread Benjamin Bannier
> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 107 > > > > > > Is the enum+switch+unreachable a common pattern in stout? It

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Benjamin Bannier
3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b Diff: https://reviews.apache.org/r/39594/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Benjamin Bannier
/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b Diff: https://reviews.apache.org/r/39594/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b Diff: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
``` Done, also a `const` member fct now. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105587 --- On Nov

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
-------- On Nov. 10, 2015, 1:45 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39595/ >

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Benjamin Bannier
<https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141> > > > > Why not use `nullptr` instead? > > Jan Schlicht wrote: > Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not > there yet. Also there's no mention of it in

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-11-03 Thread Benjamin Bannier
check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-03 Thread Benjamin Bannier
> On Oct. 8, 2015, 9:07 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp, line 54 > > <https://reviews.apache.org/r/39005/diff/2/?file=1093128#file1093128line54> > > > > We have to support CentOS 5 which has glibc

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-03 Thread Benjamin Bannier
://reviews.apache.org/r/39005/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-04 Thread Benjamin Bannier
check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-04 Thread Benjamin Bannier
er size we use "should be big enough" for any conceivable error message. I added a note to the docstring so users are aware of this limitation. In both cases we would receive some string representation of the given `errnum`. I also expanded the commen

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-03 Thread Benjamin Bannier
ps://reviews.apache.org/r/39005/#review104760 --- On Nov. 3, 2015, 10:52 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-05 Thread Benjamin Bannier
o longer checking this? The semantics of that function have changed: instead of requiring the exact same entry (which would now contain also the `mtime`), we now only require the same key which already unique identifies entries. Since `FetcherProcess::Cache::contains` was used on

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-05 Thread Benjamin Bannier
/fetcher.cpp e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b Diff: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-06 Thread Benjamin Bannier
check Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
, you can also bring back the old param > > alignment. > > Benjamin Bannier wrote: > I wanted to enforce internal linkage for the added `SizeAndMtime` which > for types would happen by wrapping them in an anonymous namespace. Having a > type in an anonymous namespace immedia

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
841880dbb11bfce603fd2791fc0 > src/slave/containerizer/fetcher.cpp > e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f > src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b > > Diff: https://reviews.apache.org/r/39595/diff/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Bannier > >

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-06 Thread Benjamin Bannier
) - 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b Diff: https://reviews.apache.org/r/39594/diff/ Testing --- make check Thanks, Benjamin

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
ompare equal we would already not take it into account in case it is not available. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105232 ----

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b Diff: https://reviews.apache.org/r/39595/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-15 Thread Benjamin Bannier
`TODO` (or better ticket) for that. - Benjamin Bannier On Oct. 14, 2015, 4:29 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-15 Thread Benjamin Bannier
single block in the block in face of concurrent `LOG` calls from other threads. - Benjamin Bannier On Oct. 15, 2015, 1:11 p.m., Bernd Mathiske wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
isit: https://reviews.apache.org/r/39008/#review101811 ------- On Oct. 6, 2015, 3:08 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generate

Re: Review Request 39088: Made shell test locale-independent.

2015-10-08 Thread Benjamin Bannier
it really is overwritten. Good catch, fixed now. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101883 ---------

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
cpp bcc1fab912410237dfe903d7a36cad9323d625a0 Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
or.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e Diff: https://reviews.apache.org/r/39005/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
ache.org/r/39005/#review101779 --- On Oct. 8, 2015, 2:29 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
---------- On Oct. 8, 2015, 2:29 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ---

Re: Review Request 39088: Made shell test locale-independent.

2015-10-08 Thread Benjamin Bannier
--- With German locale installed: % LANG=de_DE.UTF-8 make check Thanks, Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
cpp bcc1fab912410237dfe903d7a36cad9323d625a0 Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d Diff: https://reviews.apache.org/r/39007/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-12 Thread Benjamin Bannier
Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-06 Thread Benjamin Bannier
0c515568880aa6b7a65cfe2955eb7132bdfb3baf 3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d Diff: https://reviews.apache.org/r/39007/diff/ Testing (updated) --- make check Thanks, Benjamin Bannier

Review Request 39006: stout: Used thread-safe replacement for strerror.

2015-10-06 Thread Benjamin Bannier
e740d5bc0f0cc5cf8e99b2064c1e39c08282da67 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e Diff: https://reviews.apache.org/r/39006/diff/ Testing (updated) --- make check Thanks, Benjamin Bannier

Review Request 39088: Made shell test locale-independent.

2015-10-07 Thread Benjamin Bannier
- 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e Diff: https://reviews.apache.org/r/39088/diff/ Testing --- With German locale installed: % LANG=de_DE.UTF-8 make check Thanks, Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-09 Thread Benjamin Bannier
Diff: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-09 Thread Benjamin Bannier
.apache.org/r/39005/#review101956 --- On Oct. 9, 2015, 2:24 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-09 Thread Benjamin Bannier
ake check Thanks, Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
: https://reviews.apache.org/r/39008/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-08 Thread Benjamin Bannier
/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d Diff: https://reviews.apache.org/r/39007/diff/ Testing --- make check Thanks, Benjamin Bannier

Review Request 40445: Added linter for license headers in some file types.

2015-11-18 Thread Benjamin Bannier
ca9e9810aca921734be5224e3ef71fe7ff4aa03d support/mesos-license.py PRE-CREATION Diff: https://reviews.apache.org/r/40445/diff/ Testing --- Ran the a whole clean checkout through the linter with only one expected failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a license). Thanks, Benjamin

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-11-18 Thread Benjamin Bannier
checkout with % ./support/mesos-license.py $(find . -type f | grep -v '^./.git') The only expected failure here should be from `3rdparty/libprocess/stout/tests/protobuf_tests.proto` which does have no license at all. Thanks, Benjamin Bannier

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

2015-11-18 Thread Benjamin Bannier
/protobuf_tests.proto` which does have no license at all. Thanks, Benjamin Bannier

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-18 Thread Benjamin Bannier
at all. Thanks, Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-13 Thread Benjamin Bannier
/diff/ Testing --- make check Thanks, Benjamin Bannier

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Benjamin Bannier
/40776/diff/ Testing --- `make check` and verified test does not fail in at least 1000 iterations. Thanks, Benjamin Bannier

Re: Review Request 41077: Fixed the license header in src/linux/ns.hpp.

2015-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41077/#review109310 --- Ship it! Ship It! - Benjamin Bannier On Dec. 8, 2015, 6:26 a.m

  1   2   3   4   5   6   7   8   9   10   >