Re: Review Request 36867: Add labels to FrameworkInfo.

, 2015, 6:25 p.m. PDT, Neil Conway wrote: Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. By Neil Conway. *Updated July 27, 2015, 6:25 p.m.* *Bugs: * MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 *Repository: * mesos Description This is intended to support

Review Request 37445: Fix typos in style guide.

in style guide. Diffs - docs/mesos-c++-style-guide.md 9c1a00c32043fa10038e38bd7cbc561aafcd6ea0 Diff: https://reviews.apache.org/r/37445/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 36867: Add labels to FrameworkInfo.

Thanks, Neil Conway

Re: Review Request 36867: Add labels to FrameworkInfo.

/fault_tolerance_tests.cpp 7b977f5e8195d9f42b21f36eb36fb156471caa20 src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c Diff: https://reviews.apache.org/r/36867/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

g/r/39516/#comment161469> Is this comment still relevant? - Neil Conway On Oct. 21, 2015, 1:19 p.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39569: Added output operator for Executor struct in agent

g/r/39569/#comment161740> Can we fix the leading whitespace? src/slave/slave.cpp (line 2135) <https://reviews.apache.org/r/39569/#comment161741> See above. src/slave/slave.cpp (line 3440) <https://reviews.apache.org/r/39569/#comment161742> See above. - Neil Conway

Re: Review Request 39385: Fixed link conversion regexp in website.

no changes observed. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

-> RECOVERING -> VOTING transition. But playing around with doing that, I think it will take a bit of thought to make sure we're doing it correctly. So I'd like to leave that to a separate review. - Neil Conway On Oct. 29, 2015, 4:50 a.m., Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

hat in some cases, we need to retry coordinator election up to ~70 times (!), because we don't currently use a backoff; that should probably be fixed, per comments above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

eed to retry coordinator election up to ~70 times (!), because we don't currently use a backoff; that should probably be fixed, per comments above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

or/ Isn't "master" accurate, since a non-coordinator might try to pass a promise (e.g., during catchup)? - Neil ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review10387

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

s above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

.apache.org/r/39325/#review103873 --- On Oct. 20, 2015, 8:45 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

(at minimum, to remove "_Coming Soon_" from the notes about ACLs.) - Neil Conway On Nov. 13, 2015, 1:23 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

/launcher.cpp PRE-CREATION src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed src/tests/mesos.cpp 5667e961fe70d15defbb127c174e91376ca9de3d Diff: https://reviews.apache.org/r/39946/diff/ Testing --- Thanks, Neil Conway

Review Request 40326: libprocess: Marked Boost as a "system" header.

/40326/diff/ Testing --- Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10. Note that the cmake build still emits boost-related warnings: I didn't try to fix this, since cmake emits other warnings that autotools suppresses (e.g., no-unused-local-typedefs). Thanks, Neil

Review Request 40327: mesos: Marked Boost as a "system" header.

to fix this, since cmake emits other warnings that autotools suppresses (e.g., no-unused-local-typedefs). Thanks, Neil Conway

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

> On Nov. 2, 2015, 6:44 p.m., Alex Clemmer wrote: > > configure.ac, line 758 > > > > > > Sorry I'm super late to the party. Does it make sense to add these to > > the CMake build system as well? Using #pragma

Review Request 40378: Added link to upgrade guide to documentation page.

with mesos-website-container. Thanks, Neil Conway

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40326/#review106604 --- On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

other warnings that autotools suppresses (e.g., no-unused-local-typedefs). Thanks, Neil Conway

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

eeds fixes for `-Wno-unused-local-typedef` anyway.) - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40326/#review106602 --- On Nov.

Re: Review Request 40327: mesos: Marked Boost as a "system" header.

and OSX 10.10. Note that the cmake build still emits boost-related warnings: I didn't try to fix this, since cmake emits other warnings that autotools suppresses (e.g., no-unused-local-typedefs). Thanks, Neil Conway

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

> On Nov. 16, 2015, 7:55 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/configure.ac, line 211 > > <https://reviews.apache.org/r/40326/diff/1/?file=1125806#file1125806line211> > > > > Should we add this to the CMake files as well? > > Neil Conway

Review Request 40243: Documented "role" field in Resource protobuf message.

Testing --- Thanks, Neil Conway

Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a Diff: https://reviews.apache.org/r/40242/diff/ Testing --- Thanks, Neil Conway

Review Request 40244: Clarified comments in Master::Http::_operation.

https://issues.apache.org/jira/browse/MESOS-2455 Repository: mesos Description --- Clarified comments in Master::Http::_operation. Diffs - src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf Diff: https://reviews.apache.org/r/40244/diff/ Testing --- Thanks, Neil

Review Request 40246: Removed unused "using" statement from test code.

iff: https://reviews.apache.org/r/40246/diff/ Testing --- Thanks, Neil Conway

Review Request 40245: Fixed typos in comments.

src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 Diff: https://reviews.apache.org/r/40245/diff/ Testing --- Thanks, Neil Conway

Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/40247/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 40234: Added descriptions of new Docker-related flags to configuration documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40234/#review106258 --- Also: AWESOME! Thank you for working on docs :) - Neil Conway

Re: Review Request 40234: Added descriptions of new Docker-related flags to configuration documentation.

g/r/40234/#comment165017> I agree we should capitalize "Docker", but if we're going to do this, can we do it consistently, both here and in flags.cpp? - Neil Conway On Nov. 12, 2015, 4:08 p.m., Bern

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106831 --- Ship it! Ship It! - Neil Conway On Nov. 17, 2015, 10:41 a.m

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

eed to retry coordinator election up to ~70 times (!), because we don't currently use a backoff; that should probably be fixed, per comments above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

eed to retry coordinator election up to ~70 times (!), because we don't currently use a backoff. On a more realistic LAN configuration, many fewer retries will likely be needed, but we could also use a backoff instead. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/#review105129 --- Ship it! Ship It! - Neil Conway On Nov. 4, 2015, 6:50 p.m

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105128 --- Ship it! Ship It! - Neil Conway On Nov. 4, 2015, 8:24 p.m

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/#review105181 --- On Nov. 5, 2015, 12:56 a.m., Neil Conway wrote: > > --- > This is an a

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

/containerizer/launcher.cpp PRE-CREATION src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5 Diff: https://reviews.apache.org/r/39946/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39947: Refactored mock allocator into a separate header file.

://reviews.apache.org/r/39947/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39908: Added a section to Upgrades doc

908/#comment163307> AFAIK this isn't Java-specific. - Neil Conway On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

n eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 7:25 p.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 woul

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

bprocess/src/process.cpp (line 751) <https://reviews.apache.org/r/39949/#comment163523> process::initialize. 3rdparty/libprocess/src/process.cpp (line 759) <https://reviews.apache.org/r/39949/#comment163521> Can you clarify what "the first ones" means here?

Re: Review Request 39886: Added documentation about roles.

docs/roles.md PRE-CREATION Diff: https://reviews.apache.org/r/39886/diff/ Testing --- Previewed with the support/site Docker container. Thanks, Neil Conway

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

923) <https://reviews.apache.org/r/39988/#comment164173> Probably don't want this whitespace? src/tests/reservation_endpoints_tests.cpp (line 1001) <https://reviews.apache.org/r/39988/#comment164174> Whitespace. - Neil Conway On Nov. 6, 2015, 11:

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

(line 1323) <https://reviews.apache.org/r/39989/#comment164170> Grammar. src/tests/reservation_tests.cpp (line 1406) <https://reviews.apache.org/r/39989/#comment164171> Grammar. - Neil Conway On Nov. 6, 2015, 11:58 p.m., Gre

Re: Review Request 39886: Added documentation about roles.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104884 --- On Nov. 3, 2015, 7:51 p.m., Neil Conway wrote: > > --- > This is a

Re: Review Request 39886: Added documentation about roles.

69bde760ece59c68b04a903026b5903e2091ceb0 docs/roles.md PRE-CREATION Diff: https://reviews.apache.org/r/39886/diff/ Testing --- Previewed with the support/site Docker container. Thanks, Neil Conway

Re: Review Request 39886: Added documentation about roles.

eviews.apache.org/r/39886/#review104849 ------- On Nov. 3, 2015, 7:51 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16> > > > > AFAIK this isn't Java-specific. > > Isabel Jimenez wrote: > This will mostly

Review Request 39947: Refactored mock allocator into a separate header file.

/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2 src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c Diff: https://reviews.apache.org/r/39947/diff/ Testing --- Thanks, Neil Conway

Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

f731ac3284a5793b6bf510d3a5b742cbe0938217 src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5 Diff: https://reviews.apache.org/r/39946/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39597: Add Newbie guide.

ink. Same changes also needed below in a few places. docs/NewbieQuickStart.md (line 118) <https://reviews.apache.org/r/39597/#comment163037> This could be cleaned up: no need to mention JIRA URL twice. - Neil Conway On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

/upgrades.md seems a good idea, at the very least. Are we pretty confident that no one else is looking at this data, and/or we're happy to break anyone that is? - Neil Conway On Nov. 2, 2015, 8:21 p.m., Joseph Wu wrote

Review Request 39886: Added documentation about roles.

. Thanks, Neil Conway

Re: Review Request 39886: Added documentation about roles.

. -- but this is a start. - Neil Conway On Nov. 3, 2015, 1:51 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 35711: Disallow special characters in role name.

trivial member functions/constructors define in the .cpp, whereas others are defined in the header file? src/tests/roles_tests.cpp (line 29) <https://reviews.apache.org/r/35711/#comment163892> This can be rem

Re: Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/#review105496 --- AFAIK this should be marked as submitted. - Neil Conway On Oct

Review Request 40029: Fixed hyphenation, typos in configuration docs and command-line flags.

c799506f4e64d123b148543ff260d5b567263cbd Diff: https://reviews.apache.org/r/40029/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39886: Added documentation about roles.

://reviews.apache.org/r/39886/diff/ Testing --- Previewed with the support/site Docker container. Thanks, Neil Conway

Re: Review Request 39886: Added documentation about roles.

--- Previewed with the support/site Docker container. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

nk #1 should be fine, and is preferrable to the complexity of having replicas track the coordinator's version. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102710 --- On Oct. 15, 2015, 1:21 a.m., Ne

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

> docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >

Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on file descriptors.

/fcntl.hpp (line 102) <https://reviews.apache.org/r/39347/#comment160762> Needs a period (or just remove the comment). - Neil Conway On Oct. 15, 2015, 6:02 p.m., James Peach wrote: > > --- > This is an automatically generated e

Re: Review Request 31625: Fixed broken link in framework development guide

is that the markdown link conversion regexp is not correct. See https://reviews.apache.org/r/39385/ for a fix. - Neil Conway On March 2, 2015, 3:36 p.m., Palak Choudhary wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

eviews.apache.org/r/39330/#review103028 --- On Oct. 14, 2015, 10:29 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

://reviews.apache.org/r/39429/diff/ Testing --- Thanks, Neil Conway

Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- Thanks, Neil Conway

Re: Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

(and rebasing) caused post-reviews to create a new review set -- sorry for the inconvenience. New reviews are here: https://reviews.apache.org/r/39428/ https://reviews.apache.org/r/39429/ I'll mark this review discarded. - Neil Conway On Oct. 14, 2015, 10:29 p.m., Neil Conway wrote

Review Request 39428: Fixed typo in comment, minor style fixes.

e5277de5b5bdea4a44606cda7fbf69a559aeebbe Diff: https://reviews.apache.org/r/39428/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

://reviews.apache.org/r/39384/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

--- Thanks, Neil Conway

Review Request 39323: Fixed syntax error in sed usage on OSX.

and then immediately delete it. Diffs - src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d Diff: https://reviews.apache.org/r/39323/diff/ Testing --- Successfully built on OSX. Thanks, Neil Conway

Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

responses is seen. Note that in some cases, we need to retry coordinator election up to ~70 times (!), because we don't currently use a backoff; that should probably be fixed, per comments above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

, we now create a backup file and then immediately delete it. Diffs - src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d Diff: https://reviews.apache.org/r/39323/diff/ Testing --- Successfully built on OSX. Thanks, Neil Conway

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

a backup file; hence, we know create a backup file and then immediately delete it. Diffs (updated) - src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d Diff: https://reviews.apache.org/r/39323/diff/ Testing --- Successfully built on OSX. Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

ant point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

/ Testing --- make check Thanks, Neil Conway

Review Request 39104: Added source address to logging when we receive replicated log events.

osition 18 from @0.0.0.0:0 Thanks, Neil Conway

Re: Review Request 39102: Added documentation for JSON resources.

;https://reviews.apache.org/r/39102/#comment159309> Add link. - Neil Conway On Oct. 7, 2015, 7:19 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

------- On Oct. 7, 2015, 9:41 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39104/ > --

Review Request 39385: Fixed link conversion regexp in website.

e6e3547b4e550be41c8c Diff: https://reviews.apache.org/r/39385/diff/ Testing ------- Thanks, Neil Conway

Re: Review Request 39385: Fixed link conversion regexp in website.

--- site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c Diff: https://reviews.apache.org/r/39385/diff/ Testing (updated) --- Tested using "http://rubular.com/; -- didn't actually test on mesos-website-container, since it doesn't use the site code from Git just yet. Thanks, Neil Conway

Re: Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

tps://reviews.apache.org/r/39455/#comment161122> Should we use EXPECT_TRUE / ASSERT_TRUE instead? 3rdparty/libprocess/README.md (line 116) <https://reviews.apache.org/r/39455/#comment161124> Link to dispatch? - Neil Co

Review Request 39446: Fixed typos in libprocess docs.

--- Fixed typos in libprocess docs. Diffs - 3rdparty/libprocess/README.md 79304af8ff2bcf29ed0704acadb17b38c09596c4 Diff: https://reviews.apache.org/r/39446/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39444: Fixed typo in docs.

Remoortere. Bugs: MESOS-3757 https://issues.apache.org/jira/browse/MESOS-3757 Repository: mesos Description --- MESOS-3757. Diffs - docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 Diff: https://reviews.apache.org/r/39444/diff/ Testing --- Thanks, Neil

Review Request 39444: Fixed typo in docs.

Description --- MESOS-3757. Diffs - docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 Diff: https://reviews.apache.org/r/39444/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/39459/#review103179 ------- On Oct. 19, 2015, 11:06 p.m., Neil Conway wrote: > > --- > This is an a

Review Request 39463: Fixed typos in log messages and comments in replicated log code.

: https://reviews.apache.org/r/39463/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

p to ~70 times (!), because we don't currently use a backoff; that should probably be fixed, per comments above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

iews.apache.org/r/39463/#review103293 --- On Oct. 19, 2015, 11:25 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

------ On Oct. 20, 2015, 8:18 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39429/ > ---

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

://reviews.apache.org/r/39429/diff/ Testing --- Thanks, Neil Conway

Review Request 39497: Fixed quotation of interpolated variables in log messages.

port_mapping.cpp e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab Diff: https://reviews.apache.org/r/39497/diff/ Testing --- make check, visual inspection. Thanks, Neil Conway

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

uild); we can consider further cleanup separately. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102718 -----

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

above. But the important point is that election eventually succeeds and we don't hang. Thanks, Neil Conway

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

o instruct sed not to make a backup file; hence, we now create a backup file and then immediately delete it. Diffs (updated) - src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d Diff: https://reviews.apache.org/r/39323/diff/ Testing --- Successfully built on OSX. Thanks, Neil Conway

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

39056/#comment159131> I think the comment here should explain why using a double value is relevant. src/tests/reservation_tests.cpp (line 245) <https://reviews.apache.org/r/39056/#comment159128> Whitespace/capitalization. - Ne

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

) <https://reviews.apache.org/r/39056/#comment159145> "a Reserved" - Neil Conway On Oct. 6, 2015, 9:33 p.m., Mandeep Chadha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

  1   2   3   4   5   6   7   8   9   10   >