that restriction now?
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---
On Feb. 16, 20
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---
On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
s://reviews.apache.org/r/43015/#review119340
-------
On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail.
;
> > Alternatively, we can kill updatePersistentVolumes and inline it into
> > mountPersistentVolumes.
>
> Timothy Chen wrote:
> I think I simply forgot about it, let me add them.
Actually I'll just drop a TODO since we don't support update as you mentioned.
- Timothy
---
d a new state
so we're now more explicit.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
------
ated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
-------
On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
>
> ---
> This is an automaticall
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
8541a9a3d2f40cd6e78ff8fba474da214017937a
Diff: https://reviews.apache.org/r/43790/diff/
Testing
---
make check
Thanks,
Timothy Chen
/docker_containerizer_tests.cpp
8541a9a3d2f40cd6e78ff8fba474da214017937a
Diff: https://reviews.apache.org/r/43790/diff/
Testing
---
make check
Thanks,
Timothy Chen
354)
<https://reviews.apache.org/r/43854/#comment181700>
Do we have tests to test the docker runtime isolator?
- Timothy Chen
On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review120516
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 20, 2016, 2:12 p.m
/docker_containerizer_tests.cpp (line 1841)
<https://reviews.apache.org/r/43963/#comment182103>
Can you add the mesos ticket in the comments as well? it has good
information about this.
- Timothy Chen
On Feb. 25, 2016, 2 a.m., Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/#review121554
---
Ship it!
Ship It!
- Timothy Chen
On March 1, 2016, 11:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44247/#review121564
---
Ship it!
Ship It!
- Timothy Chen
On March 2, 2016, 1:44 a.m
changing how to use
persistent volumes I no longer need them.
- Timothy Chen
On March 2, 2016, 1:44 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
360/#comment183834>
Seems odd to add this in this commit?
- Timothy Chen
On March 4, 2016, 1:09 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
, so if you
can't or don't reply we will create a new patch based on this.
- Timothy Chen
On Feb. 17, 2016, 10:52 p.m., Travis Hegner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
out a proper heading.
- Timothy Chen
On March 5, 2016, 2:20 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
&g
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
&g
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
&g
/
Testing
---
make check
Thanks,
Timothy Chen
Description
---
Fixed parsing network ip address with docker.
Diffs
-
src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
Diff: https://reviews.apache.org/r/44531/diff/
Testing
---
make check
Thanks,
Timothy Chen
/
Testing
---
make check
Thanks,
Timothy Chen
/registry_puller.cpp (line 173)
<https://reviews.apache.org/r/44672/#comment185153>
From the docker code base they're checking against docker.io, not
regsitry-1.docker.io, as I assume registry-1 is not a permanent name.
I would suggest we don't hard code that as well.
- Timothy Chen
O
https://reviews.apache.org/r/44531/#review123025
-------
On March 8, 2016, 10:54 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-m
eep it all consistent.
- Timothy Chen
On March 14, 2016, 5:51 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44708/#review123534
---
Ship it!
Ship It!
- Timothy Chen
On March 14, 2016, 5:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44944/#review123979
---
Ship it!
Ship It!
- Timothy Chen
On March 17, 2016, 1:50
irectory << "'
src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 226)
<https://reviews.apache.org/r/44948/#comment186442>
ditto
- Timothy Chen
On March 17, 2016, 3:38 a.m., James Peach wrote:
>
>
g/r/44660/#comment186488>
This should fit 80 char width?
- Timothy Chen
On March 15, 2016, 4:04 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45126/#review124681
---
Ship it!
Ship It!
- Timothy Chen
On March 21, 2016, 8:31
207)
<https://reviews.apache.org/r/45186/#comment188079>
We should use the path::absolute method here
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 219)
<https://reviews.apache.org/r/45186/#comment188080>
Also log when we cannot find it.
- Timothy Che
g/r/45185/#comment188081>
I think we should also mention this only applies when image provisioner is
enabled and used.
- Timothy Chen
On March 23, 2016, 12:20 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45556/#review126478
---
Ship it!
Ship It!
- Timothy Chen
On March 31, 2016, 6:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review126479
---
Ship it!
Ship It!
- Timothy Chen
On March 31, 2016, 6:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45557/#review126480
---
Ship it!
Ship It!
- Timothy Chen
On March 31, 2016, 6:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45453/#review126499
---
Ship it!
Ship It!
- Timothy Chen
On March 29, 2016, 10:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45707/#review126954
---
Ship it!
Ship It!
- Timothy Chen
On April 4, 2016, 9:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45454/#review127119
---
Ship it!
Ship It!
- Timothy Chen
On March 29, 2016, 10:44
/docker_containerizer_tests.cpp (line 1381)
<https://reviews.apache.org/r/45455/#comment190261>
I think instead of just checking the previous inspect, can you make sure
that the container is actually stopped by using exists?
- Timothy Chen
On March 29, 2016, 10:44 p.m., Anand Mazumdar
g/r/45594/#comment190360>
Can you probably elaborate a bit more why a docker config file
configuration is needed?
I know it's most likely for pulling private registry docker files, but not
quite obvious just by reading the help text.
- Timothy Chen
On April 5, 2016, 7:21 p.
org/r/36816/#comment192761>
What other schemes are we looking to support besides http or not? What is
the intention of making it a string instead of bool as before?
- Timothy Chen
On April 17, 2016, 9:14 a.m., haosdent huang
>
> (Updated April 17, 2016, 9:14 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Michael Park, and
> Timothy Chen.
>
>
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
>
>
> Re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46142/#review129544
---
Ship it!
Ship It!
- Timothy Chen
On April 19, 2016, 12:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33647/#review81905
---
Ship it!
Ship It!
- Timothy Chen
On April 28, 2015, 11:48 p.m
5ec55
src/slave/containerizer/docker.cpp f9fc89a
src/slave/flags.hpp d3b1ce1
src/slave/flags.cpp d0932b0
src/tests/docker_containerizer_tests.cpp c9d66b3
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review82287
-------
On May 1, 2015, 9:43 p.m., Timothy Chen wrote:
>
> --
make check
Thanks,
Timothy Chen
wrote:
> Regarding the second problem, IMO, we should include a reason field in
> Termination (https://issues.apache.org/jira/browse/MESOS-2035) and let
> sendExecutorTerminatedStatusUpdate to propagate the termination reason to the
> scheduler.
>
> Timothy Chen wrote:
> Reason field sounds
wrote:
> Regarding the second problem, IMO, we should include a reason field in
> Termination (https://issues.apache.org/jira/browse/MESOS-2035) and let
> sendExecutorTerminatedStatusUpdate to propagate the termination reason to the
> scheduler.
>
> Timothy Chen wrote:
> Reason field sounds
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review82830
---
Are you still planning to merge this?
- Timothy Chen
On Feb. 4
We shouldn't need to destroy if none of the containerizers return true.
- Timothy Chen
On May 7, 2015, 4:17 p.m., Jay Buffington wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
-------
On May 2, 2015, 8:22 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> --
difference between static reservation is the principal here, are
you going to cover that?
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment133926>
What happens if you try to unreserve a reservation that is being used right
now?
- Timothy Chen
On May 8, 2015, 6:57
make check
Thanks,
Timothy Chen
sually prefix the namespace.
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/33249/#comment134015>
Remove the extra two spaces.
- Timothy Chen
On May 9, 2015, 2:42 a.m., Jay Buffington wrote:
>
> -
7;t be able to get the error
message from it?
- Timothy Chen
On May 11, 2015, 5:10 p.m., Jay Buffington wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
g/r/33249/#comment134171>
We don't enqueue destroy anymore, let's fix this comment.
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/33249/#comment134173>
I don't really understand this comment? And if you simply pause the clock
your await won't work
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33249/#review83308
---
Ship it!
Ship It!
- Timothy Chen
On May 11, 2015, 10:06 p.m
comment.
- Timothy Chen
On May 11, 2015, 10:06 p.m., Jay Buffington wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On May 11, 2015, 11:07 p.m., Timothy Chen wrote:
> > Thanks Jay the changes looks reasonable to me, will wait for Jie to comment.
>
> Jay Buffington wrote:
> Great, thanks! When you commit can you add the three separate commits
> that are here:
> https://github.
198line175>
> >
> > We should generally avoid bool args, because it is hard to see at the
> > call site what they mean.
> >
> > Suggestions:
> > - Use an enum.
> > - Keep the exists() and running() methods, factor out what
Wouldn't you want to switch on an enum so when new enums are added you can
get an warning?
- Timothy Chen
On May 12, 2015, 6:48 a.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review83497
---
Ship it!
Ship It!
- Timothy Chen
On May 12, 2015, 9:23 p.m
134539>
I think overriding __address__ static is dangerous, since we use this
variable in other places for other purposes, such as checking if we are
communicating to a remote address, etc.
I suggest we create a local address struct just for binding for listening
to public traffic.
rs/appc/hash.hpp
<https://reviews.apache.org/r/34138/#comment134559>
WSTRINGIFY to print the exit code?
- Timothy Chen
On May 13, 2015, 12:47 a.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e
r/isolators/filesystem/linux.cpp
<https://reviews.apache.org/r/34135/#comment134569>
ditto
src/slave/containerizer/isolators/filesystem/linux.cpp
<https://reviews.apache.org/r/34135/#comment134570>
Log the umount error?
src/slave/containerizer/isolators/filesystem/linux.cpp
o deprecate and reintroduce new ones
like we did the in past.
- Timothy Chen
On May 13, 2015, 12:47 a.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
le to support
multiple image provisioners in mesos containerizer in the future, so perhaps at
least leave a comment that we need to change this in the future.
src/slave/containerizer/provisioner.hpp
<https://reviews.apache.org/r/34137/#comment134888>
What would recover do?
- Tim
make check
Thanks,
Timothy Chen
ems like appc so
far is the only one that has a configurable discvoery mechanism and local dir
- Timothy Chen
On May 13, 2015, 12:47 a.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
g/r/29889/#comment135013>
change container to containerName
- Timothy Chen
On May 14, 2015, 9:39 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/34310/#comment135147>
What if the same set of resources contains both revocable and non-revocable
resources?
- Timothy Chen
On May 16, 2015, 1:14 a.m., Ian Downes wrote:
>
> ---
> This is an automati
/stout/os.hpp
<https://reviews.apache.org/r/34319/#comment135177>
Please fix the comment as we no longer have expected.
- Timothy Chen
On May 17, 2015, 4:51 a.m., Greg Mann wrote:
>
> ---
> This is an automatically gener
> On May 16, 2015, 4:46 a.m., Timothy Chen wrote:
> > src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 345
> > <https://reviews.apache.org/r/34310/diff/1/?file=961963#file961963line345>
> >
> > What if the same set of resources contains both
/include/stout/os.hpp
<https://reviews.apache.org/r/34319/#comment135863>
I don't think we neeed to change this.
- Timothy Chen
On May 17, 2015, 1:40 p.m., Greg Mann wrote:
>
> ---
> This is an automatically g
_libprocess.cpp
<https://reviews.apache.org/r/34317/#comment135869>
ditto
src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/34317/#comment135868>
ditto
- Timothy Chen
On May 17
tps://reviews.apache.org/r/34319/#comment135871>
Btw after looking at your other patches, I realize we don't really need
hasenv anymore right? And I see you've been replacing hasenv with getenv, I
think why not just remove hasenv all together?
- Timothy Chen
On May 17, 2015, 1:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34318/#review84555
---
Ship it!
Ship It!
- Timothy Chen
On May 17, 2015, 3:21 p.m
317/#comment135872>
optionally you can avoid the extra check by calling
os::getenv("PATH").get("")
- Timothy Chen
On May 17, 2015, 4:54 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generat
in cpp files to avoid process:: and
std:: everywhere, just a nit.
src/slave/containerizer/provisioners/appc/bind_backend.hpp
<https://reviews.apache.org/r/34427/#comment136122>
Should we make "rootfs" a constant somewhere?
- Timothy Chen
On May 19, 2015,
s.cpp 5520c58
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
s.cpp 5520c58
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
her one is not and that makes me wonder if maybe
> > this code path isn't being tested?
No this actually works if I just pass the flags straight without slicing, but
in the other path where I originally store the flags in a
Option and then pass that into subprocess actually gives me
b
o want
to use the promise associate to handle both cases. I'll leave a comment.
- Timothy Chen
On May 23, 2015, 6:14 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
s.cpp 5520c58
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
> On May 24, 2015, 6:07 p.m., Timothy Chen wrote:
> > src/slave/containerizer/docker.cpp, lines 845-848
> > <https://reviews.apache.org/r/29889/diff/13/?file=970849#file970849line845>
> >
> > Ah, I realize why now I want a promise.
> > So the sem
:
https://reviews.apache.org/r/29889/#review81873
-------
On May 24, 2015, 6:26 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
>
s.cpp 5520c58
Diff: https://reviews.apache.org/r/29889/diff/
Testing
---
make check
Thanks,
Timothy Chen
075c6b5
src/tests/docker_containerizer_tests.cpp 7524803
Diff: https://reviews.apache.org/r/34654/diff/
Testing (updated)
---
make check
Thanks,
Timothy Chen
/docker_containerizer_tests.cpp 7524803
Diff: https://reviews.apache.org/r/34654/diff/
Testing
---
make check
Thanks,
Timothy Chen
che.org/r/34140/#comment134949>
Check exists first?
src/slave/containerizer/provisioners/appc/store.cpp
<https://reviews.apache.org/r/34140/#comment134950>
Why not use os::rmdir?
- Timothy Chen
On May 26, 2015, 6:25 p.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/#review85564
---
Ship it!
Ship It!
- Timothy Chen
On May 13, 2015, 12:44 a.m
too. I tend to want to stay with whatever that docker client outputs
since we no longer control the format.
I think I'll follow what you said, but hold on to a JSON::Array and stringify
it when we need a string representation.
- Timothy
------
tps://reviews.apache.org/r/34135/#comment138275>
actually I'm wrong, I was reading the old style guide. The newest style
guide we do put a space, ignore my earler comment.
- Timothy Chen
On May 13, 2015, 12:47 a.m., Ian D
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review86294
---
Ship it!
Ship It!
- Timothy Chen
On June 1, 2015, 9:48 p.m
to the
MesosContainerizer instead of mechanisms.
- Timothy Chen
On May 21, 2015, 8:45 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
1 - 100 of 828 matches
Mail list logo
