Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132126123
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1446,21 +1457,21 @@ def all_of_(xs):
if isinstance(to_replace, (float, int, long, basestring)):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132125663
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1446,21 +1457,21 @@ def all_of_(xs):
if isinstance(to_replace, (float, int, long, basestri
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132115201
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1446,21 +1457,21 @@ def all_of_(xs):
if isinstance(to_replace, (float, int, long, basestring)):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132115069
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1446,21 +1457,21 @@ def all_of_(xs):
if isinstance(to_replace, (float, int, long, basestring)):
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132104328
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -261,5 +261,37 @@ class DataFrameNaFunctionsSuite extends Q
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132104291
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -261,5 +261,37 @@ class DataFrameNaFunctionsSuite extends Q
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r132103945
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -261,5 +261,37 @@ class DataFrameNaFunctionsSuite extends Q
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131830360
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1373,8 +1373,8 @@ def replace(self, to_replace, value=None,
subset=None):
Value to be repl
Github user bravo-zhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131817518
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -366,11 +370,15 @@ final class DataFrameNaFunctions private[sql
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131815429
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
@@ -145,8 +145,8 @@ class DataTypeSuite extends SparkFunSuite {
Github user bravo-zhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131814746
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -314,6 +316,7 @@ final class DataFrameNaFunctions private[sql](
Github user bravo-zhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131814622
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
@@ -145,8 +145,8 @@ class DataTypeSuite extends SparkFunSuite {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131756595
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null|
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131731670
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -366,11 +370,15 @@ final class DataFrameNaFunctions private[sql
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131578382
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null| null|
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131572498
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131571005
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null| null|
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131570273
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -261,5 +261,18 @@ class DataFrameNaFunctionsSuite extends Q
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131570031
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -314,6 +316,7 @@ final class DataFrameNaFunctions private[sql](d
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131569954
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -366,11 +370,15 @@ final class DataFrameNaFunctions private[sql]
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131569819
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
@@ -145,8 +145,8 @@ class DataTypeSuite extends SparkFunSuite {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131569456
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131569039
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null| null|
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131568706
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null|
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131568383
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131567901
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None,
subset=None):
|null| null| null|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131567720
--- Diff: python/pyspark/sql/tests.py ---
@@ -1964,6 +1964,16 @@ def test_replace(self):
.replace(False, True).first())
self.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131566016
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -261,5 +261,18 @@ class DataFrameNaFunctionsSuite extends Query
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131559076
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1446,7 +1457,7 @@ def all_of_(xs):
if isinstance(to_replace, (float, int, long, basestring
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131559178
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1460,7 +1471,8 @@ def all_of_(xs):
subset = [subset]
# Verify we we
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131535416
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1428,9 +1438,9 @@ def all_of_(xs):
"to_replace should be a float, int, long, strin
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131535534
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -366,11 +370,15 @@ final class DataFrameNaFunctions private[sql
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131535507
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -248,16 +248,16 @@ class DataFrameNaFunctionsSuite extends
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131208895
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1423,8 +1434,9 @@ def all_of_(xs):
subset = [subset]
# Verify we were
GitHub user bravo-zhang opened a pull request:
https://github.com/apache/spark/pull/18820
[SPARK-14932][SQL] Allow DataFrame.replace() to replace values with None
## What changes were proposed in this pull request?
Allow DataFrame.replace() to replace with None/null values.
36 matches
Mail list logo
