Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 6: Verified+1
Verified with unit tests.
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 6: Code-Review+2
Lets make some progress.
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Explicit run semantics for QemuImgOperation
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
*
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 237: """
Line
Arik Hadas has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Expose API for qemuimg map
..
qemuimg: Expose API for qemuimg map
Change-Id: I54d6c936239d3dcc7a3d236dbaab0a93501ada8c
Signed-off-by: Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 6: Verified+1
Tests pass, so this must verified.
--
To view, visit https://gerrit.ovirt.org/65112
To
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65112
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(1 comment)
Very partial review, will look at it again next week.
Irit Goihman has posted comments on this change.
Change subject: tests: Remove cPopenTests.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65407
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65404
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 7:
Verification:
EL7 guest with guest agent supporting the messages:
When VM gets killed on
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py
File
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/64991
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py
File
Francesco Romani has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65404
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: automation: Create coverage report sooner
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65414
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 2: Code-Review+1
good idea, I like this.
--
To view, visit https://gerrit.ovirt.org/65403
To
Martin Polednik has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64243
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: Remove cPopenTests.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65407
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 5:
(7 comments)
https://gerrit.ovirt.org/#/c/65112/5/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 459:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9: Code-Review+2
*Really* nice improvements. I like this.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64991
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2: -Code-Review
--
To view, visit https://gerrit.ovirt.org/65182
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65417
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 1:
Looks good, need to make pep8 happy.
./tests/vmTests.py:636:80: E501 line too long (81 > 79 characters)
Francesco Romani has posted comments on this change.
Change subject: static: move man under static
..
Patch Set 5: Code-Review+2
same answer as per parent patch, no reason to hold +2
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 6: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/62537/6/static/Makefile.am
File
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 20:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 35:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 53:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 33:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
*
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 46:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 19:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: WIP: docs: add tutorial
..
Patch Set 2:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 25:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 23:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File tests/utilsTests.py:
Line
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py
File tests/utilsTests.py:
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG
Commit Message:
Line 14: job
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG
Commit Message:
Line 14: job
Francesco Romani has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 44:
> The code is somewhat fine considering the TODOs, but question remains: if I
> install
Nir Soffer has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 24:
(3 comments)
Nice!
https://gerrit.ovirt.org/#/c/64373/24/tests/storage_sdm_copy_data_test.py
File
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(9 comments)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py
File
Edward Haas has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 2:
What do you mean it is not relevant?
We need it installed once for py2 and once for py3 so tests will
gerrit-hooks has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch:
Nir Soffer has posted comments on this change.
Change subject: hsm:Use sd compat instead of qemu conf compat.
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/64951/10/tests/storage_hsm_test.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File tests/utilsTests.py:
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65308/3/tests/storagetestlib_test.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 7: Code-Review+1
Maybe _shutdownLock is no longer necessary?
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: net test: fix ovs_test:test_dry_run
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65058
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG
Commit Message:
Line 14: job
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 5:
(7 comments)
Very nice!
https://gerrit.ovirt.org/#/c/65112/5/tests/qemuimg_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 3:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: un-nest kernel version gathering function
..
osinfo: un-nest kernel version gathering function
Previous function, kernelDict, had unclear
gerrit-hooks has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 5:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: drop package buildtime
..
osinfo: drop package buildtime
Buildtime of host packages was never used and only causes us problems
w/ parsing
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 5: Code-Review+2
copying dropped scores, and raising.
--
To view, visit https://gerrit.ovirt.org/65008
To
gerrit-hooks has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: py3: make gluster_cli_tests pass
..
py3: make gluster_cli_tests pass
Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24
Signed-off-by: Dan
Nir Soffer has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 8:
Edward, this works with python 3 as you can see in the jenkins and travis runs.
But in python 3 run, we are using
Nir Soffer has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 2:
Edward, flake8 works on both python 2 and 3, but this is not relevant to our
tests.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 9:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 7:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 6:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 6:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 7:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for
Nir Soffer has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/65326/5//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-10-13
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG
Commit Message:
Line 14: job
Francesco Romani has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 23:
(6 comments)
https://gerrit.ovirt.org/#/c/60481/23/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
PS23, Line
Francesco Romani has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64243/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG
Commit Message:
Line 14: job
Nir Soffer has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/65323/4//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Ala Hino has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/65112/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 497:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for branch:
Piotr Kliczewski has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File tests/utilsTests.py:
Line
Nir Soffer has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65328/6/tests/utilsTests.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65327/6/tests/utilsTests.py
File tests/utilsTests.py:
Martin Polednik has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65379/1/lib/vdsm/osinfo.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File
Martin Polednik has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit
1 - 100 of 132 matches
Mail list logo