[webstack-discuss] [sfwnv-discuss] Ruby File.readable doesn't work with ACL

2010-01-26 Thread Amanda Waite
On 26/01/2010 17:04, Henry Jen wrote: >> Ruby seems to prefer to check access rights based on >> effective uid where >> possible and not on the actual uid and some platforms >> provide a system >> call to facilitate this. OpenSolaris doesn't so the >> fallback is to >> perform manual checks using t

[webstack-discuss] [sfwnv-discuss] Ruby File.readable doesn't work with ACL

2010-01-26 Thread Amanda Waite
'test' > => false > irb(main):002:0> File.executable? 'test' > => false > irb(main):003:0> quit > > Cheers, > Henry > > >> Hi Henry, >> >> Before I look into it can you give me details of your >> set

[webstack-discuss] Code Review request for mysql-5.1.37 Upgrade(CR 6857014)

2009-12-16 Thread Amanda Waite
On 16/12/2009 12:11, sunanda menon wrote: > Amanda Waite wrote: >> On 16/12/2009 11:22, sunanda menon wrote: >>> Amanda Waite wrote: >>>> Looks ok but with a few comments: >>>> >>>> usr/src/cmd/mysql-5-1/METADATA >>>> >>>&

[webstack-discuss] Code Review request for mysql-5.1.37 Upgrade(CR 6857014)

2009-12-16 Thread Amanda Waite
On 16/12/2009 11:53, sunanda menon wrote: > usr/src/cmd/mysql-5-1/Makefile.sfw - Why all of the touching of files and the sleep statements? It's hard to see what this achieves aside from adding 20-odd seconds to the build time. >>> >>> >>> Since we are patching the m

[webstack-discuss] Code Review request for mysql-5.1.37 Upgrade(CR 6857014)

2009-12-16 Thread Amanda Waite
On 16/12/2009 11:22, sunanda menon wrote: > Amanda Waite wrote: >> Looks ok but with a few comments: >> >> usr/src/cmd/mysql-5-1/METADATA >> >> - You might want to look at Norm's update to the METADATA guidelines >> at http://wikis.sun.com/display/S

[webstack-discuss] Code Review request for mysql-5.1.37 Upgrade(CR 6857014)

2009-12-16 Thread Amanda Waite
Looks ok but with a few comments: usr/src/cmd/mysql-5-1/METADATA - You might want to look at Norm's update to the METADATA guidelines at http://wikis.sun.com/display/SFWNotes/METADATA They seem to be using a single letter in the Support field now. usr/src/cmd/mysql-5-1/Makefile.sfw - Why all

[webstack-discuss] information about mediawiki porting

2009-12-15 Thread Amanda waite
Zdenek Macura wrote: > Amanda Waite wrote: >> On 14/12/2009 16:51, Neal Pollack wrote: >>> On 12/13/09 07:55 PM, Neal Pollack wrote: >>>> Zdenek Macura wrote: >>>>> >>>>> Dear webstack team members, >>>>> >>>>

[webstack-discuss] information about mediawiki porting

2009-12-14 Thread Amanda Waite
On 14/12/2009 16:51, Neal Pollack wrote: > On 12/13/09 07:55 PM, Neal Pollack wrote: >> Zdenek Macura wrote: >>> >>> Dear webstack team members, >>> >>> I would like to inform that I'm going to port mediawiki package to >>> the release repo through SFW consolidation. >>> The reason for it is that

[webstack-discuss] Code review request for CR6902877 & 6818295

2009-12-14 Thread Amanda Waite
On 11/12/2009 10:30, sunanda menon wrote: > Hi, > > Please review the Code changes for the following bugs at > http://cr.opensolaris.org/~sunandam/6818295/. > > 6902877 [nvb127] subselect test generates crash of the server. > 6818295 [nvb110] Mysql server core dump when running tests > 'execution

[webstack-discuss] [sfwnv-discuss] Code review for Ruby patch level update (CR-6871383)

2009-11-18 Thread Amanda Waite
Thanks Paul and Jeff. I really appreciate the reviews. Amanda Jeff Trawick wrote: > Amanda Waite wrote: >> Hi Paul, >> >> Mike Sullivan advised me that the extra protofix lines may have been >> added by them and are required for incrementals. He was right so I'v

[webstack-discuss] [sfwnv-discuss] Code review for Ruby patch level update (CR-6871383)

2009-11-18 Thread Amanda Waite
Last time, I had to remove the file from SCCS and recreate it. Thanks Amanda Amanda Waite wrote: > Paul Cunningham wrote: >> Amanda, >> >> This mainly looks good to me, but below are a few observations (feel >> free to ignore) ... >> >> >> Amanda W

[webstack-discuss] [sfwnv-discuss] Code review for Ruby patch level update (CR-6871383)

2009-11-17 Thread Amanda Waite
Paul Cunningham wrote: > Amanda, > > This mainly looks good to me, but below are a few observations (feel > free to ignore) ... > > > Amanda Waite wrote: >> >> Can I get a code review for an update to Ruby 1.8.7. This updates >> Ruby 1.8.7 to patch l

[webstack-discuss] Code review for Ruby patch level update (CR-6871383)

2009-11-16 Thread Amanda Waite
Hi there, Can I get a code review for an update to Ruby 1.8.7. This updates Ruby 1.8.7 to patch level 174 and updates RubyGems to v1.3.5. The webrev is here: http://cr.opensolaris.org/~tekgrrl/CR-6871383 The patch file ${SRC}/cmd/ruby18/patches/ruby_nogdbm.patch had to be removed and re-added

[webstack-discuss] Code review for Lighttpd update to v1.4.23

2009-11-06 Thread Amanda Waite
Thanks to Sriram for the review, is there anyone else that can look over the lighttpd update for me? http://cr.opensolaris.org/~tekgrrl/CR6871404/ Thanks Amanda Amanda Waite wrote: > Hi all, > > I'm updating Lighttpd in SFW to v1.4.23 and would really appreciate it > if yo

[webstack-discuss] Code review for Lighttpd update to v1.4.23

2009-11-05 Thread Amanda Waite
th = "/usr/php/bin/php-cgi -c > /etc/php/5.2/php.ini" You're right, it's not needed which is good news. I made the change and you can find the updated webrev here: http://cr.opensolaris.org/~tekgrrl/CR6871404/ Thanks for the review Amanda > > > Looks goo

[webstack-discuss] Code review for Lighttpd update to v1.4.23

2009-11-04 Thread Amanda Waite
://cr.opensolaris.org/~tekgrrl/CR6871404/ Thanks Amanda > > - Sriram > > Amanda Waite wrote: >> Hi all, >> >> I'm updating Lighttpd in SFW to v1.4.23 and would really appreciate >> it if you could review my code. The Webrev is here: >> >> http

[webstack-discuss] Code review for Lighttpd update to v1.4.23

2009-11-04 Thread Amanda Waite
rwxrwxrwx 1 root root 9 Oct 30 10:39 man -> ./5.2/man lrwxrwxrwx 1 root root 13 Oct 30 10:39 modules -> ./5.2/modules then? % ls /usr/php/bin/php-cgi /usr/php/bin/php-cgi Same on OpenSolaris 2009.06 Amanda > > - Sriram > > Amanda Waite wrote: >>

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd update to v1.4.23

2009-11-04 Thread Amanda Waite
BTW: Lighttpd 1.4.24 was released last week, but to go with 1.4.24 would require 2 additional patches for bugs/regressions that they uncovered after release. I've chosen to go with the 'stable' version for now. Thanks Amanda Amanda Waite wrote: > Hi all, > > I'

[webstack-discuss] Code review for Lighttpd update to v1.4.23

2009-11-04 Thread Amanda Waite
Hi all, I'm updating Lighttpd in SFW to v1.4.23 and would really appreciate it if you could review my code. The Webrev is here: http://cr.opensolaris.org/~tekgrrl/CR6871404/ Things to note are that as the Lighttpd source no longer bundles spawn-fcgi we've moved it into a separate package SUNWs

[webstack-discuss] Lighttpd update Arc Case draft

2009-10-13 Thread Amanda Waite
Hi Jyri, Attached is a revised (single) Arc Case that brings together both the proposed changes to the existing Lighttpd packages and the proposal of the addition of the new SUNWspawn-fcgi package. I believe it addresses all of your points. Regards Amanda Jyri Virkki wrote: > Amanda Wa

[webstack-discuss] Lighttpd update Arc Case draft

2009-10-01 Thread Amanda Waite
Here's the Lighttpd Arc Case updated to remove OpenLDAP support. The spawn-fcgi arc case is also included in the hope that we are at the point when we can submit them to ARC. Thanks for all of the input. Amanda Jeff Trawick wrote: > Amanda Waite wrote: >> Are we good to go

[webstack-discuss] Lighttpd update Arc Case draft

2009-09-30 Thread Amanda Waite
Are we good to go with these Arc cases or do I need to drop OpenLDAP support for now? I really would like to get the main work done ASAP rather than end up having to rush to meet a code freeze deadline. Thanks a bunch Amanda Amanda Waite wrote: > Jyri Virkki wrote: >> Amanda Wa

[webstack-discuss] Lighttpd update Arc Case draft

2009-09-23 Thread Amanda Waite
Jyri Virkki wrote: > Amanda Waite wrote: > >> Attached is the draft Arc case for updating Lighttpd in SFW. I felt this >> was needed as it covers the following: >> >> - Obsolescence of spawn-fcgi in the Lighttpd packages >> > > The key question is

[webstack-discuss] OpenLDAP in SFW

2009-09-23 Thread Amanda Waite
Jyri Virkki wrote: > Jeff Trawick wrote: > >> Amanda Waite wrote: >> >>> Ok, I just read: >>> >>> "Sun products should consider Volatile interfaces as equivalent to >>> Consolidation Private. A contract is required for use of t

[webstack-discuss] conf.d and lighttpd

2009-09-16 Thread Amanda Waite
Matt Ingenthron wrote: > Hi Amanda, > > Amanda Waite wrote: >> Hi Matt, >> >> See: http://redmine.lighttpd.net/issues/1221 > > Thanks for the pointer. The idea of using cat had come up, but > obviously the lighttpd.conf shipped with Web Stack would have to d

[webstack-discuss] OpenLDAP in SFW

2009-09-16 Thread Amanda Waite
x27;t look, silly me. Amanda Jeff Trawick wrote: > Amanda Waite wrote: >> Hi there, >> >> I see that OpenLDAP in SFW has an interface stability of volatile. As >> I plan to have Lighttpd consume the OpenLDAP interfaces I would guess >> that I need to have an ag

[webstack-discuss] OpenLDAP in SFW

2009-09-16 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Hi there, >> >> I see that OpenLDAP in SFW has an interface stability of volatile. As >> I plan to have Lighttpd consume the OpenLDAP interfaces I would guess >> that I need to have an agreement in place with the Op

[webstack-discuss] Lighttpd update Arc Case draft

2009-09-16 Thread Amanda Waite
Attached is the draft Arc case for updating Lighttpd in SFW. I felt this was needed as it covers the following: - Obsolescence of spawn-fcgi in the Lighttpd packages - Addition of OpenLDAP and Lua as imported interfaces - Updates to the config file that could have an impact on the out of the

[webstack-discuss] OpenLDAP in SFW

2009-09-16 Thread Amanda Waite
Hi there, I see that OpenLDAP in SFW has an interface stability of volatile. As I plan to have Lighttpd consume the OpenLDAP interfaces I would guess that I need to have an agreement in place with the OpenLDAP owners (as per OpenSSL). Has anyone else had to tackle this? If so do you know who I

[webstack-discuss] conf.d and lighttpd

2009-09-16 Thread Amanda Waite
Hi Matt, See: http://redmine.lighttpd.net/issues/1221 Matt Ingenthron wrote: > Hi all, > > If I'm shipping some software which depends on lighttpd in > OpenSolaris, and I need to modify the configuration, there isn't a > good way to drop a file in which will augment the existing > configurati

[webstack-discuss] Draft Arc case for spawn-fcgi

2009-09-08 Thread Amanda Waite
Attached is a modified Arc Case that reflects Jeff's comments other than not using /usr/spawn-fcgi as the root of the package. Amanda Amanda Waite wrote: > Jeff Trawick wrote: >> Amanda Waite wrote: >>> Hi all, >>> >>> Attached is a draft Arc

[webstack-discuss] Draft Arc case for spawn-fcgi

2009-09-08 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Hi all, >> >> Attached is a draft Arc case for spawn-fcgi in SFW. As a reminder, >> spawn-fcgi is the component that was part of Lighttpd but is now >> distributed as a separate source bund

[webstack-discuss] Draft Arc case for spawn-fcgi

2009-09-07 Thread Amanda Waite
Peter Tribble wrote: > On Mon, Sep 7, 2009 at 3:23 PM, Amanda Waite wrote: > >> Hi all, >> >> Attached is a draft Arc case for spawn-fcgi in SFW. As a reminder, >> spawn-fcgi is the component that was part of Lighttpd but is now distributed >> as a separate s

[webstack-discuss] Draft Arc case for spawn-fcgi

2009-09-07 Thread Amanda Waite
Hi all, Attached is a draft Arc case for spawn-fcgi in SFW. As a reminder, spawn-fcgi is the component that was part of Lighttpd but is now distributed as a separate source bundle. The plan here is to change nothing about the Lighttpd user experience in OpenSolaris, yet allow spawn-fcgi to be

[webstack-discuss] Lighttpd 1.4.23 Arc Case draft and discussion

2009-09-02 Thread Amanda waite
Jyri Virkki wrote: > > On Sep 1, 2009, at 7:02 AM, Amanda Waite wrote: > >> Hi there, >> >> Attached is a very early draft of the Lighttpd 1.4.23 Arc Case. There >> is an issue that needs to be resolved before I take it forward and it >> would

[webstack-discuss] Lighttpd 1.4.23 Arc Case draft and discussion

2009-09-02 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Hi there, >> >> Attached is a very early draft of the Lighttpd 1.4.23 Arc Case. There >> is an issue that needs to be resolved before I take it forward and it >> would be useful to get everyone's input first. &g

[webstack-discuss] Lighttpd 1.4.23 Arc Case draft and discussion

2009-09-01 Thread Amanda Waite
Hi there, Attached is a very early draft of the Lighttpd 1.4.23 Arc Case. There is an issue that needs to be resolved before I take it forward and it would be useful to get everyone's input first. Lighttpd 1.4.23 no longer includes the spawn-fcgi utility which is broken out into a separate sou

[webstack-discuss] Lighttpd problems in Webstack 1.5

2009-08-04 Thread Amanda waite
Alain Geenrits wrote: > Amanda, > > Thanks, silly me. I got confused by the doc and the IPS in the title... With > the release or webstack repos I cannot find the Enterprise Manager package. > The doc does not explain how to install it as far as I can find. Any pointers > there ? > Good ques

[webstack-discuss] Lighttpd problems in Webstack 1.5

2009-08-04 Thread Amanda waite
Alain, It looks like you are trying to run the Solaris 10 WebStack distribution on OpenSolaris. In OpenSolaris the WebStack components are delivered through the /release repository. Lighttpd is packages as SUNWlighttpd14, all of the other components are delivered in a similar way. There are al

[webstack-discuss] PHP SNMP extension

2009-06-19 Thread Amanda Waite
27; though is purely temporary. I may propose that we move the net-snmp code out in to a separate /contrib package until the SFW version becomes available to SourceJuicer. Thanks Amanda > -----Original Message- > From: Amanda Waite > Sent: Friday, June 19, 2009 4:46 AM > To: we

[webstack-discuss] PHP SNMP extension

2009-06-19 Thread Amanda Waite
Hi all, The Cacti monitoring application requires the PHP SNMP extension and looking around on the mail archives and on Sun Wiki, it seems that we had planned to add this extension in 5.2.8. Do we still have plans to add SNMP support? Thanks Amanda

[webstack-discuss] Starting mongrel dumps ld usage

2009-06-12 Thread Amanda waite
David Kleiner wrote: > I went through several rounds of pain to get webstack going. Now I have 2 > ruby environments, the 1.8.7 from Sunfreeware and my own, /opt/webstack/ruby > stuff. The /usr/local/bin/ruby (Joyent uses pkgsrc) is running 7 production > mongrels, and /opt/webstack/bin/ruby,

[webstack-discuss] Starting mongrel dumps ld usage

2009-06-11 Thread Amanda waite
Which ruby is actually being used? snv_89 would have had Ruby installed and you may be picking up the version in /usr/bin. Run 'which ruby' 'ruby -v' and 'gem env' and see what they tell you. BTW: WebStack is designed to run on Solaris 10 and not on Solaris snv_* builds, I think that maybe you'v

[webstack-discuss] Starting mongrel dumps ld usage

2009-06-11 Thread Amanda waite
David, Are there any other RubyGems involved in your setup, anything using ruby_inline for instance? image_science maybe? Thanks Amanda David Kleiner wrote: > Greetings, > > I am using ruby from Webstack on Joyent snv_89 container: > > [admin at fhgyztbq /events/log]$ pkginfo -l sun-ruby18 >

[webstack-discuss] Ruby's rbconfig and C++ extensions

2009-06-08 Thread Amanda waite
Philip Antoniades wrote: > You should also make sure you have g++ installed - I got non-intuitive > errors from > > pfexec gem install mysql > > but before I could return to debug, I installed gcc for a different > reason and found I had made the gems install start working. Well for OpenSolaris

[webstack-discuss] Ruby's rbconfig and C++ extensions

2009-06-08 Thread Amanda waite
Jeff Trawick wrote: > Amanda Waite wrote: >> CXX is implicitly set to 'g++' on OpenSolaris boxes when using gmake >> or /usr/gnu/bin/make. eventmachine calls 'make' and so on >> OpenSolaris, if /usr/gnu/bin is in the PATH and before /usr/ccs/bin &g

[webstack-discuss] Ruby's rbconfig and C++ extensions

2009-06-08 Thread Amanda Waite
CXX is implicitly set to 'g++' on OpenSolaris boxes when using gmake or /usr/gnu/bin/make. eventmachine calls 'make' and so on OpenSolaris, if /usr/gnu/bin is in the PATH and before /usr/ccs/bin it will build ok without the need to set environment variables. That's what we have for OpenSolaris.

[webstack-discuss] Lighttpd and Lua: Support for mod_magnet

2009-06-02 Thread Amanda Waite
Nick Kew wrote: > > On 2 Jun 2009, at 12:52, Amanda Waite wrote: > >> Hi all, >> >> I'm planning to update Lighttpd in OpenSolaris to use the recently >> integrated Lua library. This will finally allow us to support >> mod_magnet which is a key differ

[webstack-discuss] Lighttpd and Lua: Support for mod_magnet

2009-06-02 Thread Amanda Waite
Hi all, I'm planning to update Lighttpd in OpenSolaris to use the recently integrated Lua library. This will finally allow us to support mod_magnet which is a key differentiator for Lighttpd. Would we consider adding lua to the WebStack core libraries so that we can then add mod_magnet support

[webstack-discuss] Apache mod_rewrite and .htaccess

2009-05-30 Thread Amanda waite
Jyri Virkki wrote: > Eric Reid - Sun ISV Engineering wrote: > >> There's really a whole class of software packages of this ilk -- perhaps >> it's not too late to press for a defacto standard in OSOL. Or maybe it is. >> > > Certainly not too late since IIRC not one of this class of apps has

[webstack-discuss] Apache mod_rewrite and .htaccess

2009-05-30 Thread Amanda waite
Jyri Virkki wrote: > Amanda waite wrote: > >> I have a question for you, where would you install the SilverStripe >> files to? >> > > Under /usr somewhere for all the static content, config files under > /etc, runtime (if any) under /var. In other word

[webstack-discuss] Apache mod_rewrite and .htaccess

2009-05-29 Thread Amanda waite
Jyri Virkki wrote: > Amanda Waite wrote: > >> To httpd.conf (which we are doing directly at the moment) where >> > > Not sure how you're doing that from the IPS package (w/o postinstall)? > But anyway, don't modify httpd.conf, instead have the packag

[webstack-discuss] Apache mod_rewrite and .htaccess

2009-05-29 Thread Amanda waite
Nick Kew wrote: > On Fri, 29 May 2009 16:21:30 +0100 > Amanda Waite wrote: > > >> Hi all, >> > > >> >> > > You presumably mean /path/to/silverstripe > > >> Options FollowSymLinks >> AllowOverrid

[webstack-discuss] Apache mod_rewrite and .htaccess

2009-05-29 Thread Amanda Waite
Hi all, We are packaging SilverStripe for /contrib and are looking to provide a simple silverstripe.conf with the package that will allow the allow end-users to get up and running without having to configure Apache. This is on OpenSolaris 2008.11 with the integrated Apache 2.2. SilverStripe cr

[webstack-discuss] Need another reviewer for FastCGI

2009-04-09 Thread Amanda Waite
int look at providing the sources with a working Makefile. Is that ok? Thanks Amanda > > -- Seema. > > Amanda Waite wrote: >> Hi there, >> >> With reference to my FastCGI code review request. Could someone else >> kindly review it for me? Paul has completed hi

[webstack-discuss] Need another reviewer for FastCGI

2009-04-09 Thread Amanda Waite
Hi there, With reference to my FastCGI code review request. Could someone else kindly review it for me? Paul has completed his review, but I need at least one other. I won't post the webrev link here as it's better to keep it under the same email thread. The email thread is entitled: "Code rev

[webstack-discuss] [sfwnv-discuss] Code review for FastCGI application libraries

2009-04-08 Thread Amanda Waite
d review it) > > paul > > Amanda Waite wrote: >> Thanks, I've addressed all of your comments TMPDIR has become >> TMP_PROTO_DIR to avoid classes with the build environment and I've >> used it throughout ('cept for DESTDIR in the make install target). &g

[webstack-discuss] [sfwnv-discuss] Code review for FastCGI application libraries

2009-04-07 Thread Amanda Waite
Paul Cunningham wrote: > Amanda, > > Mainly looks good, but see below .. > > Paul > > Amanda Waite wrote: >> >> Changes at http://cr.opensolaris.org/~tekgrrl/FastCGI/ see inline for >> comments. >> >> >> Paul Cunningham wrote: > > .. cu

[webstack-discuss] [sfwnv-discuss] Code review for FastCGI application libraries

2009-04-07 Thread Amanda Waite
Hi Paul, Thanks ever so much for the review. I hope the powers that be appreciate that without you there'd be nothing in SFW, something we need to fix methinks. Changes at http://cr.opensolaris.org/~tekgrrl/FastCGI/ see inline for comments. Paul Cunningham wrote: > > 1. usr/src/lib/fastcgi/

[webstack-discuss] Code review for FastCGI application libraries

2009-04-03 Thread Amanda Waite
Hi there, Can I get a code review for the integration of the FastCGI application libraries into SFW. The ARC case for this is PSARC/2009/014, OSR is 11091 Webrev is at http://cr.opensolaris.org/~tekgrrl/FastCGI/ There are no C++ libraries in this integration, as per the ARC case they will be

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-04-01 Thread Amanda Waite
mysql_config for it's LDFLAGS the RPATH will still be hardcoded to the version it was built with which is as it should be. Thanks Amanda Amanda Waite wrote: > Hi there, > > Could you kindly review the following update to Lighttpd: > > http://cr.opensolaris.org/~tekgrrl/CR-6816914/ &

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-04-01 Thread Amanda Waite
sunanda menon wrote: > Amanda Waite wrote: >> Jyri Virkki wrote: >>> Amanda Waite wrote: >>> >>>>> Define it this way instead MYSQL_PATH=/usr/mysql and >>>>> MYSQL_LIB=$(MYSQL_PATH)/lib/mysql >>>>> >>>>

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-04-01 Thread Amanda Waite
Jyri Virkki wrote: > Amanda Waite wrote: > >>> Define it this way instead MYSQL_PATH=/usr/mysql and >>> MYSQL_LIB=$(MYSQL_PATH)/lib/mysql >>> >> I think this would lead to some ambiguity and potential problems. What >> if you were to updat

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-31 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Jeff Trawick wrote: >>> Amanda Waite wrote: >>>> Hi again, >>>> >>>> I've made the changes Seema suggested and the updated webrev is at: >>>> http://cr.opensolaris.org/~tekgrrl/C

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-31 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Hi again, >> >> I've made the changes Seema suggested and the updated webrev is at: >> http://cr.opensolaris.org/~tekgrrl/CR-6816914 >> >> I've used the same variables in the Makefile.sfw as Sriram did

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-31 Thread Amanda Waite
md/Makefile are added in no particular order which seems strange giving how particular we are usually. Thanks Amanda Amanda Waite wrote: > Hi there, > > Could you kindly review the following update to Lighttpd: > > http://cr.opensolaris.org/~tekgrrl/CR-6816914/ > > Up

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-30 Thread Amanda Waite
ing dependency entries. >> >> -- Seema. >> >> >> On 03/30/09 17:02, Amanda Waite wrote: >>> Seema Alevoor wrote: >>>> >>>> >>>> On 03/30/09 16:28, Amanda Waite wrote: >>>>> Seema Alevoor wrote: >>>&

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-30 Thread Amanda Waite
ile for php right? At the moment it still says: php5: apache2 mysql-5-0 postgres/postgresql-8.3 and the file isn't updated in his webrev. Thanks Amanda > > -- Seema. > > > On 03/30/09 17:02, Amanda Waite wrote: >> Seema Alevoor wrote: >>> >>> >&g

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-30 Thread Amanda Waite
Seema Alevoor wrote: > > > On 03/30/09 16:28, Amanda Waite wrote: >> Seema Alevoor wrote: >>> usr/src/cmd/lighttpd14/Makefile.sfw : >>> Shouldn't MYSQL_CONFIG point to >>> "$(ROOT)/usr/mysql/5.1/bin/mysql_config" ? >> >>

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-30 Thread Amanda Waite
was waiting for b111 to become available. I used build 109 and I used the MySQL 5.1 libs and mysql_config from the proto area and the nightly failed because it could not find mysql_config. Amanda > > > -- Seema. > > On 03/28/09 21:09, Amanda Waite wrote: >> Hi there, >>

[webstack-discuss] Code review for updating Lighttpd to use MySQL 5.1 libs

2009-03-28 Thread Amanda Waite
Hi there, Could you kindly review the following update to Lighttpd: http://cr.opensolaris.org/~tekgrrl/CR-6816914/ Updating Lighttpd to use the MySQL 5.1 libraries also fixes 3 other issues. Lighttpd no longer has a build time dependency on /usr/sfw/bin/mysq_config and the Lighttpd package dep

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-18 Thread Amanda Waite
Looks good to me. Amanda sunanda menon wrote: > Updated webrevs posted at http://cr.opensolaris.org/~sunandam/6808952/ > > Thanks Sunanda > > Seema Alevoor wrote: >> usr/src/cmd/mysql-5-0/Makefile.sfw : >> * Use $(CCBITS64) instead of "-m64" >> * CXX64FLAGS already includes "-m64" . So, t

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Amanda Waite
Hi Sunanda, usr/src/cmd/mysql-5-0/METADATA - Can you add a NAME field as per http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines usr/src/cmd/mysql-5-0/Makefile.sfw - You can get Version numbers and Program names from the METADATA file. These are available as $(COMPONENT_NAME:sh

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Jeff Trawick wrote: >>> sunanda menon wrote: >>>> Hi , >>>> Please do a Code Review request for the upgrade of MySQL from >>>> 5.0.67 to 5.0.77 (CR 6808952) >>>> at http://cr.opensola

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Amanda Waite
Jeff Trawick wrote: > sunanda menon wrote: >> Hi , >> Please do a Code Review request for the upgrade of MySQL from 5.0.67 >> to 5.0.77 (CR 6808952) >> at http://cr.opensolaris.org/~sunandam/6808952/ >> > it looks okay to me, though it would be good for somebody more > familiar with packaging to

[webstack-discuss] Ruby Code review request: CR 6804312

2009-03-04 Thread Amanda waite
Looks good. Amanda Prashant Srinivasan wrote: > Can I request someone to please review this fix? > > http://cr.opensolaris.org/~psriniva/webrev-6804312/ > > For folks who don't have access to the CR - the fix 'fixes' a startup > failure with Merb on Ruby. The issue is caused by RubyInline being

[webstack-discuss] [sfwnv-discuss] PHP with MCrypt extension and LSARC 2009/124 implementation

2009-02-27 Thread Amanda Waite
Sriram Natarajan wrote: > > > Amanda Waite wrote: >> usr/src/cmd/php5/METADATA >> - Clean up indentation >> > anything particular ? First line, in the webrev as displayed in my browser 'php' isn't aligned with the ones underneath >> usr/src/

[webstack-discuss] [sfwnv-discuss] PHP with MCrypt extension and LSARC 2009/124 implementation

2009-02-27 Thread Amanda Waite
usr/src/cmd/php5/METADATA - Clean up indentation usr/src/pkgdefs/SUNWphp52u/prototype_com - Don't set the write bit on new files going into /usr Otherwise it looks fine BTW: I was also confused by the changes to the patch files, but the changes look ok. Also make a note to tidy up the CDDL hea

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda Waite
I've created a new CR to track the change to CFLAGS and updated the Webrev accordingly. http://cr.opensolaris.org/~tekgrrl/CR-6781455/ Thanks for all the input so far Amanda David.Comay at Sun.COM wrote: >> No more than the background noise, it's tough to judge with a Web >> Server. I use -xO

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda waite
David.Comay at Sun.COM wrote: >> No more than the background noise, it's tough to judge with a Web >> Server. I use -xO4 in all my test builds so it seemed natural to use >> it here. I'll revert it to -xO3 > > I agree with Jyri here - what have you been using from a testing > perspective? If it'

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda waite
Prashant Srinivasan wrote: > >> >> New Webrev is here: >> >> http://cr.opensolaris.org/~tekgrrl/CR-6781455/ >> > > Amanda, > > Do you want to create a CR for the CFLAGS upgrade? It'll probably be > easier for you to track this change. > What perf improvements did we get with -xO4? No more than t

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda Waite
t to the comments for the above files New Webrev is here: http://cr.opensolaris.org/~tekgrrl/CR-6781455/ Paul, could you possibly check my changes for me? Sorry to everyone on webstack-discuss who are getting this info twice. Thanks Amanda Amanda Waite wrote: > Hi there, > > >

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda Waite
utomatically these days. It also finds pcre without guidance but I want to be explicit about pcre as we have to coerce it to find the pcre header files. Can I count this as a review? ;o) Thanks Amanda > > Steve C. > > Amanda Waite wrote: >> Paul Cunningham wrote: >>>

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda Waite
Jyri Virkki wrote: > Amanda waite wrote: > >>> Noticed the rbac changes in SUNWlighttpd14r/prototype_com but didn't >>> notice where they're coming from? Also, is that part of the upstream >>> 1.4.21 update? >>> >> I learned t

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda Waite
Sriram Natarajan wrote: > what does 'rbac' within the 'prototype' do ? > > +e rbac etc/security/exec_attr 0644 root sys > +e rbac etc/security/prof_attr 0644 root sys > +e rbac etc/user_attr 0644 root sys It uses the ON i.rbac class action script to merge the SFW *_attr files into the ON files at

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda waite
Jyri Virkki wrote: > Amanda Waite wrote: > >> Hi there, >> >> >> Can I get a code review for updating Lighttpd to version 1.4.21 please. >> Webrev is here: >> >> http://cr.opensolaris.org/~tekgrrl/CR-6781455/ >> > > > I was g

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda waite
Is there anyone in the WebStack team able to review my Lighttpd update Webrev? Paul on sfwnv-discuss has already looked at it and approved. Thanks Amanda Amanda Waite wrote: > Hi there, > > > Can I get a code review for updating Lighttpd to version 1.4.21 > please. Webrev is

[webstack-discuss] Review: Fix for CR 6782657 (When ssl is enabled, prefork fails to stop gracefully)

2009-02-23 Thread Amanda Waite
Looks fine. Amanda Seema Alevoor wrote: > Hi, > > Please review the webrev for CR 6782657 at > http://cr.opensolaris.org/~seema/6782657/ > > > Thanks, > Seema. > ___ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://ma

[webstack-discuss] [sfwnv-discuss] Code review for Lighttpd 1.4.21 update

2009-02-23 Thread Amanda Waite
we decided that the same should be true for the man pages. Thanks for the review! Amanda > > Paul > > Amanda Waite wrote: >> >> Can I get a code review for updating Lighttpd to version 1.4.21 >> please. Webrev is here: >> >> http://cr.opensolaris.org/~tekgrrl/CR-6781455/ > >

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-22 Thread Amanda Waite
Hi there, Can I get a code review for updating Lighttpd to version 1.4.21 please. Webrev is here: http://cr.opensolaris.org/~tekgrrl/CR-6781455/ Thanks Amanda

[webstack-discuss] webrev for both ruby upgrade to 1.8.7 and rubygem upgrade to 1.3.1 CR6764580 & CR6788394

2009-02-12 Thread Amanda waite
Chris Zhu wrote: > Do you mean when we add comment to each file by "wx ea", we just add > the related CR(s) to files. For example: > --- > usr/src/Targetdirs > > 6764580 RubyGems needs updating to work with the latest vers

[webstack-discuss] webrev for both ruby upgrade to 1.8.7 and rubygem upgrade to 1.3.1 CR6764580 & CR6788394

2009-02-12 Thread Amanda waite
Jyri Virkki wrote: > > One example, usr/src/pkgdefs/SUNWruby18r/prototype_i386 > seems to only clean up the ident line, so that change isn't related to > either of the two CRs listed. There's a handful other cases like this. > This is just a general tidy up and I think it counts if it means that

[webstack-discuss] Code review: Fix for CR 6782600 (loading of mod_cgi and mod_cgid)

2009-02-11 Thread Amanda Waite
Didn't see any replies to this. Looks fine. Amanda Seema Alevoor wrote: > Hi, > > Kindly review the fix for CR 6782600. > > Irrespective of the MPM chosen, Apache 2.2 loaded both mod_cgi and mod_cgid > modules. > But worker MPM works with mod_cgid and prefork MPM works better with mod_cgi. > Hen

[webstack-discuss] Review: create symlink "64" to Apache 2.2 64-bit ISA directories

2009-02-11 Thread Amanda Waite
It looks just fine. My only concern would have been whether we need CDDL headers in the conf files, but as these are existing files I assume that this was covered in the original integration. Amanda Seema Alevoor wrote: > Hi, > > Webrev for CR 6782602 (create symlink "64" to Apache 2.2 64-bit

[webstack-discuss] Reviewers needed for Ruby/RubyGems code review

2009-02-11 Thread Amanda Waite
Hi there, Anyone able to help out by reviewing the Code Review for the Ruby/RubyGems update that Chris posted to sfwnv-discuss and here? http://www.opensolaris.org/jive/thread.jspa?threadID=91422&tstart=0 We are still waiting for the OSR to be approved but we want to be ready to go when it is,

[webstack-discuss] [sfwnv-discuss] Request to review CR: 6780290 and PHP 5.2.8 integration within opensolaris

2009-02-10 Thread Amanda Waite
[resend] I've been through everything and it looks ok to me. You seem to have updated the Copyright year in every file, including files (particularly the package files) with no other changes and I'd suggest that you revert them back to the parent version. If nothing else it makes the webrev a

[webstack-discuss] [sfwnv-discuss] webrev for both ruby upgrade to 1.8.7 and rubygem upgrade to 1.3.1 CR6764580 & CR6788394

2009-02-10 Thread Amanda Waite
[resend as all my emails to opensolaris.org aliases bounced today] usr/src/cmd/ruby18/sunman-stability - There's a 'C' missing from the start of Line 18 (should read "Contains") Apart from that it looks fine. I'll try installing the packages later and will run as many tests as I can think of. A

[webstack-discuss] [sfwnv-discuss] Code review for CR6764580 - RubyGems 1.3.1 update to Ruby Packages

2009-02-02 Thread Amanda waite
Update WebRev with your suggestions addressed. http://cr.opensolaris.org/~tekgrrl/gems131-CR6764580-2/ Thanks Amanda Prashant Srinivasan wrote: > Amanda waite wrote: > >> Chris Zhu wrote: >> >> >>> Hi Amanda, >>> >>> I just found

[webstack-discuss] [sfwnv-discuss] Code review for CR6764580 - RubyGems 1.3.1 update to Ruby Packages

2009-02-02 Thread Amanda waite
{ROOT}/usr/ruby/1.8/bin/ruby. Look at the shebang on ${ROOT}/usr/ruby/1.8/bin/gem on your workspace. Amanda > > Regards > Chris > > Amanda Waite wrote: >> Prashant Srinivasan wrote: >> >>> Hi Amanda, >>> Some more comments for you: >>> .gem_m

[webstack-discuss] [sfwnv-discuss] Code review for CR6764580 - RubyGems 1.3.1 update to Ruby Packages

2009-01-30 Thread Amanda Waite
instead, I'll reduce it to 3 seconds. It does say to use 'ri' and also mentions that the warnings can be suppressed with -s. I'll wait to hear if you have any more comments before updating the WebRev. The OSR got lost in the post so I can't do the putback this week. Tha

  1   2   >