thiemowmde added a comment.
I dug into the code and indeed found the place that creates constants based
on what's said in extension.json:
https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/registration/ExtensionRegistry.php$512.
But this appears to be more like
thiemowmde added a comment.
I would like to ask another question: How is it a good idea do define a
**PHP** constant in a .json file? How is my IDE supposed to find it there?
In other words: As far as I'm concerned the duplication is a **must**.
TASK DETAIL
https
thiemowmde added a comment.
Even if it's true that this started failing when a specific change in core
was made. I still believe it is the extension that must be fixed. I might get
this wrong, but my idea is: Code should not assume that the "namespaces"
section from exte
thiemowmde added a comment.
I think what you are missing is one of the steps described in Wikibase'
README.md: `git submodule update --init`
TASK DETAIL
https://phabricator.wikimedia.org/T246211
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
thiemowmde added a comment.
Oh dear, I just realized how strange my comment from 2015 sounds by now. I
totally support dropping this esoteric format! I believe PHP's internal
serialization format should be something that's internal to PHP, and not be
part of a public API. Please drop
thiemowmde added a comment.
Thanks a lot for the detailed response! However, I feel my main point got
lost. My question really is what the benefit of an isolated unit test for
"being compatible with PSR-16" is? It's not like the class
SimpleCacheWithBagOStuff is used in isola
thiemowmde added a comment.
Wasn't this what @MaxSem tried already in
https://gerrit.wikimedia.org/r/547911?
What's the point of this library anyway? As far as I can tell it's used in a
single (!) file: SimpleCacheWithBagOStuffTest. What does it do? What do we
loose when we get rid
thiemowmde added a comment.
I'm afraid such a comment won't make anybody work on this harder.
TASK DETAIL
https://phabricator.wikimedia.org/T167788
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: Tagishsimon, The_RedBurn, JAnD
thiemowmde added a comment.
As far as I understand the situation, it is not considered "broken". Whatever
the user does, they **must** check the preview to see if the date parsers guess
is correct. This won't change, no matter how good the parsers guess is.
But yes, it's
thiemowmde added a comment.
There is a .phpcs.xml in Wikibase. You can move the exclusions you want to
keep to this file, including the comments explaining them.
TASK DETAIL
https://phabricator.wikimedia.org/T243296
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
thiemowmde added subscribers: Lucas_Werkmeister_WMDE, WMDE-leszek, thiemowmde.
thiemowmde added a comment.
Note: I was the driving force when we introduced the WikibaseCodeSniffer rule
set. The main motivations back then:
1. Being able to experiment with additional, custom sniffs
thiemowmde added a comment.
> […] we have to maintain list of units, globes, etc inside the code
As suggested a while ago <https://phabricator.wikimedia.org/T167565#3359160>,
I don't think it is necessary to make the code know what valid units, globes,
etc. are. All I
thiemowmde removed thiemowmde as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T118283
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: zeljkofilipin, Lydia_Pintscher, thiemowmde, Ladsgroup, WMDE-leszek
thiemowmde closed subtask T118283: move testing things from browser tests to
qunit or phpunit tests where possible as Invalid.
TASK DETAIL
https://phabricator.wikimedia.org/T88541
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jonas, thiemowmde
Cc
thiemowmde closed this task as "Invalid".
thiemowmde added a comment.
Closing, not because what this task asks for shouldn't be done, but because
having this ticket does not help actually making it happen. It's old, contains
barely any information, and is not on any board that i
thiemowmde closed subtask T95420: [Task] Thin out scenario outlines on data
value browsertest as Invalid.
TASK DETAIL
https://phabricator.wikimedia.org/T118283
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: zeljkofilipin
thiemowmde closed subtask T95420: [Task] Thin out scenario outlines on data
value browsertest as Invalid.
TASK DETAIL
https://phabricator.wikimedia.org/T55845
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: Aklapper, WMDE-Fisch
thiemowmde closed this task as "Invalid".
TASK DETAIL
https://phabricator.wikimedia.org/T95420
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: Aklapper, WMDE-Fisch, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86,
GoranSM
thiemowmde removed thiemowmde as the assignee of this task.
thiemowmde edited subscribers, added: Ladsgroup, Jakob_WMDE, WMDE-leszek;
removed: adrianheine, Jonas.
thiemowmde removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T124784
EMAIL PREFERENCES
https
thiemowmde closed subtask T108681: [RFC] Create a new Wikibase-Change-Services
component as Declined.
TASK DETAIL
https://phabricator.wikimedia.org/T101836
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: daniel, thiemowmde
Cc: Addshore, Bene
thiemowmde closed subtask T108681: [RFC] Create a new Wikibase-Change-Services
component as Declined.
TASK DETAIL
https://phabricator.wikimedia.org/T108296
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: PokestarFan, Liuxinyu970226
thiemowmde removed thiemowmde as the assignee of this task.
thiemowmde added subscribers: Lucas_Werkmeister_WMDE, WMDE-leszek.
thiemowmde added a project: Regression.
TASK DETAIL
https://phabricator.wikimedia.org/T153854
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
thiemowmde removed thiemowmde as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T63958
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: Kwj2772, Jarekt, C933103, Capankajsmilyo, jeblad, PokestarFan, revi
thiemowmde added a comment.
Thanks for the additional analysis. Another thing I realized later is that
this might cause //actual// data loss in the Wikidata database. This can happen
when a tool uses data it got from the query service to edit the original
Wikidata entity. I believe
thiemowmde added subscribers: WMDE-leszek, Lydia_Pintscher,
Lucas_Werkmeister_WMDE.
thiemowmde moved this task from monitoring to needs discussion or investigation
on the Wikidata board.
thiemowmde added a project: Regression.
thiemowmde removed Smalyshev as the assignee of this task.
thiemowmde
thiemowmde removed thiemowmde as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T142691
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: thiemowmde, Addshore, Sjoerddebruin, gerritbot, aude, Jonas, daniel
thiemowmde added a parent task: T225162: Tracking: flapping tests in gated
extensions.
TASK DETAIL
https://phabricator.wikimedia.org/T225195
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: awight, thiemowmde, Aklapper, darthmon_wmde
thiemowmde created this task.
thiemowmde added projects: Wikimedia-production-error (Shared Build Failure),
MediaWiki-extensions-CentralAuth, EventBus,
MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
Restricted Application added projects: Wikidata
thiemowmde added a comment.
In case you are referring to the documentation in
docs/change-op-serializations.wiki
<https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/docs/change-op-serializations.wiki>,
note I wrote this very late (in 2017), based on experiments and informa
thiemowmde triaged this task as "Low" priority.
thiemowmde moved this task from incoming to needs discussion or investigation
on the Wikidata board.
thiemowmde added a project: good first bug.
thiemowmde added a comment.
Here is the line of code that is responsible for the curren
thiemowmde added a comment.
FYI, I found a way to fix the broken test. The issue seems to be that the
test cases all use the same page. The second last test moves the page and turns
it into a redirect. The last test tries to delete and restore the page, but
restores the redirect instead
thiemowmde added a comment.
I'm somewhat confused what the relevance of these questions is, why they are
asked, and who asks them. Are you a WMF or WMDE employee I'm not aware of? I
don't know who "owns" the feature this ticket is about. It's on wikidata.org
and falls into the
thiemowmde added a comment.
> you would be able to fix this issue if you were given it as a task by your
line manager?
It's open source software. People can change it and fix everything. The only
question is how many resources people are willing to spend. In a worst-case
scena
thiemowmde added a comment.
I believe we run into a very similar issue in the tour we have in the
#two-column-edit-conflict-merge
<https://phabricator.wikimedia.org/tag/two-column-edit-conflict-merge/>
extension, see T195713: Have an intro tour (No. 2)
<https://phabricator.wiki
thiemowmde closed this task as "Invalid".
thiemowmde added a comment.
- It was the author of this task who closed it.
- The task description was not very specific and actionable to begin with.
- This is something the Wikisource community can better manage on-wiki. I
don't think
thiemowmde triaged this task as "High" priority.
TASK DETAIL
https://phabricator.wikimedia.org/T221752
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: Aklapper, Anomie, aaron, Addshore, Lydia_Pintscher, thiemowmde,
thiemowmde created this task.
thiemowmde added projects: Cognate, Wikidata, Core Platform Team.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
I did a "git bisect" and tracked the issue down to this change:
https://gerrit.wikimedia.org/r/501594 (T1883
thiemowmde added a comment.
Asking users to provide "legitimate reasons" to be allowed to use one of the
(literally) most basic
<https://www.fileformat.info/info/unicode/block/basic_latin/list.htm>
**characters** is, … how to put this? It scares me. It's like asking u
thiemowmde added a comment.
Sorry for writing so much, but I feel there is an important lesson to learn
here, despite this appearing like it would be a minor thing. I feel this
highlights a quite fundamental misunderstanding.
See, limiting the use of a character is, in a way
thiemowmde added a comment.
> Item pages should split alias entries containing | character to be
consistent with Special:SetAliases
Oh my. I just realized this task was turned around, and the bug should now
become a "feature". Why? Don't we have a UI that allows to pres
thiemowmde added a subscriber: Lydia_Pintscher.
thiemowmde added a comment.
I'm afraid I have to agree with @Addshore here. Sure, it might be that many
of the aliases that currently contain pipe characters are mistakes. It might
even be the vast majority. But even if this is the case
thiemowmde added a comment.
I'm sorry for my rude comment at https://gerrit.wikimedia.org/r/502530. I
made that in a hurry.
The two relevant lines of code are these:
-
https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/Specials/SpecialSetAliases.php$82
thiemowmde removed Lucie as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T143597
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: PokestarFan, daniel, aude, gerritbot, Lucie, Lydia_Pintscher, Aklapper,
hoo
thiemowmde added subscribers: Addshore, WMDE-leszek, thiemowmde.thiemowmde added a comment.
Is there a chance this gets fixed fast? Otherwise we will temporarily disable the test. This should buy you enough time. The only thing you need to take care of then is to not forget to enable it again.TASK
thiemowmde added subscribers: thiemowmde, Lydia_Pintscher.thiemowmde edited projects, added Wikidata, Wikidata.org; removed Advanced-Search.thiemowmde added a comment.
There are two messages involved:
https://translatewiki.org/wiki/MediaWiki:search-nonefound/en is shown when "there
thiemowmde added a subscriber: matej_suchanek.thiemowmde added a comment.
I believe the gadget in question is https://www.wikidata.org/wiki/MediaWiki:Gadget-Preview.js. It might be that this edit by @matej_suchanek fixed it: https://www.wikidata.org/wiki/Special:Diff/524430620. @matej_suchanek
thiemowmde added a project: Elasticsearch.thiemowmde added subscribers: Addshore, WMDE-leszek.Restricted Application added a project: Discovery-Search.
TASK DETAILhttps://phabricator.wikimedia.org/T206100EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
thiemowmde added a project: Elasticsearch.thiemowmde added subscribers: Smalyshev, WMDE-leszek, Addshore.Restricted Application added a project: Discovery-Search.
TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
thiemowmde added a comment.
the problem does appear to be the precision
Indeed. I don't have a programmatic suggestion then, other than somehow fixing these Items manually.
Thanks for the hint to use Special:EntityData/….json!TASK DETAILhttps://phabricator.wikimedia.org/T144248EMAIL
thiemowmde added projects: DataValues, Regression.thiemowmde added subscribers: Lucas_Werkmeister_WMDE, Addshore, Lydia_Pintscher.thiemowmde added a comment.
There are indeed coordinate values in the database the current code can not deserialize any more: https://www.wikidata.org/wiki/Special:Diff
thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Need-volunteer, Easy.
TASK DETAILhttps://phabricator.wikimedia.org/T204723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, WMDE-leszek, Jonas, Lydia
thiemowmde created this task.thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, DataValues.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONcommonsMedia values are stored as strings that contain the file name only, e.g. Example_en.svg refers to https
thiemowmde added a comment.
In T99664#3848557I suggested to apply normalization to Wikimedia Commons file names before they are stored. This would solve a few related issues. Should I open a new ticket for this?TASK DETAILhttps://phabricator.wikimedia.org/T99664EMAIL PREFERENCEShttps
thiemowmde removed thiemowmde as the assignee of this task.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T102840EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ricordisamoa, gerritbot, Lydia_Pintscher
thiemowmde raised the priority of this task from "High" to "Needs Triage".thiemowmde removed thiemowmde as the assignee of this task.thiemowmde removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T47925EMAIL PREFERENCEShttps://phabricator.wikimedi
thiemowmde closed this task as "Resolved".thiemowmde removed thiemowmde as the assignee of this task.thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] [serialization/serialization](https://github.com/wmde/Serialization) → [review code chan
thiemowmde added subscribers: thiemowmde, Addshore.thiemowmde added a project: Need-volunteer.thiemowmde triaged this task as "Low" priority.thiemowmde added a comment.
This is an other situation where none of the (currently half a dozen) custom Wikibase parsers is able to understan
thiemowmde added a parent task: T87764: Bugs related to time datatype (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T198179EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, Nikki, Lahi, Gq86, GoranSMilovanovic, QZanden
thiemowmde added a subtask: T198179: Month name and year preceded or followed by a dot or comma is parsed as having a day.
TASK DETAILhttps://phabricator.wikimedia.org/T87764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Mike_Peel, PokestarFan
thiemowmde added a comment.
I strongly suggest to go with one of these solutions:
keyvalue
feature_typeosm:Q123
wikidataQ456
something_elseosm:Q789
keyvalue
osm_feature_typeQ123
wikidataQ456
osm_something_elseQ789
keyvalue
osmbase_feature_typeQ123
wikidataQ456
thiemowmde added a comment.
The idea of the #wikidata.org extension is to contain bits that are not true for all Wikibase installations but only for wikidata.org, and are not configuration (but code and binary files). This is especially true for the badge graphics, as they depend on particular
thiemowmde added subscribers: Lydia_Pintscher, WMDE-leszek.thiemowmde added a comment.
TL;DR: I, personally, believe what appears to be a cosmetic issue in OSM UI should not be solved by changing the Wikibase data model.
"Q" does not mean "wikidata.org". It means "
thiemowmde added a comment.
I believe this is going the wrong direction, because numeric entity IDs are almost completely phased out already. A big chunk of that was done in 2016 via T56085, and a whole lot of other tickets, most notably the work the team put into migrating the wb_terms table
thiemowmde added a comment.
Sorry, I confused two ideas:
Yes, we certainly can create a sniff that forbids class_exists( 'string' ).
To make a sniff understand if a class_exists can be replaced with an ExtensionRegistry check, the sniff would need to know which class belongs to which extension
thiemowmde added a comment.
The Wikibase codebase currently contains about 40 class_exists checks. The vast majority checks for CirrusSearch – I guess because that extension still doesn't have an extension.json.
Just making people aware of the issue is not very successful, as the most problematic
thiemowmde added a comment.
Personally I don't think it makes sense to split this into subtasks. Either update all codebases the same way, or none.
I furthermore suggest to close this as "declined" (as this is what the lack of interest by the Wikidata team tells me) and wait till
thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...The suggestion is to **not** care about any of these, but exclusively focus on replacing `PHPUnit_Framework_TestCase` with `TestCase`. This is the vast majority of replacements we need to do (about 84% when I
thiemowmde added a comment.
I just realized what this error message means: Some test (at the moment I don't know which) creates an Item, but this Item ends in code that expects a Lexeme.
One possible improvement is to let FormIdTextFormatter::formatEntityId throw an exception when the Entity
thiemowmde added a comment.
Are we really checking characters? I seem to remember something else but am not entirely sure.
The StringLengthValidator responsible for these checks allows to specify if it should count bytes (strlen) or characters (mb_strlen). In the current code it counts bytes
thiemowmde added a comment.
Personally, I don't think it makes sense to touch the string datatype in any machine-readable output. (In other words: I don't think this is worth a breaking change.) But I think it makes sense to prefer $propertyType as a variable name in code, and "property data
thiemowmde added a comment.
Legally, every edit requires the user to agree to the license. Even if the license is CC-0. Even if the edit removes something. Every edit becomes part of the CC-0 dataset, and this can only be done if every edit is compatible with CC-0.
In other words: I think
thiemowmde closed this task as a duplicate of T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found.
TASK DETAILhttps://phabricator.wikimedia.org/T197038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc
thiemowmde added a comment.
The CI on both extensions is green again.TASK DETAILhttps://phabricator.wikimedia.org/T197038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aleksey_WMDE, RazShuty, Lucas_Werkmeister_WMDE, Nikerabbit, KartikMistry
thiemowmde added subscribers: Jdlrobson, Aleksey_WMDE, RazShuty, Nikerabbit, KartikMistry, thiemowmde.thiemowmde merged a task: T197038: Wikibase phpunit failure blocking WikidataPageBanner patches.
TASK DETAILhttps://phabricator.wikimedia.org/T197017EMAIL PREFERENCEShttps
thiemowmde added subscribers: Lucas_Werkmeister_WMDE, RazShuty, Aleksey_WMDE.thiemowmde triaged this task as "High" priority.thiemowmde moved this task from In discussion to Blocked on the Wikidata-Page-Banner board.
TASK DETAILhttps://phabricator.wikimedia.org/T197038WORK
thiemowmde added subscribers: Tpt, thiemowmde.thiemowmde added a comment.
@hoo, I feel this ticket and the patch https://gerrit.wikimedia.org/r/217898 that got abandoned might be relevant for what you are currently working on for T182147: more convenience functions for Lua and https
thiemowmde added a comment.
@VladimirAlexiev, can you please clarify what your comment means in the context of this ticket? Are you opposing the addition of the language code "phn"?TASK DETAILhttps://phabricator.wikimedia.org/T155425EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett
thiemowmde closed this task as "Resolved".thiemowmde removed a project: Patch-For-Review.thiemowmde claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T188086EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, J
thiemowmde added subscribers: thiemowmde, Lucas_Werkmeister_WMDE.thiemowmde added a project: Easy.thiemowmde added a comment.
Instead of stuffing the sidebar that already has to many issues (no room for long link labels, print section is currently gone, it's always to many links, less is more
thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Easy.thiemowmde added a comment.
This ticket appears to be some kind of subticket of T109420: [Story] Make exports formats more visible. Both are about discoverability.
Personally I support what is asked for here. When I'm
thiemowmde added a comment.
@MisterSynergy wrote:
[…] bounds cannot be non-integers in those cases.
I'm not sure I understand this. Let's say the size of a team was 50±0.5 people in 2017. Such a confidence interval tells me that there must have been some fluctuation over the year
thiemowmde added a comment.
From all I know about quantity values and uncertainty bounds (a.k.a. "precision") I would say that "7251" is still a valid integer, even if it is followed by "±0.3".
My main argument is: Would you consider "5±1" an inte
thiemowmde added a comment.
@Lydia_Pintscher, why should an error message that can clearly be identified as an error message say "an error has occurred"? I just saw this in the patch. I think this is not only redundant but counter-productive.
Also the message "the last Lemma can
thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONList of code bases that currently use the Wikibase CodeSniffer <0.3.0, and should be updated to at least 0.3.0, better 0.4.0, if possible:the latest version:
[x] #ArticlePlaceholder https://gerrit.wikimedia.or
thiemowmde reopened this task as "Open".thiemowmde removed hoo as the assignee of this task.thiemowmde added a comment.
A qualifier name that spans 2 lines is fine since I reduced the line height. But longer names still break the layout. I tried to find an easy fix for this mult
thiemowmde reopened subtask T59774: Long qualifier name breaks layout as "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T54136EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Danwe, Charlie_WMDE, Ash_Crow, Agabi10, Aklapper, MGChe
thiemowmde added a subscriber: Lea_Lacroix_WMDE.thiemowmde added a comment.
This issue keeps confusing our users. And indeed, as @adrianheine pointed out in the task description this is getting worse every time we add a new language code that does not show up in the suggester.
A temporary
thiemowmde closed subtask T192014: Packagist is not picking up data-values/number 0.10.0 as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T155910EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, matej_suchanek, Lydia
thiemowmde claimed this task.thiemowmde closed this task as "Resolved".thiemowmde added a comment.
I updated https://packagist.org/packages/data-values/number manually, as I always do. Packagist does have this issue for years. They know it, but can't figure out how to fix it: https://
thiemowmde added a project: Patch-For-Review.thiemowmde moved this task from incoming to in progress on the Wikidata board.thiemowmde claimed this task.thiemowmde added a comment.
@hoo: https://github.com/DataValues/Number/pull/118TASK DETAILhttps://phabricator.wikimedia.org/T155910WORKBOARDhttps
thiemowmde added a comment.
What would be the alternative when we remove all return false from MediaWikiPageNameNormalizer::normalizePageName? I don't think it should return the unnormalized original string. In my opinion it would need to throw an exception – which means all code that currently
thiemowmde added a comment.
Should this be part of the services interface?
As written in https://github.com/wmde/WikibaseDataModelServices/pull/193#issuecomment-379189512:
In my opinion an array does not make much sense. The method would need to return two entity IDs then: the closest end point
thiemowmde added a comment.
Do you think we should have the simple boolean version as well? Would be a convenience shortcut mostly.
Yes, I also think an additional boolean version is worth it.
[…] you will end up supporting a search from multiple source IDs to the target IDs anyways, because
thiemowmde added a comment.
My personal remarks:
Please find variable names that are more specific than fromId, toId(s), and propertyId.
fromId could be named childId.
toIds could be named parentIds.
propertyId could be named hasParentPropertyId or relationshipPropertyId.
The method itself could
thiemowmde added a comment.
Guys, please communicate. This back-and-forth does not look like fun.TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, thiemowmdeCc: thiemowmde, Jonas
thiemowmde added a comment.
@Smalyshev, I am administrator on a lot of Packagist packages, but not on https://packagist.org/packages/wikimedia/purtle. In theory the only thing you need to do is to tag a new v1.0.7 release via git. Packagist should pick this up. If it does not, we might need
thiemowmde closed this task as "Resolved".thiemowmde claimed this task.thiemowmde added a comment.
Yes, that #kartographer issue needs to have it's own ticket. Thanks for filling one!TASK DETAILhttps://phabricator.wikimedia.org/T189409EMAIL PREFERENCEShttps://phabricator.wikimedia.or
thiemowmde removed a project: Patch-For-Review.thiemowmde moved this task from needs discussion or investigation to monitoring on the Wikidata board.thiemowmde triaged this task as "Normal" priority.thiemowmde added a comment.
This sounds like the fixes @hoo and I made cut the runti
thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde edited subscribers, added: Lydia_Pintscher; removed: adrianheine.thiemowmde added a comment.
Thanks for starting these patches, @Krinkle! I continued working on the first two and left some comments
101 - 200 of 3433 matches
Mail list logo
