Re: [Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP

2014-02-05 Thread Johannes Renner
On 01/22/2014 12:18 PM, Johannes Renner wrote: Hello, The SUSE Studio API will no longer process requests via unencrypted HTTP after Jan 2014, see here: http://blog.susestudio.com/2013/12/coming-soon-https-only-on-suse-studio.html Therefore attached is a patch to change the default endpoint

Re: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

2014-01-23 Thread Johannes Renner
On 01/21/2014 06:10 PM, Johannes Renner wrote: On 01/21/2014 03:38 PM, Jan Dobes wrote: Hello Johannes, I'm not sure how to reproduce this. I tried to create user, create custom key, assign value to system, delete user, changing values... Except some ISEs in WebUI, indexation works fine

[Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP

2014-01-22 Thread Johannes Renner
Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From f523f1d0188c4094888513026478435db169ce3c Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 22 Jan 2014 10:41:08 +0100 Subject: [PATCH] SUSE Studio API will stop working via unencrypted

[Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

2014-01-17 Thread Johannes Renner
:91) Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 910d1db851a485ec565f7e59f6b1d0d89c29 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 17 Jan 2014 12:01:45 +0100 Subject: [PATCH] Allow

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-08 Thread Johannes Renner
On 01/08/2014 02:34 PM, Michael Mraka wrote: Maximilian Meister wrote: % I see. Then it should keep the original name so we can easily figure out % where it came from and replace it with newer version in the future. % % Hi Michael, % % the original name would be pwstrength.js (in 0.5.0).

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Johannes Renner
On 12/20/2013 05:15 PM, R P Herrold wrote: On Fri, 20 Dec 2013, Maximilian Meister wrote: this patch would add a bootstrapified password strength meter to all pages where user details are being created or edited (create the initial admin user, create/edit normal users and create

[Spacewalk-devel] [PATCH] Fix NPE when uploading kickstart profile

2013-12-18 Thread Johannes Renner
Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From dbe021e76741e7f8a503ad37021e78deeeb13c3f Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 18 Dec 2013 11:32:26 +0100 Subject: [PATCH] Fix NPE when uploading kickstart profile with virt type none --- .../frontend

[Spacewalk-devel] [PATCH] Fix the Java package of DeleteGroupAction class

2013-12-18 Thread Johannes Renner
8e0a0192c54255e50a760887e1349d55492ab813 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 18 Dec 2013 14:57:00 +0100 Subject: [PATCH] Fix the java package of DeleteGroupAction class --- .../src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java| 2 +- 1 file changed, 1 insertion

[Spacewalk-devel] [PATCH] License of spacewalk-branding needs to be changed

2013-11-21 Thread Johannes Renner
From 633c050f3a068aa8a52a217c5f6ea55cd15a3937 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 21 Nov 2013 15:00:27 +0100 Subject: [PATCH] Fix the License of spacewalk-branding package --- branding/spacewalk-branding.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Spacewalk-devel] [PATCH] Fix Search for Custom Info Values + NPE

2013-11-12 Thread Johannes Renner
custom key value and before clicking on Update Key, do delete value above. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From a61776d4e453cdc7462ee95a0b9a3077f0fe886d Mon Sep 17 00:00:00 2001 From: Johannes Renner jren

Re: [Spacewalk-devel] Less compiler package to use

2013-10-24 Thread Johannes Renner
On 10/22/2013 02:07 PM, Tomáš Kašpárek wrote: I've noticed that some icons (e.g. in legend text on the left) are missing, also search button is missing some picture or text. On pages like /rhn/channels/ChannelDetail.do?cid=101 (Channels - pick one from displayed channels) old update button

Re: [Spacewalk-devel] Less compiler package to use

2013-10-22 Thread Johannes Renner
On 10/22/2013 01:05 PM, Tomáš Kašpárek wrote: Hello Johannes, I've discovered issue in 12ce0476ba547fade1cbe3819e77fd560de7fdb0 which causes RPM build errors during build time. RPM build errors: File not found:

Re: [Spacewalk-devel] Less compiler package to use

2013-10-22 Thread Johannes Renner
On 10/22/2013 02:07 PM, Tomáš Kašpárek wrote: I've locally merged contents of bootstrap-css branch and apart from spacewalk-branding all other packages (spacewalk-java and spacewalk-web) all packages were build correctly and all packages were correctly upgraded. I've noticed that some

[Spacewalk-devel] Less compiler package to use

2013-10-21 Thread Johannes Renner
Hello, While working on the Spacewalk redesign, we so far used less.js client-side. This is fine for development purposes, but it's however not the recommended way to go for production environments, see [1]. Rather we probably want to compile the spacewalk.less into spacewalk.css during the

Re: [Spacewalk-devel] Less compiler package to use

2013-10-21 Thread Johannes Renner
On 10/21/2013 01:06 PM, Michael Mraka wrote: Johannes Renner wrote: % Hello, % % While working on the Spacewalk redesign, we so far used less.js client-side. This is fine for % development purposes, but it's however not the recommended way to go for production environments, % see [1

Re: [Spacewalk-devel] ISE when changing user details on /rhn/users/UserDetails.do?uid=2

2013-10-17 Thread Johannes Renner
On 10/17/2013 04:17 PM, Tomáš Kašpárek wrote: Hello, I've merged contents of bootstrap-css branch with current Spacewalk master, built it and applied. I've noticed that changing user details as admin produces ISE. Sending you patch which fixes the problem Thank you very much for the

[Spacewalk-devel] [PATCH] Make taskomatic max memory configurable via rhn.conf

2013-09-13 Thread Johannes Renner
(AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From bff7c320b8b6a20f1f829982a166077e07989afa Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 13 Sep 2013 11:11:13 +0200 Subject: [PATCH] Make taskomatic max memory configurable via rhn.conf --- java/scripts

Re: [Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

2013-08-20 Thread Johannes Renner
are by definition Comma Separated Value files. Excel and every other spreadsheet in the world should have an option to import from comma-separated lists. If we do want to change the delimiter then we should call it something other than *.csv. -Stephen On 08/19/2013 08:21 AM, Johannes Renner wrote: Hey

[Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

2013-08-19 Thread Johannes Renner
Imendörffer From 7a446a37f1582321f432d097bd3dabdac8ecb9a2 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 19 Aug 2013 13:31:35 +0200 Subject: [PATCH 1/3] Allow users to change the CSV separator (schema changes) --- schema/spacewalk/common/tables/rhnUserInfo.sql | 6

[Spacewalk-devel] [PATCH] Fix html not being escaped in package information

2013-08-05 Thread Johannes Renner
, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 63be1b2d99b4a594e3cd198565ea5a13197aae87 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 5 Aug 2013 15:42:53 +0200 Subject: [PATCH] Fix HTML not being escaped

[Spacewalk-devel] [PATCH] Fix ISE when UUID and host ID is null

2013-07-19 Thread Johannes Renner
16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 1e0f80e4b6f43ade890dd3dae2a71bb4544dff01 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 19 Jul 2013 13:39:51 +0200 Subject: [PATCH] Fix ISE when UUID and host ID is null --- .../rhn/frontend/action

[Spacewalk-devel] [PATCH] Fix indentation on user preferences page

2013-07-12 Thread Johannes Renner
. Thanks and regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From b687d7444374ca60fdc6a8387e70013e3acb8f12 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 12 Jul 2013 11:33:30 +0200 Subject: [PATCH] Fix

Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal

2013-04-24 Thread Johannes Renner
On 04/12/2013 01:24 PM, Jan Pazdziora wrote: Johannes, let me summarize some big picture impressions, without commenting on every detail. You propose to address two situations: 1) clients in DMZ that cannot reach the server, with server able to reach the clients; 2) overloading

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-05 Thread Johannes Renner
On 04/05/2013 08:52 AM, Jan Pazdziora wrote: Hmm, I wonder if the current logic is actually correct. It feel that a kickstartable channel (for the purpose of creating kickstart profile, for example) would be channel that has at least one kickstartable tree, or channel cloned from one that has

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-04 Thread Johannes Renner
On 04/04/2013 04:31 PM, Jan Pazdziora wrote: On Thu, Apr 04, 2013 at 03:37:07PM +0200, Johannes Renner wrote: On 03/22/2013 02:55 PM, Michael Calmer wrote: Hi, please do not apply these patches. I found out, that it is not correct. It removes the channels at more places than needed. I

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-14 Thread Johannes Renner
On 03/13/2013 05:33 PM, Johannes Renner wrote: attached is a patch that should take care that only kickstartable channels are actually returned by the getKickstartableChannels() method in the ChannelFactory class. Argh, this fixes ConcurrentModificationException, sorry! -- SUSE LINUX

[Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-13 Thread Johannes Renner
From: Johannes Renner jren...@suse.de Date: Wed, 13 Mar 2013 17:00:01 +0100 Subject: [PATCH] Kickstartable channels should contain the anaconda package --- .../src/com/redhat/rhn/common/conf/ConfigDefaults.java|1 + .../src/com/redhat/rhn/domain/channel/ChannelFactory.java | 13

[Spacewalk-devel] [PATCH] Support native kvm images in SUSE Studio integration

2013-02-06 Thread Johannes Renner
df03b174f5b3f4c55d1868ee9f9c44686cdee66c Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 7 Jan 2013 16:58:34 +0100 Subject: [PATCH] Make images of type 'kvm' show up on the UI --- .../src/com/redhat/rhn/frontend/action/renderers/ImagesRenderer.java |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

2012-11-22 Thread Johannes Renner
On 11/08/2012 12:18 PM, Johannes Renner wrote: On 11/05/2012 12:03 PM, Tomas Lestach wrote: ... If there's a bug in the API call, we of course fix it. But we try to keep the current API interface as is. Spacewalk users have their scripts using our API calls and we do not want to break

[Spacewalk-devel] [PATCH] Errors with unrequired field Prefix

2012-11-15 Thread Johannes Renner
on PG only. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 7e095b96cc5d104b76cb0121ed8dc89e62ce50eb Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 15 Nov 2012 15:21:55 +0100 Subject: [PATCH] Fix

[Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters

2012-11-14 Thread Johannes Renner
Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 9628af3c615588d24d6be31d999b19e0532fdf24 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 14 Nov 2012 14:54:35 +0100 Subject: [PATCH] Check hostnames for special characters

Re: [Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters

2012-11-14 Thread Johannes Renner
On 11/14/2012 04:21 PM, Tomas Lestach wrote: On Wednesday 14 of November 2012 15:06:44 Johannes Renner wrote: Hello, I just extended the HostPortValidator class to check proxy hostnames against a regex defining a valid character set. It should allow letters (all languages), numbers

[Spacewalk-devel] [PATCH] Quartz SimpleTrigger mis-fire situations

2012-11-12 Thread Johannes Renner
e6172072966a2a7824770a48a033b064c787ac8b Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 9 Nov 2012 11:22:50 +0100 Subject: [PATCH] Fix quartz trigger initialization repeat count --- java/code/src/com/redhat/rhn/taskomatic/TaskoQuartzHelper.java |2 +- 1 file changed, 1

Re: [Spacewalk-devel] [PATCH] Kickstart profiles error handling

2012-11-12 Thread Johannes Renner
, Felix Imendörffer From 2062558127111d5fec6d1d2313d6d67e9b4208e0 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 12 Nov 2012 16:45:09 +0100 Subject: [PATCH] Fix typos --- branding/css/blue-docs.css |2 +- .../src/com/redhat/rhn

Re: [Spacewalk-devel] [PATCH] Kickstart profiles error handling

2012-11-08 Thread Johannes Renner
On 11/07/2012 04:50 PM, Tomas Lestach wrote: On Tuesday 06 of November 2012 12:30:09 Johannes Renner wrote: Hello, this is a proposed extension to commit 1ea830a in master: Validation of a kickstart profile is currently done by downloading it from the locally running cobbler. In case

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

2012-11-08 Thread Johannes Renner
On 11/05/2012 12:03 PM, Tomas Lestach wrote: ... If there's a bug in the API call, we of course fix it. But we try to keep the current API interface as is. Spacewalk users have their scripts using our API calls and we do not want to break the scripts by renaming/deleting existing API

[Spacewalk-devel] [PATCH] Kickstart profiles error handling

2012-11-06 Thread Johannes Renner
Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 5e754d93de7475a88e38578faa0d32fce7581cdb Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 6 Nov 2012 12:10:34 +0100 Subject: [PATCH] Improve kickstart profiles error handling

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

2012-11-02 Thread Johannes Renner
On 11/01/2012 01:59 PM, Tomas Lestach wrote: On Wednesday 31 of October 2012 15:00:48 Johannes Renner wrote: Hello, We found that the list of installable packages for a given system differs if you either ask the API (via system.listLatestInstallablePackages) or if you go to the Web UI

Re: [Spacewalk-devel] [PATCH] Use braces for accessing composite types in PG

2012-11-02 Thread Johannes Renner
On 10/31/2012 05:00 PM, Tomas Lestach wrote: On Wednesday 31 of October 2012 14:38:49 Johannes Renner wrote: Hey, Ok, here is the patch to make the rewritten query work with PG as well (API call 'system.listLatestUpgradablePackages'). It's actually a follow up to this commit

[Spacewalk-devel] [PATCH] Use braces for accessing composite types in PG

2012-10-31 Thread Johannes Renner
, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From f48143d211baeb4161814ae5deb537aa57642c70 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 31 Oct 2012 12:18:02 +0100 Subject: [PATCH] Use braces for accessing

[Spacewalk-devel] List of installable packages: API vs. Web UI

2012-10-31 Thread Johannes Renner
Hello, We found that the list of installable packages for a given system differs if you either ask the API (via system.listLatestInstallablePackages) or if you go to the Web UI (Systems - [choose a system] - Software - Packages - Install). After looking into it, I found there is two different

[Spacewalk-devel] [PATCH] Schedule updates for the software update stack first

2012-10-19 Thread Johannes Renner
LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From b27fdfcda077af488a17d6a2b7a18e133b01909a Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 18 Oct 2012 17:26:01 +0200 Subject: [PATCH] Schedule updates for software update stack

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-18 Thread Johannes Renner
2001 From: Johannes Renner jren...@suse.de Date: Tue, 18 Sep 2012 14:17:11 +0200 Subject: [PATCH] Validate proxy format on general config page --- .../rhn/common/validator/HostPortValidator.java| 134 .../validator/test/HostPortValidatorTest.java | 63

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-14 Thread Johannes Renner
://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/net/HostAndPort.java -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 8f2afb12a36939da36856dff630d09746b9cd8ff Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de

[Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-10 Thread Johannes Renner
not the case for you? I might look after this bug as well.. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 8ecd2908bb32bbce565503176b6fe937e851a2de Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 10 Sep

[Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)

2012-08-17 Thread Johannes Renner
dd9bf777412f470c7a8fee58408b495036f0d55b Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 17 Aug 2012 12:06:49 +0200 Subject: [PATCH] Fix missing CVEs in patches listing with Oracle 11 --- .../rhn/frontend/dto/SecurityErrataOverview.java |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)

2012-08-17 Thread Johannes Renner
On 08/17/2012 01:20 PM, Jan Pazdziora wrote: On Fri, Aug 17, 2012 at 01:02:38PM +0200, Johannes Renner wrote: Hey, apparently the method getColumnLabel() of class ResultSetMetaData returns the column label in uppercase with Oracle 11 (using ojdbc5.jar). Therefore an equals(cve

[Spacewalk-devel] [PATCH] Insert pxt session errors on postgres

2012-08-15 Thread Johannes Renner
/copyright.pxt https://hostname/help/about.pxt Attached please find a patch for the issue. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 76dfe76b7cb8a7882951849ed537a66154aa86cc Mon Sep 17 00:00:00 2001 From: Johannes Renner jren

[Spacewalk-devel] [PATCH] Script contents not properly displayed

2012-08-14 Thread Johannes Renner
() function. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From b00d36ff71783dd870e67cc969a9de2f55df4221 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 14 Aug 2012 11:46:43 +0200 Subject: [PATCH] Convert

Re: [Spacewalk-devel] [PATCH] Script contents not properly displayed

2012-08-14 Thread Johannes Renner
On 08/14/2012 03:36 PM, Stephen Herr wrote: Johannes, Could you ensure in /usr/share/pgsql/postgresql.conf that bytea_output = 'escape', and if not see if that corrects your problem? -Stephen Thanks, setting this option fixes the problem on the postgres 9.1 database we are using. We

Re: [Spacewalk-devel] [PATCH] Query not elaborated?

2012-08-13 Thread Johannes Renner
On 08/06/2012 05:59 PM, Tomas Lestach wrote: Hello Johannes, On Friday 03 of August 2012 12:44:11 Johannes Renner wrote: Hi, We found out that commit 16f30f97d657ab7019489dfac5a11f67afc2143e apparently broke the Errata page for custom channels: https://hostname/rhn/channels/manage/errata

[Spacewalk-devel] [PATCH] Query not elaborated?

2012-08-03 Thread Johannes Renner
3a688e6570caa2ef2a4d0a20ffbf3f9237865efe Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 3 Aug 2012 12:13:49 +0200 Subject: [PATCH] Call elaborate manually --- .../redhat/rhn/manager/channel/ChannelManager.java |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Spacewalk-devel] Timezone problem with DB timestamps

2012-07-30 Thread Johannes Renner
times only, and do so in PackageDto.setBuildTime(). What do you think? Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 861cf5c634c611f19ed509fb96126adb5f4cea19 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-06-06 Thread Johannes Renner
RhnHelper.DEFAULT_FORWARD, just for being consistent with recent changes here. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From d3fe367991d13c85b83e5a821688d4c32db5f248 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren

[Spacewalk-devel] spacewalk-search declared as GPL-2.0 but contains Apache licenses

2012-05-31 Thread Johannes Renner
you would have to add both license texts to the package and it should be reflected in the specfile (spacewalk-search.spec) as well: License: GPLv2 -- License: GPL-2.0 and Apache-2.0 Thank you, Johannes Renner Please see the list of files here: spacewalk-search-git-0.fd73b43/buildconf/tempjars

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-21 Thread Johannes Renner
On 05/21/2012 02:17 PM, Miroslav Suchý wrote: On 05/18/2012 05:11 PM, Miroslav Suchy wrote: I still have to test the client part. in spec: Requires: python-curl In Fedora/RHEL the package is called python-pycurl, please fix it using %if No problem. After image is scheduled, you land

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-18 Thread Johannes Renner
On 05/18/2012 02:45 PM, Miroslav Suchy wrote: In patch 0001 - schema db - you are missing upgrades for table suseCredentialsType. And upgrades for table suseCredentials differs from clean install. Oh yeah, sorry, I forgot to revise the upgrade files. I can come up with another patch fixing

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-16 Thread Johannes Renner
On 05/15/2012 09:29 PM, Miroslav Suchy wrote: On 15.5.2012 14:28, Johannes Renner wrote: On 05/15/2012 01:25 PM, Miroslav Suchy wrote: +Requires: susestudio-java-client This will require susestudio-java-client rpm? It is not present in neither in Fedora nor in jpackage. Can I take

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-16 Thread Johannes Renner
On 05/16/2012 12:49 PM, Miroslav Suchy wrote: On 16.5.2012 11:01, Johannes Renner wrote: I guess we could have some %if (0%?rhel/?suse_version) %else ... though, if you prefer that. Ok, I will put there %if and for license as well. Good, let me see how that looks like and I will change add

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-15 Thread Johannes Renner
On 05/15/2012 01:25 PM, Miroslav Suchy wrote: +Requires: susestudio-java-client This will require susestudio-java-client rpm? It is not present in neither in Fedora nor in jpackage. Can I take:

[Spacewalk-devel] [PATCH] Fix errata clone name generation in perl code

2012-04-23 Thread Johannes Renner
it was not rewritten? Or is it just remaining by accident? Thank you, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From b497b86fdfa6054c60c35a2d78f5eb8a05a445af Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-04-13 Thread Johannes Renner
On 04/11/2012 02:28 PM, Jan Pazdziora wrote: On Wed, Apr 11, 2012 at 11:43:07AM +0200, Johannes Renner wrote: I agree that clones of clones should get CM, CN, etc. instead of CL-CL-kernel*. How would you propose to detect clones for implementing this algorithm? How about having a new

[Spacewalk-devel] Removed strings still being used

2012-04-02 Thread Johannes Renner
Hey, After running our testsuite against a recent codebase, we saw (from catalina.out) that the following removed strings seem to be still in use: configchannelfilter.name configfilefilter.path config_subscribed_systems.unsubscribeSystems.success config_target_systems.subscribeSystems.success

[Spacewalk-devel] [PATCH] Checkstyle 4.1 vs. 4.3

2012-03-30 Thread Johannes Renner
0bcacfc4bbc032c17263198f5bc8dde4ec000aef Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 30 Mar 2012 10:26:25 +0200 Subject: [PATCH] Add lib directory to checkstyle classpath --- java/spacewalk-java.spec |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-30 Thread Johannes Renner
On 03/07/2012 11:57 AM, Johannes Renner wrote: On 03/06/2012 05:42 PM, Johannes Renner wrote: Hey, I want to propose a change concerning the names of cloned errata. Currently, names of cloned errata are generated like this: String clonedAdvisoryName = CL + published.getAdvisoryName

Re: [Spacewalk-devel] ivy

2012-03-28 Thread Johannes Renner
On 03/28/2012 10:38 AM, Tomas Lestach wrote: On Tuesday 27 of March 2012 23:00:53 Miroslav Suchy wrote: Do we still use ivy from jpp? Can we use apache-ivy from Fedora? Where do you see, we use ivy? I believe we do not require ivy in run or build time. If you mean development workstation

[Spacewalk-devel] Deployment of images built with SUSE Studio

2012-03-27 Thread Johannes Renner
Hello, We recently added a feature to our branch of Spacewalk that enables users to deploy images that were built with SUSE Studio [1] to registered virtual host systems. The feature involves a new action type to be put in table rhnActionType, which we chose to give the ID 500 for now (just to

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-03-27 Thread Johannes Renner
On 03/27/2012 11:35 AM, Miroslav Suchý wrote: On 03/27/2012 10:27 AM, Johannes Renner wrote: The feature involves a new action type to be put in table rhnActionType, which we chose to give the ID 500 for now (just to make sure there will be no clash in the near future). Would you maybe

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-08 Thread Johannes Renner
else who knows) should better have a look and verify this first, see the second patch. -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 22cab15a789c1d8cc50f2efb8244fbec1c9a2236 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-07 Thread Johannes Renner
On 03/06/2012 05:42 PM, Johannes Renner wrote: Hey, I want to propose a change concerning the names of cloned errata. Currently, names of cloned errata are generated like this: String clonedAdvisoryName = CL + published.getAdvisoryName().substring(3); String clonedAdvisory = CL

[Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-06 Thread Johannes Renner
scheme. Attached please find my proposed patch for spacewalk master. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 30c638790f3f3d354c2381c6f9b2f23c90e20a50 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-05 Thread Johannes Renner
On 03/05/2012 03:40 PM, Tomas Lestach wrote: On Friday 02 of March 2012 18:11:41 Johannes Renner wrote: On 02/29/2012 05:38 PM, Cliff Perry wrote: On 02/29/2012 11:05 AM, Johannes Renner wrote: Hello, I am investigating into a bug about cloned channels and errata. This is how to reproduce

[Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-02-29 Thread Johannes Renner
25cac35e2f20c249dd18ba522fe112ab058acd08 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 29 Feb 2012 16:52:43 +0100 Subject: [PATCH] Fix bug about cloned channels and errata --- .../action/channel/manage/PublishErrataAction.java |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-02-29 Thread Johannes Renner
On 02/29/2012 05:38 PM, Cliff Perry wrote: On 02/29/2012 11:05 AM, Johannes Renner wrote: Hello, I am investigating into a bug about cloned channels and errata. This is how to reproduce it on the UI: 1. Clone a channel that contains errata, but select clone without errata 2. Go

Re: [Spacewalk-devel] [PATCH] Fix query to determine available config channels in SSM

2011-12-06 Thread Johannes Renner
On 12/05/2011 06:53 PM, Michael Mraka wrote: Hi Johannes, although Tomas commited your patch neither original version nor yours are correct. a) Select from rhnSet was not restricted to user so it might interfere with other users SSM servers. b) Two servers in SSM and three channels:

[Spacewalk-devel] [PATCH] Fix query to determine available config channels in SSM

2011-11-29 Thread Johannes Renner
probably also need a fix. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 8493f940c7b6fb27e4f25f211865890fcf71f0a3 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 29 Nov 2011 16:17:34 +0100

[Spacewalk-devel] [PATCH] Remove markup from error messages

2011-11-15 Thread Johannes Renner
-- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 8960b0ca3e8df8500f9129fd06493e3f3565cb86 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 15 Nov 2011 13:55:02 +0100 Subject: [PATCH] Remove markup from error message

[Spacewalk-devel] [PATCH] Pam setting on the user page not saving

2011-10-12 Thread Johannes Renner
: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) From 4abfbdcaea3ea3ddc5d9bb6aa1d478f2975d5723 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 12 Oct 2011 13:23:01 +0200 Subject: [PATCH] Fixed pam setting on user page not saving --- .../frontend/action

Re: [Spacewalk-devel] [PATCH] Pam setting on the user page not saving

2011-10-12 Thread Johannes Renner
, -- Tomas Lestach RHN Satellite Engineering, Red Hat On 10/12/2011 02:28 PM, Johannes Renner wrote: Hello, I just fixed a bug in Spacewalk about the pam setting on the user page not saving, it can be reproduced like this: 1. Configure pam on the server (e.g. echo pam_auth_service

[Spacewalk-devel] [PATCH] NPE when scheduling a package (install/remove/upgrade) action + remote command

2011-09-08 Thread Johannes Renner
d9fa52242fdae2302d4d1ba06eb2c181df0ba6ed Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 8 Sep 2011 14:58:43 +0200 Subject: [PATCH] Fix NPE when scheduling a package action + remote command --- .../rhn/domain/action/script/ScriptAction.java |4 +++- .../action/rhnpackage/ScheduleRemoteCommand.java

[Spacewalk-devel] [PATCH] Error message when successfully toggling user roles

2011-09-06 Thread Johannes Renner
9138ab493776b334005c8ab63f635284b913da6e Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 6 Sep 2011 10:03:55 +0200 Subject: [PATCH] Do not send error message in case of success --- .../frontend/action/multiorg/SatAdminAction.java |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Spacewalk-devel] Audit Logging

2011-08-26 Thread Johannes Renner
On 08/26/2011 11:02 AM, Miroslav Suchý wrote: On 08/25/2011 06:55 PM, Johannes Renner wrote: Well, I can count three, while only one (!) of them is public. But we can still rename the other ones, no problem. I count: private static Logger log = Logger.getLogger(AuditLog.LOGGER_NAME

Re: [Spacewalk-devel] Audit Logging

2011-08-25 Thread Johannes Renner
On 08/25/2011 05:43 PM, Miroslav Suchý wrote: On 08/25/2011 02:30 PM, Johannes Renner wrote: So (1.) there are some helper classes that I put into a new separate package, see 01-new-classes.patch: AuditLog.java has 4 (!) functions log() and all of them has different semantics - if I ommit

Re: [Spacewalk-devel] [PATCH] Synchronization to Software Profiles

2011-07-29 Thread Johannes Renner
On 07/29/2011 04:33 PM, Cliff Perry wrote: On 07/29/2011 09:55 AM, Johannes Renner wrote: Hello, I fixed a subtle bug in the spacewalk web UI that caused the scheduling of a system's synchronization to a software profile to not work anymore. The patch in the attachment should fix the problem

[Spacewalk-devel] [PATCH] Refactor listing of channels: RedHat.do - Vendor.do

2011-07-05 Thread Johannes Renner
patch. Thank you, Johannes -- SUSE LINUX Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) From 506bbd5b7df16f0bdf04de8b31b3b4fc4f80b5c7 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 5 Jul

Re: [Spacewalk-devel] [PATCH] Refactor listing of channels: RedHat.do - Vendor.do

2011-07-05 Thread Johannes Renner
On 07/05/2011 12:23 PM, Johannes Renner wrote: Hello, for making it more generic, we refactored the web UI vendor channel listing from 'RedHat.do' to 'Vendor.do'. Unfortunately, doing this in a consistent way includes changes in quite an amount of files. If this refactoring is still

[Spacewalk-devel] Password Strength Verification

2011-05-10 Thread Johannes Renner
Hello, I was recently investigating in hardening security in the spacewalk web-app by introducing password strength verification for new passwords, which means forcing the users to choose passwords with a certain strength. It currently seems to me as if there are two options that I listed below

[Spacewalk-devel] [PATCH] Do not show success message when passwords don't match

2011-03-28 Thread Johannes Renner
don't match. Greetings, Johannes -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 5c07c2b9824ff125a0d5f66426b3fe996d94a213 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 28 Mar 2011 13:45:25 +0200 Subject: [PATCH] Do not show success message when

[Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes

2011-03-01 Thread Johannes Renner
this link during the creation of a new note will otherwise lead to internal server error (NPE), because (of course) the nid is still null. Regards, Johannes Renner - -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.15 (GNU/Linux

Re: [Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes

2011-03-01 Thread Johannes Renner
On 03/01/2011 02:29 PM, Jan Pazdziora wrote: By the way: will you be submitting the patch for the Has Signed Metadata feature as well? Yes, this one is also going to be submitted, but unfortunately I can't tell you exactly when. The problem is that this is currently not a single patch, but

[Spacewalk-devel] [PATCH] Password with less than minlength characters accepted

2011-01-27 Thread Johannes Renner
in not being able to login anymore after sign out! Attached is a patch that fixes the problem. Greetings, Johannes Renner -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 57bac09f19795e5fc4c21514da4ac20bef9cc79d Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date