SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5673946822
Thanks for the update in d8cb0cbb7, @goutamadwant. Against `0a84c6b811419fad551840e07d88bb8f49157945`, F1, F2, F3, F5, F7 and F8 already look addressed: the `MAX_ACTIVE_SPLITS = 100` bound with the `activeSplitsTruncated` flag, `validateCount` and `validateExactSplitCounts`, the defensive unmodifiable copy over the immutable `CdcSnapshotSplitProgress`, enum-by-name encoding in `CdcProgressReportSerializer`, and the secrets rule plus connector list in `docs/en/developer/cdc-progress.md`. I consider those resolved. Two points I still can't confirm from the thread: 1. **F4** – does the runtime collection section of `docs/en/developer/cdc-progress.md` now describe the registration-based enumerator report path rather than a pull/derive model? If you've already reworded it, a pointer to the section is enough. 2. **F6** – has the `CdcProgressLifecycle.SNAPSHOT` Javadoc been narrowed so it no longer lists enumerator-owned discovery/assignment, consistent with the ownership rule in the doc? Since the earlier check was against `0a84c6b811419fad551840e07d88bb8f49157945`, please also confirm none of those changes moved in d8cb0cbb7. Once F4 and F6 are confirmed and the CI you triggered has finished, I'm happy to take another pass. <!-- streview-comment:1057 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
