reviews  

Messages by Thread

• • Re: Review Request 29669: Change index to point to API thrift documentation. Kevin Sweeney
  • Re: Review Request 29669: Change index to point to API thrift documentation. Zameer Manji
• Review Request 29662: Fixed make-python-sdists Steve Niemitz
  • Re: Review Request 29662: Fixed make-python-sdists Bill Farner
  • Re: Review Request 29662: Fixed make-python-sdists Bill Farner
  • Re: Review Request 29662: Fixed make-python-sdists Steve Niemitz
• Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Joshua Cohen
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Kevin Sweeney
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Joshua Cohen
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Bill Farner
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Joshua Cohen
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Brian Wickman
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Joshua Cohen
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Bill Farner
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Aurora ReviewBot
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Joshua Cohen
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Kevin Sweeney
  • Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Brian Wickman
• Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Issam EL ATIF
  • Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Zameer Manji
  • Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Issam EL ATIF
  • Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Bill Farner
  • Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Issam EL ATIF
  • Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Kevin Sweeney
  • Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE Aurora ReviewBot
• Review Request 29472: Updates documentation markdown to a consistent style. Dave Lester
  • Re: Review Request 29472: [WIP] Updates documentation markdown to a consistent style. Dave Lester
  • Re: Review Request 29472: [WIP] Updates documentation markdown to a consistent style. Bill Farner
  • Re: Review Request 29472: [WIP] Updates documentation markdown to a consistent style. Aurora ReviewBot
• Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Kevin Sweeney
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Kevin Sweeney
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Kevin Sweeney
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Stephan Erb
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Stephan Erb
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Stephan Erb
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Stephan Erb
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Aurora ReviewBot
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Aurora ReviewBot
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Aurora ReviewBot
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Aurora ReviewBot
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Kevin Sweeney
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Steve Niemitz
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Aurora ReviewBot
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Bill Farner
  • Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper Kevin Sweeney
• Review Request 29463: Upgrade pystachio to 0.7.4. Brian Wickman
  • Re: Review Request 29463: Upgrade pystachio to 0.7.4. Zameer Manji
  • Re: Review Request 29463: Upgrade pystachio to 0.7.4. Aurora ReviewBot
  • Re: Review Request 29463: Upgrade pystachio to 0.7.4. Brian Wickman
  • Re: Review Request 29463: Upgrade pystachio to 0.7.4. Kevin Sweeney
  • Re: Review Request 29463: Upgrade pystachio to 0.7.4. Brian Wickman
• Review Request 29426: Fixes markdown formatting in Vagrant documentation. Dave Lester
  • Re: Review Request 29426: Fixes markdown formatting in Vagrant documentation. Aurora ReviewBot
  • Re: Review Request 29426: Fixes markdown formatting in Vagrant documentation. Joe Smith
  • Re: Review Request 29426: Fixes markdown formatting in Vagrant documentation. Kevin Sweeney
• Review Request 29423: Fixes typo in Developing Aurora Client documentation. Dave Lester
  • Re: Review Request 29423: Fixes typo in Developing Aurora Client documentation. Aurora ReviewBot
  • Re: Review Request 29423: Fixes typo in Developing Aurora Client documentation. Joe Smith
  • Re: Review Request 29423: Fixes typo in Developing Aurora Client documentation. Dave Lester
  • Re: Review Request 29423: Fixes typo and markdown in Developing Aurora Client documentation. Dave Lester
  • Re: Review Request 29423: Fixes typo and markdown in Developing Aurora Client documentation. Aurora ReviewBot
  • Re: Review Request 29423: Fixes typo and markdown in Developing Aurora Client documentation. Kevin Sweeney
• Review Request 29348: Removing duplicate target. Maxim Khutornenko
  • Re: Review Request 29348: Removing duplicate target. Kevin Sweeney
  • Re: Review Request 29348: Removing duplicate target. Aurora ReviewBot
• Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Kevin Sweeney
  • Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Aurora ReviewBot
  • Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Joe Smith
  • Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Bill Farner
  • Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Brian Wickman
• Review Request 29275: Fixing build break. Maxim Khutornenko
  • Re: Review Request 29275: Fixing build break. Brian Wickman
• Review Request 29271: Removing cron schedule support from createJob and killTasks Maxim Khutornenko
  • Re: Review Request 29271: Removing cron schedule support from createJob and killTasks Aurora ReviewBot
  • Re: Review Request 29271: Removing cron schedule support from createJob and killTasks Kevin Sweeney
  • Re: Review Request 29271: Removing cron schedule support from createJob and killTasks Maxim Khutornenko
  • Re: Review Request 29271: Removing cron schedule support from createJob and killTasks Bill Farner
• Review Request 29267: Remove unused 3rdparty dependencies. Kevin Sweeney
  • Re: Review Request 29267: Remove unused 3rdparty dependencies. Brian Wickman
  • Re: Review Request 29267: Remove unused 3rdparty dependencies. Kevin Sweeney
  • Re: Review Request 29267: Remove unused 3rdparty dependencies. Aurora ReviewBot
• Review Request 29216: Removing client v1 code. Maxim Khutornenko
  • Re: Review Request 29216: Removing client v1 code. Aurora ReviewBot
  • Re: Review Request 29216: Removing client v1 code. Maxim Khutornenko
  • Re: Review Request 29216: Removing client v1 code. Aurora ReviewBot
  • Re: Review Request 29216: Removing client v1 code. Zameer Manji
  • Re: Review Request 29216: Removing client v1 code. Bill Farner
  • Re: Review Request 29216: Removing client v1 code. Maxim Khutornenko
  • Re: Review Request 29216: Removing client v1 code. Kevin Sweeney
  • Re: Review Request 29216: Removing client v1 code. Maxim Khutornenko
  • Re: Review Request 29216: Removing client v1 code. Aurora ReviewBot
  • Re: Review Request 29216: Removing client v1 code. Maxim Khutornenko
  • Re: Review Request 29216: Removing client v1 code. Maxim Khutornenko
  • Re: Review Request 29216: Removing client v1 code. Aurora ReviewBot
• Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Kevin Sweeney
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Maxim Khutornenko
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Aurora ReviewBot
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Maxim Khutornenko
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Maxim Khutornenko
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Aurora ReviewBot
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Kevin Sweeney
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Brian Wickman
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Kevin Sweeney
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Brian Wickman
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Joshua Cohen
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Aurora ReviewBot
  • Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Brian Wickman
• Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Brian Wickman
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Kevin Sweeney
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Brian Wickman
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Kevin Sweeney
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Kevin Sweeney
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Aurora ReviewBot
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Brian Wickman
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Kevin Sweeney
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Aurora ReviewBot
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Joe Smith
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Joe Smith
  • Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. Joe Smith
• Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Aurora ReviewBot
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Bill Farner
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Zameer Manji
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Zameer Manji
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Zameer Manji
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Aurora ReviewBot
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Maxim Khutornenko
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Aurora ReviewBot
  • Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct Bill Farner
• Review Request 29132: get_client_version should never be allowed to run unpatched in test. Brian Wickman
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Brian Wickman
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Aurora ReviewBot
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Joe Smith
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Brian Wickman
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Brian Wickman
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Kevin Sweeney
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Kevin Sweeney
  • Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test. Joe Smith
• Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style. Brian Wickman
  • Re: Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style. Kevin Sweeney
  • Re: Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style. Brian Wickman
  • Re: Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style. Aurora ReviewBot
• Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. Aurora ReviewBot
  • Re: Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. Bill Farner
  • Re: Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. Bill Farner
  • Re: Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. Aurora ReviewBot
  • Re: Review Request 29117: Adding thrift API changes document. Bill Farner
  • Re: Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. David McLaughlin
  • Re: Review Request 29117: Adding thrift API changes document. Maxim Khutornenko
  • Re: Review Request 29117: Adding thrift API changes document. Kevin Sweeney
  • Re: Review Request 29117: Adding thrift API changes document. Aurora ReviewBot
• Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version. Joshua Cohen
  • Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version. Zameer Manji
  • Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version. Kevin Sweeney
  • Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version. Joshua Cohen

• Earlier messages
• Later messages